Re: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check

2014-05-21 Thread K Colford
Then that's how I'll re implement it. -Original Message- From: Eric Blake Date: Wed, 21 May 2014 14:08:50 To: Paul Eggert; Kieran Colford; Subject: Re: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check On 05/21/2014 01:58 PM, Paul Eggert wrote: > On 05/21/

Re: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check

2014-05-21 Thread Eric Blake
On 05/21/2014 01:58 PM, Paul Eggert wrote: > On 05/21/2014 11:54 AM, Kieran Colford wrote: >> I definitely agree >> with your suggestion of having a module put them in config.h > > Why config.h? Can't it be put into a new include file, supplied by > Gnulib? stringops.h, say?We shouldn't bloat co

Re: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check

2014-05-21 Thread Paul Eggert
On 05/21/2014 11:54 AM, Kieran Colford wrote: I definitely agree with your suggestion of having a module put them in config.h Why config.h? Can't it be put into a new include file, supplied by Gnulib? stringops.h, say?We shouldn't bloat config.h unless we really need to.

Re: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check

2014-05-21 Thread Kieran Colford
On 14-05-21 02:48 PM, Eric Blake wrote: > On 05/21/2014 12:00 PM, Kieran Colford wrote: >> With the removal of STREQ and STRNEQ from gnulib, this syntax test is >> no longer useful and simply generates a nuisance error message that >> can't be fixed by gnulib. > > STREQ and STRNEQ have never been

Re: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check

2014-05-21 Thread Eric Blake
On 05/21/2014 12:48 PM, Eric Blake wrote: > On 05/21/2014 12:00 PM, Kieran Colford wrote: >> With the removal of STREQ and STRNEQ from gnulib, this syntax test is >> no longer useful and simply generates a nuisance error message that >> can't be fixed by gnulib. > > STREQ and STRNEQ have never bee

Re: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check

2014-05-21 Thread Eric Blake
On 05/21/2014 12:00 PM, Kieran Colford wrote: > With the removal of STREQ and STRNEQ from gnulib, this syntax test is > no longer useful and simply generates a nuisance error message that > can't be fixed by gnulib. STREQ and STRNEQ have never been provided by a generic .h file in gnulib, to my kn

[PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check

2014-05-21 Thread Kieran Colford
With the removal of STREQ and STRNEQ from gnulib, this syntax test is no longer useful and simply generates a nuisance error message that can't be fixed by gnulib. --- top/maint.mk |8 1 file changed, 8 deletions(-) diff --git a/top/maint.mk b/top/maint.mk index b6cd5a2..5b345ad 1006