On 05/21/2014 12:00 PM, Kieran Colford wrote: > With the removal of STREQ and STRNEQ from gnulib, this syntax test is > no longer useful and simply generates a nuisance error message that > can't be fixed by gnulib.
STREQ and STRNEQ have never been provided by a generic .h file in gnulib, to my knowledge, so this commit message is misleading. However, several .c files define them rather consistently, as well as tests/macros.h (although that header is not installed for use outside of tests), and it is easy to copy that definition into your code as well. > --- > top/maint.mk | 8 -------- > 1 file changed, 8 deletions(-) I'd rather not remove this rule - at least 2 projects I work on (coreutils and libvirt) would be negatively impacted if the rule disappears. Instead, you can customize your cfg.mk to skip this rule (by adding it to local-checks-to-skip). For that matter, maybe we should add a new gnulib module that can be used to provide these macros as part of config.h rather than forcing downstream packages to rewrite it themselves. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
