Then that's how I'll re implement it. -----Original Message----- From: Eric Blake <ebl...@redhat.com> Date: Wed, 21 May 2014 14:08:50 To: Paul Eggert<egg...@cs.ucla.edu>; Kieran Colford<colfo...@gmail.com>; <bug-gnulib@gnu.org> Subject: Re: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check
On 05/21/2014 01:58 PM, Paul Eggert wrote: > On 05/21/2014 11:54 AM, Kieran Colford wrote: >> I definitely agree >> with your suggestion of having a module put them in config.h > > Why config.h? Can't it be put into a new include file, supplied by > Gnulib? stringops.h, say?We shouldn't bloat config.h unless we really > need to. Indeed, using a new header instead of bloating config.h ensures that existing .c files in gnulib that already define their own STREQ won't hit collisions (because they merely won't include the new file). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
