Re: proposed patch: verify: new macro verify_expr; verify_true deprecated

On 06/13/2011 08:10 PM, Paul Eggert wrote: > It's relatively common to want to verify a property at compile-time > inside an expression, when using a macro. For example, in Emacs, > I might want to do something like this: > >#define ENCODE_CHAR(charset, c) \ > (verify_true (sizeof (c) <=

proposed patch: verify: new macro verify_expr; verify_true deprecated

It's relatively common to want to verify a property at compile-time inside an expression, when using a macro. For example, in Emacs, I might want to do something like this: #define ENCODE_CHAR(charset, c) \ (verify_true (sizeof (c) <= sizeof (int)), \ [some expression that assumes siz

Re: [PATCH 1/2] Enable more syntax checks, eliminate useless C preprocessor parentheses

[redirecting to bug-gnulib] On 06/13/2011 05:27 PM, James Youngman wrote: > On Mon, Jun 13, 2011 at 4:28 PM, Eric Blake wrote: >> On 06/11/2011 07:42 PM, James Youngman wrote: >>> +++ b/find/find.c > [...] > > Thanks for these comments. They're addressed in the patch "Assume > SIGCHLD and O_NO

Re: ftoastr: link error on HP-UX

Stefano Lattarini wrote: > Hello Paul, and sorry for the nitpickiness, but ... It's nice to apologize for it, but we live for nitpickiness, here ;-) Thank you. > On Monday 13 June 2011, Paul Eggert wrote: >> Thanks for the bug report. I pushed this: >> >> diff --git a/ChangeLog b/ChangeLog >> in

Re: Dealing with character ranges in grep

Hi All. > Date: Thu, 09 Jun 2011 10:14:01 -0700 > From: Paul Eggert > To: Paolo Bonzini > CC: Aharon Robbins , bug-grep , > bug-gnulib , k...@freefriends.org > Subject: Re: Dealing with character ranges in grep > > On 06/08/2011 10:14 PM, Aharon Robbins wrote: > > > So, for the upcoming

Re: fseek, ftell warnings

Hi Eric, > Actually, I'm wondering if we need modules/fseeko to depend on > modules/fseek, or if we can come up with some other approach. After > all, the whole idea is that portable programs should only be using > fseeko, not fseek. But by making fseeko depend on fseek, then > stdio.in.h will a

fix test failures on Solaris 8

In a gettext build on Solaris 8, I'm seeing 5 test failures: FAIL: test-mbrtowc4.sh FAIL: test-mbsrtowcs4.sh FAIL: test-mbsstr3.sh FAIL: test-setlocale1.sh FAIL: test-wcrtomb.sh The reason for these failures is that when LC_ALL is set to zh_CN.GB18030, the test programs (which are libto

Re: [PATCH 0/348] move AC_LIBOBJ invocations to the module descriptions

Stefano Lattarini wrote: ... > Maybe this is a stupid question, but why are you removing the > `sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT' check here > (and its rules below)? If this is intended, it should be > mentioned in the ChangeLog IMHO. Ouch. That's two in one day. I removed it by

Re: ftoastr: link error on HP-UX

Hello Paul, and sorry for the nitpickiness, but ... On Monday 13 June 2011, Paul Eggert wrote: > Thanks for the bug report. I pushed this: > > diff --git a/ChangeLog b/ChangeLog > index 19a3dff..571df81 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,11 @@ > +2011-06-13 Paul Eggert >

Re: ftoastr: link error on HP-UX

Thanks for the bug report. I pushed this: ChangeLog |8 lib/ftoastr.c | 14 -- modules/ftoastr |1 + 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index 19a3dff..571df81 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3

Re: [PATCH 0/348] move AC_LIBOBJ invocations to the module descriptions

Hi Jim. On Monday 13 June 2011, Jim Meyering wrote: > > Thanks for the list. > Once you've applied your 300+ changes, > I'll make sure that this rule passes: > > From 4246fedf03280c5876fe90ffba8f9722218be61d Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Mon, 13 Jun 2011 18:01:47 +0200 >

Re: [PATCH 0/348] move AC_LIBOBJ invocations to the module descriptions

Bruno Haible wrote: > Jim Meyering wrote: >> This looks like a fine improvement. >> I reviewed only the first dozen or so. > > Thanks for the review. Most of the patches follow the same idiom. > >> This new policy looks particularly easy to violate accidentally. >> What do you think about adding a

Re: fseeko, ftello: avoid inline function in include file

On 06/13/2011 09:38 AM, Bruno Haible wrote: > Eric Blake wrote: >> This looks reasonable to me (and no problem on the license change). > > Good, I've applied it, together with the same change for fseeko: > > > 2011-06-13 Bruno Haible > > fseeko: Provide a non-inline replacement of fsee

Re: gnulib-tool: avoid side effects between different gnulib-tool invocations

> 2011-06-08 Bruno Haible > > gnulib-tool: Better isolation between different gnulib-tool invocations. When --makefile-name is specified, the witness C macro is not being defined as a C macro automatically. This fixes it. 2011-06-13 Bruno Haible gnulib-tool: Addendum to 201

Re: fseeko, ftello: avoid inline function in include file

Eric Blake wrote: > This looks reasonable to me (and no problem on the license change). Good, I've applied it, together with the same change for fseeko: 2011-06-13 Bruno Haible fseeko: Provide a non-inline replacement of fseek(). * lib/stdio.in.h (fseek): Don't provide if mod

Re: system call trace tools

Eric Blake asked: > Does anyone know the HP-UX counterpart to Linux' strace in order to see > what syscalls are in use by the HP-UX shell, and why/where fd 9 is > getting closed? Here's the tools I know of: - Linux, *BSD: strace - MacOS X: dtruss (based on dtrace, need to make it setuid root your

Re: fseeko, ftello: avoid inline function in include file

On 06/13/2011 05:21 AM, Bruno Haible wrote: > The fix is to move the inline function to non-inline code. Actually > lib/ftell.c > already exists, with the right code. > > The purpose of that inline function, as the comments say, is to ensure ftell() > is consistent with ftello(). But that can be

freebsd 8.2 test failure: test-file-has-acl.sh

Hi, Trying to find a system on which I can reproduce Bruno's the init.sh failure (pretty sure I've seen it on non-HP), I built the very latest coreutils/gnulib on a FreeBSD 8.2-RELEASE system. All tests passed except this one from gnulib: FAIL: test-file-has-acl.sh (exit: 1)

Re: [PATCH 0/348] move AC_LIBOBJ invocations to the module descriptions

Jim Meyering wrote: > This looks like a fine improvement. > I reviewed only the first dozen or so. Thanks for the review. Most of the patches follow the same idiom. > This new policy looks particularly easy to violate accidentally. > What do you think about adding a syntax-check rule to help avoi

Re: [PATCH 0/348] move AC_LIBOBJ invocations to the module descriptions

Bruno Haible wrote: > In we > found out that every AC_LIBOBJ invocation must be triggered from a module > that contains the referred file. Otherwise bugs occur. > > The most straightforward and safe way to ensure this is to more t

fseeko, ftello: avoid inline function in include file

Hi Eric, Building gettext on Solaris 9, I'm seeing this link error: cc -O -DHAVE_CONFIG_H -I. -I.. -DIN_GETTEXT_TOOLS_GNULIB_TESTS=1 -I. -I. -I.. -I./.. -I../gnulib-lib -I./../gnulib-lib -I../intl -D_REENTRANT -I/home/haible/prefix-solaris9-sparc-cc/include -g -c -o test-spawn-pipe-child.

gnulib-tool: allow more comments

It can be useful to add comments in the 'Depends-on' section of a module description. This change lets gnulib-tool recognize these comments. 2011-06-13 Bruno Haible gnulib-tool: Allow comments in the 'Depends-on' section. * doc/gnulib.texi (Module description): Mention comment

Re: fclose/fflush and GNU RCS

() Thien-Thi Nguyen () Thu, 09 Jun 2011 13:55:52 +0200 (Please correct me if i'm wrong.) [Mr. T voice] I pity the fool! If so, that means RCS was masking this bug all along, right? To debug, i will need to find out where a call to ‘fclose’ presumes (incorrectly) that the file posit

Re: acls on HP-UX

Bruno Haible wrote: > Hi Jim, > > By the way, you may want to announce this support of HP-UX >= 11.11 ACLs in > the > coreutils/NEWS file. > >> I prefer to split strings, > > I don't like splitting strings that contain simply long messages. If adding > a line break before the string does not help

ftoastr: link error on HP-UX

Hi Paul, Trying to compile coreutils-8.12 on HP-UX 11.11 with gcc 4.2.4, I get this link error: CCLD od /usr/ccs/bin/ld: Unsatisfied symbols: strtof (first referenced in ../lib/libcoreutils.a(ftoastr.o)) (code) collect2: ld returned 1 exit status gmake[3]: *** [od] Error 1 The

Re: acls on HP-UX

Hi Jim, By the way, you may want to announce this support of HP-UX >= 11.11 ACLs in the coreutils/NEWS file. > I prefer to split strings, I don't like splitting strings that contain simply long messages. If adding a line break before the string does not help reaching the 80-columns limit, I leav

Re: acls on HP-UX

Bruno Haible wrote: > On HP-UX 11.11 and newer, I'm seeing these test failures: > > file_has_acl("tmpfile0") returned no, expected yes > FAIL: test-file-has-acl.sh > > FAIL: test-copy-acl.sh > FAIL: test-copy-file.sh > > It turns out that the support for HP-UX ACLs that I added on 2008-06-0