Jim Meyering wrote:
> This looks like a fine improvement.
> I reviewed only the first dozen or so.

Thanks for the review. Most of the patches follow the same idiom.

> This new policy looks particularly easy to violate accidentally.
> What do you think about adding a syntax-check rule to help avoid that?

Yes, this would be good. I don't know how to write such a syntax-check
rule (it uses perl, right?). But I can tell you the file list to which it
should be applied. Namely, all m4/*.m4 files, except

  close.m4
  dprintf.m4
  dup2.m4
  faccessat.m4
  fchdir.m4
  fclose.m4
  fcntl.m4
  fprintf-posix.m4
  open.m4
  printf-posix.m4
  snprintf.m4
  sprintf-posix.m4
  stdio_h.m4
  vasnprintf.m4
  vasprintf.m4
  vdprintf.m4
  vfprintf-posix.m4
  vprintf-posix.m4
  vsnprintf.m4
  vsprintf-posix.m4

Bruno
-- 
In memoriam Anna Göldi <http://en.wikipedia.org/wiki/Anna_Göldi>

Reply via email to