On 06/13/2011 09:38 AM, Bruno Haible wrote: > Eric Blake wrote: >> This looks reasonable to me (and no problem on the license change). > > Good, I've applied it, together with the same change for fseeko: > > > 2011-06-13 Bruno Haible <br...@clisp.org> > > fseeko: Provide a non-inline replacement of fseek(). > * lib/stdio.in.h (fseek): Don't provide if module 'fseek' is not used. > * modules/fseeko (Depends-on): Add fseek. > * modules/fseek (License): Change to LGPLv2+.
Actually, I'm wondering if we need modules/fseeko to depend on modules/fseek, or if we can come up with some other approach. After all, the whole idea is that portable programs should only be using fseeko, not fseek. But by making fseeko depend on fseek, then stdio.in.h will always end up replacing fseek even if it is not going to be used, and we lose the ability to issue gcc warnings about unintended use of fseek when fseeko should have been used. Of course, the fseeko replacement needs to fix flaws in the native fseek if there is no native fseeko, but if we can make it do that without also dragging in the fseek module, that would be better. I'm okay with a converse dependency, though, where fseek depends on fseeko. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
