the issue, and to
J. Random Hacker for providing suggestions and testing the patch.
--8<---cut here---end--->8---
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
er.home>"’ option to ensure that
your first patch is sent in response to the current thread.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
c test file with a ‘.plt’ extension, one patch
for each test file migrated to Test::Simple, one for fixing the XFAIL
hack...
Feel free to adapt to your particular case, since you understand the
dependencies between the change you made better than I do.
Can you send the updated patches?
Thanks.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Mathieu Lirzin writes:
> Lukas Fleischer writes:
>
>> On Sat, 07 Jul 2018 at 23:45:27, Mathieu Lirzin wrote:
>>> Lukas Fleischer writes:
>>>
>>> > As of Python 3.5, but unoptimized and optimized bytecode are stored
>>> > within .pyc files;
Lukas Fleischer writes:
> On Sat, 07 Jul 2018 at 23:45:27, Mathieu Lirzin wrote:
>> Lukas Fleischer writes:
>>
>> > As of Python 3.5, but unoptimized and optimized bytecode are stored
>> > within .pyc files; .pyo files are no longer generated. Update the Python
t; t/python-virtualenv.sh | 4
> t/python10.sh| 6 --
> t/python12.sh| 3 +--
> t/python3.sh | 1 -
> 8 files changed, 6 insertions(+), 30 deletions(-)
Thanks for the patch.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
stalling byte-compiled files installed in '__pycache__'
> subdirectories.
Tell me if I am overlooking something, but I guess this change will
imply that the uninstallation does not properly work with older python
version? Have you tried?
This support is important in the context of Auto
from the ‘t/compile*.sh’ files if the issue is closely related to an
already tested one, or if that is not the case you can add a new test
script.
Can you add a rationale in the commit message before the ChangeLog part
too?
Thanks.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Mathieu Lirzin writes:
> Previously ‘automake’ and ‘aclocal’ were handling the case of being
> interpreted as a Shell script by using a hack leveraging the fact that
> Shell and Perl has a compatible syntax intersection allowing those
> scripts to launch ‘perl’ from the shel
dhat.com/show_bug.cgi?id=1140725
>
> * lib/install-sh: Implement safer 'mkdir -p' test by running
> '$mkdirprog $mkdir_mode "$tmpdir"' first.
> (scriptversion): Bump.
> ---
> lib/install-sh | 25 +++++----
> 1 file changed, 17 insertions
ser look in the following days.
Thanks for reminding us.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
patch anyway. If you have other ideas regarding how
Python support in Automake could be improved, feel free to share your
ideas on or your patches on this list.
Sorry for the delay.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Previously ‘automake’ and ‘aclocal’ were handling the case of being
interpreted as a Shell script by using a hack leveraging the fact that
Shell and Perl has a compatible syntax intersection allowing those
scripts to launch ‘perl’ from the shell.
* bin/aclocal.in: Remove cryptic launching hack.
*
Hello,
Mathieu Lirzin writes:
> Mathieu Lirzin writes:
>
>>>>From a936b7d4cf8583ace0be6756b4b066a2c1aebe18 Mon Sep 17 00:00:00 2001
>> From: Paolo Bonzini
>> Date: Mon, 31 Oct 2016 13:30:50 +0100
>> Subject: [PATCH] automake: Do not require ltmain.sh for o
ure time.
WDYT?
[1] https://www.gnu.org/software/automake/manual/html_node/VPATH-Builds.html
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
through 2 runs of
>> configure / make / make install ?
>>
>
> Yes, the alternative to this is to run everything twice with a different
> `PYTHON=` value, unless I'm missing something and there's an easier way
> that would make this patch irrelevant.
Could you ex
Hello Paolo,
Mathieu Lirzin writes:
>>From a936b7d4cf8583ace0be6756b4b066a2c1aebe18 Mon Sep 17 00:00:00 2001
> From: Paolo Bonzini
> Date: Mon, 31 Oct 2016 13:30:50 +0100
> Subject: [PATCH] automake: Do not require ltmain.sh for out-of-tree libtool
>
> If Automake does not
I am opening a bug to keep track of this.
Mathieu Lirzin writes:
> Paolo Bonzini writes:
>
>> On 31/10/2016 13:30, Paolo Bonzini wrote:
>>> If Automake does not see LT_SUPPORTED_TAG, it assumes an old libtool
>>> that does not know about AC_REQUIRE_AUX_FILE. Ho
ution and sorry for the delay.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
gt; * doc/automake.texi (List of Automake options): Document the portability of
> the tar-ustar and tar-pax options better.
> ---
Pushed in commit fab4fb3aabf0a20d4c99fb7171de163d42e391e2.
Thanks.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
://git.savannah.gnu.org/cgit/automake.git/tree/README
>
> Where to send patches, and discuss the automake development process
> -and the design of new features.
> +and the design of new features.
>
> Simon
I have pushed commit 0186f3fccb9d1382acf6674f3ce385c447190d94
is bug. Here are the commands I have executed from
the Automake git repository:
$ PERL=/path/to/local/perl ./bootstrap
$ ./configure PERL=/path/to/local/perl
$ make
Can you provide a recipe to help me reproduce it?
Sorry for the delay.
Thanks.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
btool_bundled = 1;
+ }
elsif ($macro eq 'LT_SUPPORTED_TAG')
{
$libtool_tags{$args[1]} = 1;
$libtool_new_api = 1;
+ $libtool_bundled = 1;
}
elsif ($macro eq '_LT_AC_TAGCONFIG')
{
@@ -5498,6 +5508,7 @@ EOF
# Hardcode the tags supported by Libtool 1.5.
%libtool_tags = (CC => 1, CXX => 1, GCJ => 1, F77 => 1);
}
+ $libtool_bundled = 1;
}
}
--
2.9.5
Thanks.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
t; up to 1.4.
>
> This patch was never applied.
I will take a look at this in the weekend.
Thanks for reminding us.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
asedefs/V1_chap08.html#tag_08_03
>
> and look for "TZ".
Thanks for fixing that and for the reference.
> From 5b240b3b36766045a47a6ad89ae5f4550e81d534 Mon Sep 17 00:00:00 2001
> From: Paul Eggert
> Date: Thu, 21 Sep 2017 20:08:48 -0700
> Subject: [PATCH] * lib/mdate.sh (TZ): Use portable setting.
nitpick:
Hello,
Mathieu Lirzin writes:
> Right now we are using this branch naming scheme:
>
>- micro: for next micro version
>- minor: for next minor version
>- master: for next major version
>
> Given the current state of Automake I consider that the main scenario
Hello Eric,
Eric Dorland writes:
> This is a good change but it's not enough unfortunately to make it
> reproducible. mdate-sh also needs to support SOURCE_DATE_EPOCH. I'm
> working on a patch for that.
Thanks for working on that.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6
nu.org/cgit/automake.git/commit/?id=199e7a445040270fa5ef67623c56cde40d765199
>
Thanks for taking care of that.
IMO it is important that <https://www.gnu.org/licenses/gpl-howto.html>
reflects that change too. AIUI this page serves as a model for GPL
license notices.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
gt; ---
> lib/mdate-sh | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Applied with slight modifications in commit
7c25c996d1c7c212a5981aa0e9c4434b6f33f7b8
Thanks.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
ine flags.
Since the Fortran compiler list is actually maintained in Autoconf, I
prefer waiting for the review to be done there before applying this
patch in Automake.
Let me know when that's the case.
Thanks.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
[1] http://
#x27; => ['.S', '.sx']);
>
> # Fortran 77
Would it be possible for you to provide a minimal example/scenario which
demonstrates the issue solved?
Sorry for the delay.
Thank you.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
MS += bar src/bar
+noinst_LIBRARIES += libbar.a src/libbar.a
+bar_SOURCES = src/main.c
+bar_LDADD = libbar.a
+src_bar_SOURCES = src/main.c
+src_bar_LDADD = src/libbar.a
+libbar_a_SOURCES = src/foo.c
+libbar_a_CPPFLAGS = -DVAL=0
+src_libbar_a_SOURCES = src/foo.c
+src_libbar_a_CPPFLAGS = -DVAL=1
+
+# CLASHING PROGRAM + LIB
+noinst_PROGRAMS += libzap_a src/zap
+noinst_LIBRARIES += src/libzap.a
+libzap_a_SOURCES = src/main.c src/foo.c
+libzap_a_CPPFLAGS = -DVAL=2
+src_zap_SOURCES = src/main.c
+src_zap_LDADD = src/libzap.a
+src_libzap_a_SOURCES = src/foo.c
+src_libzap_a_CPPFLAGS = -DVAL=3
+
+# NON-CLASHING
+noinst_PROGRAMS += src/foo-uniq
+src_foo_uniq_SOURCES = src/main.c src/foo.c
+src_foo_uniq_CPPFLAGS = -DVAL=4
+END
+
+cat > src/foo.c << 'END'
+int
+foo ()
+{
+ return VAL;
+}
+END
+
+cat > src/main.c << 'END'
+int foo (void);
+
+int
+main ()
+{
+ return foo ();
+}
+END
+
+$ACLOCAL
+$AUTOCONF
+$AUTOMAKE --add-missing
+
+./configure
+$MAKE
+set +e
+./foo || fail_ "./foo should return 0"
+./src/foo; test $? = 1 || fail_ "./src/foo should return 1"
+./bar || fail_ "./bar should return 0"
+./src/bar; test $? = 1 || fail_ "./src/bar should return 1"
+./libzap_a; test $? = 2 || fail_ "./libfoo_a should return 2"
+./src/zap; test $? = 3 || fail_ "./src/prog_libfoo should return 3"
+./src/foo-uniq; test $? = 4 || fail_ "./foo_uniq should return 4"
+set -e
+$MAKE clean
--
2.9.4
Thank you for your good work, patience, and good will!
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
j-objname-clash.sh \
t/subobj-vpath-pr13928.sh \
t/subobj-pr13928-more-langs.sh \
t/subpkg.sh \
diff --git a/t/subobj-objname-clash.sh b/t/subobj-objname-clash.sh
new file mode 100644
index 00000..48408cb23
--- /dev/null
+++ b/t/subobj-objname-clash.sh
@@ -0,0 +1,94 @@
+#! /bin/sh
+# Copyright (C) 1996-2017 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# Make sure that object names don't clash when using subdir-objects.
+
+. test-init.sh
+
+mkdir -p src
+
+cat >> configure.ac << 'END'
+AC_PROG_CC
+AC_PROG_RANLIB
+AC_OUTPUT
+END
+
+cat > Makefile.am << 'END'
+AUTOMAKE_OPTIONS = subdir-objects foreign
+
+include prog.mk
+include lib.mk
+END
+
+# Check that programs with same basename don't end up sharing the same
+# object files.
+cat > prog.mk << 'END'
+noinst_PROGRAMS = foo src/foo
+src_foo_CPPFLAGS = -DVAL=1
+src_foo_SOURCES = src/foo.c src/main.c
+
+foo_CPPFLAGS = -DVAL=0
+foo_SOURCES = src/foo.c src/main.c
+END
+
+# Check the same thing for libraries.
+cat > lib.mk << 'END'
+noinst_LIBRARIES = libbar.a src/libbar.a
+
+libbar_a_SOURCES = src/foo.c
+libbar_a_CPPFLAGS = -DVAL=0
+
+src_libbar_a_SOURCES = src/foo.c
+src_libbar_a_CPPFLAGS = -DVAL=1
+
+noinst_PROGRAMS += bar src/bar
+
+bar_SOURCES = src/main.c
+bar_LDADD = libbar.a
+
+src_bar_SOURCES = src/main.c
+src_bar_LDADD = src/libbar.a
+END
+
+cat > src/foo.c << 'END'
+int
+foo ()
+{
+ return VAL;
+}
+END
+
+cat > src/main.c << 'END'
+int foo (void);
+
+int
+main ()
+{
+ return foo ();
+}
+END
+
+$ACLOCAL
+$AUTOCONF
+$AUTOMAKE --add-missing
+
+./configure
+$MAKE
+./foo || fail_ "./foo should return 0"
+./src/foo && fail_ "./src/foo should return 1"
+./bar || fail_ "./bar should return 0"
+./src/bar && fail_ "./src/bar should return 1"
+$MAKE clean
--
2.11.0
Thanks.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Hello,
Thomas Martitz writes:
> Am 23.04.2017 um 18:39 schrieb Mathieu Lirzin:
>
>>> From 8cd0a71abac70bbdcaac804dc7964fa9f34753a0 Mon Sep 17 00:00:00 2001
>>> From: Thomas Martitz
>>> Date: Mon, 13 Mar 2017 12:41:59 +0100
>>> Subject: [PATCH 1/3] Shor
+++
> 4 files changed, 207 insertions(+), 5 deletions(-)
> create mode 100644 t/subdir-objects-objname.sh
[...]
> From 5cf501dd932b4aabcc60b489e4f19c2ad8a757cc Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin
> Date: Thu, 13 Apr 2017 14:19:15 +0200
> Subject: [PATCH 2/3] Tes
Hello,
Thomas Martitz writes:
> Am 13.04.2017 um 14:59 schrieb Mathieu Lirzin:
>
>> I have not spent a long time digging through the mailing list archive,
>> There seem to have a lot of mail related to subdir-objects past bugs
>> which makes it hard to find the info
Mathieu Lirzin writes:
> See attached patch for more details. It adds a test which passes on
> current 'minor' branch but fails when applied on top of your patch. The
> intent is to allow you to reproduce the issue.
Here is the missing
S) -g
>
> resulted in objects:
> sub/sub_foo-foo.o
>
> now object file name is:
> sub/foo-foo.o
I don't know if this is feasible to only use long names when there is an
executable or library basename clash. I suppose this would not be trivial to
implement. WDYT?
Thanks and sorry for the long delay.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
any news from me before the
end of April. After that I will be more available (than ever) and we will
hopefully merge your patch!
I should have let you know about that situation.
Sorry about that.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Hello Thomas,
Thomas Martitz writes:
> Am 07.03.2017 um 18:44 schrieb Mathieu Lirzin:
>
>> Sorry, but I am still not convinced. While I agree it is only a small
>> change regarding the amount of code, this new option has to be
>> documented and maintained. Beyond o
Hello Thomas,
Thomas Martitz writes:
> Am 03.03.2017 um 16:06 schrieb Mathieu Lirzin:
>>
>> Thomas Martitz writes:
>>
>>> My use case is to make use of non-recursive Automake for faster build
>>> times and global dependencies, while also generate subdire
ngle line of _SHORTNAME, and
> without the defect when used inside a conditional. As a result, prog_a
> is built from prog_a-a.o regardless of where make was invoked, and is
> not built twice for two make invocations.
>
> The ability to use _SHORTNAME to override even that is, of course
Thomas Martitz writes:
> Am 02.03.2017 um 18:47 schrieb Mathieu Lirzin:
>> Hello Thomas,
>>
>> Thomas Martitz writes:
>>
>>> Am 16.01.2017 um 13:56 schrieb Thomas Martitz:Hello Jim and other folks,
>>>>
>>>> This is a friendly remind
, not being able to use '_SHORTNAME' with %reldir% and
%canon_reldir% inside Makefile snippets seems like a bug. What about
trying to fix it without the 'object-shortname' option?
I hope my feedback after such long review delay will not be too
frustrating. :/
Thank you.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
ntainer:
https://www.gnu.org/software/maintainer-tips
The following link extensively document most of the questions you might
have regarding GNU and the release process:
https://www.gnu.org/prep/maintain/maintain.html
For Automake specific release process, you can take a look at HACKING in
the repo.
Best regards.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
ledgeable about Automake usage.
WDYT?
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Mathieu Lirzin writes:
> Hello,
>
> This patch adds a test driver for Guile Scheme by using the SRFI-64
> Scheme API for test suites:
>
> http://srfi.schemers.org/srfi-64/srfi-64.html
>
> Since Guile is the standard extensibility interpreter for GNU
> software,
The user can now directly test Guile code with SRFI-64 Scheme API.
* lib/test-driver.scm: New script.
* lib/Makefile.inc (dist_script_DATA): Add it.
* doc/automake.texi (Guile Tests): New section.
* t/guile-tests-doc.sh: New test.
* t/list-of-tests.mk: Add it.
* t/ax/am-test-lib.sh: Adapt to it.
-
Guile code out of the box. This test driver is already
used by GNU Guix.
This is my first contribution to Automake so I haven't filed my
copyright assignment yet.
TIA for your comments or reviews.
Mathieu Lirzin (1):
guile: add a test driver script
doc/automake.texi
The user can now directly test Guile code with SRFI-64 Scheme API.
* lib/test-driver.scm: New script.
* lib/Makefile.inc (dist_script_DATA): Add it.
* doc/automake.texi (Guile Tests): New section.
* t/guile-tests-doc.sh: New test.
* t/list-of-tests.mk: Add it.
* t/ax/am-test-lib.sh: Adapt to it.
-
Guile code out of the box. This test driver is already
used by GNU Guix.
This is my first contribution to Automake so I haven't filed my
copyright assignment yet.
TIA for your comments and reviews.
Mathieu Lirzin (1):
guile: add a test driver script
doc/automake.texi
51 matches
Mail list logo
