Lukas Fleischer <lfleisc...@lfos.de> writes: > On Sat, 07 Jul 2018 at 23:45:27, Mathieu Lirzin wrote: >> Lukas Fleischer <lfleisc...@lfos.de> writes: >> >> > As of Python 3.5, but unoptimized and optimized bytecode are stored >> > within .pyc files; .pyo files are no longer generated. Update the Python >> > tests such that the test do not fail if .pyo files are missing. >> >> Like in other message, it is important that the test suite passes >> with older python version. Have you checked? > > Note that this patch only removes some checks, so after this patch, > everything is strictly less restrictive. I don't see how this could > possibly break backwards compatibility. > > Nevertheless, I just made sure that everything still works with Python > 2.7.15.
OK I overlooked that. I think a inlined comment in the concerned tests explaining why python object files presence is not tested would help future code reader to understand. Can you send an updated patch? Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
