* Stefano Lattarini wrote on Tue, Sep 07, 2010 at 03:15:54AM CEST:
> > --- a/lib/am/check.am
> > +++ b/lib/am/check.am
> > + { echo "TEST_LOGS = "; \
> > + for f in $$list; do \
> > + test .log = $$f ||
A small comment update, for maint. This is documented in autoconf.texi
'Failure in Make Rules'.
Cheers,
Ralf
Posix 2008 requires make to set errexit.
* lib/am/check.am: Update comment.
diff --git a/lib/am/check.am b/lib/am/check.am
index e519391..c612b22 100644
--- a/lib/am/check.a
* Ralf Wildenhues wrote on Sun, Aug 08, 2010 at 01:58:45PM CEST:
> * Stefano Lattarini wrote on Sun, Jun 27, 2010 at 06:14:41PM CEST:
> > Modernize, improve and/or extend test scripts `conf*.test'.
> >
[...]
> > * tests/confh.test: Use the `configure.in' stub created by ./defs,
> > rather than wri
Hello Ralf. It seems you are confusing "set -e" and "set -r"...
On Tuesday 07 September 2010, Ralf Corsepius wrote:
> On 09/06/2010 07:51 PM, Ralf Wildenhues wrote:
> > Hello Ralf,
> >
> > * Ralf Corsepius wrote on Mon, Sep 06, 2010 at 07:49:04PM CEST:
> >> On 09/06/2010 05:18 PM, Stefano Latt
On 09/06/2010 07:51 PM, Ralf Wildenhues wrote:
Hello Ralf,
* Ralf Corsepius wrote on Mon, Sep 06, 2010 at 07:49:04PM CEST:
On 09/06/2010 05:18 PM, Stefano Lattarini wrote:
This is mostly a cosmetic/consistency patch. I hope you'll find it
worth applying nonetheless.
Internationalization test
The updated patches passed "make check", so I'm pushing them.
They are attached, just for the record.
Regards,
Stefano
From 521dda8c24be40219aaff2611ec30c8501494389 Mon Sep 17 00:00:00 2001
From: Stefano Lattarini
Date: Wed, 2 Jun 2010 21:45:57 +0200
Subject: [PATCH 1/4] Tests defs: $srcdir is
Oh, and I forgot to ask: OK to push with this last amending applied?
Regards,
Stefano
On Monday 06 September 2010, Bruno Haible wrote:
> Hello Stefano,
Hi Bruno. Thanks for your all your quick reviews.
> Ralf said:
> > Give Bruno some time for comments before applying to the
> > pot-primary branch, please.
>
> Yes, please. Give me always between 2 days (48 hours) and 7 days to
>
Hi Stefano,
> > > Internationalization tests: prefer `test ! -r' over `test ! -f'
> >
> > Why? ...
> Just in case the file is erroneously created as (say) a directory or
> a symlink, a situation `test -f' would not catch.
I see, thanks. This is indeed more probable than that an unreadable
file i
On Monday 06 September 2010, Bruno Haible wrote:
> Hi Stefano,
>
> > Internationalization tests: prefer `test ! -r' over `test ! -f'
>
> Why? Why is it more important to check that an expected file has
> read permissions, than to check that it is a regular file?
Just in case the file is erroneousl
On Monday 06 September 2010, Bruno Haible wrote:
> Hi Stefano,
>
> > ... since the failing `test' is in a
> > `||' compound command. Fix this problem by explicitly calling
> > `Exit 1' where needed.
>
> Yes, please apply. I did not know until today that && and ||
> commands behave specially unde
Hi Stefano,
> Internationalization tests: prefer `test ! -r' over `test ! -f'
Why? Why is it more important to check that an expected file has
read permissions, than to check that it is a regular file?
This is not an objection. I just find it odd to use 'test -f' for
the positive test and 'test
On Monday 06 September 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Mon, Sep 06, 2010 at 04:56:50PM CEST:
> > Internationalization tests: prefer `make distdir' over `make
> > dist'.
> >
> > Instead of running `make dist', then uncompressing the created
> > tarball, and then grepping
Hi Stefano,
> ... since the failing `test' is in a
> `||' compound command. Fix this problem by explicitly calling
> `Exit 1' where needed.
Yes, please apply. I did not know until today that && and || commands behave
specially under 'set -e'.
Bruno
Hi Stefano,
> simply run `make distdit' and anylize. This is both faster and
s/anylize/analyze/
This patch is a nice simplification. And maybe it also increases portability
(I don't know which file names a tarball will contain when you create it on
a file system which is case-insignificant with
On Sunday 05 September 2010, Ralf Wildenhues wrote:
> Hello,
>
> * Jim Meyering wrote on Sat, Sep 04, 2010 at 07:28:58PM CEST:
> > Stefano Lattarini wrote:
> > > What about instead making the names of the temporaries
> > > source/build/install directories used by "make distcheck"
> > > configurabl
Hi Stefano,
> And the attached patch should be squashed in previous patch n.3.
This is also fine with me. Thanks!
Bruno
Hello Stefano,
Ralf said:
> Give Bruno some time for comments before applying to the pot-primary
> branch, please.
Yes, please. Give me always between 2 days (48 hours) and 7 days to react.
> tests/README suggest
Oops, I had completely missed this file. Now that I read it, I see that the
'pot-m
On Monday 06 September 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Mon, Sep 06, 2010 at 09:22:51PM CEST:
> > What about my pending patch "Testsuite: use $SHELL to run tests
> > which are shell scripts."?
>
> I'll reply in that thread.
>
> > That should ensure that the tests are ru
On Monday 06 September 2010, Ralf Wildenhues wrote:
> Hello Stefano,
>
> * Stefano Lattarini wrote on Mon, Sep 06, 2010 at 05:06:23PM CEST:
> > This patch fixes potential false negatives in the new tests.
> >
> > Internationalization tests: do not ignore failures.
> >
> > Some tests used the idi
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 09:22:51PM CEST:
> On Monday 06 September 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Mon, Sep 06, 2010 at 05:06:23PM CEST:
> > That also means, that we should probably be more cautious with
> > removing `|| Exit 1' instances from
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 08:59:20PM CEST:
> On Monday 06 September 2010, Ralf Wildenhues wrote:
> > > "Unfortunately", there is no bug fixed by this patch. I can only
> > > offer the above argumentation (plus consistency of $testsrcdir
> > > and $top_testsrcdir).
> >
> >
On Monday 06 September 2010, Ralf Wildenhues wrote:
> > "Unfortunately", there is no bug fixed by this patch. I can only
> > offer the above argumentation (plus consistency of $testsrcdir
> > and $top_testsrcdir).
>
> Your verbose explanation above and this seem to contradict each
> other. ;-)
I'
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 04:56:50PM CEST:
> Internationalization tests: prefer `make distdir' over `make dist'.
>
> Instead of running `make dist', then uncompressing the created
> tarball, and then grepping the uncompressed tar archive, we can
> simply run `make distdit'
Hello Stefano,
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 03:07:30PM CEST:
> I noticed some problems (both serious and cosmetic) in your patch.
> Here is a summary of the in decreasing order of relevance:
>
> 1. You sometimes failed to use `$MAKE' instead of `make' and `Exit'
> instea
Hello Stefano,
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 05:06:23PM CEST:
> This patch fixes potential false negatives in the new tests.
> Internationalization tests: do not ignore failures.
>
> Some tests used the idiom:
> test $builddir = '.' || test ! -f posub/foo-bar.pot
> to check
Hello Ralf,
* Ralf Corsepius wrote on Mon, Sep 06, 2010 at 07:49:04PM CEST:
> On 09/06/2010 05:18 PM, Stefano Lattarini wrote:
> >This is mostly a cosmetic/consistency patch. I hope you'll find it
> >worth applying nonetheless.
> >Internationalization tests: prefer `test ! -r' over `test ! -f'
>
Hi Stefano,
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 11:28:27AM CEST:
> On Monday 06 September 2010, Ralf Wildenhues wrote:
> > Well, in v1.11-139-g6fee87c and before that in v1.11-138-gc6bbc45
> > the above line was move resp. introduced. Was that a buglet in the
> > latter patch?
> No
On 09/06/2010 05:18 PM, Stefano Lattarini wrote:
This is mostly a cosmetic/consistency patch. I hope you'll find it
worth applying nonetheless.
Regards,
Stefano
-*-*-
Internationalization tests: prefer `test ! -r' over `test ! -f'
test -r is non-portable.
Very old shells do not support
This is mostly a cosmetic/consistency patch. I hope you'll find it
worth applying nonetheless.
Regards,
Stefano
-*-*-
Internationalization tests: prefer `test ! -r' over `test ! -f'
We now use `test ! -r' rather than `test ! -f' to check that
a file does not exists (`test ! -e' would be eve
This patch fixes potential false negatives in the new tests.
Regards,
Stefano
-*-*-*-
Internationalization tests: do not ignore failures.
Some tests used the idiom:
test $builddir = '.' || test ! -f posub/foo-bar.pot
to check that a file is build in the source directory, not in
the build di
I'd like to add also the following "optimization" patch.
Regards,
Stefano
-*-*-*-
Internationalization tests: prefer `make distdir' over `make dist'.
Instead of running `make dist', then uncompressing the created
tarball, and then grepping the uncompressed tar archive, we can
simply run `mak
And the attached patch should be squashed in previous patch n.3.
Sorry for the noise,
Stefano
From 97c6d5fb46f7f98dce21cd38b1e83b5ea1f2ffdc Mon Sep 17 00:00:00 2001
From: Stefano Lattarini
Date: Mon, 6 Sep 2010 15:20:47 +0200
Subject: [PATCH] SquashMe
---
ChangeLog|3 ++-
On Monday 06 September 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Mon, Sep 06, 2010 at 01:05:25AM CEST:
> > On Sunday 05 September 2010, Ralf Wildenhues wrote:
> > > * Stefano Lattarini wrote on Fri, Sep 03, 2010 at 12:14:18AM
CEST:
> > > > -srcdir=${srcdir-'@abs_srcdir@'}
> > > >
34 matches
Mail list logo
