* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 08:59:20PM CEST:
> On Monday 06 September 2010, Ralf Wildenhues wrote:
> > > "Unfortunately", there is no bug fixed by this patch. I can only
> > > offer the above argumentation (plus consistency of $testsrcdir
> > > and $top_testsrcdir).
> >
> > Your verbose explanation above and this seem to contradict each
> > other. ;-)
> I'll probably look like an idiot unable to understand basic humourism,
> but I have to ask... Why?
Well, you explained that with the old code,
srcdir=${srcd...@abs_srcdir@}
it was still necessary that afterwards, $srcdir would be equal to the
absolute source directory name, which means, a user setting of $srcdir
could cause a bug, like this:
srcdir=elsewhere ./foo.test
> The old code wasn't bugged, it was just
> uselessly redundant (which, mind it, is IMHO a good enough reason to
> accept the patch). Does this makes sens?
No. The old code *was* buggy, and that's why your patch is ok.
;-)
Thanks,
Ralf
