Hi Stefano,
* Stefano Lattarini wrote on Mon, Sep 06, 2010 at 11:28:27AM CEST:
> On Monday 06 September 2010, Ralf Wildenhues wrote:
> > Well, in v1.11-139-g6fee87c and before that in v1.11-138-gc6bbc45
> > the above line was move resp. introduced. Was that a buglet in the
> > latter patch?
> No, there's no bug to be fixed that I know of. It's just that we
> really need $testsrcdir to be the *real* absolute path of $(srcdir),
> so there's no need to read it from the environment when we can just
> AC_SUBST it (also, currently we have to absolutize $testsrcdir, which
> add a fork for every test).
I gather that you are saying that the
srcdir=${srcd...@abs_srcdir@}
part was never needed since v1.11-138-gc6bbc45, and at that time already
should have been
srcd...@abs_srcdir@
(modulo quoting). In that case, the patch is fine, thanks.
> > If yes, then this patch is fine.
> "Unfortunately", there is no bug fixed by this patch. I can only
> offer the above argumentation (plus consistency of $testsrcdir and
> $top_testsrcdir).
Your verbose explanation above and this seem to contradict each other.
;-)
Thanks,
Ralf
