Re: Review Request 130232: Fix crash during musicbrainz search

https://git.reviewboard.kde.org/r/130232/#review103636 ------- On Авг. 23, 2017, 3:40 п.п., Sergey Ivanov wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 130232: Fix crash during musicbrainz search

marked as submitted. Review request for Amarok. Changes --- Submitted with commit 88ee85a8333cf54dc123fef5e07a1c92ab9f7261 by Sergey Ivanov to branch master. Bugs: 328359 https://bugs.kde.org/show_bug.cgi?id=328359 Repository: amarok Description --- + Fixed search result

Re: Review Request 130232: Fix crash during musicbrainz search

- Thanks, Sergey Ivanov

Review Request 130232: Fix crush during musicbrainz search

0ffb284055 src/musicbrainz/MusicBrainzXmlParser.h c7f9e72c0e src/musicbrainz/MusicBrainzXmlParser.cpp 290a275aed Diff: https://git.reviewboard.kde.org/r/130232/diff/ Testing --- Thanks, Sergey Ivanov

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

> On Июнь 20, 2016, 10:42 п.п., Olivier Churlaud wrote: > > Ship It! > > Olivier Churlaud wrote: > It should work with new version: it's a must. If people complain about > older version being broken, then we can see. But archlinux won't be able to > ship Amarok without this fix. Yes, and

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

(version range) of ffmpeg. But if you pretty sure that your version will compile and work with ffmpeg 0.11 It's ok to keep It like this. Btw probably It's time to drop support of antiant versions like 0.7 and 0.8. - Sergey Ivanov On Янв. 9, 2016, 6:24 д.п., Diane T

Re: Trying to solve bug 240409

t; >> Ya, trying to get the feature working on Taglib was the next thing I was >> going to do. I will try to find more information about it and get back. >> >>> >>> Let's defer the decision how to represent this in Amarok until underlying >>> libraries are ready, I must say that the idea to use MultiTrack may end >>> up to >>> be the good way, but please let us think about this more. >>> >> I think Multitrack is how QuickTime does it( or I have a really old >> version ) and it looks pretty good. >> >> P.S sorry for submitting the patch, I was almost done with it when I read >> the email >> >>> [1] https://mail.kde.org/mailman/listinfo/taglib-devel >>> >>> Matěj >>> >> >> > > ___ > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel > > -- Sergey Ivanov ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: compile error: ‘avformat_close_input’ was not declared in this scope

t;> >> This is likely the commit that's causing problems: >> >> http://quickgit.kde.org/index.php?p=amarok.git&a=commit&h=5e609a6dccb523655205eabc29d26cda503796c2 >> Something it changed must have been introduced after version 0.7. >> (Easy to do, ffmpeg's API changes are a nightmare.) Sergey, could you >> look at this please? > > > > > ___ > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel -- Sergey Ivanov ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Make MusicBrainz tagger more accurate and easy to use

: /home/kash/workspace/amarok.git/src/musicbrainz/MusicBrainzFinder.cpp:441:114: error: macro "Q_FOREACH" passed 3 arguments, but takes just 2 /home/kash/workspace/amarok.git/src/musicbrainz/MusicBrainzFinder.cpp:520:43: error: macro "Q_FOREACH" passed 3 arguments, but takes just

Re: Review Request: Avoid memory error in MP4TagHelper::embeddedCover() (bug 283675)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102828/#review7287 --- Ship it! Looks good for me. - Sergey Ivanov On Oct. 13

Re: Review Request: Avoid memory error in MP4TagHelper::embeddedCover() (bug 283675)

ttp://git.reviewboard.kde.org/r/102828/#comment6308> Nope, this is not the same thing. Originaly function tried to find largest picture (that is why variable was called maxSize :) ), but now It will return first one that bigger then 1024. - Sergey Ivanov On Oct. 11, 2011, 4:48 p.m., Charles Reiss

Re: Review Request: Fix translation in EditFilterDialog filter string

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102443/#review6047 --- Ship it! There is nothing to review, just commit It. Don't forg

Re: [amarok] /: Switch MusicDNS decoder back from avcodec_decode_audio2 to avcodec_decode_audio3.

rnings unless we work out which minor version it was added on and > check for that as well. > > Sam > > On 17/05/11 18:53, Lydia Pintscher wrote: >> changelog please :) >> >> Also: Is this version bump ok? How old is 0.6? >> >> >> Cheers &

Re: Review Request: Fix use of deprecated avcodec_decode_audio2 in MusicBrainz support

visit: > http://git.reviewboard.kde.org/r/101372/ > --- > > (Updated May 16, 2011, 7:41 p.m.) > > > Review request for Amarok and Sergey Ivanov. > > > Summary > --- > > The function avcode

Re: Amarok Crash in collection browser

. > > Peter > > "Happiness makes up in height what it lacks in length" > -- Robert Frost > > ___ > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel > > -- Sergey Ivan

Re: Review Request: Podcast episode filename configuration

> On March 11, 2011, 9:54 p.m., Sergey Ivanov wrote: > > src/core-impl/podcasts/sql/SqlPodcastProvider.cpp, line 1461 > > <http://git.reviewboard.kde.org/r/100686/diff/2/?file=10665#file10665line1461> > > > > One more crash on track without album. > &g

Review Request: Organize Collection Wizard

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100852/ --- Review request for Amarok. Summary --- Merged Source and Destination

Re: Review Request: Adds new Track Progression mode which only plays queued items

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100405/#review1911 --- Ship it! Feature seems useful and code looks good. - Sergey

Re: Review Request: Podcast episode filename configuration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100686/#review1910 --- src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cp

Re: Review Request: Podcast episode filename configuration

> On Feb. 21, 2011, 7:14 a.m., Bart Cerneels wrote: > > Dialog needs to be improved and the available tokens (%bla) need to be > > explained with an info text. > > File renaming implemented. > > Removing filename layout from the base class PodcastChannel, it's SQL > > specific. > > Code formatt

Re: Review Request: Refactoring of tag dialog, remove statistics pane

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100758/#review1694 --- When I try to find tags for several tracks in MusicBrainz DB, Ta

Re: Podcast episode filename config - field suggestions

included? > ___ > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel > > -- Sergey Ivanov ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Podcast episode filename configuration

> On Feb. 19, 2011, 8:12 p.m., Sergey Ivanov wrote: > > src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp, line 28 > > <http://git.reviewboard.kde.org/r/100686/diff/1/?file=9514#file9514line28> > > > > Better to use QLatin1Stri

Re: Review Request: Podcast episode filename configuration

> On Feb. 19, 2011, 8:12 p.m., Sergey Ivanov wrote: > > src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp, line 28 > > <http://git.reviewboard.kde.org/r/100686/diff/1/?file=9514#file9514line28> > > > > Better to use QLatin1Stri

Re: Review Request: Podcast episode filename configuration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100686/#review1518 --- Almost all new code doesn't follow amarok code formating style (

Re: Review Request: fix bug 266171. Add HTML tag in guitar tabs applet for tabs from ultimate-guitar.com

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100670/#review1465 --- Ship it! Looks good, and make sense. - Sergey On Feb. 16, 20

Re: Review Request: New dynamic bias

> On Feb. 13, 2011, 7:36 a.m., Sergey Ivanov wrote: > > Some times I get several copies of 1 track in newer generated playlist > > (very rarely in random mode, and frequently with match by rating - my > > collection is very bad rated, so there are not so many tracks to

Re: Review Request: New dynamic bias

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100630/#review1400 --- Some times I get several copies of 1 track in newer generated pl

Re: Review Request: New dynamic bias

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100630/#review1378 --- In file included from /home/kash/workspace/amarok.git/tests/dyn

Re: MusicBrainz

ll see what the problem is: > http://www.abload.de/image.php?img=colorsd9fv.png > > Regards, > Martin > ___ > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel > -- Sergey Ivanov

Re: MusicBrainz

___ > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel > -- Sergey Ivanov ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Expansion of MusicBrainz dialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100443/#review1063 --- Check out latest git, there are some changes according to your e

Re: Review Request: Implements a preview button in the collection organizer dialog along with an "automatic preview" checkbox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100270/#review1007 --- Good Idea, I would found such feature very useful when I was reo

Re: Review Request: Remove includeCollection and excludeCollection

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100425/#review1006 --- Ship it! If It unused, and removing of It won't have side-effec

Organize collection dialog. Unavailable parts replacement

organize collection files. But some of this tags/fields unknown, %disc for example. So we should move tracks to "collectionDir/Artist_Name/NA/Disk_Number/" folder or to "collectionDir/Artist_Name/Disk_Number/"? -- Sergey Ivanov __

Re: Amarok 2.4

2011/1/16 Mark Kretschmann : > Anyone got an idea how or why this could happen? > > Cheers, Mark. > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel > Well, collection scanner runs by timer, there is no file system monitor

Re: Review Request: File tag handler refactoring

MetaTagLib implementation. :) - Sergey On Jan. 12, 2011, 1:58 p.m., Sergey Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Filter Editor Dialog "restyling"

/suggestions/comments? :) - Sergey On Dec. 27, 2010, 12:58 p.m., Sergey Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: "store statistics to file" should not include "rating" - only the play-changing statistics. Rating should be saved along with other tags normally.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100231/#review916 --- Ship it! 2.4 released, so Ship It. - Sergey On Dec. 21, 2010,

Re: Review Request: Fix Inconsistencies with Organize Files Dialog when canceling Dialog

> On Jan. 8, 2011, 11:43 a.m., Sergey Ivanov wrote: > > I think that It's a bad idea to apply any settings when user press Cancel, > > so storing Format Presets should stay in onAccept slot. > > Agree with second statement. > > > > And finally this patc

Re: Review Request: Change tooltips for time labels according to leftTimeDisplayRemaining setting

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100371/#review913 --- src/widgets/ProgressWidget.cpp

Re: Review Request: Prevent crash in "Similar Artists" applet when nothing playing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100385/#review912 --- Ship it! Make sense. Ship it. - Sergey On Jan. 14, 2011, 3:23

Re: Review Request: coverbling applet (playground) build was broken in 2.4 git

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100395/#review911 --- Ship it! Ship It. - Sergey On Jan. 15, 2011, 2:58 p.m., Manu

Re: Review Request: Patch for resolving Inconsistent display of track numbering in Collection browser and Playlist. JJ Bug No. 260973

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100394/#review910 --- Ship it! Looks ok. - Sergey On Jan. 15, 2011, 3:52 p.m., Bhar

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated Jan. 12, 2011, 1:58 p.m.) Review request for Amarok. Changes --

Re: Localized icons in Amarok

://mail.kde.org/mailman/listinfo/amarok-devel > > IMHO, Hz looks much more better then Гц. -- Sergey Ivanov ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Fix Inconsistencies with Organize Files Dialog when canceling Dialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100321/#review771 --- I think that It's a bad idea to apply any settings when user pres

Re: Review Request: File tag handler refactoring

> Well, these colors where there before me, screenshot used to show that now Amarok can guess tags from full track path, not only from filename. And this feature is just a minor addition, not the main patch target. :) -- Sergey Ivanov ___ Amarok-d

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2011-01-07 20:29:46.128664) Review request for Amarok. Changes

Re: Review Request: Fixed Organize Files Dialog to allow for loading presets when in advanced mode

> On 2010-12-27 08:41:37, Sergey Ivanov wrote: > > Looks good. > > Philipp Schmidt wrote: > Then someone with push-access will need to push :D Done. - Sergey --- This is an automatically generated e-mail. To

Re: Review Request: Filter Editor Dialog "restyling"

---------- On 2010-12-27 12:58:32, Sergey Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100250/

Re: Review Request: Filter Editor Dialog "restyling"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100250/ --- (Updated 2010-12-27 12:58:32.852794) Review request for Amarok. Changes

Re: Review Request: Fix for USB storage mode media players

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100194/#review621 --- src/MediaDeviceCache.cpp

Re: Review Request: Fixed Organize Files Dialog to allow for loading presets when in advanced mode

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100244/#review619 --- Ship it! Looks good. - Sergey On 2010-12-25 21:34:18, Philipp

Re: Review Request: "store statistics to file" should not include "rating" - only the play-changing statistics. Rating should be saved along with other tags normally.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100231/#review618 --- Ship it! Looks good. - Sergey On 2010-12-21 17:04:14, Alan Ez

Review Request: Filter Editor Dialog "restyling"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100250/ --- Review request for Amarok. Summary --- Polish "a bit" filter editor d

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2010-12-21 13:21:19.978675) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2010-12-20 15:05:55.778862) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2010-12-18 13:55:38.595673) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

by taglib, but not listed before. - Sergey --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/#review555 --- On 2010-12

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/#review517 ------- On 2010-12-11 11:52:39, Sergey Ivanov wrote: > > --

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2010-12-11 11:52:39.805321) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2010-12-08 22:15:26.453918) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2010-12-06 19:39:13.412353) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

plicitly request it now. Nope, there is no charset detector at all. - Sergey --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/#review458 -----

Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- Review request for Amarok. Summary --- Rewrite tag reading stuff to m

Re: Review Request: Remove addMatchTo and addMatch( Meta::DataPtr )

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100182/#review452 --- Ship it! Looks good, and works for me. - Sergey On 2010-12-01

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100168/#review411 --- Ship it! Well, now It looks good for me. But here http://pastebi

Re: Review Request: Merge tag reading and writing into one file.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100169/#review406 --- Ship it! I've been thinking about It, but you made It first. :)

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100168/#review407 --- You got me wrong. I meant you should check albums and artists for

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100168/#review401 --- src/playlistmanager/sql/SqlUserPlaylistProvider.cpp

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100168/#review395 --- src/playlistmanager/sql/SqlUserPlaylistProvider.cpp

Re: "Edit Track Details" dialog

ure.fr > Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org). > ___ > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel > -- Sergey Ivanov ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Bug 240811: Moodbar support and issue with ProxyTrack::uidUrl()

2010/11/18 Nikhil Marathe : > On Thu, Nov 18, 2010 at 2:51 PM, Sergey Ivanov <123k...@gmail.com> wrote: > > I'm not too sure about this, since the moodbar plugin can have > moodbars cached, and changing the uidUrl() > means that the cache is invalidated. Also the MD5 make

Re: Bug 240811: Moodbar support and issue with ProxyTrack::uidUrl()

t; MoodbarManager, but > uidUrl() is the most apt. > > Regards, > Nikhil > ___ > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel > Wha

Re: Review Request: Album Artist. Further support improvements

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-17 14:32:40.538323) Review request for Amarok. Changes

Re: Review Request: Album Artist. Further support improvements

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-17 13:59:32.765324) Review request for Amarok. Changes

Re: Review Request: Album Artist. Further support improvements

-11-16 11:38:35, Sergey Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100135/ > --- > > (Upd

Re: Review Request: Added support for showing compilations on Ipod

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100156/#review349 --- Ship it! src/core-impl/collections/ipodcollection/handler/IpodH

Re: Review Request: Album Artist. Further support improvements

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-16 11:38:35.670498) Review request for Amarok. Summary

Re: Review Request: Album Artist. Further support improvements

should the noCompilation variable be removed unless you can argue why this > > doesn't make sense. > > > > Sergey Ivanov wrote: > Track could only has 2 states: belong_to_compilation or > belong_to_regular_album. But to indicate this 1bit information is currently

Re: Review Request: Album Artist. Further support improvements

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-16 11:21:17.152719) Review request for Amarok. Changes

Re: Review Request: Album Artist. Further support improvements

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/#review339 --- On 2010-11-15 15:34:42, Sergey Ivanov wrote: > > ---

Re: Review Request: Album Artist. Further support improvements

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-15 15:34:42.346771) Review request for Amarok. Changes

Re: Review Request: Album Artist. Further support improvements

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-14 22:37:15.817713) Review request for Amarok. Changes

Re: Review Request: Album Artist. Further support improvements

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-12 06:43:40.674045) Review request for Amarok. Summary

Re: Review Request: Album Artist. ?urther support improvements

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-12 06:43:15.275265) Review request for Amarok. Changes

Re: Review Request: Album Artist for QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-10 19:35:59.303372) Review request for Amarok. Changes

Re: Review Request: Album Artist for QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-10 15:25:41.998719) Review request for Amarok. Changes

Re: Review Request: Fixes for TagUtility. Turn back MPC files support.

, Sergey Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100129/ > --- > > (Update

Re: Review Request: Fixes for TagUtility. Turn back MPC files support.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100129/ --- (Updated 2010-11-07 08:43:45.646733) Review request for Amarok. Changes

Re: Review Request: Album Artist for QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-06 22:10:42.870991) Review request for Amarok. Changes

Re: Review Request: Album Artist for QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-06 19:58:32.908609) Review request for Amarok. Summary

Re: Review Request: Album Artist for QueryMaker

----------- On 2010-11-06 14:41:00, Sergey Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100135/ > ---

Re: Review Request: Album Artist for QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- (Updated 2010-11-06 14:41:00.191557) Review request for Amarok. Changes

Review Request: Album Artist for QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ --- Review request for Amarok. Summary --- Add new QueryType - AlbumArtis

Re: Review Request: Helper Methods for FileType Enum in new Class FileTypeSupport, get Type in TagDialog from Database instead of Extension, some Code Changes as Example of the Advantage of the Helpe

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100088/#review306 --- src/widgets/MetaQueryWidget.cpp

Re: Review Request: Helper Methods for FileType Enum in new Class FileTypeSupport, get Type in TagDialog from Database instead of Extension, some Code Changes as Example of the Advantage of the Helpe

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100088/#review303 --- Ship it! Looks Ok for me. But there should not be space between

Re: Review Request: Helper Methods for FileType Enum in new Class FileTypeSupport, get Type in TagDialog from Database instead of Extension, some Code Changes as Example of the Advantage of the Helpe

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100088/#review301 --- shared/FileType.cpp

Re: Review Request: Helper Methods for FileType Enum in new Class FileTypeSupport, get Type in TagDialog from Database instead of Extension, some Code Changes as Example of the Advantage of the Helpe

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100088/#review298 --- shared/FileType.cpp

  1   2   >