----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100194/#review621 -----------------------------------------------------------
src/MediaDeviceCache.cpp <http://git.reviewboard.kde.org/r/100194/#comment456> & has greater priority then &&, parenthesis don't make difference. src/core-impl/collections/umscollection/support/UmsConnectionAssistant.cpp <http://git.reviewboard.kde.org/r/100194/#comment457> We still need check drive for existence to prevent crashes. What was wrong with HP devices? - Sergey On 2010-12-08 21:55:12, Lukáš Tinkl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100194/ > ----------------------------------------------------------- > > (Updated 2010-12-08 21:55:12) > > > Review request for Amarok. > > > Summary > ------- > > This patch fixes identifying general USB storage mode media players, plus > adds some minor fixes and cleanups. The main change is in > UmsConnectionAssistant::identify method. > > > Diffs > ----- > > src/MediaDeviceCache.cpp babb8ff > > src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp > 92339ff > src/core-impl/collections/umscollection/support/UmsConnectionAssistant.cpp > 5956a2b > > Diff: http://git.reviewboard.kde.org/r/100194/diff > > > Testing > ------- > > > Screenshots > ----------- > > Amarok in USB mode > http://git.reviewboard.kde.org/r/100194/s/21/ > > > Thanks, > > Lukáš > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
