> On Feb. 19, 2011, 8:12 p.m., Sergey Ivanov wrote: > > src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp, line 28 > > <http://git.reviewboard.kde.org/r/100686/diff/1/?file=9514#file9514line28> > > > > Better to use QLatin1String here, and why don't write just > > filenameLayout == QLatin1String( "%default" ) instead? > > Sandeep Raghuraman wrote: > Tried using QLatin1String, but I'm unable to figure out how to convert > QString into QLatin1String. Should I change the original member variable to > QLatin1String?
You don't need to do It QLatin1String has proper operator for this (http://doc.qt.nokia.com/latest/qlatin1string.html#operator-eq-eq). - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100686/#review1518 ----------------------------------------------------------- On Feb. 19, 2011, 5:36 p.m., Sandeep Raghuraman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100686/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2011, 5:36 p.m.) > > > Review request for Amarok and Bart Cerneels. > > > Summary > ------- > > Adds a dialog to configure podcast episode filenames. Added a filenamelayout > column to podcastchannels table and a member to PodcastMeta to hold the > filename layout. Podcast database version updated to 5. > > > This addresses bug 155075. > https://bugs.kde.org/show_bug.cgi?id=155075 > > > Diffs > ----- > > src/CMakeLists.txt d47daf4 > src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.h PRE-CREATION > src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp > PRE-CREATION > src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigWidget.ui > PRE-CREATION > src/core-impl/podcasts/sql/PodcastSettingsBase.ui e1f36e7 > src/core-impl/podcasts/sql/PodcastSettingsDialog.h 08fdad3 > src/core-impl/podcasts/sql/PodcastSettingsDialog.cpp de53d77 > src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 777825e > src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 9784d08 > src/core/podcasts/PodcastMeta.h e11b2eb > src/core/podcasts/PodcastMeta.cpp fb82fa8 > > Diff: http://git.reviewboard.kde.org/r/100686/diff > > > Testing > ------- > > > Thanks, > > Sandeep > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
