----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100135/ -----------------------------------------------------------
(Updated 2010-11-17 14:32:40.538323) Review request for Amarok. Changes ------- Tinny fix to FileNameLayoutDialog, %albumartist haven't been recognized. Summary ------- Add new QueryType - AlbumArtist. Add grouping by Album Artist for Collection Browser. Add Album Artist field to TagDialog. Add Album Artist to TagGuesser and Organize Collection dialog. Add ability to read/write Album Artist for iPod collection. Diffs (updated) ----- src/amarokurls/NavigationUrlGenerator.cpp 5c48e73 src/amarokurls/NavigationUrlRunner.cpp 2d6384b src/browsers/CollectionTreeItemModelBase.h 23a189f src/browsers/CollectionTreeItemModelBase.cpp 7015cd4 src/browsers/CollectionTreeView.cpp 2bb894c src/browsers/collectionbrowser/CollectionWidget.cpp 8623079 src/core-impl/collections/db/sql/SqlMeta.cpp ff899fe src/core-impl/collections/db/sql/SqlQueryMaker.h 680050f src/core-impl/collections/db/sql/SqlQueryMaker.cpp ca105e8 src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp 72cd07d src/core-impl/collections/ipodcollection/handler/IpodHandler.h 07e0380 src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp cd50661 src/core-impl/collections/ipodcollection/handler/capabilities/IpodReadCapability.h 44af297 src/core-impl/collections/ipodcollection/handler/capabilities/IpodReadCapability.cpp 3825187 src/core-impl/collections/ipodcollection/handler/capabilities/IpodWriteCapability.h fe13f76 src/core-impl/collections/ipodcollection/handler/capabilities/IpodWriteCapability.cpp f89100c src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp d2c5248 src/core-impl/collections/mediadevicecollection/handler/capabilities/ReadCapabilityBase.h 9fe0b9a src/core-impl/collections/mediadevicecollection/handler/capabilities/WriteCapability.h 8cf4012 src/core-impl/collections/mtpcollection/handler/MtpHandler.h 095d3fa src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp f93eb99 src/core-impl/collections/mtpcollection/handler/capabilities/MtpReadCapability.h 598ede2 src/core-impl/collections/mtpcollection/handler/capabilities/MtpReadCapability.cpp c95d43d src/core-impl/collections/mtpcollection/handler/capabilities/MtpWriteCapability.h b5c111f src/core-impl/collections/mtpcollection/handler/capabilities/MtpWriteCapability.cpp e8c9834 src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.h 63d6c2c src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp c17c3fd src/core-impl/collections/support/MemoryMatcher.h f660b27 src/core-impl/collections/support/MemoryMatcher.cpp 29fc12c src/core-impl/collections/support/MemoryQueryMaker.h 72ddaf1 src/core-impl/collections/support/MemoryQueryMaker.cpp 81bf9b6 src/core-impl/collections/support/MemoryQueryMakerInternal.h db94d8b src/core-impl/collections/support/MemoryQueryMakerInternal.cpp eeffd77 src/core-impl/collections/support/XmlQueryReader.cpp b5518f0 src/core-impl/collections/support/XmlQueryWriter.h 5caf7bc src/core-impl/collections/support/XmlQueryWriter.cpp 3c9cf41 src/core-impl/collections/umscollection/handler/UmsHandler.h 70edc26 src/core-impl/collections/umscollection/handler/UmsHandler.cpp c402c54 src/core-impl/collections/umscollection/handler/capabilities/UmsReadCapability.h 85f76d1 src/core-impl/collections/umscollection/handler/capabilities/UmsReadCapability.cpp 071d19e src/core/collections/MetaQueryMaker.h 799825a src/core/collections/MetaQueryMaker.cpp 10ae2a7 src/core/collections/QueryMaker.h 9c15659 src/core/collections/QueryMaker.cpp 78c6ba7 src/core/meta/support/MetaConstants.h ba56248 src/core/meta/support/MetaUtility.cpp 5cf4519 src/dialogs/FilenameLayoutDialog.h 2e20c77 src/dialogs/FilenameLayoutDialog.cpp 9b572a9 src/dialogs/FilenameLayoutDialog.ui b65b6f1 src/dialogs/MusicBrainzTagger.cpp a9fc8a2 src/dialogs/TagDialog.h fbc89ae src/dialogs/TagDialog.cpp fa0b33a src/dialogs/TagDialogBase.ui 816ecb5 src/dialogs/TagGuesser.h 476b16d src/dialogs/TagGuesser.cpp bd3820d src/services/ServiceSqlQueryMaker.h 5591ecc src/services/ServiceSqlQueryMaker.cpp 197f2cf src/services/ampache/AmpacheServiceQueryMaker.cpp 7dee8c8 src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp 4dc8fed src/services/scriptable/ScriptableServiceQueryMaker.cpp 76faca2 Diff: http://git.reviewboard.kde.org/r/100135/diff Testing ------- Tested with SQL and iPod (Memory) collections. Seems works for me. Screenshots ----------- Only one album "Once". As It should be. http://git.reviewboard.kde.org/r/100135/s/17/ 2 albums, and 3rd is somewhere below. http://git.reviewboard.kde.org/r/100135/s/18/ http://git.reviewboard.kde.org/r/100135/s/19/ Album Artist for Organize collection dialog http://git.reviewboard.kde.org/r/100135/s/20/ Thanks, Sergey
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
