Never mind that, I'm an idiot and haven't had breakfast yet. Sorry for
the noise.
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
ding CXX object
src/services/lastfm/CMakeFiles/amarok_service_lastfm.dir/LastFmTreeModel.o
[12:27:03] /home/sam/devel/amarok/src/services/lastfm/LastFmTreeModel.cpp:
In member function ‘void LastFmTreeModel::slotAddTopArtists()’:
[12:27:03]
/home/sam/devel/amarok/src/services/lastfm/LastFmTreeModel.cp
Matthias
It's an unhelpful error message, but you need to squash the two
commits to a single commit before uploading the patch to reviewboard.
Sam
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
o know what you think.
>
> Cheers
> Matthias
Hi Matthias,
Please submit your patch to the reviewboard: https://git.reviewboard.kde.org/
You'll need an account with https://identity.kde.org/ to log in.
Thanks for the work!
Sam
___
Amaro
On 14 July 2012 15:15, Mathias Panzenböck wrote:
> Since (I think) yesterday I get these compile errors:
>
> /home/panzi/software/amarok/src/musicbrainz/MusicDNSAudioDecoder.cpp: In
> member function ‘virtual void MusicDNSAudioDecoder::run()’:
> /home/panzi/software/amarok/src/musicbrainz/MusicDNS
o (ideally with a slightly older KDE version).
- Sam Lade
On June 11, 2012, 3:14 p.m., Matěj Laitl wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.r
et Bhatti wrote:
> Well, the patch I uploaded and my repo both show the indentation, not
> sure why it isn't visible to you ?
>
> Sam Lade wrote:
> There is indentation present, but again it's a tab rather than spaces
> (and tabs and spaces are mixed throughout
indentation (see HACKING/intro_and_style.txt). You should configure your IDE or
text editor to do this automatically to make life easier.
- Sam
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org
e the
changes after release of Amarok 2.6, but that was before ffmpeg had rolled out
a release breaking this. It may need #ifdefing.
- Sam Lade
On May 27, 2012, 10:28 p.m., Christoph Feck wrote:
>
> ---
> This is an automatical
the code's plausible and you've tested.
- Sam Lade
On April 1, 2012, 11:10 p.m., Lachlan Dufton wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
by [disambiguation "album by"
> site:wikipedia.org]. That it, if one had two albums named "Monolith" from
> iTunes, they would also be merged into a single "compilation".
Here's a thought: if it's a single compilation album, you won't get multip
e() slots are
> > activated) before returning the tracks, which is done in the loop this
> > patch removes.
> >
> > I'd suggest using QEventLoop::ExcludeUserInputEvents, too.
Okay, that makes sense, thanks. Pushing the ExcludeUserInputEvents version.
- S
similar
timespan by simply stopping the bisect once the range has been narrowed
to within the block - but you also have the option to continue the
bisect and narrow down the problem further.
Sam
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
.
On 10/11/11 02:43, Rick W. Chen wrote:
> Why don't we make taglib dependency mandatory?
>
> On 09 Nov 2011 16:16 +0100, Sam Lade:
>> Git commit 7a0cdb830170d8b438a7e00f656cb0234aa8bd32 by Sam Lade.
>> Committed on 09/11/2011 at 16:14.
>> Pushed by lade into br
> On Sept. 12, 2011, 12:08 p.m., Sam Lade wrote:
> > First of all, thanks for looking at this - I know it's been annoying a lot
> > of our users.
> >
> > It doesn't seem to be working reliably for me. Sometimes an audio CD is
> > correctly shown o
o grep for, or I can just dump the lot if
you can find it), or any other debugging info you're after.
- Sam
On Sept. 11, 2011, 4:40 p.m., Luc Menut wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
the wrong code style please.
>
> Harald Sitter wrote:
> look at the other amarok source files and you'll hopefully notice that
> you are missing plenty of whitespaces
See HACKING/intro_and_style.txt for the Amarok style guide.
- Sam
--
reviewboard.kde.org/
(you'll need an account with identity.kde.org, if I remember correctly),
rather than the mailing list. It makes everything much neater and easier
to keep track of - things on the list can get lost far too easily.
Sam
___
Amarok-devel
On 25/07/11 10:19, Mark Kretschmann wrote:
> On Mon, Jul 25, 2011 at 10:08 AM, Bart Cerneels wrote:
>> We've found a rather irritating, troll tickling bug in 2.4.2 that
>> already has a fix by Sam in review [1].
>>
>> In addition master only has bugfixes now, no
g seems to
behave as expected. No badgering popups are shown.
Thanks,
Sam
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
ou open src/context/scriptengine/javascript/bind_dataengine.h
there's a "#if !KDE_IS_VERSION(4, 6, 81)" check, which is the offending
line. Change the 81 to an 80 and you should be in business. (As I
understand it, beta 1 had the same version number and did not have the
source change...)
Sam
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
On 04/06/11 10:50, Myriam Schweingruber wrote:
> Hi all,
>
> On Sat, Jun 4, 2011 at 11:21, Valorie Zimmerman
> wrote:
>> Sucks.
>>
>> In a word. I find it unusable, and would rather see the old one back
>> again, if this can't be made 1. discoverable and 2. accurate.
>
> I must agree, the usabil
rsion
in this case.
Irritatingly, avcodec_decode_audio3 is apparently introduced part way
though version 52 of libavcodec, which will still cause deprecation
warnings unless we work out which minor version it was added on and
check for that as well.
Sam
On 17/05/11 18:53, Lydia Pintscher wrote:
.
Diffs
-
src/musicbrainz/MusicDNSAudioDecoder.cpp 6d82bb0
Diff: http://git.reviewboard.kde.org/r/101372/diff
Testing
---
Amarok builds successfully with latest git ffmpeg.
MusicBrainz tagging works correctly.
Thanks,
Sam
___
Amarok-devel
> Cheers
> Lydia
>
I think Mark is correct in American English, but I've never seen
"anytime" used in British English. Which one we're using is a whole
different debate entirely, but "at any time" would be correct in either
variant. On the other hand, "a
25 matches
Mail list logo
