(copying this to the amarok-devel list) It does work without TagLib (it'll guess tags from filenames, and other functions work fine). Building without it's always been allowed.
This said, I don't have any problem myself with making it required; it's a pretty major feature. On 10/11/11 02:43, Rick W. Chen wrote: > Why don't we make taglib dependency mandatory? > > On 09 Nov 2011 16:16 +0100, Sam Lade: >> Git commit 7a0cdb830170d8b438a7e00f656cb0234aa8bd32 by Sam Lade. >> Committed on 09/11/2011 at 16:14. >> Pushed by lade into branch 'master'. >> >> CMake warning on missing TagLib >> >> Patch by Ryan McCoskrie >> >> REVIEW:103090 >> >> M +2 -0 CMakeLists.txt >> >> http://commits.kde.org/amarok/7a0cdb830170d8b438a7e00f656cb0234aa8bd32 >> >> diff --git a/CMakeLists.txt b/CMakeLists.txt >> index 6fb0491..cba1387 100644 >> --- a/CMakeLists.txt >> +++ b/CMakeLists.txt >> @@ -50,6 +50,8 @@ if(TAGLIB_FOUND) >> include(CheckTagLibFileName) >> >> check_taglib_filename(COMPLEX_TAGLIB_FILENAME) >> +else() >> + message(WARNING "You are building Amarok without taglib. This has been >> known to cause many strange behaviours and is strongly advised against.") >> endif() >> >> # -------------------------- > _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
