> On June 21, 2012, 2:08 p.m., Matěj Laitl wrote: > > tests/core/collections/TestCollection.cpp, line 34 > > <http://git.reviewboard.kde.org/r/105166/diff/2/?file=70025#file70025line34> > > > > Strange indentation again. Hmm? > > Jasneet Bhatti wrote: > Don't understand this one. > There are two levels of indentation and the variable definition is > according to intro_and_style. > Please explain what is the fault. > > Matěj Laitl wrote: > There is no indentation from what I see here. > > Jasneet Bhatti wrote: > Well, the patch I uploaded and my repo both show the indentation, not > sure why it isn't visible to you ? > > Sam Lade wrote: > There is indentation present, but again it's a tab rather than spaces > (and tabs and spaces are mixed throughout the patch). Please use spaces only > for indentation (see HACKING/intro_and_style.txt). You should configure your > IDE or text editor to do this automatically to make life easier. > > Jasneet Bhatti wrote: > Oh I get it now. This will sound silly but I didn't know that four spaces > and one tab of width four appear differently and so was confused about what > mixing tabs and spaces meant. Will make sure to never press Tab again while > writing patches. Thanks for clearing that. > > Matěj Laitl wrote: > > Will make sure to never press Tab again while writing patches. > > No, you should absolutely press Tab otherwise your spacebar and thumb > finger will go away. ;) Just configure your editor to add 4 spaces instead of > tab or even better advance to next tab position by inserting spaces. (Kate > (KDevelop) does this nicely)
That's not actually necessary - any reasonable text editor/IDE will have tab settings which allow you to configure it to use spaces for indentation, even when you press the tab key. I don't know what you're using, but here's how I have some of the common ones set: In Qt Creator, tools > options > text editor > behaviour > tabs and indentation (set to spaces only, tab size 8, indent size 4) In Kate, settings > configure Kate > editing > indentation (spaces, tab width 4, indentation width 4, always advance to next tab position) In vim, in .vimrc: set softtabstop=4 set tabstop=8 set shiftwidth=4 set expandtab - Sam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105166/#review14948 ----------------------------------------------------------- On June 21, 2012, 1:38 p.m., Jasneet Bhatti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105166/ > ----------------------------------------------------------- > > (Updated June 21, 2012, 1:38 p.m.) > > > Review request for Amarok and Sven Krohlas. > > > Description > ------- > > This patch implements a unit test for core/collections/Collection > > There are abstract classes to be tested as well, which can only be done when > subclasses define the pure virtual functions. So tests for those will be done > along with the subclasses. > > > Diffs > ----- > > tests/core/collections/CMakeLists.txt 2efd1fe > tests/core/collections/TestCollection.h PRE-CREATION > tests/core/collections/TestCollection.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105166/diff/ > > > Testing > ------- > > Test passes on my repository > > > Thanks, > > Jasneet Bhatti > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
