----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104464/#review12113 -----------------------------------------------------------
A couple of minor things - first, in the heightForWidth code, it's not at all clear what's going on with the padding (you use padding * 4 at first, and later just use 8). Clean that up and comment it. Second, the else keyword is superfluous. Otherwise, looks good. I haven't tested myself (I'm away and don't have Amarok built), but the code's plausible and you've tested. - Sam Lade On April 1, 2012, 11:10 p.m., Lachlan Dufton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104464/ > ----------------------------------------------------------- > > (Updated April 1, 2012, 11:10 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Fix for bug #292081 > > AnimatedBarWidget is modified to wrap text when widget is too narrow. > > > This addresses bug 292081. > https://bugs.kde.org/show_bug.cgi?id=292081 > > > Diffs > ----- > > src/aboutdialog/AnimatedBarWidget.h 8ec32ad > src/aboutdialog/AnimatedBarWidget.cpp f40dd6d > > Diff: http://git.reviewboard.kde.org/r/104464/diff/ > > > Testing > ------- > > Tested changed widget correctly wraps text when About dialog is resized. > > > Thanks, > > Lachlan Dufton > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
