Re: Review Request: Fix infinite loop in context view eating CPU until main window is shown

> On Nov. 28, 2011, 12:40 a.m., Rick W. Chen wrote: > > I've not seen this problem on my setup. Just tried the patch and it doesn't > > cause any issues here. Ship it. > > Rick W. Chen wrote: > I gave the "Ship it!" prematurely. There are so

Re: Review Request: Fix infinite loop in context view eating CPU until main window is shown

> On Nov. 28, 2011, 12:40 a.m., Rick W. Chen wrote: > > I've not seen this problem on my setup. Just tried the patch and it doesn't > > cause any issues here. Ship it. I gave the "Ship it!" prematurely. There are some layout problems appearing with certain

Re: Review Request: Fix infinite loop in context view eating CPU until main window is shown

tried the patch and it doesn't cause any issues here. Ship it. - Rick W. Chen On Nov. 27, 2011, 2:30 p.m., Matěj Laitl wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: [amarok] /: Add option to toggle showing of browser background images

On 06 Nov 2011 21:41 +0100, Bart Cerneels: > On Sun, Nov 6, 2011 at 13:29, Rick W. Chen wrote: > > On 06 Nov 2011 09:22 +0100, Bart Cerneels: > >> Micro option! And as far as I can tell because only one user > >> complained on the forums. Unless Rick has a personal pref

Re: [amarok] /: Add option to toggle showing of browser background images

t too pleasing. > > Bart > > On Sun, Nov 6, 2011 at 05:18, Rick W. Chen wrote: > > Git commit 07ca7cc2ea3d792bd7f4b63e8eac68bbd5358f46 by Rick W. Chen. > > Committed on 05/11/2011 at 14:03. > > Pushed by rickc into branch 'master'. > > > > A

Re: Review Request: Re-Add old "Normal" moodbar style

fault option. Happy has always seem a bit too happy... - Rick W. Chen On Nov. 3, 2011, 10:28 a.m., Florian Eßer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: Use QGraphicsScene::NoIndex instead of QGraphicsScene::BspTreeIndex (avoid Qt bug crashing amarok)

> On July 19, 2011, 10:46 p.m., Rick W. Chen wrote: > > yep, that crash is super annoying. hmm actually, on track change there's a noticeable delay in the context browser. Can anyone reproduce this? - Rick W.

Re: Review Request: Use QGraphicsScene::NoIndex instead of QGraphicsScene::BspTreeIndex (avoid Qt bug crashing amarok)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101966/#review4877 --- Ship it! yep, that crash is super annoying. - Rick W. On Jul

Re: [amarok] /: Add Rick W. Chen to Authors list.

On 28 May 2011 18:57 +0200, Teo Mrnjavac: > Git commit dbd88769054e899d3090f74733e5f7c56139b8eb by Teo Mrnjavac. > Committed on 28/05/2011 at 18:56. > Pushed by mrnjavac into branch 'master'. > > Add Rick W. Chen to Authors list. > Rick W. Chen has been nominated for

Re: Review Request: Fix: Recently played tracks are not updated in currrent track applet.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101015/#review2332 --- src/context/widgets/RecentlyPlayedListWidget.cpp

Re: Review Request: Fix 266645: Update wikipedia applet when metadata in a stream changes.

ly generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100953/ > --- > > (Updated March 29, 2011, 4:42 p.m.) > > > Review request for Amarok and Rick W. Chen. > > > Summary > --- > >

Re: Review Request: Fix 266645: Update wikipedia applet when metadata in a stream changes.

org/r/100953/ > --- > > (Updated March 29, 2011, 4:42 p.m.) > > > Review request for Amarok and Rick W. Chen. > > > Summary > --- > > WikipediaEnginePrivate has a member "Meta::TrackPtr currentTrack" and to > che

Re: Review Request: fix detection of IPod Classic (at least)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100889/#review2056 --- Ship it! Looks good. Works well. Do you have commit access? -

Re: Review Request: fix detection of IPod Classic (at least)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100889/#review2051 --- Hi, I've got a similar patch in the queue as well. It checks whe

Re: Review Request: Trivial cosmetic fix to context view 'albums' applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100805/#review1817 --- src/context/applets/albums/AlbumsView.cpp

Re: Something strange in Now Playing applet

On 23 Nov 2010 03:48 -0800, Valorie Zimmerman: > It looks fine, but is reporting odd information. For instance, see > this one from earlier tonight: > > http://imagebin.ca/view/UNMAPGNz.html > > Notice the time reported for each of the tracks played, and also the > number of Artists and Albums in

Re: Review Request: Capability cleanup

> On 2010-11-15 21:56:45, Ralf Engels wrote: > > Rick noticed that contextualActions were commented out. > > That was a mistake. They need to be commented in again and all the actions > > need to be freed after finish like at all the other places. I made a patch on top of your diff that renable

Re: [Amarok] 7bca886: debug: use elapsed timer

On 09 Nov 2010 14:32 +0100, Kevin Funk: > Tuesday 09 November 2010, "Rick W. Chen" : > > On 09 Nov 2010 11:47 +0100, Kevin Funk: > > > > I noticed in Debug_p.h BlockPrivate was defined but not used, so I > > thought it was intended to be used later. I'v

Re: [Amarok] 7bca886: debug: use elapsed timer

On 09 Nov 2010 16:58 +0100, Kevin Funk: > Tuesday 09 November 2010, Dan Meltzer : > > Theres a performance graphing script in one of the top level > > directories, with a readme as well. It ties into the PERF_LOG macro > > in debug.h > > > > Dan, > > > Oh, someone with knowledge about PERF_LOG.

Re: [Amarok] 7bca886: debug: use elapsed timer

On 09 Nov 2010 11:47 +0100, Kevin Funk: > Tuesday 09 November 2010, "Rick W.Chen" : > > commit 7bca88681ee8248741d0b6daa966326512621bbd > > branch master > > Author: Rick W. Chen > > Date: Tue Nov 9 17:06:12 2010 +1300 > > > > debug: use

Re: Review Request: Improve lyrics applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/#review319 --- I'm able to resolve the text colour problem. For the labels that

Re: Podcast Engine

On 05 Nov 2010 22:13 +0100, Conrad Hübler: > It would make sense to improve the album applet that it shows the latest > podcasts but the first step is a plasmaengine. After that it should be > discussed wheather using album applet or creating a new podcast applet. The albums applet is suitable f

Re: Review Request: Improve lyrics applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/#review296 --- ChangeLog

Re: Review Request: Fix crash in Albums context applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100134/#review295 --- Ship it! Works well. - Rick W. On 2010-11-04 20:02:05, James

Re: Review Request: Match space-separated search terms individually

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100128/#review266 --- src/playlist/proxymodels/ProxyBase.cpp

Re: Review Request: Remove MainWindow dock layout resize hacks

tp://git.reviewboard.kde.org/r/100107/#review243 ------- On 2010-10-31 03:20:25, Rick W. Chen wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request: Remove MainWindow dock layout resize hacks

Removing them can only be a good thing. > > Rick W. Chen wrote: > It'd be good to have someone test it on qt 4.6. I'd be able to do that > myself in the next few days or so. kde 4.4 as well - Rick W. --- This