> On 2010-11-01 07:12:23, Mark Kretschmann wrote: > > Seems to work for me too. No issues so far. So apparently something might > > have been fixed upstream. > > > > And tbh, I've started to lose track of all our various layout (QDockWidget) > > hacks. Removing them can only be a good thing.
It'd be good to have someone test it on qt 4.6. I'd be able to do that myself in the next few days or so. - Rick W. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100107/#review243 ----------------------------------------------------------- On 2010-10-31 03:20:25, Rick W. Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100107/ > ----------------------------------------------------------- > > (Updated 2010-10-31 03:20:25) > > > Review request for Amarok. > > > Summary > ------- > > This patch removes the dock resize hacks introduced in > 8cb577dc891e13668098292f821f3a8131ced4b4, which was from the merge request > http://gitorious.org/amarok/amarok/merge_requests/154 . > > There were dock resizing issues at the time, where the sizes and ratios of > different docks were not restored properly when maximizing and restarting > amarok. Now, at least with the new kde/qt dependencies I'm not experiencing > any problem of the sort. > > > Diffs > ----- > > src/MainWindow.cpp 9102558 > src/MainWindow.h 4593d47 > > Diff: http://git.reviewboard.kde.org/r/100107/diff > > > Testing > ------- > > Tested with different dock arrangements: > - maximize and unmaximize window > - restart amarok > - hide and unhide window > > The sizes and ratios of the docks remain the same. > > > Thanks, > > Rick W. > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
