Dear Tuomas, dear Amarok development team.
Tuomas Nurmi - 29.04.24, 22:15:33 CEST:
> I am happy to announce the immediate availability of Amarok 3.0
> "Castaway" […]
Thank you, that is wonderful!
I appreciate it!
Best,
--
Martin
On Tue, Aug 04, 2015 at 10:53:16PM +1200, Ben Cooksley wrote:
> On Tue, Aug 4, 2015 at 10:38 PM, Martin Sandsmark
> wrote:
> > But what kind of legal risk are we talking about here?
> The same one Redhat / Fedora don't like at all, and which SUSE is
> working around...
B
hy they wouldn't use
VLC, especially if we make a kick-ass qml-based UI for it.
I don't see what licensing issues there would be, the core parts of VLC are
lgpl 2+, and the rest is gpl2+, pretty much the same as almost everything
else in KDE.
--
Martin Sandsmark
_
th someone
established elsewhere (outside of KDE, even).
--
Martin Sandsmark
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
er.
That said, I'm not too familiar with Tomahawk, but I suspect it might already
cover more of what people want from a pure music player. But someone who is
more familiar with it chime in with what it is missing wrt. integration in
Plasma, and then we can see how hard those things are to fi
er the world, which parts of the
world does KDE have mirrors that Videolan doesn't? (And also same question
as above.)
And in my humble opinion, that some distros cripple themselves shouldn't be
our problem... If a distro doesn't prov
ly straight-forward to just build libdvdread and/or VLC without that
dependency. From some simple googling it seems like fedora already ships a
libdvdread without de-scrambling enabled, for example.
--
Martin Sandsmark
___
Amarok-devel mailing list
ting or reuse
and adapt it. Make it as robust and reliable as you can. Make it just work.
100% of the time (or at least 99,99%), like my CD player, like my Rockbox
based Sansa e260. When I want to enjoy multimedia, I am absolutely not in the
mood to discuss with unfinished and buggy software. Or to get a diploma about
how the Linux audio stack works in order to find out what the issue is this
time.
Thanks,
--
Martin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
my systems so far. It
needs quite a bit of convincing for me to ever try it again.
In any case, whatever you choose to do: The best of success for you.
Plasma/KDE needs simple to use and reliable multimedia stuff. If the player
you want to create fi
shortcut "Ctrl+F1". Whenever you press that to get to
desktop 1 it would also open the help in the active application. Global
shortcuts need to be filtered out.
- Martin
---
This is an automatically
space/409fdfab03e7a0b5a61e7796e1fba85b143eab3b
Diffs
-
src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d
src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6
Diff: https://git.reviewboard.kde.org/r/122450/diff/
Testing
---
Thanks,
Martin Gr
> On Feb. 27, 2015, 1:13 p.m., Myriam Schweingruber wrote:
> > I didn't give a ship it yet as I want to get Amarok 2.9 beta out first.
I don't get this argument. It would be very important if we get this change
into the beta and best also in stable r
> > one just omit it alltogether?
>
> Martin Klapetek wrote:
> This way it clears the existing shortcut, I think, no?
I followed the code which is used in the other places in Amarok. Given that I
don't care whether it's needed to be that, but the consi
> > one just omit it alltogether?
This way it clears the existing shortcut, I think, no?
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.re
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122450/#review76703
---
ping, anyone?
- Martin Gräßlin
On Feb. 6, 2015, 9:06 a.m
s.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d
src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6
Diff: https://git.reviewboard.kde.org/r/122450/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/ma
about Phonon, so me not
knowing how to do it doesn't say much about how difficult it actually is.
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.
iff: https://git.reviewboard.kde.org/r/120399/diff/
Testing
---
Still compiles, and pressing pause continuously no longer extends the timer
infinitely.
Thanks,
Martin Lyth
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailma
picture) and Opus. Thus, this
patch makes sure not to use video streams.
Diffs
-
src/core/transcoding/formats/TranscodingOpusFormat.cpp dc6b743
Diff: https://git.reviewboard.kde.org/r/114563/diff/
Testing
---
Thanks,
Martin Brodbeck
> On Dec. 20, 2013, 11:28 a.m., Matěj Laitl wrote:
> > This patch looks good to me, but I wonder - other formats may need a
> > similar option, don't they?
OggVorbis already has this option. I don't know if other formats have
/transcoding/formats/TranscodingOpusFormat.cpp dc6b743
Diff: http://git.reviewboard.kde.org/r/114563/diff/
Testing
---
Thanks,
Martin Brodbeck
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
displayed. This will fix bug
#328451.
Diffs
-
ChangeLog 107aa48
shared/tag_helpers/VorbisCommentTagHelper.cpp dc02a1c
Diff: http://git.reviewboard.kde.org/r/114406/diff/
Testing
---
Thanks,
Martin Brodbeck
___
Amarok-devel mailing
> On Dec. 12, 2013, 1:52 p.m., Mark Kretschmann wrote:
> > The "Ship It" is just a default text from ReviewBoard, it's not to be taken
> > literally. Of course we can commit it for you :) I'll do it tonight when
> > I'm back home.
>
> Mar
I do know. :) I was not sure to whom Matěj was talking when he said
not to forget the tags when committing.
Thanks!
- Martin
---
This is an automatically generated e-mail. To reply, visit:
http:/
dc02a1c
Diff: http://git.reviewboard.kde.org/r/114406/diff/
Testing
---
Thanks,
Martin Brodbeck
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
-
shared/tag_helpers/VorbisCommentTagHelper.cpp dc02a1c
Diff: http://git.reviewboard.kde.org/r/114406/diff/
Testing
---
Thanks,
Martin Brodbeck
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Diff: http://git.reviewboard.kde.org/r/114406/diff/
Testing
---
Thanks,
Martin Brodbeck
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
corner of it) and recently KDE Frameworks and couple others) use Google
Mock. I, for one, also never heard of it before.
Cheers
--
Martin Klapetek | KDE Developer
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
> On Feb. 26, 2013, 12:50 p.m., Martin Brodbeck wrote:
> > Ship It!
>
> Matěj Laitl wrote:
> > Stupid me, there's never a faultless patch from me. :-/
>
> No faultless patch was ever posted to reviewboard, at least not when I'm
> the re
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108907/#review28125
---
Ship it!
Ship It!
- Martin Brodbeck
On Feb. 26, 2013, 8:08
ATION
src/core/transcoding/formats/TranscodingOpusFormat.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/108907/diff/
Testing
---
Thanks,
Martin Brodbeck
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/lis
://git.reviewboard.kde.org/r/108907/diff/
Testing
---
Thanks,
Martin Brodbeck
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
src/core/transcoding/formats/TranscodingOpusFormat.cpp PRE-CREATION
src/core/CMakeLists.txt 2809dc3
Diff: http://git.reviewboard.kde.org/r/108907/diff/
Testing
---
Thanks,
Martin Brodbeck
___
Amarok-devel mailing list
Amarok-devel@kde.org
/transcoding/formats/TranscodingOpusFormat.h PRE-CREATION
src/core/transcoding/formats/TranscodingOpusFormat.cpp PRE-CREATION
src/core/CMakeLists.txt 2809dc3
Diff: http://git.reviewboard.kde.org/r/108907/diff/
Testing
---
Thanks,
Martin Brodbeck
63a83e1
shared/config.h.cmake 004dd57
shared/tag_helpers/TagHelper.cpp 4534018
shared/FileType.h b3d4470
README c49d284
Diff: http://git.reviewboard.kde.org/r/108542/diff/
Testing
---
Thanks,
Martin Brodbeck
___
Amarok-devel mailing list
/transcoding/TranscodingController.cpp 265d1f8
src/core/transcoding/TranscodingDefines.h 8c68f15
Diff: http://git.reviewboard.kde.org/r/108907/diff/
Testing
---
Thanks,
Martin Brodbeck
___
Amarok-devel mailing list
Amarok-devel@kde.org
https
/transcoding/TranscodingDefines.h 8c68f15
Diff: http://git.reviewboard.kde.org/r/108907/diff/
Testing
---
Thanks,
Martin Brodbeck
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
shared/FileType.cpp 43d8777
shared/FileTypeResolver.cpp 63a83e1
shared/config.h.cmake 004dd57
shared/tag_helpers/TagHelper.cpp 4534018
shared/FileType.h b3d4470
README c49d284
Diff: http://git.reviewboard.kde.org/r/108542/diff/
Testing
---
Thanks,
Marti
x27;t
> > needed for TAGLIB_MOD_FOUND?
That's a good question. Are you sure that the TAGLIB_MOD_FOUND part compiles?
Here, for the OPUS stuff, I need the include.
- Martin
---
This is an automatically generated e-mail. To repl
bout Amarok::Opus, because it's an Ogg container? Flac also uses
Amarok::Ogg. But to be honest I don't know what exactly this parameter means...
- Martin
---
This is an automatically generated e-mail. To reply, visit:
http
b3d4470
shared/FileType.cpp 43d8777
shared/FileTypeResolver.cpp 63a83e1
shared/config.h.cmake 004dd57
shared/tag_helpers/TagHelper.cpp 4534018
Diff: http://git.reviewboard.kde.org/r/108542/diff/
Testing
---
Thanks,
Martin Brodbeck
/tag_helpers/TagHelper.cpp 45340180139b9ac0604ad93483dd9fd725a4cb02
Diff: http://git.reviewboard.kde.org/r/108542/diff/
Testing
---
Thanks,
Martin Brodbeck
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo
> On Aug. 8, 2011, 6:14 p.m., Martin Blumenstingl wrote:
> >
Sorry, it seems that reviewboard ate my comment :(
Here's the original text:
Please speak up in the next few days if something speaks AGAINST committing
this (otherwise I'll commit next week).
The patch itself
the setStatus(Active) in amarok?
If the user wants, he can completely disable it in amarok's settings.
If the user enables the tray icon it's always shown (unless he explicitly
tells the systray plasmoid to "hide" it).
Kind Regards,
Martin
___
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102077/#review5520
---
- Martin
On July 24, 2011, 6:29 p.m., Martin Blumenstingl
round/CMakeLists.txt 4cd4052
Diff: http://git.reviewboard.kde.org/r/102077/diff
Testing
---
The coverbling applet installs successful if playground is enabled.
I did not test anything else (except disabling the switch again and seeing if
the coverbling applet is now excluded).
Thanks,
M
> On July 24, 2011, 6:06 p.m., Commit Hook wrote:
> > This review has been submitted with commit
> > 0cc4eb24c951b29e4f140d8c7e3bd7e5d79f6654 by Manu Wagner to branch master.
Thanks for the patch - and sorry that it took so long to get it inclu
t with the checkbox enabled and disabled.
Works as expected.
Thanks,
Martin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
fications?
>
> Kevin Funk wrote:
> Yep, Martin, please also apply this to the KNotificationBackend. It
> should be straight forward.
>
> I'm basically the maintainer of the Notification modules, it would be a
> good idea to use a common base (proxy) for al
Diff: http://git.reviewboard.kde.org/r/101508/diff
Testing
---
Tested it with the checkbox enabled and disabled.
Works as expected.
Thanks,
Martin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
rash anymore when re-adding the lyrics applet and pressing
"ESC"
-If lyrics are edited in TagDialog the LyricsApplet is updated again
etc.
Thanks,
Martin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
and update() already check if the lyrics were really
updated.
src/context/engines/lyrics/LyricsEngine.cpp
<http://git.reviewboard.kde.org/r/100892/#comment1718>
See what the comment says, that code-block was simply misplaced.
t and pressing
"ESC"
etc.
Thanks,
Martin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Value
I have no clue where that could come from.
At least he said he compiled qtscriptgenerator against the right Qt version.
Regards,
Martin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
tag should be added.
This addresses bug 266171.
https://bugs.kde.org/show_bug.cgi?id=266171
Diffs
-
src/context/engines/tabs/TabsEngine.cpp 7c893c6
Diff: http://git.reviewboard.kde.org/r/100670/diff
Testing
---
Tested with various songs from my library.
Thank
bug 266171.
https://bugs.kde.org/show_bug.cgi?id=266171
Diffs
-
src/context/engines/tabs/TabsEngine.cpp 7c893c6
Diff: http://git.reviewboard.kde.org/r/100670/diff
Testing
---
Tested with various songs from my library.
Thanks,
Martin
___
Am
n.
You can follow this thread if you want to know what's going on: [0].
Regards,
Martin
[0] http://mail.kde.org/pipermail/plasma-devel/2011-February/014997.html
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
src/context/Applet.h 35ff00d
src/context/Applet.cpp 3226a8c
src/context/applets/lyrics/LyricsApplet.h 81a5cf9
src/context/applets/lyrics/LyricsApplet.cpp ef2eaaa
Diff: http://git.reviewboard.kde.org/r/100617/diff
Testing
---
-Tried Amarok with KDE 4.6.0 -&g
9fv.png
Regards,
Martin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
direct) we have to update the URL (= the key) in the QHash.
- Martin
On 2011-01-02 20:25:45, Martin Blumenstingl wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://gi
/diff
Testing
---
I tested Sven's "Free Music Charts" script: it works fine now.
Fetching lyrics through the "Ultimate Lyrics" script is also still working.
Thanks,
Martin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
a track in the tracks table, then I use the url field to make a lookup
in the urls table where I use the rpath field as the track's path. In my case,
the rpath entries look like "./home/martin/Music/Artist/Album/Trackname.ogg".
Currently (I'm using Amarok from Git) I have to
(when clicking the refetch)
button. Rick could never reproduce it.
So there are two reasons why I'm writing this mail:
-First I'd like to know how often you get that alignment bug (or if you don't
get it at all).
-and it would be nice if you could play around with t
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100013/#review341
---
Ship it!
Rick and Leo gave their "go" on IRC.
- M
op of yours at
> > g...@git.kde.org:clones/amarok/rickc/amarok branch
> > rr/improve-lyrics-applet-v3. Please try it out and see if there are any
> > other problems. Thanks.
>
> Martin Blumenstingl wrote:
> There's one issue remaining: sometimes the te
ad.de/img/text-misplaced95wb.png
Unfortunately I have no idea yet how to fix it.
It may be a Plasma/Qt bug.
- Martin
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100013/#review319
-
onst needed here anyway. SIGNAL/SLOT normalizes signatures to
> > remove const foo& refs.
Ah okay - done :)
> On 2010-11-05 21:50:28, Leo Franchi wrote:
> > src/context/engines/lyrics/LyricsEngine.cpp, line 92
> > <http://git.reviewboard.kde.org/r/100013/diff/2/?file=3209#f
> > e.g. text scrolling widget. It became hard to read because I have a light
> > background. Are you able to change the brush for the showMessage directly
> > without changing other colours?
>
> Leo Franchi wrote:
> I have the same issue: http://i.imgur.com/LZ4Up.jpg
I
he wants to refetch lyrics
http://git.reviewboard.kde.org/r/100013/s/16/
Thanks,
Martin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
ar.
But I need more testers :)
Screenshots
---
The warning which is shown when the user might lose changes
http://git.reviewboard.kde.org/r/100013/s/15/
The warning which is shown when asking the user if he wants to refetch lyrics
http://git.reviewboard.kde.org/r/100013/s/16/
Thanks,
M
7a94e
src/themes/context/Amarok-Mockup/colors a0b9488
Diff: http://git.reviewboard.kde.org/r/100013/diff
Testing
---
I've been using a patched amarok for the past two days -> I couldn't find bugs
so far.
But I need more testers :)
Thanks,
Martin
_
71 matches
Mail list logo
