----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100617/ -----------------------------------------------------------
Review request for Amarok. Summary ------- There were multiple bugs in libplasma which broke the lyrics applet (Applet::showMessage() to be correct). See this BR: https://bugs.kde.org/show_bug.cgi?id=265738 This broke the following features: -The "refresh lyrics" button had no function (it showed the message, but it didn't do anything) -The "you may lose unsaved changes" warning had the same issues as the "refetch lyrics" functionality Unfortunately due to the libplasma bugs the two features of the LyricsApplet will not work in KDE 4.6. You either need to patch 4.6 with the following two patches - or wait until KDE 4.6.1: http://commits.kde.org/kdelibs/6a4bf6e507e5a084ab52a5a7ced1a8cbb70187a8 http://commits.kde.org/kdelibs/c9256561d74c9e890c061f4c289a4437a125953d I fixed the following issues: -added libplasma >=4.6.0 compatibility -using amarok with libplasma <4.6.0 should still work (but I haven't tested it) It's not entirely sure that the signature of the Plasma::Applet::messageButtonClicked signal will have the Plasma namespace in the future. But I hope it does. You may want to follow the discussion here: http://mail.kde.org/pipermail/plasma-devel/2011-February/014997.html Diffs ----- src/context/Applet.h 35ff00d src/context/Applet.cpp 3226a8c src/context/applets/lyrics/LyricsApplet.h 81a5cf9 src/context/applets/lyrics/LyricsApplet.cpp ef2eaaa Diff: http://git.reviewboard.kde.org/r/100617/diff Testing ------- -Tried Amarok with KDE 4.6.0 -> the refetch action works again :) Thanks, Martin
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
