----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101508/ -----------------------------------------------------------
(Updated June 5, 2011, 5:05 p.m.) Review request for Amarok. Changes ------- Moved the check if a fullscreen window is active to KNotificationBackend. Summary ------- It can be quite annoying if fullscreen applications are running and you are controlling amarok via keyboard shortcuts. Then the OSD disturbs you. To work around this I simply added a little check which does not show the OSD if a fullscreen application is focused/active. Of course this is configurable. The behavior does not change with this patch, as the setting defaults to "false". Diffs (updated) ----- src/KNotificationBackend.h 9ed23e8 src/KNotificationBackend.cpp 150db84 src/amarokconfig.kcfg 6957e93 src/configdialog/dialogs/NotificationsConfig.cpp 52a0584 src/configdialog/dialogs/NotificationsConfig.ui 3b0c47f src/widgets/Osd.h fa0755f src/widgets/Osd.cpp c6b1d22 Diff: http://git.reviewboard.kde.org/r/101508/diff Testing ------- Tested it with the checkbox enabled and disabled. Works as expected. Thanks, Martin
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
