> On Dec. 12, 2013, 1:52 p.m., Mark Kretschmann wrote: > > The "Ship It" is just a default text from ReviewBoard, it's not to be taken > > literally. Of course we can commit it for you :) I'll do it tonight when > > I'm back home. > > Martin Brodbeck wrote: > Mark, this I do know. :) I was not sure to whom Mat?j was talking when he > said not to forget the tags when committing. > > Thanks!
Any news on this? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114406/#review45597 ----------------------------------------------------------- On Dec. 12, 2013, 11:51 a.m., Martin Brodbeck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114406/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2013, 11:51 a.m.) > > > Review request for Amarok and Matěj Laitl. > > > Bugs: 328451 > https://bugs.kde.org/show_bug.cgi?id=328451 > > > Repository: amarok > > > Description > ------- > > With this patch, covers from Ogg files (for example Vorbis and Opus) using > the recommended METADATA_BLOCK_PICTURE tag will be displayed. This will fix > bug #328451. > > > Diffs > ----- > > ChangeLog 107aa48 > shared/tag_helpers/VorbisCommentTagHelper.cpp dc02a1c > > Diff: http://git.reviewboard.kde.org/r/114406/diff/ > > > Testing > ------- > > > Thanks, > > Martin Brodbeck > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
