Re: Review Request: GSoC report: Integrate Spotify into Amarok #3 (squashed commits, recent on top)

ptResolver class supports external .js and non-spotify resolvers. It'll work with any external process that implements the playdar + tomahawk extensions resolver API. thanks! - Leo Franchi On June 10, 2012, 7:10 a.m., Zhengliang Feng wrote: > >

Re: GSoC report #2 - Integrate Spotify into Amarok

On May 27, 2012, at 10:13 PM, Ryan Feng wrote: > Hi, > > The Spotify service plugin has two parts, a standalone Spotify resolver and > a Amarok side Script Resolver, it's mainly from Tomahawk. I've rewrote the > Amarok side resolver, it can work without Tomahawk base classes and headers > now.

Fwd: Shutdown of V3 of the Echo Nest API is imminent.

HI guys, just an FYI: The echo nest dynamic playlist bias (is it even still there? I forget) uses the V3 version of the API. it would need to be ported to libechonest that uses the v4 of the api. cheers, leo Begin forwarded message: > From: Paul Lamere > Subject: Shutdown of V3 of the Echo N

Re: [amarok] /: Add Rick W. Chen to Authors list.

On May 29, 2011, at 7:17 AM, Rick W. Chen wrote: > On 28 May 2011 18:57 +0200, Teo Mrnjavac: >> Git commit dbd88769054e899d3090f74733e5f7c56139b8eb by Teo Mrnjavac. >> Committed on 28/05/2011 at 18:56. >> Pushed by mrnjavac into branch 'master'. >> >> Add Rick W. Chen to Authors list. >> Rick W.

Re: diploma thesis done \o/

On Monday, May 02, 2011 01:12:39 PM Lydia Pintscher wrote: > Heya folks :) > > I handed in the printed version of my thesis this morning. You can > find the pdf version here: > http://www.slideshare.net/lydiapintscher/collaborative-and-transparent-free- > software-development > > Thanks so much t

Re: Review Request: New dynamic bias

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100630/#review1517 --- So I'm against merging this review request as it is right now. H

Re: Review Request: New dynamic bias

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100630/#review1493 --- I was playing around and removed an And bias that I added and th

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

> On Feb. 8, 2011, 2:36 a.m., Andy Coder wrote: > > This seems reasonable enough to me. Especially since JsonQt was used > > because it was already hanging around in the source tree, and availability > > of friendly JSON libraries in package repos wasn't what it is today. > > However, if the

Re: Parts of Amarok which were built by GSoC students

Here are the projects: > 2006: > Ian - DAAP > > 207: > Ian - New Amarok 2.0 Playlist > Leo - Context View > > 2008: > Alejandro - MediaDevice framework > Daniel Winter - Nepomuk Collection > Daniel Jones - Dynamic Playlists > Casey - MP3Tunes integration > Peter - Scripting API / support > Will

Re: Regression Alert: Collection completely borked

On Fri, Jan 7, 2011 at 11:16 AM, Mark Kretschmann wrote: > Ahoy, > > I just noticed that Amarok would play an album, say from Artist X, and > in reality it plays an album from Artist Y. Then, complete albums are > missing. > > I did a full rescan, it did not help. Then I nuked my database, but > t

Re: Playdar Collection

On Thursday, December 16, 2010 01:44:15 PM Bart Cerneels wrote: > On Thu, Dec 16, 2010 at 11:51, Mark Kretschmann wrote: > > Hey all, > > > > recently several people have noticed that our new "Playdar Collection" > > is causing a slowdown in startup time. I'm wondering, should we not > > default-

Re: Review Request: Fixing Coverbling applet build from playground

> On 2010-11-28 00:19:48, Leo Franchi wrote: > > Sorry for the lack of review. Looks good to me. Do you have git push access > > or should I commit for you? Ok, pushed. Thanks! - Leo --- This is an automatically gener

Re: Review Request: Fetch cover for DAAP Albums #240060

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100176/#review443 --- Ship it! I don't have a DAAP server to test, but on a first look

Re: Review Request: Playlist Queue Editor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/#review442 --- Ship it! Looks good to me now! I'd just shrink it a bit more.. t

Re: Review Request: Playlist Queue Editor

> On 2010-11-28 23:46:36, Leo Franchi wrote: > > Ok, a few comments from using it. Here are issues I think need to be > > addressed: > > > > * I think the action should be centered like the other actions below the > > playlist, probable with a separator. >

Re: Review Request: Playlist Queue Editor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/#review436 --- Ok, a few comments from using it. Here are issues I think need to

Re: Review Request: Playlist Queue Editor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100177/#review434 --- Code looks okay, will test functionality in a bit. Thanks! src/

Re: Review Request: New context menu applet to display guitar and bass-tablature

> On 2010-11-28 13:03:52, Alexander Potashev wrote: > > I see white text instead of black, and it may be hard to read it on light > > blue background. Could you please make the text always black? > > Leo Franchi wrote: > Are you testing this patch? This has gone i

Re: Review Request: New context menu applet to display guitar and bass-tablature

> On 2010-11-28 13:03:52, Alexander Potashev wrote: > > I see white text instead of black, and it may be hard to read it on light > > blue background. Could you please make the text always black? Are you testing this patch? This has gone into amarok git and had a lot of updates there, so pleas

Re: Review Request: Fixing Coverbling applet build from playground

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100146/#review426 --- Ship it! Sorry for the lack of review. Looks good to me. Do you

Re: Review Request: Up/down key track selection while using progressive search widget

> On 2010-11-21 20:28:48, Leo Franchi wrote: > > +1 from me too. Do you have a git account, or should we push for you? > > Thomas Karpiniec wrote: > I'm pretty sure I don't. If you could push it for me that would be great, > thanks. :) Great. Pushed

Google Code-In Tasks

Hi guys, This is just a quick note as i'm filling in for Lydia. Turns out though KDE has a whole bunch of Code-In tasks, students are taking them fast and we don't want to run out! Some mentors have already begun to receive patches from their students, so this is a very real and tangible way to

Re: Review Request: Up/down key track selection while using progressive search widget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100124/#review385 --- Ship it! +1 from me too. Do you have a git account, or should we

Re: Scanner benchmark

On Tue, Nov 16, 2010 at 6:48 PM, Jeff Mitchell wrote: > On 11/13/2010 03:07 PM, Leo Franchi wrote: >> Hello, >> >> Below are my observations too, just to see if other users' compare. >> >> On Sat, Nov 13, 2010 at 4:06 AM, Mikko C. wrote: >>> Hi, &

Re: Scanner benchmark

Hello, Below are my observations too, just to see if other users' compare. On Sat, Nov 13, 2010 at 4:06 AM, Mikko C. wrote: > Hi, > I found some time to run some tests with the new scanner. > > Amarok from git master of today: > Full rescan with the collection already being present on the extern

Re: Black Context View - Lolwut?

On Friday, November 12, 2010 08:40:41 AM Bart Cerneels wrote: > On Fri, Nov 12, 2010 at 07:33, Mark Kretschmann wrote: > > Hey all, > > > > check out what my Amarok just did. I have no idea how or why that > > happened :) > > > > (See attached screenshot) > > > > -- > > Mark Kretschmann > > Ama

Re: RFC: develop feature branches in main repo

of a new branch is announced on this > mailing list. This keeps a log in a public archive with the reason for > the branch, a place to discuss and to get more contributors. Makes sense to me. We shouldn't have such a huge number of branches that they clog up

Re: RFC: develop feature branches in main repo

On Tuesday, November 09, 2010 09:21:21 PM Bart Cerneels wrote: > On Tue, Nov 9, 2010 at 17:04, Ian Monroe wrote: > > On Tue, Nov 9, 2010 at 9:57 AM, Leo Franchi wrote: > >> On Tuesday, November 09, 2010 09:50:29 AM Ian Monroe wrote: > >>> I know some people are s

Re: RFC: develop feature branches in main repo

On Tuesday, November 09, 2010 09:50:29 AM Ian Monroe wrote: > I know some people are still using Gitorious repos and such for the > ongoing work. However recently everyone has been granted the right to > create branches on our git.kde.org/amarok.git repo. > > I think it would raise the visibility

Re: broken install target

On Monday, November 08, 2010 07:31:12 PM Mathias Panzenböck wrote: > current git produces this error on make install: > > CMake Error at src/images/icons/cmake_install.cmake:208 (FILE): >file INSTALL cannot find > > "/home/panzi/software/amarok/src/images/icons/hi16-action-lastfm-loved-radi

Re: time to update the about dialog

On Sunday, November 07, 2010 11:26:02 PM Myriam Schweingruber wrote: > Hi all, > > On Fri, Nov 5, 2010 at 22:53, Lydia Pintscher wrote: > > Heya folks :) > > > > I think it's time to look at who should be added to the about dialog > > for 2.4. We've had a lot of contributions from new people lat

Re: Review Request: Match space-separated search terms individually

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100128/#review314 --- Ship it! I think he meant const ref, so const QString&. But I'll

Re: Review Request: Coverbling applet (playground) build fix

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100133/#review313 --- Ship it! Looks good to me too, after the minor whitespace fix!

Re: New collection scanner

Hi Ralf, An update. After your various fixes, scanning is much faster now (yay QSharedMemory!) Now it gets stuck at 24%, here is the debug output: http://pastebin.com/HPadHHtf leo On Wednesday, November 03, 2010 06:09:35 PM Ralf Engels wrote: > Hi all, > since this morning (very early) the ne

Re: Review Request: Improve lyrics applet

> On 2010-11-05 07:41:17, Rick W. Chen wrote: > > src/themes/context/Amarok-Mockup/colors, lines 53-67 > > > > > > These changed the colours for some of the strings the the context view. > > e.g. text scrolling widget

Re: Review Request: Improve lyrics applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/#review308 --- src/context/Applet.cpp

Re: Podcast Engine

On Friday, November 05, 2010 04:16:59 PM Ian Monroe wrote: > Seems like it would make sense to decide on this now. If you want to > make a plasma engine first (I'm personally not convinced plasma > engines make sense for use in Amarok), it would matter if the > resulting applet only worked with Pod

Re: handling of "ship it"

On Wednesday, November 03, 2010 04:54:31 PM Lydia Pintscher wrote: > Heya folks > > In the last days I've seen a few occurences of the following: > > * patch gets submitted to reviewboard > * patch gets very quick review > * ship it is clicked by one person or more > * patch gets commited > * per

Re: Review Request: New context menu applet to display guitar and bass-tablature

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100117/#review272 --- Ship it! Works great now. I'll commit it. However, you should a