----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100176/#review443 -----------------------------------------------------------
Ship it! I don't have a DAAP server to test, but on a first look the code looks okay. I don't think ServiceAlbumCoverDownloader is the proper class to use, as it;s a part of the service framework and uses ServiceAlbums. I don't know the collection framework very well, and if there is a utility class to use or not, sorry. - Leo On 2010-11-28 15:03:30, Dennis Francis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100176/ > ----------------------------------------------------------- > > (Updated 2010-11-28 15:03:30) > > > Review request for Amarok. > > > Summary > ------- > > This is just a copy and paste attempt to introduce cover fetch functionality > for DAAP albums. I used PlaydarMeta.h/.cpp as the reference. > > Please suggest better methods ! > > The cover arts does not persists between multiple runs of amarok; it seems to > load the art from internet everytime. Should I be using > ServiceAlbumCoverDownloader which has implemented caching ? > > > This addresses bug 240060. > https://bugs.kde.org/show_bug.cgi?id=240060 > > > Diffs > ----- > > src/core-impl/collections/daap/DaapMeta.h 8187d1e > src/core-impl/collections/daap/DaapMeta.cpp 61aa0db > > Diff: http://git.reviewboard.kde.org/r/100176/diff > > > Testing > ------- > > I am using a firefly DAAP server. > Cover art is getting fetched in non-blocking mode. > > > Thanks, > > Dennis > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
