t; right? Only thing I like about it is clearer diff when adding new values -
> > but that's just cosmetic.
C++11 and C99 actually allow the trailing comma.
- Edward Hades
---
This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113272/#review41929
---
Ship it!
Ship It!
- Edward Hades Toroshchin
On Oct. 16
571>
Probably you should remove private data, like directory path and library ID.
- Edward Hades Toroshchin
On Oct. 16, 2013, 5:11 p.m., Konrad Zemek wrote:
>
> ---
> This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113278/#review41888
---
Ship it!
Ship It!
- Edward Hades Toroshchin
On Oct. 16
ttp://git.reviewboard.kde.org/r/113278/#comment30570>
I would probably add the "Importer" to the end, just for the off-chance
someone attempts to load an old library with old type id.
Don't know if it sounds important, just wanted to point out.
- Edward Hades Toroshchin
On Oct. 16, 20
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112148/#review38200
---
Thanks, Frank! Awesome job.
- Edward Hades Toroshchin
On
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111804/#review36908
---
Ship it!
but fix the whitespace error first.
- Edward Hades
Please check, if this indeed compiles and works. Please also check that the
"Shuffle" playlist sort works after Amarok restart. (I believe it isn't in the
current solution.)
- Edward Hades Toroshchin
On July 30, 2013, 8:16 p.m., Fabian Kosmale wrote:
>
>
/uploaded/files/2013/02/03/nepomuk-sync.png
Thanks,
Edward Hades Toroshchin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Git commit ad83a4bbc5d217768701e91d072e723fa10ae2da by Edward Hades.
Committed on 31/05/2013 at 12:46.
Pushed by hades into branch 'master'.
add -Wall and -Wextra to the debug build flags
Watch out for those warnings now!
CCMAIL: amarok-devel@kde.org
M +1-0CMakeLists
er hand, there
> > are about 265 files that use using namespace XYZ; syntax for function
> > definitions. Please improve, rather than fight, consistency.
>
> Edward Hades Toroshchin wrote:
> It's not about consistency. Favouring the using-directive is not a
> qu
individual developers.
> >
> > There are about 25 .cpp files in current Amarok source code that embody
> > all the method definitions into namespace XYZ {}. On the other hand, there
> > are about 265 files that use using namespace XYZ; syntax for function
&g
/nepomuk-sync.png
Thanks,
Edward Hades Toroshchin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
ng a favour to your reviewers,
> i.e. me.
I don't mind that at all. It's the thing you're perfectly right about.
- Edward Hades
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.or
,
Edward Hades Toroshchin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
<http://git.reviewboard.kde.org/r/108717/diff/11/?file=145268#file145268line46>
> >
> > We prefer Qt equivalents of std classes, if they exist. But reading
> > documentation of std::auto_ptr, it doesn't seem to make sense as a function
> > argument, you d
ne, however the process to do it
> would be
> to gradually remove classes out of it, so the change shouldn't be really
> "abrupt" as you would be essentially removing an empty library.
>
> > Having said all that, I should emphasize, that your views on components
> > and memory usage rules are quite good and I agree with them completely
> > (at least in general, there are some details that should be polished
> > out, naturally).
>
> Good. While it may look as the contrary, I actually think we have a very
> similar goals and approaches, just with one technical difference (to split
> or
> not to split, that's the question). As I've said above, that question
> doesn't
> have to be answered until very late in the process.
>
> I'd also like to have feedback from other devs rather than a 2-man
> discussion.
> Bart, Ralf, Markey, Sam, Sven, Téo!
>
> Many of us seem to be coming to Akademy, maybe we can actually start a bit
> of
> hacking there? (not just discussing)
>
> Cheers,
> Matěj
> ___
> Amarok-devel mailing list
> Amarok-devel@kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>
--
Edward "Hades" Toroshchin,
dr_lepper on irc.freenode.org
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
>
Do you really need a nested block here?
- Edward Hades Toroshchin
On May 27, 2013, 6:21 p.m., Konrad Zemek wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.revi
at
> > /home/mark/Devel/src/amarok/src/EngineController.cpp:342
> > #17 0x7f7e0d1442fe in App::~App (this=0x7fffbaed2118) at
> > /home/mark/Devel/src/amarok/src/App.cpp:206
> > #18 0x0040f948 in main (argc=4, argv=0x7fffbaed34b8) at
> > /home/mark/Devel/src/amaro
ections probably can, but that's probably it.
- Edward Hades
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110520/#review32797
-
rc/main.cpp:330
> >
This looks like a bug in Nepomuk, I've asked on the #nepomuk-kde channel
already.
The crash happens on this line:
nepomuk-core-4.10.2/libnepomukcore/resource/resource.cpp:699:
if (!m_data->uri().isEmpty())
(m_data is apparently null)
- Edward Hades
--
://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/nepomuk-sync.png
Thanks,
Edward Hades Toroshchin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/nepomuk-sync.png
Thanks,
Edward Hades Toroshchin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
/02/03/nepomuk-counting-querymaker.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/nepomuk-queries.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/nepomuk-sync.png
Thanks,
Edward Hades Toroshchin
___
Amarok
ments
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/nepomuk-counting-querymaker.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/nepomuk-queries.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/nepomuk-sync.png
Thanks,
E
/02/03/nepomuk-counting-querymaker.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/nepomuk-queries.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/03/nepomuk-sync.png
Thanks,
Edward Hades Toroshchin
___
Amarok
oard.kde.org/r/110187/#comment23646>
whitespace error
- Edward Hades Toroshchin
On April 25, 2013, 2:36 p.m., Patrick von Reth wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
> On April 25, 2013, 3:43 p.m., Edward Hades Toroshchin wrote:
> > Thanks for the fix. However, this is the approach, we've used originally,
> > and it didn't prove very reliable. I think we even went back and forth more
> > than once.
> >
> > So y
ot only that, it could also lead to problems if several users tried to
use Amarok simultaneously.
I suggest you check, where does this path come from. Why is storageLocation
empty?
- Edward Hades Toroshchin
On April 25, 2013, 2:36 p.m., Patrick von Reth wrote:
>
> ---
;. I would personally list all the
missing enum values explicitly.
Thanks!
- Edward Hades Toroshchin
On April 24, 2013, 12:25 a.m., Konrad Zemek wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git
On Wed, Apr 3, 2013 at 6:06 AM, Sven Krohlas wrote:
> This project has a history of taking decisions on IRC, but imho it is
> time to ask ourselves weather this is a good approach. Imho it is not.
>
Definitely not.
--
Edward "Hades" Toroshchin,
dr_lepper
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109157/#review28081
---
Why do you want the intermediate libs at all?
- Edward Hades
uch things happen: we discussed something on IRC, and Bart wasn't aware
of that.
Bart, I've committed the hint before the review. Then strohel asked me
to open this review to ask the usability folks to help. Which I did.
--
Edward "Hades"
shift to move instead of copying" for
> dropping items onto Collections pane.
> This review [...] is about *context menus*.
Hiding context menu items until the user holds Shift is not uncommon. In an
operating system called Windows™ (which you might have heard o
,
Edward Hades Toroshchin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
-sync.png
Thanks,
Edward Hades Toroshchin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Diff: http://git.reviewboard.kde.org/r/108717/diff/
Testing (updated)
---
Playing tracks from Nepomuk collection, browsing, filtering, adding/removing
labels.
Thanks,
Edward Hades Toroshchin
___
Amarok-devel mailing list
Amarok-devel@kde.org
1d6e3b1066e13fd6adba15ae6b1d81f8ca28a5d9
Diff: http://git.reviewboard.kde.org/r/108717/diff/
Testing
---
Playing tracks from Nepomuk collection, browsing, filtering.
Thanks,
Edward Hades Toroshchin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org
/collections/nepomukcollection/meta/NepomukYear.cpp
1d6e3b1066e13fd6adba15ae6b1d81f8ca28a5d9
Diff: http://git.reviewboard.kde.org/r/108717/diff/
Testing
---
Playing tracks from Nepomuk collection, browsing, filtering.
Thanks,
Edward Hades Toroshchin
/collections/nepomukcollection/meta/NepomukYear.cpp
1d6e3b1066e13fd6adba15ae6b1d81f8ca28a5d9
Diff: http://git.reviewboard.kde.org/r/108717/diff/
Testing
---
Playing tracks from Nepomuk collection, browsing, filtering.
Thanks,
Edward Hades Toroshchin
/nepomukcollection/meta/NepomukYear.cpp
1d6e3b1066e13fd6adba15ae6b1d81f8ca28a5d9
Diff: http://git.reviewboard.kde.org/r/108717/diff/
Testing
---
Playing tracks from Nepomuk collection, browsing, filtering.
Thanks,
Edward Hades Toroshchin
* PlaylistManager::downloadPlaylist() is moved as a helper method to
> FilePlaylist and incorporated to the backgroundJob that performs the playlist
> loading.
So you propose not to maintain the current behavior, but just go with it and
refactor th
not trip up on this. Better remove the
> > ';' to be compatible with the less forgiving compilers out there, like MSVC.
Since you're missing all the fun in the ircs, I'll ask here again: what's the
problem with {;}?
- Edward Hades
ard, when you've already compiled the StatSyncing code, perhaps you
> can lightly test it? ;) UI in Amarok Config, scrobbling still working,
> synchronizing with Last.fm (warning: non-interactive part is time-consuming)
> or with an iPod...
Sure, just don't wait for me b
on in StatSync::Provider, and according to
yourself. And it won't make it useless. Again, your Provider is in main
thread, but it isn't useless, despite that it's essentially a blocking
interface to QueryMaker.
--
Edward "Hades" Toroshchin
dr_lepper on irc.freenode.org
__
e it on my side.
Well, if you document the diamond inheritance for people who have heard
first of it, you could've documented this "pattern" here as well.
--
Edward "Hades" Toroshchin
dr_lepper on irc.freenode.org
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
> On Nov. 17, 2012, 7:59 p.m., Edward Hades Toroshchin wrote:
> > Haven't run it yet, but at least it compiles okay :)
>
> Matěj Laitl wrote:
> Thanks for the attentive review, I didn't expect somebody to dive that
> deep and I'm grateful.
>
>
> On Nov. 17, 2012, 7:59 p.m., Edward Hades Toroshchin wrote:
> > src/services/lastfm/SynchronizationAdapter.cpp, lines 38-43
> > <http://git.reviewboard.kde.org/r/107348/diff/1/?file=94955#file94955line38>
> >
> > This should be Qt::AutoConnection. Otherwise
. Looks fine.
Scanned some folders with creepy characters. Looks also fine.
Thanks,
Edward Hades Toroshchin
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
e configure which folders Nepomuk
> > indexes? You should use these for this call. (not a merge-blocker)
>
> Edward Hades Toroshchin wrote:
> Phalgun, add a // TODO comment here, so that this can be investigated in
> the future.
>
> Bart Cerneels wrote:
> You shoul
x27;t make any sense there.
> On Sept. 4, 2012, 6:11 p.m., Matěj Laitl wrote:
> > src/core-impl/collections/nepomukcollection/meta/NepomukTrack.h, line 114
> > <http://git.reviewboard.kde.org/r/106042/diff/7/?file=83672#file83672line114>
>
sign issue:
> >
> > You either need MemoryCollection or all these hashes, but not both. I'm
> > still not convinced that you cannot avoid MemoryCollection at all, but if
> > you use it, don't duplicate MapChanger.
>
> Edward Hades Toroshchin wrote:
sign issue:
> >
> > You either need MemoryCollection or all these hashes, but not both. I'm
> > still not convinced that you cannot avoid MemoryCollection at all, but if
> > you use it, don't duplicate MapChanger.
>
> Edward Hades Toroshchin wrote:
sign issue:
> >
> > You either need MemoryCollection or all these hashes, but not both. I'm
> > still not convinced that you cannot avoid MemoryCollection at all, but if
> > you use it, don't duplicate MapChanger.
>
> Edward Hades Toroshchin wrote:
42/diff/4/?file=79207#file79207line216>
> >
> > You don't need your hash just for this! Just do:
> >
> > m_memoryColl->artistMap().contains( artistLabel ) (or something
> > similar, ensire that the map is (const)-referenced and to copied
12, 9:23 a.m., Vishesh Handa wrote:
> > src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.cpp,
> > line 67
> > <http://git.reviewboard.kde.org/r/106042/diff/3/?file=78575#file78575line67>
> >
> > Minor nitpick - QString::fromLatin1( .. )
Rather
/NfsDeviceHandler.cpp
<http://git.reviewboard.kde.org/r/106094/#comment13907>
Are you sure it couldn't have been done with QUrl::host() and QUrl::path()?
src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.cpp
<http://git.reviewboard.kde.org/r/106094/#comment13908>
Same here.
nice progress bar here, by using
Amarok::Components::Logger->newProgressOperation()
(although I'm not quite sure it works immediately with ThreadWeaver jobs)
- Edward Hades Toroshchin
On Aug. 16, 2012, 3:52 p.m., Phalgun Guduthur wrote:
>
> ---
;
b) If the "update automatically" checkbox is set, it checks for updates
automatically.
Screenshots
---
the first-run widget
http://git.reviewboard.kde.org/r/106071/s/680/
Thanks,
Edward Hades Toroshchin
___
Amarok-devel mailin
on.
> > How about a real Nepumuk backed collection not using sql at all?
> >
> > I would like to reject this request if you agree.
Ralf, note the review description:
> Please note, this is only for proof of concept. This is not intended to be
> shipped.
Sorry, I should
A direct question like
"Would you like Amarok to contact {{servicename}}? This will send your
current location, names of your children and your SSN to
{{servicename}}, which can do whatever they want with it. But you really
should do that, otherwise you won't be able to enjoy {{benefits}} of
valid country has been set.
Yeah, that'd be nice.
Cheers,
--
Edward "Hades" Toroshchin
dr_lepper on irc.freenode.org
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Manager is ready.
As far as I've seen, no one caches the result. There is even a TODO comment
that suggests that such caching should be implemented in the
collectionFolders() itself.
Also, the desired behavior of caller when MountPointManager is not ready is
ike to see this project crash and burn because of a
lacking API functionality, or something of the kind.
I think the Russian Amarok users would be very pleased if you
implement this project.
Best,
--
Edward "Hades" Toroshchin,
dr_lepper
iting.
This however would not please the guy at bug 223309 [1] and other
old-amarok fans, because they would also like to remove items #1 and #2
(and I personally see their point), but I do not think it is very easy
to implement.
What do you think?
Best,
--
Edward "Hades" Toroshchin
g/r/100372/diff
Testing
---
It compiles, it creates example presets if playlistgenerator.xml is missing.
Thanks,
Edward Hades
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Can you please show the cmake output (when it succeedes without having
mysql)? Also, please check if you have the mysql_config binary.
--
Edward "Hades" Toroshchin,
dr_lepper on irc.freenode.org
___
Amarok-devel mailing list
Amarok-devel@kde
67 matches
Mail list logo
