----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106071/ -----------------------------------------------------------
Review request for Amarok. Description ------- magnatune: first update related tweaks These commits pursue single basic goal: not to let Magnatune service plugin go ahead and download bunch of stuff from Magnatune at the first Amarok run. Basically, it's just a "allow auto updates" checkbox in the settings (disabled by default), and a messge in Magnatune UI telling the user, that she needs to let Amarok download Magnatune database manually, or let Amarok download it automagically ever after. magnatune: added "auto update database" option magnatune: honor auto update settings magnatune: ask user to update database This adds a widget to the Magnatune service pane, that tells the user, that Amarok needs to download Magnatune database, and that this can also be performed automatically. Diffs ----- src/services/magnatune/CMakeLists.txt 524b3e8cf3d45597cd91b5f0a181ebcc0878a229 src/services/magnatune/MagnatuneConfig.h f1d25ebd3643086df4e09902a6b022a13765e810 src/services/magnatune/MagnatuneConfig.cpp 18ee8985b3cedbbf3559ef50a5a94643655d5269 src/services/magnatune/MagnatuneConfigWidget.ui 782ef25e153cee152ab4fbc35e1cd2de393bbe63 src/services/magnatune/MagnatuneNeedUpdateWidget.h PRE-CREATION src/services/magnatune/MagnatuneNeedUpdateWidget.cpp PRE-CREATION src/services/magnatune/MagnatuneNeedUpdateWidget.ui PRE-CREATION src/services/magnatune/MagnatuneSettingsModule.cpp 3d7790b2c8d0719014695fa0ea04be5b929802dd src/services/magnatune/MagnatuneStore.h 3f80e4c6e1cb350a14a3a157e76642ff48a96fcf src/services/magnatune/MagnatuneStore.cpp b1c5252f0d32bde21af6f39abcae485f8899162d Diff: http://git.reviewboard.kde.org/r/106071/diff/ Testing ------- The following correct behavior is observed: 1. First run: a) Magnatune does not download the database automatically; b) The "you need to download the database" widget appears. 2. After "update" button has been clicked: a) Magnatune database is being downloaded; b) The "you need to download the database" widget disappears. 3. Subsequent runs (after a successful update): a) Magnatune just works; b) If the "update automatically" checkbox is set, it checks for updates automatically. Screenshots ----------- the first-run widget http://git.reviewboard.kde.org/r/106071/s/680/ Thanks, Edward Hades Toroshchin
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
