Re: [amarok] src/core-impl/collections/upnpcollection: Update Amarok to work with Cagibi >= 0.2.0 D-BUS API

2012-01-21 Thread Myriam Schweingruber
On Sat, Jan 21, 2012 at 18:54, Ralf Engels wrote: > Git commit 7913c4a58ebe010baf58dda825f2341d856ad2d7 by Ralf Engels. > Committed on 21/01/2012 at 18:52. > Pushed by rengels into branch 'master'. > > Update Amarok to work with Cagibi >= 0.2.0 D-BUS API > > Cagibi 0.2.0 changed the D-BUS API incl

Re: Review Request: Enable find as you type support in the playlist

2012-01-21 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102442/#review9982 --- Been thinking about it. It's a nice functionality, but also hard

Re: Review Request: Rework transcoding: CollectionLocation asks user, not caller of prepareCopy()

2012-01-21 Thread Matěj Laitl
> On Jan. 21, 2012, 11:56 a.m., Ralf Engels wrote: > > No obvious technical issues. > > > > However, I am wondering: Is there really a transcoding capability? > > I mean, we should be able to transcode everything independent of the > > collection it's in. > > > > Also, I don't like the concep

Re: Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

2012-01-21 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103741/#review9977 --- I agree. This patch looks wrong. beginInsertRows(.., 0, 0); shou

Re: Review Request: Rework transcoding: CollectionLocation asks user, not caller of prepareCopy()

2012-01-21 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103752/#review9975 --- No obvious technical issues. However, I am wondering: Is there

Re: [amarok] /: CollectionLocation: make associated collection pointer non-const

2012-01-21 Thread Matěj Laitl
(Kevin, sorry for resend, originally I failed and send it to you directly) On 21. 1. 2012 Kevin Funk wrote: > On Saturday 21 January 2012, 01:39, Matěj Laitl wrote: > > Git commit 99a7d0b5bb541ed6400213d81cc7683935666514 by Matěj Laitl. > > Committed on 20/01/2012 at 15:21. > > Pushed by laitl int

Re: Review Request: Possibility to give an UMS-Collaction a descriptive name

2012-01-21 Thread Volker Christian
> On Jan. 20, 2012, 1:51 p.m., Bart Cerneels wrote: > > Since the prettyName automatically falls back to the device name it gets > > from solid it's already configured automatically. As such it's a completely > > non invasive option in that dialog. It might be a good idea to prevent > > accide

Re: Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

2012-01-21 Thread Jaime Torres Amate
> On Jan. 20, 2012, 10:53 a.m., Matěj Laitl wrote: > > src/browsers/playlistbrowser/PlaylistBrowserModel.cpp, line 643 > > > > > > I don't understand this. Do not add a new playlist if there were no > > playlists p

Re: Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

2012-01-21 Thread Jaime Torres Amate
> On Jan. 20, 2012, 10:53 a.m., Matěj Laitl wrote: > > src/browsers/playlistbrowser/PlaylistBrowserModel.cpp, line 643 > > > > > > I don't understand this. Do not add a new playlist if there were no > > playlists p

Re: Review Request: Possibility to give an UMS-Collaction a descriptive name

2012-01-21 Thread Volker Christian
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736/ --- (Updated Jan. 20, 2012, 11:41 a.m.) Review request for Amarok and Bart Cer

Re: [amarok] /: CollectionLocation: make associated collection pointer non-const

2012-01-21 Thread Kevin Funk
On Saturday 21 January 2012, 01:39, Matěj Laitl wrote: > Git commit 99a7d0b5bb541ed6400213d81cc7683935666514 by Matěj Laitl. > Committed on 20/01/2012 at 15:21. > Pushed by laitl into branch 'master'. > > CollectionLocation: make associated collection pointer non-const > > CollectionLocation is u