> On Jan. 20, 2012, 1:51 p.m., Bart Cerneels wrote: > > Since the prettyName automatically falls back to the device name it gets > > from solid it's already configured automatically. As such it's a completely > > non invasive option in that dialog. It might be a good idea to prevent > > accidental changes by disabling the editability of the textEntry field, but > > that is nitpicking and can be done later in a few minutes. > > > >
I have also changed the implementation of prettyName to return the configured collection name if it exists. Thus, if the user didn't change the collection name in the dialog the name from solid is used. Otherwise, when the user has changed the name in the dialog this changed name is used. So it's not a good idea to disable the editability of the textEntry field as it is essential for this feature! - Volker ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736/#review9969 ----------------------------------------------------------- On Jan. 20, 2012, 11:41 a.m., Volker Christian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103736/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2012, 11:41 a.m.) > > > Review request for Amarok and Bart Cerneels. > > > Description > ------- > > I sometimes missed the possibility to give an UMS-Collection a descriptive > name. This patch adds this feature to the USM-Collection. > > > Diffs > ----- > > src/core-impl/collections/umscollection/UmsCollection.h 7c86fab > src/core-impl/collections/umscollection/UmsCollection.cpp aaa9a6d > src/core-impl/collections/umscollection/UmsConfiguration.ui d9a6365 > > Diff: http://git.reviewboard.kde.org/r/103736/diff/diff > > > Testing > ------- > > > Screenshots > ----------- > > UMS-Config Dialog > http://git.reviewboard.kde.org/r/103736/s/417/ > UMS-Collection > http://git.reviewboard.kde.org/r/103736/s/418/ > > > Thanks, > > Volker Christian > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
