> On Jan. 20, 2012, 10:53 a.m., Matěj Laitl wrote: > > src/browsers/playlistbrowser/PlaylistBrowserModel.cpp, line 643 > > <http://git.reviewboard.kde.org/r/103741/diff/1/?file=47490#file47490line643> > > > > I don't understand this. Do not add a new playlist if there were no > > playlists previously? > > > > (both new and old approach suffer from this)
I read the code the wrong way :-(. it is inserted in m_playlists not the other way. But, if it is inserted in m_playlists, why does the crash is in the at() method? And why doing it only if i>0 fixes the crash (for me)? - Jaime Torres ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103741/#review9962 ----------------------------------------------------------- On Jan. 19, 2012, 9:23 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103741/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2012, 9:23 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Avoid trying to add no rows (if i==0). > > > This addresses bug 285541. > https://bugs.kde.org/show_bug.cgi?id=285541 > > > Diffs > ----- > > src/browsers/playlistbrowser/PlaylistBrowserModel.cpp e507547 > > Diff: http://git.reviewboard.kde.org/r/103741/diff/diff > > > Testing > ------- > > Until this little change, I was reproducing the bug. > > > Thanks, > > Jaime Torres Amate > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
