----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736/ -----------------------------------------------------------
(Updated Jan. 20, 2012, 11:41 a.m.) Review request for Amarok and Bart Cerneels. Changes ------- Fixed white space ;-) Most of the time the filesystem label is used as the collection name. Though, in some circumstances this is not the case. For example if you own a Samsung Galaxy SII equiped with a build in usb-memory card and an external micro-sd card, both collections are named as "Android UMS Collection" regardless of which labels are assigned to the filesystems on the cards. This makes it hard to distinguish them in amarok. Thus, i introduced this feature. By default the collection name is choosen to be the string prittyName() returns. Description ------- I sometimes missed the possibility to give an UMS-Collection a descriptive name. This patch adds this feature to the USM-Collection. Diffs (updated) ----- src/core-impl/collections/umscollection/UmsCollection.h 7c86fab src/core-impl/collections/umscollection/UmsCollection.cpp aaa9a6d src/core-impl/collections/umscollection/UmsConfiguration.ui d9a6365 Diff: http://git.reviewboard.kde.org/r/103736/diff/diff Testing ------- Screenshots ----------- UMS-Config Dialog http://git.reviewboard.kde.org/r/103736/s/417/ UMS-Collection http://git.reviewboard.kde.org/r/103736/s/418/ Thanks, Volker Christian
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel