[Bug 310999]
For whatever reason this bug seems to attract spam, so I'm going to restrict comments to attempt to help with that. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/310999 Title: comodo seen issuing certificates unwisely To manage notifications about this bug go to: https://bugs.launchpad.net/nss/+bug/310999/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1065126]
*** Bug 1715025 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1065126 Title: "Always do this from now on" does not work To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1065126/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1065126]
*** Bug 1668182 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1065126 Title: "Always do this from now on" does not work To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1065126/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1065126]
*** Bug 1679561 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1065126 Title: "Always do this from now on" does not work To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1065126/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1820514]
https://searchfox.org/mozilla- central/rev/44a212460990ecf50a8e972d3cbde2e7216b/dom/webbrowserpersist/moz.build#7-9 may help in figuring out how this happened. That said, I don't know of anyone actively working on embedding who would own this, and if anything that seems like a poorer fit in terms of what the code is doing... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1820514 Title: Saving a web page from Tom's Hardware forums fails To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1820514/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1820514]
Saving only the HTML works, "web page, complete" doesn't. There's some issue with nsIWebBrowserPersist here. There's a `
[Bug 263505]
Looks like Chrome bakes the list in, see e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=610495 , without out-of-band updates. We now (as of bug 1459891) do this, too, but fortunately our updates are mostly automatic (they are automatically created by a bot based on the authoritative list, and reviewed by a human). I think that's probably sufficient to move forward with this bug, even if out-of-band updates would be a nice bonus. There should probably be an about:config pref to turn search-for-non-psl-domains off. Marco, could this be part of the quantumbar improvements? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/263505 Title: Wishlist: add "use input as a search term" to "address not found" page To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/263505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1850529]
*** Bug 1597006 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1850529/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1850529]
(In reply to Emilio Cobos Álvarez (:emilio) from comment #10) > Ah, thanks for the update Olivier :) > > I think it'd still be nice to detect this at configure time if possible, but > it may be not worth the churn. I agree - me and a gsoc student were stumped on this for close to a month, trying to figure out what was wrong with their setup. There's also been a succession of dupes filed. Can we add a configure check to prevent building with clang 6 unless located in `.mozbuild` ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1850529/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1850529]
Oops, wrong needinfo requestee. (In reply to :Gijs (he/him) from comment #12) > Can we add a configure check to prevent building with clang 6 unless located > in `.mozbuild` ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1850529 Title: Crash after update to 71.0~b5+build1-0ubuntu0.16.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1850529/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1065126]
*** Bug 1600471 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1065126 Title: "Always do this from now on" does not work To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1065126/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 25830]
Backlog grooming: bugs without an assignee cannot be P1. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/25830 Title: Option to display file in browser, treat as text/plain To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/25830/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 597825]
We hide the menubar by default and have lived with this for nearly 20 years. I don't think it needs priority right now - we have enough on our plate as part of the Photon backlog. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/597825 Title: Menu accelerators in Firefox don't follow the GNOME policy. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/597825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1065126]
*** Bug 1589121 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1065126 Title: "Always do this from now on" does not work To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1065126/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to Abhro from comment #152) > I do have history turned off, but visit previously visited sites that I do > know that TLD for and do not need to search for, thus pressing > [Ctrl+]Shift+Enter for .net / .org directly. I see the usefulness in being > able to open new windows from the awesome bar, but the .net / .org is still > widely enough used TLDs IME, less so across the globe - that is, if I'm in (say) France, I'd probably prefer `.fr`, in South Africa, .za, etc. The .net/.org shortcut was always hardcoded, and as noted before, no other browser has shortcuts for any other domains. > that such autocomplete is desired behavior for some. > Any advice on reverting the behavior, or making a toggle between 'TLD > autocomplete' and 'open address in new window' possible? You can control the suffix of `.com` and change it to something else using the `browser.fixup.alternate.suffix` pref in about:config , if you like. You could also use bookmarks for the sites you use regularly enough that you know the TLD, so that you don't need a modifier key at all and can probably hit enter sooner (TBH, I suspect this is likely to be an improvement for your usecase). As I already said in comment #150, I don't think we'll bring back (an option to use) separate modifier keys for .net/.org. Marco, can you confirm? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
*** Bug 1025847 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
(In reply to Meridel from comment #46) > Prefs copy looks good and hasn't changed from what we have currently. > > Edits to close warning dialogue: > -Numbers less than ten should be spelled out. So if the user is closing 2 - > 9 tabs, spell out the number of tabs. This is really annoying to implement, and requires localizers to provide translations for all these numbers. It also makes it harder to scan for the numbers when reading the warning. It's also not clear to me that any convention in (American?) English that you're using here applies in other languages (eg I grew up in the Netherlands and the rule I got taught was to write out numbers under 20, as well as any numbers divisible by 10 (under 100) or 100 (under 1000), etc.). So it would be "five thousand tabs" but "5341 tabs". I would be unsurprised if other languages used other conventions still. It also doesn't seem related to this bug. If you feel strongly that this is necessary, can you file a separate bug for this, maybe with more details about how that should work? For the changes to the prefs: (In reply to Amy Lee [:amylee] UX from comment #44) > I've attached a spec for Preferences when Session Restore is Enabled and > Disabled. The warning will not show up by default if Session Restore is > enabled but I've added a pref that allows users to turn the warning message > on when Session Restore is enabled if desired. I have a several concerns here. First, now if users have session restore enabled there is 1 pref that governs both window closing and quitting. Unfortunately, there isn't a pref to turn on warnings for quit but not have warnings when closing multiple tabs otherwise. This would be desirable because it's easy to mis-hit cmd-q when trying to hit cmd-w (to close a tab). You have to try pretty hard to mis-hit cmd-shift-w (to close a window) or to close multiple tabs using the mouse. So I want a warning when quitting but not when closing a window, but I can't have that either today or with the implementation you're suggesting. That seems like something we should fix. Second, users who are used to the current behavior with session restore enabled (esp. on Windows, where mis-hitting ctrl-shift-q is also not a major concern) will start getting warning dialogs when we implement the new behavior. That seems disruptive. But we can't turn off the warning everywhere because then they won't get a warning when closing a window, which they might have relied upon. Any thoughts about how to address that? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
*** Bug 1499401 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
(In reply to Amy Lee [:amylee] UX from comment #49) > (In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #48) > > Second, users who are used to the current behavior with session restore > > enabled (esp. on Windows, where mis-hitting ctrl-shift-q is also not a major > > concern) will start getting warning dialogs when we implement the new > > behavior. That seems disruptive. But we can't turn off the warning > > everywhere because then they won't get a warning when closing a window, > > which they might have relied upon. Any thoughts about how to address that? > > The default settings of Session Restore would be what we have currently (not > having warnings). That's not really what happens today. Today, there are warnings when closing windows, or using "close tabs to the right", or using "close other tabs" - but not when quitting, if and only if session restore is enabled. Specifically, the preference you're suggesting we surface "under" Restore Previous Session already exists, and its default is true (ie warn when closing tabs). However, there are hardcoded checks for "does the user have session restore enabled?" in the code that avoid warning when quitting, irrespective of whether the "warn when closing tabs" checkbox is checked. In your new design, we'd remove the hardcoded checks to ask session restore in the code that actually implements warning, and cosmetically we'd move the checkbox in about:preferences, and add some logic to tick/untick (and set/unset the pref) when the user toggles restoring their session. But that doesn't solve the conundrum here - the pref would be turned on by default, and we'd remove the checks, so then the user will start getting warnings. We could have a one-time migration that turns off the "warn when closing tabs" pref for people who have session restore turned on, but that also seems like it'd potentially confuse users who would no longer see warnings when closing windows / multiple tabs (e.g. via "close tabs to the right") where they did see those before. What would you prefer we do? Disable the warnings everywhere for session restore users, or accept that we'll now start warning session restore users who might not have expected this? (In reply to Amy Lee [:amylee] UX from comment #49) > I think we are getting very specific for an issue that I think affects a > small population of users. While I sympathise with the sentiment here, we already made a change in bug 1438499 (to show the same "closing multiple tabs" warning when quitting when session store is not enabled, removing a separate option to show an alternative dialog that people had to opt in to via about:config), and already people on Nightly are basically saying that that removed a "fail-safe": (In reply to Kestrel from bug 1438499 comment #47) > browser.showQuitWarning was a good fail-safe to avoid data loss but now that > it has been removed a suitable replacement is needed, hopefully Bug 550559 > can be expedited to avoid a regression. ... because the "closing multiple tabs" warning on quit is enabled/disabled together with the same warning when closing windows/other/right-hand tabs, there's no way to force the quit warning to come up but not warn for closing windows / multiple tabs, and that's burning people (it seems). (In reply to Amy Lee [:amylee] UX from comment #49) > It starts to become overkill if we try to provide > such specific checkbox options (ie. warn me when quitting, warn me when > closing a window, etc.). FWIW, I think the only requirement here is quitting vs. everything else, and I think an about:config pref would be fine. I don't think this is going to be a slippery slope. Quitting is by its nature *much* more destructive than closing a single window, and as noted, easier to do by accident (esp. on macOS/Linux) than all the other ways of closing multiple tabs. If you're convinced that we don't need to provide an option here, that works, but I think we need to tread carefully and deliberately here. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
Amy, this bug is still assigned to you - is there more that needs to happen design-wise or is this ready to be implemented? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
Created attachment 9021147 Bug 550559 - also show close warnings when session restore is active, r?jaws -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
*** Bug 502908 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
(In reply to Amy Lee [:amylee] UX from comment #69) > (In reply to :Gijs (he/him) from comment #68) > > (In reply to :Gijs (he/him) from comment #67) > > > (In reply to Amy Lee [:amylee] UX from comment #65) > > > > Comment on attachment 9021147 > > > > Bug 550559 - also show close warnings when session restore is active, > > > > r?jaws > > > > > > > > Hi, > > > > > > > > I installed the mac version and I don't see an update to > > > > about:preferences > > > > under the Tabs section (“Warn you when quitting and closing multiple > > > > tabs”) > > > > > > The checkbox is only visible when the user opts out of the warning. This > > > is > > > the existing UX today. > > > > Specifically, this happened in bug 1063625, and there's some discussion > > about it there. > > Hi, > > I mean the warning text hasn't been updated to "Warn you when quitting and > closing multiple tabs", right now it still reads as "Warn you when closing > multiple tabs" Uh, I don't really understand how that's possible. https://hg.mozilla.org/try/rev/b7b641a61f5e#l3.14 shows the change to the string - the old string is no longer present. I just checked the builds produced by try myself, and I can see the new string. The string identifier also changed, so I don't really understand how it's even possible for it to show the old string. Are you sure you ran the .app from the .dmg I linked? Can you try it with a new profile? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
(In reply to :Gijs (he/him) from comment #67) > (In reply to Amy Lee [:amylee] UX from comment #65) > > Comment on attachment 9021147 > > Bug 550559 - also show close warnings when session restore is active, r?jaws > > > > Hi, > > > > I installed the mac version and I don't see an update to about:preferences > > under the Tabs section (“Warn you when quitting and closing multiple tabs”) > > The checkbox is only visible when the user opts out of the warning. This is > the existing UX today. Specifically, this happened in bug 1063625, and there's some discussion about it there. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
Comment on attachment 9021147 Bug 550559 - also show close warnings when session restore is active, r?jaws (In reply to Amy Lee [:amylee] UX from comment #61) > (In reply to :Gijs (he/him) from comment #59) > > Amy, this bug is still assigned to you - is there more that needs to happen > > design-wise or is this ready to be implemented? > > The design is ready to be implemented. Can you please reassign the bug to > someone that implement? OK. I attached a patch. Here are some builds to test: Linux64: https://queue.taskcluster.net/v1/task/Zd3pnRF4QzatNAU9w4kgyw/runs/0/artifacts/public/build/target.tar.bz2 Mac: https://queue.taskcluster.net/v1/task/fNm10L8cQ_6MS4FuBly_Ag/runs/0/artifacts/public/build/target.dmg Windows: https://queue.taskcluster.net/v1/task/TsxrJ8xgQe- pRSlpV7rgbg/runs/0/artifacts/public/build/target.zip Can you let me know if this matches your expectations? Thank you! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
(In reply to Amy Lee [:amylee] UX from comment #65) > Comment on attachment 9021147 > Bug 550559 - also show close warnings when session restore is active, r?jaws > > Hi, > > I installed the mac version and I don't see an update to about:preferences > under the Tabs section (“Warn you when quitting and closing multiple tabs”) The checkbox is only visible when the user opts out of the warning. This is the existing UX today. I'm happy to change it, but the comments there implied that this was intentional, with the idea that the dialogs themselves offer a checkbox to turn this off, at which point it can be turned back on in the preferences. Do you think the checkbox should always be visible? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
Amy, have you had a chance to check the build again? These changes otherwise have r+ and are ready to land. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
Note: we're tweaking this in bug 1506173, so subject to change, but: Release Note Request (optional, but appreciated) [Why is this notable]: long-standing behavior changes subtly [Affects Firefox for Android]: no [Suggested wording]: The "You're closing multiple tabs" warning now applies to quitting Firefox with automatic session restore turned on. [Links (documentation, blog post, etc)]: n/a -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
(In reply to sh.siddhartha from comment #81) > Does the fix not consider pinned tabs? I use multiple windows with many > pinned tabs of websites I regularly use (mail, etc). Ctrl+Q only warns > before quitting if there are at least 2 *unpinned* open tabs. Should it not > consider pinned tabs in the count as well? I think so. Please file a follow-up bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1638610]
(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #3) > > are there spec reasons we can't just stop navigation permanently as soon as > > we fire beforeunload > > At first blush, per spec you can't stop navigation inside beforeunload at > all. Or something. Figuring out what the spec says here is rocket science. > :( (In reply to Anne (:annevk) from comment #5) > First of all, agreed with bz that this is in need of heavy refactoring. > Unfortunately there has been a lot of that, so I haven't gotten around to it > yet. If we had more editors, maybe... > > Having read through navigate and its various associated algorithms a few > times now, I don't think anything there stops this, since the user is > allowed to navigate elsewhere until the page navigated to actually starts > arriving (at that point navigate starts blocking certain navigation > attempts, though not all). > > Now, we could make tweaks, but that's tricky. E.g., if the user clicks onclick=window.location='/x'>test after dismissing the dialog, should > that fail or work? (In reply to Anne (:annevk) from comment #22) > No, the situation around this specification-wise hasn't really improved from three years ago unfortunately. So... I'm going to be quite tentative here, because I'm very much not an expert, and both of you are. But if I'm reading: https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigate Specifically, > If there is a preexisting attempt to navigate browsingContext, and the source browsing context is the same as browsingContext, and that attempt is currently running the unload a document algorithm, then return without affecting the preexisting attempt to navigate browsingContext. > If the prompt to unload algorithm is being run for the active document of browsingContext, then return without affecting the prompt to unload algorithm. I assume that the second of these now does mean that we can avoid navigation from within beforeunload itself, right? I'm guessing (it's a bit hard to tell for me, not knowing where to look in the spec) that we don't unload the current document (ie we don't hit the first cited condition) until we start getting a response for the initial navigation, and so between these two conditions (ie after `beforeunload` and before `unload`), timers (setTimeout etc.) and any other events may trigger JS that starts another navigation, and per spec that should override the earlier navigation. As Anne points out at the end of comment 5, blocking all navigation after 1 navigation has started is tricky. I'm tempted to suggest we try to pass whether a navigation was the result of a user action (similar/using popup blocking state) down to loadinfo in some way, and make user-triggered navigation be un- overridable by webpage navigations. That would, AIUI fix this bug (and all its variations). It's also a bit complex, and I would be happy to hear other alternatives - in particular, I'm quite curious if any of these bugs affect other browsers and what, if any, mitigations they have in place. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1638610 Title: Dependency of JavaScript objects is Misconfigured Browser Crashes. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1638610/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1065126]
*** Bug 1657785 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1065126 Title: "Always do this from now on" does not work To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1065126/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1065126]
*** Bug 1623555 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1065126 Title: "Always do this from now on" does not work To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1065126/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to cousteau from comment #163) > I don't see how removing shift-enter and ctrl-shift-enter is even remotely related to the original request of making ctrl-enter open URLs in a new tab. The point of the bug as filed was to make link opening modifiers work the same between the url bar and other usecases. That applies to shift and ctrl-shift as much as it does to just ctrl. > Personally, if this feature were really necessary (in which case it should have been opened as a separate bug), I would rather have it moved to an unused combination. For example, Windows-enter could be "open in new window" and Windows-alt-enter for "open in new tab, but on the background". We don't use any windows+ shortcuts inside Firefox and doing so would be going against platform convention, which we wouldn't do without very good reasons, so this is a non-starter. > Ultimately, removing the shortcut for .net and .org but keeping it for .com somehow suggests that .net and .org sites are "less important" than .com ones. I could expect that from a browser developed by google.com or microsoft.com, but not from one developed by mozilla.org. In the global alexa top 50 there is 1 .org site (wikipedia), 1 .net site (a Chinese site), and 48 .com sites, and so .com sites are pretty conclusively more commonly used. Not to mention the fact that, if for whatever reason .net (or any other suffix) is more common in your own browsing habits, you can configure the default suffix in about:config (both before and after this change), and it was never possible to configure the suffix for shift-enter and ctrl-shift-enter. I'm going to restrict comments here. The recent history of comments is just repeated complaints that reiterate ground that has already been covered, and as such isn't productive anymore. To reiterate: - we won't (add a pref to) revert this behavior change. See comment #143. There are always trade-offs when making changes to frequently-used parts of the browser like the URL bar. We considered these trade-offs carefully before making the change. That doesn't mean we believe there are no negative side-effects, or that we don't regret people having to retrain muscle memory - it means we made the change despite those side-effects, because we believe the upsides outweigh those negative side-effects. - yes, there's remaining ground to cover in terms of fixing up shortcuts to be even more consistent with other browsers and/or with other uses of modifier keys within Firefox. See bug 1513830, bug 1506203, bug 1506247 . If there's other inconsistencies that got missed, please file separate follow-up bugs. - you can already change the default completion for ctrl-enter to something else in about:config using browser.fixup.alternate.suffix , if that's preferable over .com . - there are extant bugs on file for improving webextension control over shortcuts via bug 1215061 and deps. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
*** Bug 1365469 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
*** This bug has been marked as a duplicate of bug 550559 *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
Comment on attachment 9004028 -fixquit.patch make warn=true warn again Thanks for the suggested patch. There's a plan and UX design in bug 550559, and that'll involve more work than just changing this check. I'd take an updated patch in that bug (I'll dupe this over in a sec). It looks like you'd need to also update the label in the preferences ( https://searchfox.org/mozilla- central/rev/c3fef66a5b211ea8038c1c132706d02db408093a/browser/components/preferences /in-content/main.xul#88-89 - change the identifier for l10n there, and change the identifier and string in https://searchfox.org/mozilla- central/rev/c3fef66a5b211ea8038c1c132706d02db408093a/browser/locales/en- US/browser/preferences/preferences.ftl#179-181 ), and there may be some automated tests that need adjusting. I'm also not sure what branch you wrote this patch against - but it wouldn't apply against nightly, because the code has changed and also checks the warnOnClose pref now (which it should probably keep doing, at least for now). Finally, for your next patch, please could you post something generated by `hg export` or `git show` instead of just the diff, so that the commit properly credits you and includes a summary of the change (ie commit message). Thank you! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 583797]
(In reply to Kestrel from comment #65) > The fix for Bug 550559 did not end up resolving this issue, > browser.warnOnQuit = true still does not work with browser.tabs.warnOnClose > = false. After bug 1506173, there's now a separate pref, browser.sessionstore.warnOnQuit , which you can use to have a quit warning if you have session restore enabled. There's also a checkbox in the prefs/options for this feature. If session restore is not enabled, browser.tabs.warnOnClose still governs whether you get a confirmation warning (if there are multiple tabs). We don't intend to add a third, separate pref/warning for people who *do* want to have a quit warning, *don't* turn on session restore, and *don't* want warnings when closing windows / multiple tabs (ie making browser.tabs.warnOnClose = false + no automatic session restore + browser.warnOnQuit = true show a dialog is not something we're interested in doing. The "point" of the warning is to avoid losing tabs that you can't currently see / may have forgotten you had; from that perspective, wanting a warning for quitting but not for closing a window with multiple tabs doesn't really make sense). Keeping this bug open doesn't really make sense given we've fixed part of it and don't want to make further changes as implied by the bug. But we don't have a "partly fixed" resolution value. So to close this, I have to pick an imperfect resolution value. I'm going to go with "works for me", because the more recent comments here, as well as the proposed patch, are all about the case where people *do* have session restore enabled, which now has an option (that is also exposed in the preferences/options, not just about:config) to do what this bug wants. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
Also, if we're going to change this on only some platforms, given the contention, the most straightforward thing would be to have a pref that we default to different values on Windows - then Windows users who don't care for the IE behaviour can flip it, or vice versa. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to Florian Quèze [:florian] [:flo] from comment #84) > (In reply to :Gijs Kruitbosch from comment #83) > > > Seems to me from comment 81 that this change should not be OS X - specific. > > So do you think we should remove the maybeCanonizeURL code altogether? I > wasn't sure if we wanted to keep this behavior inherited from Internet > Explorer on at least Windows, so I suggested making the minimal behavior > change for a first patch (I was helping nox understand how this code works > while we were waiting at the airport). I'm not familiar with the pedigree of maybeCanonizeURL. It looks like the functionality was originally introduced in 2002 by Hyatt with no bug number. It does look like IE still does this type of completion. Philipp, what do you want to do? (note that "keep matching IE on Windows" != "only change this on OS X"; we should specialcase Windows, not OS X) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to Anthony Ramine [:nox] from comment #87) > :Gijs I don't understand what you mean about a pref on Windows if we only > change this "on only some platforms", given that platform would be macOS > where that behaviour is the odd one. Why do a pref? As I understand comment #84, if we keep this behaviour (ctrl-enter completing to www..com) at all, it'll be on Windows only. I don't see how macOS is special - Windows is, and Linux and macOS should get the 'open in a new tab' behaviour. What I'm saying is that whether we use the existing canonizeURL behaviour should go be behind a pref that's true on Windows and false everywhere else (ifdef'd in all.js). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to :Gijs from comment #96) > add a preference line in all.js Err, might need to be in firefox.js - check where the other urlbar behaviour prefs live. :-) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to Florian Quèze [:florian] [:flo] from comment #90) > (In reply to :Gijs Kruitbosch from comment #86) > > Also, if we're going to change this on only some platforms, given the > > contention, the most straightforward thing would be to have a pref that we > > default to different values on Windows - then Windows users who don't care > > for the IE behaviour can flip it, or vice versa. > > A pref would make sense, especially if we want to be able to test both > behaviors on all platforms. I didn't suggest it mostly because of comment > 62, but that comment was arguably more about exposing the pref in the UI > than about having a pref in the implementation. Yeah - I don't think we want UI, but if we're going to do different things per-OS we might as well implement-via-hidden-pref than hardcode the OS distinctions. There's plenty of precedent for that, e.g. backspace-for-history.back being a hidden pref (browser.backspace_action) that's different on Linux vs. elsewhere. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(but all that is subject to what Philipp says - he reopened the bug in comment #81 so it's up to him to clarify.) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
Comment on attachment 8818332 Bug 237027 - Properly handle accel keys in address bar on macOS. https://reviewboard.mozilla.org/r/98432/#review98694 Seems to me from comment 81 that this change should not be OS X - specific. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to Anthony Ramine [:nox] from comment #95)
> What should I do to get this fixed?
Your patch does:
> } else if (this.AppConstants.platform == "macosx") {
and
> this.AppConstants.platform == "macosx") {
It also hardcodes 'accel' to always mean 'ctrl'.
Instead, leave the accel handling as-is, don't check for the OS, but add
a preference line in all.js, e.g. for
"browser.urlbar.accelenter.newtab". Use #ifdefs for that pref and, on
Windows, set it to false, and on everything else, to true.
Then instead of checking the OS in your patch, check the preference, and
use that to decide what to do.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566
Title:
Inconsistent shortcuts for new tab
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to Marco Bonardo [::mak] from comment #107) > And, we could make canonize complete to browser.fixup.alternate.prefix and > browser.fixup.alternate.suffix, so the user can adapt it to his needs. We already use .suffix, see https://searchfox.org/mozilla- central/rev/c3fef66a5b211ea8038c1c132706d02db408093a/browser/base/content/urlbarBindings.xml#1048-1055 . I think using prefix can be a follow-up bug, that doesn't seem super valuable to me (in fact, I would prefer to get rid of the alternate stuff as it's currently needlessly being mixed in with other bits of URL fixup in nsDefaultURIFixup, but that's a separate discussion). I'll remove shift support here because it affects the pref name, and adding a pref and then renaming it immediately seems stupid. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aad17bf2c7fa4acaf46e1d71cf79069d192d5ecd -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to avada from comment #113) > (In reply to Marco Bonardo [::mak] from comment #111) > > It should, yes. Overall the idea is that CTRL will be the canonization key, > > and it should be possible to disable it, as well as it should imo be > > possible to set what to canonize to (if one prefers .it to .com, for > > example). > > Then on Mac, CMD will open in a new tab, rather trying to canonize. > > Will this finally work with the normal find bar an not just the quickfind > bar? I don't understand - this bug has nothing to do with the find bar, it's about the location bar. The 'search bar' in the summary is about the bar that searches on your default search engine (e.g. duckduckgo, google, bing, ...), not the find-in-page feature. Did you mean to comment on a different bug? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to Marco Bonardo [::mak] (Away 9-26 Aug) from comment #103) > I made a small sheet to better understand what changes here, please check > and comment if something doesn't look correct. > https://docs.google.com/spreadsheets/d/ > 1VVEVjyIYRZIFteM71j5bJhENa2xXT82gaikr0WgpKLA/edit#gid=0 > > I didn't test the patch, I just assumed, on IRC Gijs said it's likely > different. > Anyway, I added a row with the behavior I'm suggesting, that is pretty much > the same as Chromium, apart ALT+Enter on the Mac. I think I implemented this in the updated patch, though I left out the support for downloads using 'alt-enter' on mac. I'm not convinced people want that behaviour, and in any case it'd re-introduce per-platform checks and some redundant calls to whereToOpenLink that I'm not super- fond of. Note that the spreadsheet doesn't cover shift-enter, which also canonifies today. I left that as-is, though of course that now also comes under the pref, and can therefore be turned off (at which point we'll open a new window instead). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to alexander.kern from comment #123) > Hey all, I think opening a new tab in background in a fast way/without > leaving the current page is very useful. I had an extension for that but > it's no longer possible because webext API does not offer that possibility. Not from the URL bar, but extensions can definitely open background tabs, so an add-on could still do this using a page/browser action or a sidebar to offer you UI. > That's why I'm following this bug closely. However now I'm surprised. Here > are all the things that happen on Firefox nightly 64.0a1 (2018-09-06) > (64-Bit): > > ctrl: add www..com > ctrl shift: www.com (should be add www..com in new window?) > shift: new window foreground > alt: new tab foreground > alt ctrl: add www..com and open in new tab foreground > alt shift: nothing happens, should be default action in tab background or > new window background? > alt shift ctrl: www.com new tab background > > The name/description of this bug is "Inconsistent "open in new tab" > shortcuts (Ctrl+Enter for links, but Alt+Enter in address bar and search > bar)" > > So I think the changes now are useful, but do they solve the original issue? > Ctrl+Enter still doesn't open a new tab in background, like it does > everywhere else. I suggest: > > ctrl: open in new tab in background This behavior is now possible, but it's behind a pref (about:config, browser.urlbar.ctrlCanonizesURLs), because the outcome of some of the (long) discussion here was that to remain consistent with Chrome and IE/Edge, we would continue to keep that as the default (see e.g. comment #93). Note that AFAIK Chrome uses `ctrl-enter` even on Linux and Mac, so per the spreadsheet in comment #103 ( https://docs.google.com/spreadsheets/d/1VVEVjyIYRZIFteM71j5bJhENa2xXT82gaikr0WgpKLA/edit#gid=0 ) the default there is also to use ctrl-enter. (This is a change on mac, where it used to be cmd-enter.) I'll change the summary to more accurately reflect what was changed here. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
Release Note Request (optional, but appreciated) [Why is this notable]: see comment #121 [Affects Firefox for Android]: no [Suggested wording]: not sure, maybe: "Changes to URL bar autocomplete shortcuts" [Links (documentation, blog post, etc)]: I'll update https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly#w_miscellaneous_2 . (In reply to Stanley Chan from comment #121) > It will also require documentation updates (i.e. > https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox- > tasks-quickly#w_miscellaneous_2 and I'll submit an update for this after submitting this comment; it'll need to be approved by the SUMO admins. > https://blog.mozilla.org/firefox/keyboard-shortcuts-command-qwerty/) I'll set user-doc-needed here for the above and to get this updated as well. > this is literally 15 year old behavior that is changing. It's also been > blogged about over the years throughout various websites that cater to the > power user (such as LifeHacker and How-To-Geek), but that's nothing that > Mozilla controls. No, I'm afraid if we could never update something that had been documented anywhere else, we would have long ago stopped making Firefox because of our inability to change pretty much anything... even our easter eggs get documented, for better and for worse... > That being said, can we get about:config options to configure the Ctrl-Shift > and Shift-Enter shortcuts in the address bar? There is already for the ctrl-enter case (you can change the suffix via about:config's browser.fixup.alternate.suffix). We removed the shift /ctrl-shift option completely because no other browser has those and they didn't seem useful. > When this feature was first > added, .com, .net. and .org were the most popular of TLD suffixes. Today, I > can see how that is different, and I will admit that I do not complete .net > and .org domains as often. I agree that not many people used it, but perhaps > it can be more accessible if a user can configure those prefixes and > suffixes directly. I see your point, but can I just point out that: - shift-click/enter normally opens new windows on all other types of shortcuts / bookmark/history entries etc. - shift-click/enter is also used for "turning off" switch-to-tab (in order to open links that you have open already a second time) - shift when used with opening new tabs in other places (which uses 'ctrl' on Win/Linux) toggles the background/foreground-ness of tabs so having Yet Another Possible Meaning for the 'shift' modifier here is neither very user-friendly nor all that maintainable in the codebase we have. In fact, even removing it caused me a few different headaches trying to not break any of the other behaviors. The other thing is the value proposition. You'd want this shortcut to avoid typing '.' followed by 2-3 other characters (generally... if you use loads of different '.americanexpress' domains and want to configure ctrl-shift-enter for those, then I'm very sorry...). Just the awkwardness of `ctrl-shift-enter` rather than simply typing those 3-4 chars doesn't seem very valuable to me. That's in addition to the fact that, 15 years since this stuff was implemented, we now autofill history for domains, so if you've visited the site before you can just hit 'enter' straightaway anyway... We're also much more reluctant to add more magical about:config switches that we don't expose in the "regular" options/preferences (and yet more reluctant to add *more* things to those options). So on the whole, I'm not excited about adding this back, not even with configurable suffixes. If my arguments don't seem convincing, please file a separate bug and we'll discuss there, but with 121 comments here so far, I don't think this is the best place. :-) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1ef953500c15e1a86adb2456623e886df479bf8 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
Created attachment 8996717 Bug 237027 - allow turning off URL canonization, remove shift support, and move the remainder from 'cmd' to 'ctrl' on mac, r?mak This isn't convention on macOS or other *nix platforms. Even on Windows, some people may prefer a different behavior. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to avada from comment #118) > Not at all. With the quickfind bar you can press enter to open a link, or > press ctrl+enter to open it in a new tab. But you can not do this with the > normal findbar. That is not relevant to this bug, which is about the location bar and the web search bar and what happens if you press ctrl-enter in that. Those don't share any code with the find bar, so any changes there would have to be a different bug, in a different component, and affecting different code. Your suggestion was discussed in bug 1232096 and wontfixed there. This bug is not related and therefore not the right place to ask for reconsideration. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to alexander.kern from comment #125) > (Yeah, but not using the URL bar is just not as nice. For example look & > feel, use search & bookmarks keywords, afaik.) Yep... perhaps there's room for webextensions to have a larger scope for interaction with the URL bar - you could file a bug in the webextensions product. > Ah thanks, I missed the mention of that pref! Well I'd rather have it not be > consistent, but I understand your reasoning and gave my opinion. Likewise! It's a tricky problem - I was joking on IRC the other day that really we need like 10 modifier keys instead of just 3, then it wouldn't be so hard to come up with a way to make things not conflict... > Still, should the combinations not stack like ctrl+shift canonize and open > in new window? alt+ctrl does already stack as expected (canonize and open > new tab). Why does only that stack? And alt+shift to open in new background > tab would be incredibly useful for users who don't want to mess with > about:config or don't know about it. They can just find it by trying it out > or understanding how stacking should work. > > Anyway this is a followup issue and you said you wanted this bug to be > closed, so if I don't hear back soon I'll submit a new ticket. Thanks! Yes, please submit a new bug for alt-shift / ctrl-shift. :-) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to alexander.kern from comment #128) > Oh and it's not possible with the search bar right now! They don't seem to > share the code. Is that considered as a bug? :Gijs? Could you file a separate issue, and we can work out if it's fixable there? IIRC there are some other subtleties with how search behaves (e.g. defaults for whether tabs open in the foreground or not when you use the page context menu to search are governed by a different pref to the one governing "normal" links opened in tabs). So I'm not sure off- hand how easy it would be to fix. Either way we usually try to fix 1 thing per bug to avoid confusion about what is/isn't fixed. So fixing the search bar, given that it's not using the same code as per your comment, will need to have its own bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to David Balažic from comment #134) > How exactly is this fixed? Where? > > The https://www.mozilla.org/en-US/firefox/64.0/releasenotes/ doesn't mention > it. It does: "The macOS keyboard shortcut to add "www" and ".com" to a URL is now ctrl-enter instead of [apple]-enter" This is the only by-default change here. See the end of comment 124. > (In reply to Julien Cristau [:jcristau] from comment #132) > > Added to 64beta release notes: > > Changes to URL bar autocomplete keyboard shortcuts: use ctrl-enter for URL > > canonicalization on all platforms, and offer an opt-out for Windows/Linux > > users where it interferes with opening URLs in (background) tabs > > Was this dropped for the final release? No, the relnote just got repeatedly rewritten to simplify it and make it understandable/relevant for people who hadn't followed this bug. > What is the opt-out mechanism? On Windows/Linux you can change this by setting `browser.urlbar.ctrlCanonizesURLs` to false. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to Jesse Peden from comment #136) > On macOS, how can I bring back CMD-Enter for URL completion? I do not want > CTRL-Enter on macOS, and I can't seem to find the option in about:config to > change it back. There isn't one. Ctrl-Return is consistent with Safari and Chrome on mac. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to alexander.kern from comment #139) > :Gijs, I don't know how to tag people here so I hope posting here again is > ok to contact you. Could you show me the lines where you changed this code > so I can have a look at it? Because on the issue I created I commented on bug 1506203. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to uhr80386 from comment #146) > What happened so shift+enter and ctrl+shift+enter? > Up to know shift+enter did .net and ctrl+shift+enter did .org.. now it does > open a new window or simply use .com. They were removed to enable support for opening URLs in a new window. No other browser implements these, and with the current set of available TLDs being rather different from those of the late 90s, there didn't seem a good reason to keep this behaviour. There isn't a pref to revert that change. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 66566]
(In reply to smmalis37 from comment #150) > > What happened so shift+enter and ctrl+shift+enter? > > Up to know shift+enter did .net and ctrl+shift+enter did .org.. now it does > > open a new window or simply use .com. > > I've been a Firefox user for years now. I use these keyboard shortcuts > daily. net and org are still extremely common TLDs, even with others > becoming more common. This change is annoying enough for me to seriously > consider downgrading to 63. I ask the Firefox team to please consider > reverting this change until there is a way for this functionality to be > supported by an extension. I don't see this happening. Consistency both with other browsers and other shortcuts trumps the need for alternative domain autocompleting (and really, without the other browsers it would probably have trumped .com autocomplete, too). I'm also really quite confused by the .net / .org case - do you turn off autocomplete and/or history (in the location bar), or something? Why can't you just hit "normal" enter when the domain you want gets autocompleted? Do you just visit new .net/.org domains (where you somehow do know the exact TLD you want, so you don't use a search engine, but you have never visited before) every day? That seems like a very niche usecase... In terms of add-ons, it'd be pretty trivial to write an add-on that just provided you a toolbar button that, when clicked (or activated via a new shortcut of the add-on's choosing), provided an alternative input, where you could type anything and it'd just suffix '.net' or '.org' and navigate the current URL to it. I accept that's quite kludgy, but if you really can't use autocomplete / history for this and are annoyed at typing '.net' or '.org' after URLs, I think that might currently be your best option. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1638610]
*** Bug 1404513 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1638610 Title: Dependency of JavaScript objects is Misconfigured Browser Crashes. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1638610/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 230102]
*** Bug 944394 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/230102 Title: No warning when closing multiple tabs To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/230102/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 230102]
*** Bug 1011838 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/230102 Title: No warning when closing multiple tabs To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/230102/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1407882]
*** This bug has been marked as a duplicate of bug 1081142 *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1407882 Title: Firefox won't automatically adjust the toolbar / tab and content size under high resolution environment in Ubuntu 14.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1407882/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 350407]
*** Bug 1106261 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/350407 Title: Locally saved webpages not displaying correctly To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/350407/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 18995]
*** Bug 1116679 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/18995 Title: [MASTER] "Open With" dialog not user-friendly To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/18995/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 73536]
*** Bug 1088008 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/73536 Title: MASTER Firefox crashes on instant X server shutdown To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/73536/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1315020]
*** Bug 1006649 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1315020 Title: PDF.js prints blank pages To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1315020/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1315020]
(In reply to l.borowka from comment #33) > Firefox 30 beta 2 have this same problem. :/ Yes, there is no fix for the issue yet - we just backed out the patch that caused it from release. As far as I can tell, we're hoping to fix the issue properly on beta. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1315020 Title: PDF.js prints blank pages To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1315020/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1315020]
*** Bug 1007672 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1315020 Title: PDF.js prints blank pages To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1315020/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 519928]
*** Bug 1046390 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/519928 Title: Firefox incorrectly renders table borders when zooming To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/519928/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 308952]
FireFTP is no longer supported. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/308952 Title: FireFTP(Mozilla) cannot LIST files To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/308952/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 241937]
Comment on attachment 8902388
Bug 450915 - Increase the drag space of the TabsToolbar by 15px on the bottom
to improve the tab reordering experience.
https://reviewboard.mozilla.org/r/173956/#review182276
r+ with the downloads and home button included. We can followup making
the 20px match the navbar height more exactly, and/or dealing with the
menubar.
::: browser/base/content/browser.css:184
(Diff revision 2)
> .tabbrowser-tabs[movingtab] > .tabbrowser-tab[fadein]:not([selected]) {
>transition: transform 200ms var(--animation-easing-function);
> }
>
> +#TabsToolbar[movingtab] > .tabbrowser-tabs {
> + padding-bottom: 20px;
Clever. Two questions:
- the 20px feels kind of arbitrary. I guess this should basically be the navbar
height, right? Is there some way we can more closely approximate this?
- should we also do the same for the top and the menubar, if the menubar is
permanently visible (so on non-osx) ?
::: browser/base/content/browser.css:193
(Diff revision 2)
> + margin-top: -20px;
> + pointer-events: none;
> +}
> +
> +/* Allow dropping a tab on the bookmarks-menu-button to create a bookmark. */
> +#TabsToolbar[movingtab] + #nav-bar > #nav-bar-customization-target >
> #bookmarks-menu-button {
We should do the same for the downloads and the home button, which both
also do reasonable things if dropping tabs on them.
::: browser/themes/shared/tabs.inc.css:29
(Diff revision 2)
> :root:-moz-lwtheme {
>--tab-line-color: var(--lwt-accent-color);
> }
>
> #tabbrowser-tabs,
> +#tabbrowser-tabs > .tabbrowser-arrowscrollbox,
Just for my (& future) understanding, why was this necessary?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/241937
Title:
Handle tabs like other gnome apps
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/241937/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 241937]
*** Bug 802934 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/241937 Title: Handle tabs like other gnome apps To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/241937/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796661]
I'm hopeful this (ie the end-user-facing issue; we've not changed what temp dir is used) would be fixed on current nightlies ( https://nightly.mozilla.org/ ) based on bug 1555644 being fixed on Linux/macOS now. Would it be possible for you to verify if your issue is resolved on nightly? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796661 Title: Firefox can't download files to an fscrypt protected, unlocked folder To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796661/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1940417]
Does the flickering happen on a mozilla.org (not distro) Firefox, with a clean separate profile with no other changes (add-ons, prefs changed, etc.)? See [this SUMO page](https://support.mozilla.org/kb/profile- manager-create-remove-switch-firefox-profiles) for details on how to create a separate profile. If so, can you provide the graphics portion of the about:support section of such a profile, please? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1940417 Title: On Wayland toolbar menus are sometimes invisible/flickering To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1940417/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1065126]
The fix for this as far as Firefox is concerned is riding the trains with Firefox 97. Thunderbird ended up with their own fixes that made it to TB 96 and 91.4.1. Any remaining issues with either Firefox or Thunderbird should be filed separately at this point - reopening this 14-year-old bug isn't going to be useful. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1065126 Title: "Always do this from now on" does not work To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1065126/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1065126]
(In reply to Anje from comment #203) > there are going to be an increase in Thunderbird users I can't comment on Thunderbird, and recommend you contact the Thunderbird devs through non-bugzilla channels (matrix or email is probably best). I believe that bug 1690395 was reopened and tracks the TB issue. I'm hopeful that the Firefox changes will help TB devs fix this, but TB is different enough that other/more work may be necessary. You should discuss that with the TB folks. > If someone is already working on this, it would be helpful to communicate this I did communicate this, in comment #201, which you quoted and therefore must have read. I don't know why you didn't take my word for it. If you don't trust my bugzilla comments, then no other change I could make to this bug would convince you that work is ongoing, and the issue is with the lack of trust, not with whatever work we are doing. I did not assign someone to this bug or set a release date because the fix for this bug is part of a bigger project. Although we have hopes about which release that change will ship in, we can't promise anything right now - it depends how long it takes to stabilize the changes in question. Downloads are complex and have a lot of edgecases. We're currently testing out these fixes on the Firefox nightly channel. In barely a week, nightly users have already found 10 or so new issues with it which will need addressing. As a result, I also did not (and still do not) want to write down a version or release here, because inevitably that information may get outdated or superseded, and then users will just be more upset. (I have been reluctant to share the other bug links because quite frankly, 200 comments on those bugs is not something that is going to help anyone, either. I've added one now, **please** do not deluge that one with comments instead; it won't help.) > outsider users are being polite in trying to explain how important this bug is Being polite is necessary, but not sufficient reason for commenting on a bug. This is a bug tracker, in which developers track work, and it isn't a user complaints forum. Being asked several times a week "when is this going to be fixed", no matter how politely, only delays a release date for the actual fix. I restricted comments for exactly this reason. We're sorry this hasn't been fixed yet, we know this is important to users, and that is why we are working on it. No further comments stating how important it is or how terrible it is that this hasn't yet been fixed are necessary, nor indeed helpful, at this point. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1065126 Title: "Always do this from now on" does not work To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1065126/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1065126]
*** Bug 1736804 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1065126 Title: "Always do this from now on" does not work To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1065126/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1796661]
If the previous fix didn't fix it, the new downloads changes that are shipping with 97 should have done. I'm going to resolve this wfm; if this is still broken with 97 or later, please reopen and provide more information. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1796661 Title: Firefox can't download files to an fscrypt protected, unlocked folder To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1796661/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1065126]
The fix got postponed to 98 because of last-minute issues being discovered while it was on beta. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1065126 Title: "Always do this from now on" does not work To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1065126/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 572074]
Stealing per IRC. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/572074 Title: New tabs open to the right of all existing tabs instead of opening next to the current tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/572074/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 572074]
Created attachment 8781962 middlemouse on new tab button should create a new tab related to current, Refactored as suggested, and added a comment why we're using the target of the source event. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/572074 Title: New tabs open to the right of all existing tabs instead of opening next to the current tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/572074/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 572074]
(In reply to Dão Gottwald [:dao] from comment #69)
> Comment on attachment 8781962
> middlemouse on new tab button should create a new tab related to current,
>
> > function BrowserOpenNewTabOrWindow(event) {
> >- if (event.shiftKey) {
> >+ let where = whereToOpenLink(event);
> >+ if (where == "window") {
> > OpenBrowserWindow();
> > } else {
> >-BrowserOpenTab();
> >+// Make new tab related to current except when created via a shortcut
> > command.
>
> This comment doesn't seem accurate, e.g. we don't want to open the tab
> related to the current one for plain clicks... right?
>
> >+let sourceNotKeyEvent = !event.sourceEvent ||
> >event.sourceEvent.target.localName != "key";
> >+let relatedToCurrent = (where == "tab" || where == "tabshifted") &&
> >sourceNotKeyEvent;
> >+openUILinkIn(BROWSER_NEW_TAB_URL, "tab", {relatedToCurrent,
> >+ inBackground: where ==
> >"tabshifted"});
>
> I'm somewhat confused by this. Why are you not passing through "tabshifted"
> as openUILinkIn's 'where' argument?
I literally just used the suggestion you gave in comment #65. I can't
just pass "tab" because in some cases where == "current". I'll rewrite
to use a ternary and drop the inBackground prop, I guess? I'm fairly
sure there will be no behavioural difference compared to the current
patch.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/572074
Title:
New tabs open to the right of all existing tabs instead of opening
next to the current tab
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/572074/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 572074]
(In reply to :Gijs Kruitbosch (PTO recovery mode) from comment #70)
> (In reply to Dão Gottwald [:dao] from comment #69)
> > >+let sourceNotKeyEvent = !event.sourceEvent ||
> > >event.sourceEvent.target.localName != "key";
> > >+let relatedToCurrent = (where == "tab" || where == "tabshifted") &&
> > >sourceNotKeyEvent;
> > >+openUILinkIn(BROWSER_NEW_TAB_URL, "tab", {relatedToCurrent,
> > >+ inBackground: where ==
> > >"tabshifted"});
> >
> > I'm somewhat confused by this. Why are you not passing through "tabshifted"
> > as openUILinkIn's 'where' argument?
>
> I literally just used the suggestion you gave in comment #65. I can't just
> pass "tab" because in some cases where == "current".
I meant, I can't just pass |where|.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/572074
Title:
New tabs open to the right of all existing tabs instead of opening
next to the current tab
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/572074/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 572074]
Created attachment 8782084 middlemouse on new tab button should create a new tab related to current, MozReview-Commit-ID: DOxw0CGpRcp -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/572074 Title: New tabs open to the right of all existing tabs instead of opening next to the current tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/572074/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 572074]
Comment on attachment 8782846
patch v4
Review of attachment 8782846:
-
Meh. r+ I guess? I'm not sure why this is "simpler", but obviously it
works, so whatever.
As far as the "window" case is concerned, you're explicitly regressing
bug 644186, but you reviewed that and it never had ui-review, so up to
you if you think you need it here.
::: browser/base/content/browser.js
@@ -7839,5 @@
> }
>}
> };
>
> -function BrowserOpenNewTabOrWindow(event) {
This method is referenced by a number of add-ons including but not
limited to tabmixplus. We probably need to list it in the compat notes.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/572074
Title:
New tabs open to the right of all existing tabs instead of opening
next to the current tab
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/572074/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 572074]
(In reply to سليمان السهمي (Soulaïman Sahmi) from comment #78) > Although the status says FIXED the keyboard shortcut `Ctrl+T` (which I use > most) still doesn't work as expected. (In reply to Michael from comment #81) > This bug is definitely not fixed, either in FF 51 (I have FF52, and there's > no solution there) or in Seamonkey. And unfortunately, the suggested addons > are FF-only. I would still like to see a solution ... This bug is specifically about middle-clicking or modifier-clicking the actual button, not about what happens if you use the keyboard shortcut, or what happens if you click the button with the left mouse button without using any modifier keys on the keyboard, and this bug is specific to Firefox. If you want to change keyboard behaviour, or want to see a change in seamonkey, or the *specific* changes I just outlined don't work for you (check in a clean profile to make sure add-ons like tabmixplus aren't changing the behaviour), file a new bug. Commenting here will not help. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/572074 Title: New tabs open to the right of all existing tabs instead of opening next to the current tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/572074/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 39136]
*** Bug 1787765 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/39136 Title: firefox should render unrecognized text/* as text/plain To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/39136/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 39136]
*** Bug 1841975 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/39136 Title: firefox should render unrecognized text/* as text/plain To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/39136/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1065126]
We've hit 200 comments here and the vast majority of recent comments are arguing about exactly how dumb Firefox programmers like me are for not having fixed it yet, so I'm locking comments as there seems to be little point. We are actively working on a fix, but as several comments here have already pointed out, it isn't trivial and will come with some side- effects to 20-odd year old ways that Firefox has done downloads. The root cause of this issue is outlined in comment #22: avoiding dataloss when applications don't provide the user with control over the resulting file, while the file is stored ephemerally (ie in the temp folder) and gets deleted later. We'll update this bug when we're confident about those changes making their way to release. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1065126 Title: "Always do this from now on" does not work To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1065126/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
