(In reply to Anthony Ramine [:nox] from comment #95) > What should I do to get this fixed?
Your patch does: > } else if (this.AppConstants.platform == "macosx") { and > this.AppConstants.platform == "macosx") { It also hardcodes 'accel' to always mean 'ctrl'. Instead, leave the accel handling as-is, don't check for the OS, but add a preference line in all.js, e.g. for "browser.urlbar.accelenter.newtab". Use #ifdefs for that pref and, on Windows, set it to false, and on everything else, to true. Then instead of checking the OS in your patch, check the preference, and use that to decide what to do. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/66566 Title: Inconsistent shortcuts for new tab To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs