[jira] [Commented] (MNG-8190) Restrict build pom feature to 4.1.0 model version

2024-10-13 Thread Didier Loiseau (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889041#comment-17889041
 ] 

Didier Loiseau commented on MNG-8190:
-

{quote}The first problem is that the resolver is used before building the main 
model when downloading Maven extensions.
{quote}
Based on some debugging, I think a new {{RepositorySystemSession}} gets 
instantiated after extensions have been resolved. I think it would be 
acceptable to use the new behavior for extensions, and then switch back when 
detecting an old pom. The problem, however, is that the new instance is created 
before calling {{{}DefaultProjectBuilder.build(){}}}, and in 
{{{}DefaultProjectBuilder.BuildSession#build(){}}}, it seems there is some 
dependency resolution happening already in some cases, right after the model is 
built – and it does not seem to be a very good place to switch.
{quote}The second problem is that we could have mixed modelVersions and I don't 
think we can change during the resolution (afaik). We could assume a fixed 
value and look at the root project's modelVersion I suppose.
{quote}
I think it would make sense to take the root’s modelVersion indeed – this 
behavior could be documented. I suppose projects shouldn’t be partially 
migrated anyway.
{quote}Also this would work only when building projects. When consuming, the 
intent of the developer would not be followed, as this would mean each 
dependency should be resolved differently.
{quote}
Indeed, but this is already an issue today with Maven 4… AND with Maven 3, 
since a library developer may already think that their 
{{}} will apply to end-users when it actually does not. 
The same workarounds will remain needed if the library is intended to be used 
by Maven 3 dependents.
{quote}So I'm not saying we can't, but I'm not really sure that it will 
actually lessen the disruption.
{quote}
Most projects shouldn’t have mixed modelVersions, and I think we can assume 
that extensions will run the same as before. For me the important thing is that 
the resulting artifact should have the same dependencies if it’s still in 
modelVersion 4.0.0 – especially for war/ear/fatjar/docker images which bundle 
them.

When users switch to modelVersion 4.1.0, they can fix their dependency 
management if the new resolution does not satisfy them.

Personally, I’m fine with the new behavior and I think most projects will not 
be affected at all. For those that are affected, they would typically get newer 
versions of their transitive dependencies, as requested by the intermediate 
dependencies, which seems to be a good thing.

In the worst case though, it could be that they get an older or incompatible 
version, and the consequences are difficult to predict.

I’m thus worried about potential backlash, as [it happened for this exact 
reason in Maven 
3.4|https://lists.apache.org/thread/c0p0dsrwb45zm974vn95pdvy3gnfs8ox] almost 8 
years ago. Of course the context is different since this is a major release, 
and I don’t know what’s allowed. But from my understanding, this is the only 
(potentially) breaking change, isn’t it?

> Restrict build pom feature to 4.1.0 model version
> -
>
> Key: MNG-8190
> URL: https://issues.apache.org/jira/browse/MNG-8190
> Project: Maven
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 4.0.0-beta-3
>Reporter: Karl Heinz Marbaise
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-5
>
>
> Currently I can omit the version tag in a parent definition (or dependency) 
> in a module with ModelVersion:4.0.0 which is not correct.
> This should fail with an appropriate failure message even in Maven 4.0.0+ 
> We should allow omitting the version tag (parent) in a module only for Maven 
> 4+ with the ModelVersion 4.1.0 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRESOLVER-603) Apache HTTP transport should expose config for max redirects

2024-10-13 Thread Didier Loiseau (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888967#comment-17888967
 ] 

Didier Loiseau commented on MRESOLVER-603:
--

Thanks [~cstamas] for the implementation. Previously you put Fix Version 1.9.23 
as well, do you plan to backport it? It would be useful for Maven 3.9.

> Apache HTTP transport should expose config for max redirects
> 
>
> Key: MRESOLVER-603
> URL: https://issues.apache.org/jira/browse/MRESOLVER-603
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: Resolver
>Affects Versions: 1.9.x
>Reporter: Didier Loiseau
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.2, 1.9.23
>
>
> Apache HttpClient allows to {{{}RequestConfig.maxRedirects{}}}. It would be 
> nice to expose it through configuration as for Jetty (MRESOLVER-595) and 
> Wagon.
> Also note that setting it to 0 actually sets a value of 50, so it could be 
> nice to be able to disable redirects entirely (as for Jetty).
> Ideally this should be implemented in 1.9.x since it {{HttpTransport}} is the 
> default in Maven 3.9. (apparently the fix version was copied from 
> MRESOLVER-595 when I cloned it)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump org.codehaus.plexus:plexus-java from 1.2.0 to 1.3.0 [maven-compiler-plugin]

2024-10-13 Thread via GitHub


slachiewicz commented on PR #263:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/263#issuecomment-2408891778

   @dependabot recreate


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-8190) Restrict build pom feature to 4.1.0 model version

2024-10-13 Thread Guillaume Nodet (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889044#comment-17889044
 ] 

Guillaume Nodet commented on MNG-8190:
--

[~cstamas] thoughts ?

> Restrict build pom feature to 4.1.0 model version
> -
>
> Key: MNG-8190
> URL: https://issues.apache.org/jira/browse/MNG-8190
> Project: Maven
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 4.0.0-beta-3
>Reporter: Karl Heinz Marbaise
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-5
>
>
> Currently I can omit the version tag in a parent definition (or dependency) 
> in a module with ModelVersion:4.0.0 which is not correct.
> This should fail with an appropriate failure message even in Maven 4.0.0+ 
> We should allow omitting the version tag (parent) in a module only for Maven 
> 4+ with the ModelVersion 4.1.0 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (MDEP-956) silent parameter is not taken into account

2024-10-13 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold resolved MDEP-956.

Resolution: Fixed

> silent parameter is not taken into account
> --
>
> Key: MDEP-956
> URL: https://issues.apache.org/jira/browse/MDEP-956
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: copy-dependencies
>Affects Versions: 3.7.0, 3.7.1, 3.8.0
>Reporter: Philippe De Neve
>Assignee: Elliotte Rusty Harold
>Priority: Minor
>
> When setting the {{silent}} parameter to {{{}true{}}}, the 
> {{copy-dependencies}} goal remains non-silent.
> To reproduce:
> {code:bash}
> git clone https://gitlab.com/philippedn/jli.git
> cd jli/demos/jfxm
> mvn prepare-package # silent parameter set to true in pom.xml
> {code}
> Output:
> {code:bash}
> ...
> [INFO] Copying artifact 'org.openjfx:javafx-controls:jar:22.0.2:compile' 
> (/mnt/storage/maven-repository/org/openjfx/javafx-controls/22.0.2/javafx-controls-22.0.2.jar)
>  to 
> /mnt/storage/code/scripts/jli/demos/jfxm/target/jars/javafx-controls-22.0.2.jar
> [INFO] Copying artifact 
> 'org.openjfx:javafx-controls:jar:linux:22.0.2:compile' 
> (/mnt/storage/maven-repository/org/openjfx/javafx-controls/22.0.2/javafx-controls-22.0.2-linux.jar)
>  to 
> /mnt/storage/code/scripts/jli/demos/jfxm/target/jars/javafx-controls-22.0.2.jar
> [INFO] Copying artifact 'org.openjfx:javafx-graphics:jar:22.0.2:compile' 
> (/mnt/storage/maven-repository/org/openjfx/javafx-graphics/22.0.2/javafx-graphics-22.0.2.jar)
>  to 
> /mnt/storage/code/scripts/jli/demos/jfxm/target/jars/javafx-graphics-22.0.2.jar
> [INFO] Copying artifact 
> 'org.openjfx:javafx-graphics:jar:linux:22.0.2:compile' 
> (/mnt/storage/maven-repository/org/openjfx/javafx-graphics/22.0.2/javafx-graphics-22.0.2-linux.jar)
>  to 
> /mnt/storage/code/scripts/jli/demos/jfxm/target/jars/javafx-graphics-22.0.2.jar
> [INFO] Copying artifact 'org.openjfx:javafx-base:jar:22.0.2:compile' 
> (/mnt/storage/maven-repository/org/openjfx/javafx-base/22.0.2/javafx-base-22.0.2.jar)
>  to 
> /mnt/storage/code/scripts/jli/demos/jfxm/target/jars/javafx-base-22.0.2.jar
> [INFO] Copying artifact 'org.openjfx:javafx-base:jar:linux:22.0.2:compile' 
> (/mnt/storage/maven-repository/org/openjfx/javafx-base/22.0.2/javafx-base-22.0.2-linux.jar)
>  to 
> /mnt/storage/code/scripts/jli/demos/jfxm/target/jars/javafx-base-22.0.2.jar
> ...
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MDEP-958) maven-dependency-analyzer to 1.15.0

2024-10-13 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MDEP-958:
--

 Summary: maven-dependency-analyzer to 1.15.0
 Key: MDEP-958
 URL: https://issues.apache.org/jira/browse/MDEP-958
 Project: Maven Dependency Plugin
  Issue Type: Dependency upgrade
Reporter: Elliotte Rusty Harold
Assignee: Elliotte Rusty Harold






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MDEP-958] Bump org.apache.maven.shared:maven-dependency-analyzer from 1.14.1 to 1.15.0 [maven-dependency-plugin]

2024-10-13 Thread via GitHub


elharo merged PR #434:
URL: https://github.com/apache/maven-dependency-plugin/pull/434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.maven.reporting:maven-reporting-api from 4.0.0-M12 to 4.0.0 [maven-dependency-plugin]

2024-10-13 Thread via GitHub


elharo merged PR #435:
URL: https://github.com/apache/maven-dependency-plugin/pull/435


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MDEP-958) maven-dependency-analyzer to 1.15.0

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888989#comment-17888989
 ] 

ASF GitHub Bot commented on MDEP-958:
-

elharo merged PR #434:
URL: https://github.com/apache/maven-dependency-plugin/pull/434




> maven-dependency-analyzer to 1.15.0
> ---
>
> Key: MDEP-958
> URL: https://issues.apache.org/jira/browse/MDEP-958
> Project: Maven Dependency Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MDEP-82] - resolve plugin dependencies [maven-dependency-plugin]

2024-10-13 Thread via GitHub


elharo commented on code in PR #130:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/130#discussion_r1798282946


##
src/main/java/org/apache/maven/plugins/dependency/resolvers/ResolvePluginsMojo.java:
##
@@ -37,21 +40,42 @@
 import 
org.apache.maven.shared.transfer.artifact.resolve.ArtifactResolverException;
 import 
org.apache.maven.shared.transfer.dependencies.DefaultDependableCoordinate;
 import 
org.apache.maven.shared.transfer.dependencies.resolve.DependencyResolverException;
+import org.codehaus.plexus.component.annotations.Requirement;
+import org.eclipse.aether.artifact.ArtifactTypeRegistry;
+import org.eclipse.aether.graph.Dependency;
+
+import java.io.IOException;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
 
 /**
  * Goal that resolves all project plugins and reports and their dependencies.
  *
  * @author mailto:bri...@apache.org";>Brian Fox
  * @since 2.0
  */
-@Mojo( name = "resolve-plugins", defaultPhase = 
LifecyclePhase.GENERATE_SOURCES, threadSafe = true )
+//CHECKSTYLE_OFF: LineLength

Review Comment:
   This shouldn't be needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Resolved] (MDEP-958) maven-dependency-analyzer to 1.15.0

2024-10-13 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold resolved MDEP-958.

Resolution: Fixed

> maven-dependency-analyzer to 1.15.0
> ---
>
> Key: MDEP-958
> URL: https://issues.apache.org/jira/browse/MDEP-958
> Project: Maven Dependency Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MDEP-650) dependency:unpack doesn't seem to handle version ranges

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888991#comment-17888991
 ] 

ASF GitHub Bot commented on MDEP-650:
-

elharo commented on code in PR #12:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/12#discussion_r1798284616


##
src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestUnpackMojo.java:
##
@@ -80,8 +93,25 @@ protected void setUp()
 DefaultRepositorySystemSession repoSession = 
(DefaultRepositorySystemSession) session.getRepositorySession();
 
 repoSession.setLocalRepositoryManager( new 
SimpleLocalRepositoryManager( stubFactory.getWorkingDir() ) );
+
+artifactHandlerManager = new DefaultArtifactHandlerManager();
+
+Map handlerMap = new HashMap<>();
+handlerMap.put("", new DefaultArtifactHandler(""));
+handlerMap.put("jar", new DefaultArtifactHandler("jar"));
+artifactHandlerManager.addHandlers(handlerMap);
+}
+
+@Override
+protected void tearDown()
+{
+super.tearDown();

Review Comment:
   this comes last, not first



##
src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/AbstractFromConfigurationMojo.java:
##
@@ -189,6 +202,105 @@ protected List getProcessedArtifactItems( 
ProcessArtifactItemsRequ
 return artifactItems;
 }
 
+/**
+ * If the artifact item has a version range, rather than a version, this
+ * method attempts to resolve this range by inspecting the list of 
resolved dependencies
+ * in the project for a match, before using the maven dependency resolver 
to resolve
+ * the range.
+ *
+ * If the dependency can be found and the version fits the artifact item's 
range
+ * then the artifact item is updated with the found version.
+ *
+ * If the dependency is not found or the range does not match, then the 
version
+ * is not changed.
+ *
+ * @param artifactItem  The artifact item to update, if required.

Review Comment:
   nit: the artifact item to update, if required
   
   per oracle javadoc conventions



##
src/test/java/org/apache/maven/plugins/dependency/testUtils/stubs/DependencyResolverStub.java:
##
@@ -0,0 +1,98 @@
+package org.apache.maven.plugins.dependency.testUtils.stubs;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.model.Model;
+import org.apache.maven.project.ProjectBuildingRequest;
+import org.apache.maven.shared.artifact.filter.resolve.TransformableFilter;
+import org.apache.maven.shared.transfer.artifact.resolve.ArtifactResult;
+import org.apache.maven.shared.transfer.dependencies.DependableCoordinate;
+import 
org.apache.maven.shared.transfer.dependencies.resolve.DependencyResolver;
+import 
org.apache.maven.shared.transfer.dependencies.resolve.DependencyResolverException;
+
+/**
+ * A very simple stub to use for whiteboxing the a Maven DependencyResolver
+ * class.
+ */
+public class DependencyResolverStub implements DependencyResolver {
+
+private Map coordCache = new HashMap<>();
+
+public void addDependableCoordinateLookup(
+final DependableCoordinate coord,
+final Artifact artifact )
+{
+coordCache.put( coord.toString(), artifact );
+}
+
+@Override
+public Iterable resolveDependencies(
+final ProjectBuildingRequest buildingRequest,
+final DependableCoordinate coordinate,
+final TransformableFilter filter ) throws 
DependencyResolverException
+{
+
+
+if ( coordCache.get( coordinate.toString() ) != null ) {
+ArtifactResult result = new ArtifactResult()
+{
+
+@Override
+public Artifact getArtifact()
+{
+// TODO Auto-generated method stub

Review Comment:
   remove comment



##
pom.x

Re: [PR] [MDEP-650] - dependency:unpack doesn't seem to handle version ranges [maven-dependency-plugin]

2024-10-13 Thread via GitHub


elharo commented on code in PR #12:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/12#discussion_r1798284616


##
src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestUnpackMojo.java:
##
@@ -80,8 +93,25 @@ protected void setUp()
 DefaultRepositorySystemSession repoSession = 
(DefaultRepositorySystemSession) session.getRepositorySession();
 
 repoSession.setLocalRepositoryManager( new 
SimpleLocalRepositoryManager( stubFactory.getWorkingDir() ) );
+
+artifactHandlerManager = new DefaultArtifactHandlerManager();
+
+Map handlerMap = new HashMap<>();
+handlerMap.put("", new DefaultArtifactHandler(""));
+handlerMap.put("jar", new DefaultArtifactHandler("jar"));
+artifactHandlerManager.addHandlers(handlerMap);
+}
+
+@Override
+protected void tearDown()
+{
+super.tearDown();

Review Comment:
   this comes last, not first



##
src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/AbstractFromConfigurationMojo.java:
##
@@ -189,6 +202,105 @@ protected List getProcessedArtifactItems( 
ProcessArtifactItemsRequ
 return artifactItems;
 }
 
+/**
+ * If the artifact item has a version range, rather than a version, this
+ * method attempts to resolve this range by inspecting the list of 
resolved dependencies
+ * in the project for a match, before using the maven dependency resolver 
to resolve
+ * the range.
+ *
+ * If the dependency can be found and the version fits the artifact item's 
range
+ * then the artifact item is updated with the found version.
+ *
+ * If the dependency is not found or the range does not match, then the 
version
+ * is not changed.
+ *
+ * @param artifactItem  The artifact item to update, if required.

Review Comment:
   nit: the artifact item to update, if required
   
   per oracle javadoc conventions



##
src/test/java/org/apache/maven/plugins/dependency/testUtils/stubs/DependencyResolverStub.java:
##
@@ -0,0 +1,98 @@
+package org.apache.maven.plugins.dependency.testUtils.stubs;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.model.Model;
+import org.apache.maven.project.ProjectBuildingRequest;
+import org.apache.maven.shared.artifact.filter.resolve.TransformableFilter;
+import org.apache.maven.shared.transfer.artifact.resolve.ArtifactResult;
+import org.apache.maven.shared.transfer.dependencies.DependableCoordinate;
+import 
org.apache.maven.shared.transfer.dependencies.resolve.DependencyResolver;
+import 
org.apache.maven.shared.transfer.dependencies.resolve.DependencyResolverException;
+
+/**
+ * A very simple stub to use for whiteboxing the a Maven DependencyResolver
+ * class.
+ */
+public class DependencyResolverStub implements DependencyResolver {
+
+private Map coordCache = new HashMap<>();
+
+public void addDependableCoordinateLookup(
+final DependableCoordinate coord,
+final Artifact artifact )
+{
+coordCache.put( coord.toString(), artifact );
+}
+
+@Override
+public Iterable resolveDependencies(
+final ProjectBuildingRequest buildingRequest,
+final DependableCoordinate coordinate,
+final TransformableFilter filter ) throws 
DependencyResolverException
+{
+
+
+if ( coordCache.get( coordinate.toString() ) != null ) {
+ArtifactResult result = new ArtifactResult()
+{
+
+@Override
+public Artifact getArtifact()
+{
+// TODO Auto-generated method stub

Review Comment:
   remove comment



##
pom.xml:
##
@@ -30,7 +30,7 @@ under the License.
   
 
   maven-dependency-plugin
-  3.1.2-SNAPSHOT
+  3.1.1.alehane-SNAPSHOT

Review Comment:
   nope



##
src/test/java/org/apache/maven/plugins/dependency/testUtils/stubs/DependencyResol

[jira] [Updated] (MDEP-435) improve mvn dependency:tree - add optional xml output of the results

2024-10-13 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold updated MDEP-435:
---
Issue Type: New Feature  (was: Improvement)

> improve mvn dependency:tree - add optional xml output of the results
> 
>
> Key: MDEP-435
> URL: https://issues.apache.org/jira/browse/MDEP-435
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: tree
> Environment: all
>Reporter: Kow Unk
>Priority: Major
>  Labels: close-pending
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The output of mvn dependency:tree would be more useful to me if it was in a 
> format that is machine readable.  I would like to create some tooling to be 
> able to easily determine what is causing a particular jar to be included.
> for example:
> >mymvntool -why org.springframework:org.springframework.beans:3.0.5
> org.springframework.beans-3.0.5 is being *dragged* in by: 
> my.otherproject.core:1.1
> %end of search
> another use:
> >mymvntool -makeexclusionfor 
> >org.springframework:org.springframework.beans:3.0.5
> 
>  
>org.springframework
>org.springframework.beans
>  
> 
> or even:
> >mymvntool -makeexclusionfor org.springframework:*:3.0.5
> this would pickup all the included jars in the project and build exclusions 
> for them. 
> It may have been dumb to pick spring as the exclusion resource, but this is 
> just an example.  having xml output would be valuable to me and probably 
> others too.
> -K



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (MNG-8301) [REGRESSION] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD

2024-10-13 Thread Maarten Mulders (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maarten Mulders resolved MNG-8301.
--
Resolution: Not A Problem

Following MNG-8190, the observed behaviour is expected: a POM that wants to 
leverage features from Maven 4 should explicitly adhere to the 4.1.0 XSD and 
modelVersion.

> [REGRESSION] Can't build a project without modelVersion=4.1.0 but with 4.1.0 
> (beta-4) XSD
> -
>
> Key: MNG-8301
> URL: https://issues.apache.org/jira/browse/MNG-8301
> Project: Maven
>  Issue Type: Bug
>  Components: POM
>Affects Versions: 4.0.0-beta-5
> Environment: Apache Maven 4.0.0-beta-5-SNAPSHOT 
> (fee69f2f89c6f32dbef0ec55a7f6e8c071d4b6a9)
> Java version: 23, vendor: Eclipse Adoptium, runtime: 
> /Library/Java/JavaVirtualMachines/temurin-23.jdk/Contents/Home
> OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac"
>Reporter: Didier Loiseau
>Priority: Major
>
> A project whose pom.xml refers to the [4.1.0-beta-4 
> XSD|https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd] and that lacks a 
> {{modelVersion}} element used to be buildable with Maven 4.0.0-beta-4. Maven 
> would infer from the XSD that it should use _modelVersion_ 4.1.0.
> With the current snapshots of 4.0.0-beta-5, it can no longer be built:
> {quote}{{[ERROR]   The project 
> org.apache.maven.its.mng8301:module-b:1-SNAPSHOT 
> (/Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml)
>  has 1 error}}
> {{[ERROR]     'dependencies.dependency.version' for 
> org.apache.maven.repro:module-a:jar is missing. @ 
> org.apache.maven.its.mng8301:module-b:[unknown-version], 
> file:///Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml,
>  line 17, column 9}}
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MNG-8301) [REGRESSION] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD

2024-10-13 Thread Maarten Mulders (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maarten Mulders closed MNG-8301.


> [REGRESSION] Can't build a project without modelVersion=4.1.0 but with 4.1.0 
> (beta-4) XSD
> -
>
> Key: MNG-8301
> URL: https://issues.apache.org/jira/browse/MNG-8301
> Project: Maven
>  Issue Type: Bug
>  Components: POM
>Affects Versions: 4.0.0-beta-5
> Environment: Apache Maven 4.0.0-beta-5-SNAPSHOT 
> (fee69f2f89c6f32dbef0ec55a7f6e8c071d4b6a9)
> Java version: 23, vendor: Eclipse Adoptium, runtime: 
> /Library/Java/JavaVirtualMachines/temurin-23.jdk/Contents/Home
> OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac"
>Reporter: Didier Loiseau
>Priority: Major
>
> A project whose pom.xml refers to the [4.1.0-beta-4 
> XSD|https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd] and that lacks a 
> {{modelVersion}} element used to be buildable with Maven 4.0.0-beta-4. Maven 
> would infer from the XSD that it should use _modelVersion_ 4.1.0.
> With the current snapshots of 4.0.0-beta-5, it can no longer be built:
> {quote}{{[ERROR]   The project 
> org.apache.maven.its.mng8301:module-b:1-SNAPSHOT 
> (/Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml)
>  has 1 error}}
> {{[ERROR]     'dependencies.dependency.version' for 
> org.apache.maven.repro:module-a:jar is missing. @ 
> org.apache.maven.its.mng8301:module-b:[unknown-version], 
> file:///Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml,
>  line 17, column 9}}
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (DOXIA-749) MarkdownSink: Fenced code blocks must be located at the beginning of a line

2024-10-13 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/DOXIA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated DOXIA-749:
--
Description: 
If currently a {{Sink.text()}} is followed by a 
{{Sink.verbatim(SinkEventAttributeSet.SOURCE)}} with some text it is not 
emitted on a dedicated line through the {{MarkdownSink}}.

However according to https://spec.commonmark.org/0.31.2/#fenced-code-blocks

{quote}A fenced code block begins with a code fence, preceded by up to three 
spaces of indentation.{quote}

  was:
If currently a {{Sink.text()}} is followed by a {{Sink.verbatim(...)}} with 
some text it is not emitted on a dedicated line through the {{MarkdownSink}}.

However according to https://spec.commonmark.org/0.31.2/#fenced-code-blocks

{quote}A fenced code block begins with a code fence, preceded by up to three 
spaces of indentation.{quote}


> MarkdownSink: Fenced code blocks must be located at the beginning of a line
> ---
>
> Key: DOXIA-749
> URL: https://issues.apache.org/jira/browse/DOXIA-749
> Project: Maven Doxia
>  Issue Type: Bug
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.1
>
>
> If currently a {{Sink.text()}} is followed by a 
> {{Sink.verbatim(SinkEventAttributeSet.SOURCE)}} with some text it is not 
> emitted on a dedicated line through the {{MarkdownSink}}.
> However according to https://spec.commonmark.org/0.31.2/#fenced-code-blocks
> {quote}A fenced code block begins with a code fence, preceded by up to three 
> spaces of indentation.{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Bump org.apache.maven:maven-core from 3.0 to 3.8.1 [maven-shared-io]

2024-10-13 Thread via GitHub


dependabot[bot] opened a new pull request, #25:
URL: https://github.com/apache/maven-shared-io/pull/25

   Bumps [org.apache.maven:maven-core](https://github.com/apache/maven) from 
3.0 to 3.8.1.
   
   Commits
   
   https://github.com/apache/maven/commit/05c21c65bdfed0f71a2f2ada8b84da59348c4c5d";>05c21c6
 [maven-release-plugin] prepare release maven-3.8.1
   https://github.com/apache/maven/commit/d295dc362fe7d7b189b4976a5742a17362eb51a1";>d295dc3
 [MNG-7128] keep blocked attribute from mirrors in artifact repositories
   https://github.com/apache/maven/commit/a46906806a31edb462b935e380a657b6efde6231";>a469068
 next version in branch 3.8.x is 3.8.1-SNAPSHOT
   https://github.com/apache/maven/commit/dad8a3e1c55f34b7949945bc622f26447ddbf4f9";>dad8a3e
 [maven-release-plugin] prepare for next development iteration
   https://github.com/apache/maven/commit/6aa1f4acf5d6323e9aa08b763cb9933dc96749b9";>6aa1f4a
 [maven-release-plugin] prepare release maven-3.8.0
   https://github.com/apache/maven/commit/907d53ad3264718f66ff15e1363d76b07dd0c05f";>907d53a
 [MNG-7118] block HTTP repositories by default
   https://github.com/apache/maven/commit/899465aeec03753ea91e15a79579eab76369c016";>899465a
 [MNG-7117] add support for blocked mirror
   https://github.com/apache/maven/commit/fa79cb22e456cc65522b5bab8c4240fe08c5775f";>fa79cb2
 [MNG-7116] add support for mirrorOf external:http:*
   https://github.com/apache/maven/commit/e5f6634e17362387282b3867c9b23d4b54fea871";>e5f6634
 use Maven Resolver 1.6.2
   https://github.com/apache/maven/commit/09f77da9b0c39848fe763bdd4a392151eec0d8c3";>09f77da
 [MNG-7119] Upgrade Maven Wagon to 3.4.3
   Additional commits viewable in https://github.com/apache/maven/compare/maven-3.0...maven-3.8.1";>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven:maven-core&package-manager=maven&previous-version=3.0&new-version=3.8.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/maven-shared-io/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump org.apache.maven:maven-compat from 3.0 to 3.8.1 [maven-shared-io]

2024-10-13 Thread via GitHub


dependabot[bot] opened a new pull request, #26:
URL: https://github.com/apache/maven-shared-io/pull/26

   Bumps [org.apache.maven:maven-compat](https://github.com/apache/maven) from 
3.0 to 3.8.1.
   
   Commits
   
   https://github.com/apache/maven/commit/05c21c65bdfed0f71a2f2ada8b84da59348c4c5d";>05c21c6
 [maven-release-plugin] prepare release maven-3.8.1
   https://github.com/apache/maven/commit/d295dc362fe7d7b189b4976a5742a17362eb51a1";>d295dc3
 [MNG-7128] keep blocked attribute from mirrors in artifact repositories
   https://github.com/apache/maven/commit/a46906806a31edb462b935e380a657b6efde6231";>a469068
 next version in branch 3.8.x is 3.8.1-SNAPSHOT
   https://github.com/apache/maven/commit/dad8a3e1c55f34b7949945bc622f26447ddbf4f9";>dad8a3e
 [maven-release-plugin] prepare for next development iteration
   https://github.com/apache/maven/commit/6aa1f4acf5d6323e9aa08b763cb9933dc96749b9";>6aa1f4a
 [maven-release-plugin] prepare release maven-3.8.0
   https://github.com/apache/maven/commit/907d53ad3264718f66ff15e1363d76b07dd0c05f";>907d53a
 [MNG-7118] block HTTP repositories by default
   https://github.com/apache/maven/commit/899465aeec03753ea91e15a79579eab76369c016";>899465a
 [MNG-7117] add support for blocked mirror
   https://github.com/apache/maven/commit/fa79cb22e456cc65522b5bab8c4240fe08c5775f";>fa79cb2
 [MNG-7116] add support for mirrorOf external:http:*
   https://github.com/apache/maven/commit/e5f6634e17362387282b3867c9b23d4b54fea871";>e5f6634
 use Maven Resolver 1.6.2
   https://github.com/apache/maven/commit/09f77da9b0c39848fe763bdd4a392151eec0d8c3";>09f77da
 [MNG-7119] Upgrade Maven Wagon to 3.4.3
   Additional commits viewable in https://github.com/apache/maven/compare/maven-3.0...maven-3.8.1";>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven:maven-compat&package-manager=maven&previous-version=3.0&new-version=3.8.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/maven-shared-io/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MSHARED-1444) Bump commons-io:commons-io from 2.11.0 to 2.14.0 #24

2024-10-13 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MSHARED-1444:
-

 Summary: Bump commons-io:commons-io from 2.11.0 to 2.14.0 #24
 Key: MSHARED-1444
 URL: https://issues.apache.org/jira/browse/MSHARED-1444
 Project: Maven Shared Components
  Issue Type: Dependency upgrade
  Components: maven-shared-io
Reporter: Sylwester Lachiewicz
Assignee: Sylwester Lachiewicz
 Fix For: maven-shared-io-3.0.1






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1444] Bump commons-io:commons-io from 2.11.0 to 2.14.0 [maven-shared-io]

2024-10-13 Thread via GitHub


slachiewicz merged PR #24:
URL: https://github.com/apache/maven-shared-io/pull/24


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1444) Bump commons-io:commons-io from 2.11.0 to 2.14.0 #24

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889037#comment-17889037
 ] 

ASF GitHub Bot commented on MSHARED-1444:
-

slachiewicz merged PR #24:
URL: https://github.com/apache/maven-shared-io/pull/24




> Bump commons-io:commons-io from 2.11.0 to 2.14.0 #24
> 
>
> Key: MSHARED-1444
> URL: https://issues.apache.org/jira/browse/MSHARED-1444
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-shared-io
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: maven-shared-io-3.0.1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1444) Bump commons-io:commons-io from 2.11.0 to 2.14.0 #24

2024-10-13 Thread Sylwester Lachiewicz (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz closed MSHARED-1444.
-
Resolution: Fixed

> Bump commons-io:commons-io from 2.11.0 to 2.14.0 #24
> 
>
> Key: MSHARED-1444
> URL: https://issues.apache.org/jira/browse/MSHARED-1444
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-shared-io
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: maven-shared-io-3.0.1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSTAGE-24) set minimum maven version to 3.1

2024-10-13 Thread Sylwester Lachiewicz (Jira)


 [ 
https://issues.apache.org/jira/browse/MSTAGE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz updated MSTAGE-24:
---
Summary: set minimum maven version to 3.1  (was: set minimum maven version 
to 3.6.3)

> set minimum maven version to 3.1
> 
>
> Key: MSTAGE-24
> URL: https://issues.apache.org/jira/browse/MSTAGE-24
> Project: Maven Stage Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump commons-io:commons-io from 2.6 to 2.14.0 [maven-stage-plugin]

2024-10-13 Thread via GitHub


slachiewicz merged PR #14:
URL: https://github.com/apache/maven-stage-plugin/pull/14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MSTAGE-29) Bump commons-io:commons-io from 2.6 to 2.14.0

2024-10-13 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MSTAGE-29:
--

 Summary: Bump commons-io:commons-io from 2.6 to 2.14.0
 Key: MSTAGE-29
 URL: https://issues.apache.org/jira/browse/MSTAGE-29
 Project: Maven Stage Plugin
  Issue Type: Dependency upgrade
Reporter: Sylwester Lachiewicz
Assignee: Sylwester Lachiewicz
 Fix For: 3.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSTAGE-29) Bump commons-io:commons-io from 2.6 to 2.14.0

2024-10-13 Thread Sylwester Lachiewicz (Jira)


 [ 
https://issues.apache.org/jira/browse/MSTAGE-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz closed MSTAGE-29.
--
Resolution: Fixed

> Bump commons-io:commons-io from 2.6 to 2.14.0
> -
>
> Key: MSTAGE-29
> URL: https://issues.apache.org/jira/browse/MSTAGE-29
> Project: Maven Stage Plugin
>  Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSTAGE-24) set minimum maven version to 3.6.3

2024-10-13 Thread Sylwester Lachiewicz (Jira)


 [ 
https://issues.apache.org/jira/browse/MSTAGE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz updated MSTAGE-24:
---
Summary: set minimum maven version to 3.6.3  (was: set minimum maven 
version to 3.1)

> set minimum maven version to 3.6.3
> --
>
> Key: MSTAGE-24
> URL: https://issues.apache.org/jira/browse/MSTAGE-24
> Project: Maven Stage Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-8301) [REGRESSION] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD

2024-10-13 Thread Maarten Mulders (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maarten Mulders updated MNG-8301:
-
Description: 
A project whose pom.xml refers to the [4.1.0-beta-4 
XSD|https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd] and that lacks a 
{{modelVersion}} element used to be buildable with Maven 4.0.0-beta-4. Maven 
would infer from the XSD that it should use _modelVersion_ 4.1.0.

With the current snapshots of 4.0.0-beta-5, it can no longer be built:
{quote}{{[ERROR]   The project org.apache.maven.its.mng8301:module-b:1-SNAPSHOT 
(/Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml)
 has 1 error}}
{{[ERROR]     'dependencies.dependency.version' for 
org.apache.maven.repro:module-a:jar is missing. @ 
org.apache.maven.its.mng8301:module-b:[unknown-version], 
file:///Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml,
 line 17, column 9}}
{quote}

  was:
A project whose pom.xml refers to the [4.0.0-beta-4 
XSD|https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd] and that lacks a 
{{modelVersion}} element used to be buildable with Maven 4.0.0-beta-4. Maven 
would infer from the XSD that it should use _modelVersion_ 4.1.0.

With the current snapshots of 4.0.0-beta-5, it can no longer be built:
{quote}{{[ERROR]   The project org.apache.maven.its.mng8301:module-b:1-SNAPSHOT 
(/Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml)
 has 1 error}}
{{[ERROR]     'dependencies.dependency.version' for 
org.apache.maven.repro:module-a:jar is missing. @ 
org.apache.maven.its.mng8301:module-b:[unknown-version], 
file:///Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml,
 line 17, column 9}}
{quote}


> [REGRESSION] Can't build a project without modelVersion=4.1.0 but with 4.1.0 
> (beta-4) XSD
> -
>
> Key: MNG-8301
> URL: https://issues.apache.org/jira/browse/MNG-8301
> Project: Maven
>  Issue Type: Bug
>  Components: POM
>Affects Versions: 4.0.0-beta-5
> Environment: Apache Maven 4.0.0-beta-5-SNAPSHOT 
> (fee69f2f89c6f32dbef0ec55a7f6e8c071d4b6a9)
> Java version: 23, vendor: Eclipse Adoptium, runtime: 
> /Library/Java/JavaVirtualMachines/temurin-23.jdk/Contents/Home
> OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac"
>Reporter: Didier Loiseau
>Priority: Major
>
> A project whose pom.xml refers to the [4.1.0-beta-4 
> XSD|https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd] and that lacks a 
> {{modelVersion}} element used to be buildable with Maven 4.0.0-beta-4. Maven 
> would infer from the XSD that it should use _modelVersion_ 4.1.0.
> With the current snapshots of 4.0.0-beta-5, it can no longer be built:
> {quote}{{[ERROR]   The project 
> org.apache.maven.its.mng8301:module-b:1-SNAPSHOT 
> (/Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml)
>  has 1 error}}
> {{[ERROR]     'dependencies.dependency.version' for 
> org.apache.maven.repro:module-a:jar is missing. @ 
> org.apache.maven.its.mng8301:module-b:[unknown-version], 
> file:///Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml,
>  line 17, column 9}}
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8301) [REGRESSION] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD

2024-10-13 Thread Didier Loiseau (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888972#comment-17888972
 ] 

Didier Loiseau commented on MNG-8301:
-

[~mthmulders], the description is a bit confusing because you say “4.0.0-beta-4 
XSD” but it links to https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd

I think it actually works as intended, following MNG-8190?

> [REGRESSION] Can't build a project without modelVersion=4.1.0 but with 4.1.0 
> (beta-4) XSD
> -
>
> Key: MNG-8301
> URL: https://issues.apache.org/jira/browse/MNG-8301
> Project: Maven
>  Issue Type: Bug
>  Components: POM
>Affects Versions: 4.0.0-beta-5
> Environment: Apache Maven 4.0.0-beta-5-SNAPSHOT 
> (fee69f2f89c6f32dbef0ec55a7f6e8c071d4b6a9)
> Java version: 23, vendor: Eclipse Adoptium, runtime: 
> /Library/Java/JavaVirtualMachines/temurin-23.jdk/Contents/Home
> OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac"
>Reporter: Didier Loiseau
>Priority: Major
>
> A project whose pom.xml refers to the [4.0.0-beta-4 
> XSD|https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd] and that lacks a 
> {{modelVersion}} element used to be buildable with Maven 4.0.0-beta-4. Maven 
> would infer from the XSD that it should use _modelVersion_ 4.1.0.
> With the current snapshots of 4.0.0-beta-5, it can no longer be built:
> {quote}{{[ERROR]   The project 
> org.apache.maven.its.mng8301:module-b:1-SNAPSHOT 
> (/Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml)
>  has 1 error}}
> {{[ERROR]     'dependencies.dependency.version' for 
> org.apache.maven.repro:module-a:jar is missing. @ 
> org.apache.maven.its.mng8301:module-b:[unknown-version], 
> file:///Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml,
>  line 17, column 9}}
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-8301] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD [maven-integration-testing]

2024-10-13 Thread via GitHub


DidierLoiseau commented on code in PR #386:
URL: 
https://github.com/apache/maven-integration-testing/pull/386#discussion_r1798191158


##
core-it-suite/src/test/resources/mng-8301-project-without-modelversion/module-a/pom.xml:
##
@@ -0,0 +1,10 @@
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd";>

Review Comment:
   `xmlns` does not match `schemaLocation`
   ```suggestion
   http://maven.apache.org/POM/4.1.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd";>
   ```



##
core-it-suite/src/test/resources/mng-8301-project-without-modelversion/module-b/pom.xml:
##
@@ -0,0 +1,17 @@
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd";>
+
+  
+org.apache.maven.its.mng8301
+m4womv
+  
+
+  module-b
+
+  
+
+  org.apache.maven.repro

Review Comment:
   It’s the wrong `groupId`
   ```suggestion
 org.apache.maven.its.mng8301
   ```



##
core-it-suite/src/test/resources/mng-8301-project-without-modelversion/module-b/pom.xml:
##
@@ -0,0 +1,17 @@
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd";>

Review Comment:
   ```suggestion
   http://maven.apache.org/POM/4.1.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd";>
   ```



##
core-it-suite/src/test/resources/mng-8301-project-without-modelversion/pom.xml:
##
@@ -0,0 +1,46 @@
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd";>

Review Comment:
   ```suggestion
   http://maven.apache.org/POM/4.1.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd";>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (DOXIA-749) MarkdownSink: Block elements inside list items must be separated by blank line

2024-10-13 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/DOXIA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated DOXIA-749:
--
Summary: MarkdownSink: Block elements inside list items must be separated 
by blank line  (was: MarkdownSink: Fenced code blocks must be located at the 
beginning of a line)

> MarkdownSink: Block elements inside list items must be separated by blank line
> --
>
> Key: DOXIA-749
> URL: https://issues.apache.org/jira/browse/DOXIA-749
> Project: Maven Doxia
>  Issue Type: Bug
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.1
>
>
> If currently a {{Sink.text()}} is followed by a 
> {{Sink.verbatim(SinkEventAttributeSet.SOURCE)}} with some text it is not 
> emitted on a dedicated line through the {{MarkdownSink}}.
> However according to https://spec.commonmark.org/0.31.2/#fenced-code-blocks
> {quote}A fenced code block begins with a code fence, preceded by up to three 
> spaces of indentation.{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (DOXIA-749) MarkdownSink: Block elements inside list items must be separated by blank line

2024-10-13 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/DOXIA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated DOXIA-749:
--
Description: 
Each block element inside a list item must be separated by a blank line and 
properly indented. Currently e.g. verbatim blocks inside list items are not 
correctly formatted though:

{code}
If you prefer to do everything by hand from command templates, you can do 
either with `svn` command:

- Unix:
```
SVNPUBSUB=https://svn.apache.org/repos/asf/maven/website/components

svn cp $SVNPUBSUB/xxx-archives/yyy-LATEST $SVNPUBSUB/xxx-archives/yyy-$version 
-m "Archive versioned site."

svn rm $SVNPUBSUB/xxx/yyy -m "Remove old site."
svn cp $SVNPUBSUB/xxx-archives/yyy-$version $SVNPUBSUB/xxx/yyy -m "Publish new 
site."
```
{code}

What is necessary though is
{code}

- Unix:

```
SVNPUBSUB=https://svn.apache.org/repos/asf/maven/website/components

svn cp $SVNPUBSUB/xxx-archives/yyy-LATEST 
$SVNPUBSUB/xxx-archives/yyy-$version -m "Archive versioned site."

svn rm $SVNPUBSUB/xxx/yyy -m "Remove old site."
svn cp $SVNPUBSUB/xxx-archives/yyy-$version $SVNPUBSUB/xxx/yyy -m "Publish 
new site."
```

{code}

  was:
If currently a {{Sink.text()}} is followed by a 
{{Sink.verbatim(SinkEventAttributeSet.SOURCE)}} with some text it is not 
emitted on a dedicated line through the {{MarkdownSink}}.

However according to https://spec.commonmark.org/0.31.2/#fenced-code-blocks

{quote}A fenced code block begins with a code fence, preceded by up to three 
spaces of indentation.{quote}


> MarkdownSink: Block elements inside list items must be separated by blank line
> --
>
> Key: DOXIA-749
> URL: https://issues.apache.org/jira/browse/DOXIA-749
> Project: Maven Doxia
>  Issue Type: Bug
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.1
>
>
> Each block element inside a list item must be separated by a blank line and 
> properly indented. Currently e.g. verbatim blocks inside list items are not 
> correctly formatted though:
> {code}
> If you prefer to do everything by hand from command templates, you can do 
> either with `svn` command:
> - Unix:
> ```
> SVNPUBSUB=https://svn.apache.org/repos/asf/maven/website/components
> svn cp $SVNPUBSUB/xxx-archives/yyy-LATEST 
> $SVNPUBSUB/xxx-archives/yyy-$version -m "Archive versioned site."
> svn rm $SVNPUBSUB/xxx/yyy -m "Remove old site."
> svn cp $SVNPUBSUB/xxx-archives/yyy-$version $SVNPUBSUB/xxx/yyy -m "Publish 
> new site."
> ```
> {code}
> What is necessary though is
> {code}
> - Unix:
> ```
> SVNPUBSUB=https://svn.apache.org/repos/asf/maven/website/components
> svn cp $SVNPUBSUB/xxx-archives/yyy-LATEST 
> $SVNPUBSUB/xxx-archives/yyy-$version -m "Archive versioned site."
> svn rm $SVNPUBSUB/xxx/yyy -m "Remove old site."
> svn cp $SVNPUBSUB/xxx-archives/yyy-$version $SVNPUBSUB/xxx/yyy -m 
> "Publish new site."
> ```
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-8301] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD [maven-integration-testing]

2024-10-13 Thread via GitHub


mthmulders closed pull request #386: [MNG-8301] Can't build a project without 
modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD
URL: https://github.com/apache/maven-integration-testing/pull/386


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MARTIFACT-71) don't WARN if timestamp property is inherited but only INFO

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889014#comment-17889014
 ] 

ASF GitHub Bot commented on MARTIFACT-71:
-

hboutemy opened a new pull request, #58:
URL: https://github.com/apache/maven-artifact-plugin/pull/58

   (no comment)




> don't WARN if timestamp property is inherited but only INFO
> ---
>
> Key: MARTIFACT-71
> URL: https://issues.apache.org/jira/browse/MARTIFACT-71
> Project: Maven Artifact Plugin
>  Issue Type: Improvement
>  Components: artifact:check-buildplan
>Affects Versions: 3.5.1
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.5.2
>
>
> as seen in MNG-8258, WARNING is too aggressive: inheriting is completely 
> valid, just a choice
> it's better to display an INFO in the spirit of "this project inherits 
> timestamp from parent pom yyy, value xxx"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MARTIFACT-71) don't WARN if timestamp property is inherited but only INFO

2024-10-13 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/MARTIFACT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated MARTIFACT-71:

Labels: pull-request-available  (was: )

> don't WARN if timestamp property is inherited but only INFO
> ---
>
> Key: MARTIFACT-71
> URL: https://issues.apache.org/jira/browse/MARTIFACT-71
> Project: Maven Artifact Plugin
>  Issue Type: Improvement
>  Components: artifact:check-buildplan
>Affects Versions: 3.5.1
>Reporter: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>
> as seen in MNG-8258, WARNING is too aggressive: inheriting is completely 
> valid, just a choice
> it's better to display an INFO in the spirit of "this project inherits 
> timestamp from parent pom yyy, value xxx"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [DOXIA-746] Sink API: add method for block comment [maven-doxia]

2024-10-13 Thread via GitHub


michael-o commented on code in PR #236:
URL: https://github.com/apache/maven-doxia/pull/236#discussion_r1798300480


##
doxia-sink-api/src/main/java/org/apache/maven/doxia/sink/Sink.java:
##
@@ -1724,6 +1724,17 @@ public interface Sink extends AutoCloseable {
  */
 void comment(String comment);
 
+/**
+ * Add a comment. The default implementation will just call {@link 
#comment(String)}.
+ *
+ * @param comment The comment to write.
+ * @param isBlockComment If true this is a block comment, 
i.e. nothing should follow on the same line
+ * @since 2.1
+ */
+default void comment(String comment, boolean isBlockComment) {
+comment(comment);
+}

Review Comment:
   I would rather name it the way it is: `void blockComment`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MDEP-891) Used undeclared dependencies found for class which is used by an indirect class

2024-10-13 Thread Elliotte Rusty Harold (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888992#comment-17888992
 ] 

Elliotte Rusty Harold commented on MDEP-891:


Based on the description this seems likely to be a bug in the analyzer, not the 
dependency-plugin. Can we move the issue there?

> Used undeclared dependencies found for class which is used by an indirect 
> class
> ---
>
> Key: MDEP-891
> URL: https://issues.apache.org/jira/browse/MDEP-891
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: analyze-only
>Affects Versions: 3.6.0, 3.6.1
>Reporter: Karl Heinz Marbaise
>Priority: Critical
> Fix For: waiting-for-feedback
>
> Attachments: SO-mvn-question-main.zip
>
>
> Based on an example described on 
> [StackOverflow|https://stackoverflow.com/questions/77360885/maven-dependency-plugin-3-6-started-to-find-new-used-undeclared-dependencies]
>  with the example project https://github.com/DmitryTen/SO-mvn-question which 
> can be used as reproducer (attached that example to the issue).
> The failure starts happening with {{Maven Dependency Plugin:3.6.0}}:
> {code}
> [INFO] --- dependency:3.6.0:analyze-only (analyze-dependencies) @ test ---
> [ERROR] Used undeclared dependencies found:
> [ERROR]org.springframework:spring-web:jar:5.3.5:compile
> [INFO] -
> {code}
> If we change the version of the plugin to 3.5.0:
> {code}
> [INFO] --- dependency:3.5.0:analyze-only (analyze-dependencies) @ test ---
> [INFO] No dependency problems found
> [INFO] Copying org.example:test:pom:1.0-SNAPSHOT to project local repository
> [INFO] Copying org.example:test:jar:1.0-SNAPSHOT to project local repository
> [INFO] Copying org.example:test:pom:consumer:1.0-SNAPSHOT to project local 
> repository
> [INFO] 
> --
> {code}
> After a bit more diving into it, it looks like the upgrade of the 
> {{maven-dependency-analyzer:1.3.2}} in release 3.6.0 of the 
> {{maven-dependency-plugin}} 
> (https://issues.apache.org/jira/projects/MDEP/versions/12352921) caused that 
> issue. If I use an older version of {{maven-dependency-plugin}}  for example 
> 3.5.0 and upgrade there the {{maven-dependency-analyzer:1.3.1}} it will fail 
> with the same output. The version {{maven-dependency-analyzer:1.3.0}} will 
> work fine.
> I have taken a look into the code of the classes:
> The class {{StandaloneVaultConfig}} which is created in the example project 
> uses {{AppRoleAuthentication}} which is part of 
> {{org.springframework.vault:spring-vault-core}}. The usage of classes from 
> {{org.springframework:spring-web:jar:5.3.5:compile}} happening in the class 
> {{AppRoleAuthentication}}. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8301) [REGRESSION] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD

2024-10-13 Thread Maarten Mulders (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888994#comment-17888994
 ] 

Maarten Mulders commented on MNG-8301:
--

[~Didier Loiseau] after our investigation on GitHub, do you agree we can close 
this one?

> [REGRESSION] Can't build a project without modelVersion=4.1.0 but with 4.1.0 
> (beta-4) XSD
> -
>
> Key: MNG-8301
> URL: https://issues.apache.org/jira/browse/MNG-8301
> Project: Maven
>  Issue Type: Bug
>  Components: POM
>Affects Versions: 4.0.0-beta-5
> Environment: Apache Maven 4.0.0-beta-5-SNAPSHOT 
> (fee69f2f89c6f32dbef0ec55a7f6e8c071d4b6a9)
> Java version: 23, vendor: Eclipse Adoptium, runtime: 
> /Library/Java/JavaVirtualMachines/temurin-23.jdk/Contents/Home
> OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac"
>Reporter: Didier Loiseau
>Priority: Major
>
> A project whose pom.xml refers to the [4.1.0-beta-4 
> XSD|https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd] and that lacks a 
> {{modelVersion}} element used to be buildable with Maven 4.0.0-beta-4. Maven 
> would infer from the XSD that it should use _modelVersion_ 4.1.0.
> With the current snapshots of 4.0.0-beta-5, it can no longer be built:
> {quote}{{[ERROR]   The project 
> org.apache.maven.its.mng8301:module-b:1-SNAPSHOT 
> (/Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml)
>  has 1 error}}
> {{[ERROR]     'dependencies.dependency.version' for 
> org.apache.maven.repro:module-a:jar is missing. @ 
> org.apache.maven.its.mng8301:module-b:[unknown-version], 
> file:///Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml,
>  line 17, column 9}}
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8301) [REGRESSION] Can't build a project without modelVersion=4.1.0 but with 4.1.0 (beta-4) XSD

2024-10-13 Thread Didier Loiseau (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888996#comment-17888996
 ] 

Didier Loiseau commented on MNG-8301:
-

[~mthmulders], I think so yes. With the right xmlns & xsd it seems ok.

> [REGRESSION] Can't build a project without modelVersion=4.1.0 but with 4.1.0 
> (beta-4) XSD
> -
>
> Key: MNG-8301
> URL: https://issues.apache.org/jira/browse/MNG-8301
> Project: Maven
>  Issue Type: Bug
>  Components: POM
>Affects Versions: 4.0.0-beta-5
> Environment: Apache Maven 4.0.0-beta-5-SNAPSHOT 
> (fee69f2f89c6f32dbef0ec55a7f6e8c071d4b6a9)
> Java version: 23, vendor: Eclipse Adoptium, runtime: 
> /Library/Java/JavaVirtualMachines/temurin-23.jdk/Contents/Home
> OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac"
>Reporter: Didier Loiseau
>Priority: Major
>
> A project whose pom.xml refers to the [4.1.0-beta-4 
> XSD|https://maven.apache.org/xsd/maven-4.1.0-beta-4.xsd] and that lacks a 
> {{modelVersion}} element used to be buildable with Maven 4.0.0-beta-4. Maven 
> would infer from the XSD that it should use _modelVersion_ 4.1.0.
> With the current snapshots of 4.0.0-beta-5, it can no longer be built:
> {quote}{{[ERROR]   The project 
> org.apache.maven.its.mng8301:module-b:1-SNAPSHOT 
> (/Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml)
>  has 1 error}}
> {{[ERROR]     'dependencies.dependency.version' for 
> org.apache.maven.repro:module-a:jar is missing. @ 
> org.apache.maven.its.mng8301:module-b:[unknown-version], 
> file:///Users/maarten/Code/open-source/maven/m4-no-modelversion-repro/module-b/pom.xml,
>  line 17, column 9}}
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-8302) CLIng and/or rootDirectory being mandatory causes warning at start when no root discovered

2024-10-13 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MNG-8302:
-
Description: 
Since CLIng, and/or making rootDirectory mandatory, all the CLI tools (mvn, 
mvnenc) we have so far produce WARNING about "root directory not found" (the 
standard message) when invoked from directory that cannot have root directory 
(like doing some CLI-only mojo from home directory, or invoking mvnenc).
This is wrong, as this message should be emitted by mvn only (tools like mvnenc 
are not likely to ever use this directory), and even then, ONLY when there is 
POM/project in context.

When I do {{mvn toolbox:gav-tree -Dgav=...}} from my home directory (mojo is 
direct invocation. does not need project) or just {{mvnenc init}} this warning 
is wrong.

  was:
Since CLIng, and/or making rootDirectory mandatory, all the CLI tools (mvn, 
mvnenc) we have so far produce WARNING about "root directory not found" (the 
standard message) when invoked from directory that cannot have root directory 
(like doing some CLI-only mojo from home directory, or invoking mvnenc).
This is wrong, as this message should be emitted by mvn only (tools like mvnenc 
are not likely to ever use this directory), and even then, ONLY when there is 
POM/project in context.

When I do {{mvn toolbox:gav-tree -Dgav=...}} from my home directory (mojo is 
direct invocation. does not need project) this warning is wrong.


> CLIng and/or rootDirectory being mandatory causes warning at start when no 
> root discovered
> --
>
> Key: MNG-8302
> URL: https://issues.apache.org/jira/browse/MNG-8302
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0-beta-5
>
>
> Since CLIng, and/or making rootDirectory mandatory, all the CLI tools (mvn, 
> mvnenc) we have so far produce WARNING about "root directory not found" (the 
> standard message) when invoked from directory that cannot have root directory 
> (like doing some CLI-only mojo from home directory, or invoking mvnenc).
> This is wrong, as this message should be emitted by mvn only (tools like 
> mvnenc are not likely to ever use this directory), and even then, ONLY when 
> there is POM/project in context.
> When I do {{mvn toolbox:gav-tree -Dgav=...}} from my home directory (mojo is 
> direct invocation. does not need project) or just {{mvnenc init}} this 
> warning is wrong.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MNG-8302) CLIng and/or rootDirectory being mandatory causes warning at start when no root discovered

2024-10-13 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-8302:


 Summary: CLIng and/or rootDirectory being mandatory causes warning 
at start when no root discovered
 Key: MNG-8302
 URL: https://issues.apache.org/jira/browse/MNG-8302
 Project: Maven
  Issue Type: Bug
  Components: Core
Reporter: Tamas Cservenak
 Fix For: 4.0.0-beta-5


Since CLIng, and/or making rootDirectory mandatory, all the CLI tools (mvn, 
mvnenc) we have so far produce WARNING about "root directory not found" (the 
standard message) when invoked from directory that cannot have root directory 
(like doing some CLI-only mojo from home directory, or invoking mvnenc).
This is wrong, as this message should be emitted by mvn only (tools like mvnenc 
are not likely to ever use this directory), and even then, ONLY when there is 
POM/project in context.

When I do {{mvn toolbox:gav-tree -Dgav=...}} from my home directory (mojo is 
direct invocation. does not need project) this warning is wrong.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [SUREFIRE-2277] Fix bug in RunResult serialisation/deserialisation to (from) failsafe-summary.xml [maven-surefire]

2024-10-13 Thread via GitHub


hubertgrzeskowiak commented on code in PR #790:
URL: https://github.com/apache/maven-surefire/pull/790#discussion_r1798627694


##
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java:
##
@@ -84,12 +85,14 @@ public static RunResult toRunResult(File 
failsafeSummaryXml) throws Exception {
 String skipped = xpath.evaluate("/failsafe-summary/skipped", root);
 String failureMessage = 
xpath.evaluate("/failsafe-summary/failureMessage", root);
 String timeout = xpath.evaluate("/failsafe-summary/@timeout", 
root);
+String flakes = xpath.evaluate("/failsafe-summary/flakes", root);
 
 return new RunResult(
 parseInt(completed),
 parseInt(errors),
 parseInt(failures),
 parseInt(skipped),
+isBlank(flakes) ? 0 : parseInt(flakes),

Review Comment:
   nit: do you reckon it's worth adding a comment why we are treating this 
differently, i.e. because of backward compatibility?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [SUREFIRE-2277] Fix bug in RunResult serialisation/deserialisation to (from) failsafe-summary.xml [maven-surefire]

2024-10-13 Thread via GitHub


hubertgrzeskowiak commented on code in PR #790:
URL: https://github.com/apache/maven-surefire/pull/790#discussion_r1798627583


##
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java:
##
@@ -84,12 +85,14 @@ public static RunResult toRunResult(File 
failsafeSummaryXml) throws Exception {
 String skipped = xpath.evaluate("/failsafe-summary/skipped", root);
 String failureMessage = 
xpath.evaluate("/failsafe-summary/failureMessage", root);
 String timeout = xpath.evaluate("/failsafe-summary/@timeout", 
root);
+String flakes = xpath.evaluate("/failsafe-summary/flakes", root);

Review Comment:
   nit: would be better to move this two lines up, right under `skipped`. 
`completed`, `errors`, `failures` and `skipped` all belong to the same type of 
field as `flakes`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MARTIFACT-64) add diagnose and hints for Git commit timestamp support

2024-10-13 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MARTIFACT-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy updated MARTIFACT-64:
---
Description: 
some issues with Git commit timestamp support has been reported: need to 
investigate root cause and provide help

=> add {{-Ddiagnose}}

  was:some issues with Git commit timestamp support has been reported: need to 
investigate root cause and provide help


> add diagnose and hints for Git commit timestamp support
> ---
>
> Key: MARTIFACT-64
> URL: https://issues.apache.org/jira/browse/MARTIFACT-64
> Project: Maven Artifact Plugin
>  Issue Type: Improvement
>Affects Versions: 3.5.1
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>
> some issues with Git commit timestamp support has been reported: need to 
> investigate root cause and provide help
> => add {{-Ddiagnose}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MARTIFACT-64) add -Ddiagnose and hints for Git commit timestamp support

2024-10-13 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MARTIFACT-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy updated MARTIFACT-64:
---
Summary: add -Ddiagnose and hints for Git commit timestamp support  (was: 
add diagnose and hints for Git commit timestamp support)

> add -Ddiagnose and hints for Git commit timestamp support
> -
>
> Key: MARTIFACT-64
> URL: https://issues.apache.org/jira/browse/MARTIFACT-64
> Project: Maven Artifact Plugin
>  Issue Type: Improvement
>Affects Versions: 3.5.1
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>
> some issues with Git commit timestamp support has been reported: need to 
> investigate root cause and provide help
> => add {{-Ddiagnose}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (DOXIA-749) MarkdownSink: Fenced code blocks must be located at the beginning of a line

2024-10-13 Thread Konrad Windszus (Jira)
Konrad Windszus created DOXIA-749:
-

 Summary: MarkdownSink: Fenced code blocks must be located at the 
beginning of a line
 Key: DOXIA-749
 URL: https://issues.apache.org/jira/browse/DOXIA-749
 Project: Maven Doxia
  Issue Type: Bug
Reporter: Konrad Windszus
Assignee: Konrad Windszus
 Fix For: 2.0.1


If currently a {{Sink.text()}} is followed by a {{Sink.sectionTitle(...)}} with 
some text it is not emitted on a dedicated line through the {{MarkdownSink}}.

However according to https://spec.commonmark.org/0.31.2/#atx-headings

{quote} The opening # character may be preceded by up to three spaces of 
indentation {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (DOXIA-749) MarkdownSink: Fenced code blocks must be located at the beginning of a line

2024-10-13 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/DOXIA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated DOXIA-749:
--
Description: 
If currently a {{Sink.text()}} is followed by a {{Sink.sectionTitle(...)}} with 
some text it is not emitted on a dedicated line through the {{MarkdownSink}}.

However according to https://spec.commonmark.org/0.31.2/#fenced-code-blocks

{quote}A fenced code block begins with a code fence, preceded by up to three 
spaces of indentation.{quote}

  was:
If currently a {{Sink.text()}} is followed by a {{Sink.sectionTitle(...)}} with 
some text it is not emitted on a dedicated line through the {{MarkdownSink}}.

However according to https://spec.commonmark.org/0.31.2/#atx-headings

{quote} The opening # character may be preceded by up to three spaces of 
indentation {quote}


> MarkdownSink: Fenced code blocks must be located at the beginning of a line
> ---
>
> Key: DOXIA-749
> URL: https://issues.apache.org/jira/browse/DOXIA-749
> Project: Maven Doxia
>  Issue Type: Bug
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.1
>
>
> If currently a {{Sink.text()}} is followed by a {{Sink.sectionTitle(...)}} 
> with some text it is not emitted on a dedicated line through the 
> {{MarkdownSink}}.
> However according to https://spec.commonmark.org/0.31.2/#fenced-code-blocks
> {quote}A fenced code block begins with a code fence, preceded by up to three 
> spaces of indentation.{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (DOXIA-749) MarkdownSink: Fenced code blocks must be located at the beginning of a line

2024-10-13 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/DOXIA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated DOXIA-749:
--
Description: 
If currently a {{Sink.text()}} is followed by a {{Sink.verbatim(...)}} with 
some text it is not emitted on a dedicated line through the {{MarkdownSink}}.

However according to https://spec.commonmark.org/0.31.2/#fenced-code-blocks

{quote}A fenced code block begins with a code fence, preceded by up to three 
spaces of indentation.{quote}

  was:
If currently a {{Sink.text()}} is followed by a {{Sink.sectionTitle(...)}} with 
some text it is not emitted on a dedicated line through the {{MarkdownSink}}.

However according to https://spec.commonmark.org/0.31.2/#fenced-code-blocks

{quote}A fenced code block begins with a code fence, preceded by up to three 
spaces of indentation.{quote}


> MarkdownSink: Fenced code blocks must be located at the beginning of a line
> ---
>
> Key: DOXIA-749
> URL: https://issues.apache.org/jira/browse/DOXIA-749
> Project: Maven Doxia
>  Issue Type: Bug
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.1
>
>
> If currently a {{Sink.text()}} is followed by a {{Sink.verbatim(...)}} with 
> some text it is not emitted on a dedicated line through the {{MarkdownSink}}.
> However according to https://spec.commonmark.org/0.31.2/#fenced-code-blocks
> {quote}A fenced code block begins with a code fence, preceded by up to three 
> spaces of indentation.{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRESOLVER-603) Apache HTTP transport should expose config for max redirects

2024-10-13 Thread Tamas Cservenak (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888977#comment-17888977
 ] 

Tamas Cservenak commented on MRESOLVER-603:
---

Yeah, agree, backport to Resolver 1.9.x would be useful. Still, we are focused 
on Maven4 (and hence soon happening Resolver 2.0.2 release), so most probably 
will split this issue (clone it for 1.9.23), and when able to get to it, do it 
(or anyone else can chime in).

> Apache HTTP transport should expose config for max redirects
> 
>
> Key: MRESOLVER-603
> URL: https://issues.apache.org/jira/browse/MRESOLVER-603
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: Resolver
>Affects Versions: 1.9.x
>Reporter: Didier Loiseau
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.2, 1.9.23
>
>
> Apache HttpClient allows to {{{}RequestConfig.maxRedirects{}}}. It would be 
> nice to expose it through configuration as for Jetty (MRESOLVER-595) and 
> Wagon.
> Also note that setting it to 0 actually sets a value of 50, so it could be 
> nice to be able to disable redirects entirely (as for Jetty).
> Ideally this should be implemented in 1.9.x since it {{HttpTransport}} is the 
> default in Maven 3.9. (apparently the fix version was copied from 
> MRESOLVER-595 when I cloned it)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCOMPILER-203) Allow compiler-plugin to specify annotation processor dependencies

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889022#comment-17889022
 ] 

ASF GitHub Bot commented on MCOMPILER-203:
--

slachiewicz merged PR #264:
URL: https://github.com/apache/maven-compiler-plugin/pull/264




> Allow compiler-plugin to specify annotation processor dependencies
> --
>
> Key: MCOMPILER-203
> URL: https://issues.apache.org/jira/browse/MCOMPILER-203
> Project: Maven Compiler Plugin
>  Issue Type: New Feature
>Affects Versions: 2.3.2, 3.1
> Environment: Java 6+
>Reporter: David M. Lloyd
>Assignee: Andreas Gudian
>Priority: Major
> Fix For: 3.5
>
>
> Right now the status quo for annotation processor artifacts requires one of 
> two actions:
> # Use an external plugin for annotation processing
> # Put the annotation processor in as a dependency with {{provided}} scope
> The former is suboptimal because the external plugins are clunky and 
> ill-supported, and inflexible/hard to use.  The latter is suboptimal because 
> it is often the case that you do not want to leak annotation processor 
> classes on to the application class path.
> It should be possible to add annotation processor dependency artifacts to the 
> compiler plugin configuration such that they are recognized by the annotation 
> processing search algorithm of the compiler, but they do not actually appear 
> on the compilation class path.  Ideally they would also be isolated from one 
> another (dependency graphs and all), but that's more of a "nice to have".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MNG-8304) Bump net.bytebuddy:byte-buddy from 1.15.3 to 1.15.4

2024-10-13 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-8304:


 Summary: Bump net.bytebuddy:byte-buddy from 1.15.3 to 1.15.4
 Key: MNG-8304
 URL: https://issues.apache.org/jira/browse/MNG-8304
 Project: Maven
  Issue Type: Task
Reporter: Guillaume Nodet


GitHub Pull Request: https://github.com/apache/maven/pull/1791



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MNG-8303) Bump ch.qos.logback:logback-classic from 1.5.8 to 1.5.9

2024-10-13 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-8303:


 Summary: Bump ch.qos.logback:logback-classic from 1.5.8 to 1.5.9
 Key: MNG-8303
 URL: https://issues.apache.org/jira/browse/MNG-8303
 Project: Maven
  Issue Type: Task
Reporter: Guillaume Nodet


GitHub Pull Request: https://github.com/apache/maven/pull/1789



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [DOXIA-746] Sink API: add method for block comment [maven-doxia]

2024-10-13 Thread via GitHub


kwin commented on code in PR #236:
URL: https://github.com/apache/maven-doxia/pull/236#discussion_r1798473474


##
doxia-sink-api/src/main/java/org/apache/maven/doxia/sink/Sink.java:
##
@@ -1724,6 +1724,17 @@ public interface Sink extends AutoCloseable {
  */
 void comment(String comment);
 
+/**
+ * Add a comment. The default implementation will just call {@link 
#comment(String)}.
+ *
+ * @param comment The comment to write.
+ * @param isBlockComment If true this is a block comment, 
i.e. nothing should follow on the same line
+ * @since 2.1
+ */
+default void comment(String comment, boolean isBlockComment) {
+comment(comment);
+}

Review Comment:
   I am still thinking about a more suitable name, because this only affects 
the suffix, but not the prefix of the comment (i.e. in case of `true` the 
comment is not necessarily the only thing in the line). Any good idea here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MDEP-957] By default, don't report slf4j-simple as unused [maven-dependency-plugin]

2024-10-13 Thread via GitHub


slawekjaranowski commented on code in PR #433:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/433#discussion_r1798476056


##
src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java:
##
@@ -228,11 +228,15 @@ public abstract class AbstractAnalyzeMojo extends 
AbstractMojo {
  * For example, org.apache.* will match all artifacts whose 
group id starts with
  * org.apache., and :::*-SNAPSHOT will match all 
snapshot artifacts.
  * 
+ * 
+ * By default, org.slf4j:slf4j-simple is ignored. Setting this property to 
an empty list
+ * will allow it to be detected.
+ * 
  *
  * @since 2.10
  */
 @Parameter
-private String[] ignoredUnusedDeclaredDependencies = new String[0];
+private String[] ignoredUnusedDeclaredDependencies = 
{"org.slf4j:slf4j-simple::"};

Review Comment:
   1. why not use a `default` option of parameter?
   2. when user defined another ignores list it will be overridden ... maybe we 
need add it latter to be always ignored ...
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MDEP-957) Special case slf4j-simple et al to not report used but undeclared

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889024#comment-17889024
 ] 

ASF GitHub Bot commented on MDEP-957:
-

slawekjaranowski commented on code in PR #433:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/433#discussion_r1798476056


##
src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java:
##
@@ -228,11 +228,15 @@ public abstract class AbstractAnalyzeMojo extends 
AbstractMojo {
  * For example, org.apache.* will match all artifacts whose 
group id starts with
  * org.apache., and :::*-SNAPSHOT will match all 
snapshot artifacts.
  * 
+ * 
+ * By default, org.slf4j:slf4j-simple is ignored. Setting this property to 
an empty list
+ * will allow it to be detected.
+ * 
  *
  * @since 2.10
  */
 @Parameter
-private String[] ignoredUnusedDeclaredDependencies = new String[0];
+private String[] ignoredUnusedDeclaredDependencies = 
{"org.slf4j:slf4j-simple::"};

Review Comment:
   1. why not use a `default` option of parameter?
   2. when user defined another ignores list it will be overridden ... maybe we 
need add it latter to be always ignored ...
   





> Special case slf4j-simple et al to not report used but undeclared
> -
>
> Key: MDEP-957
> URL: https://issues.apache.org/jira/browse/MDEP-957
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
> Originally reported in 
> https://issues.apache.org/jira/browse/MSHARED-1204?filter=-1
> slf4j-simple is often deliberately added to classpaths to shut up annoying 
> warnings from SLF4J at run and test time, even though it isn't absolutely 
> required. Can we do better with our analysis of the common case and similar 
> ones, rather than reporting it as declared but unused?
> ```
> 
>   org.slf4j
>   slf4j-simple
>   test
> 
> ```



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Refactoring: AbstractCompilerMojo: Replace StringBuilder with String.join() [maven-compiler-plugin]

2024-10-13 Thread via GitHub


slachiewicz merged PR #265:
URL: https://github.com/apache/maven-compiler-plugin/pull/265


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump commons-io:commons-io from 2.7 to 2.14.0 in /src/it/MCOMPILER-203-processorpath/annotation-user [maven-compiler-plugin]

2024-10-13 Thread via GitHub


slachiewicz merged PR #264:
URL: https://github.com/apache/maven-compiler-plugin/pull/264


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MCOMPILER-592] don't validate the project.build.outputTimestamp [maven-compiler-plugin]

2024-10-13 Thread via GitHub


stokito closed pull request #266: [MCOMPILER-592] don't validate the 
project.build.outputTimestamp
URL: https://github.com/apache/maven-compiler-plugin/pull/266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MCOMPILER-592) IndexOutOfBoundsException when project.build.outputTimestamp is empty

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889023#comment-17889023
 ] 

ASF GitHub Bot commented on MCOMPILER-592:
--

stokito closed pull request #266: [MCOMPILER-592] don't validate the 
project.build.outputTimestamp
URL: https://github.com/apache/maven-compiler-plugin/pull/266




> IndexOutOfBoundsException when project.build.outputTimestamp is empty
> -
>
> Key: MCOMPILER-592
> URL: https://issues.apache.org/jira/browse/MCOMPILER-592
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.12.0, 3.12.1, 3.13.0
>Reporter: Thijs Rijpert
>Priority: Minor
>
> Due to a combination of plugins, it is possible for the 
> project.build.outputTimestamp property to have an empty string as a value. 
> This causes an IndexOutOfBoundsException on line 1242 when it tries to access 
> the first character in the string. 
> This can be fixed by doing an isEmpty check before doing the charAt check. I 
> will create an PR for this.
> While this bug is caused by another plugin, I think this should be fixed in 
> the compiler because the error returned (IndexOutOfBoundsException), is vague 
> and hard to debug.
> The workaround for this issue is setting the project.build.outputTimestamp 
> property with an arbitrary value.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump org.vafer:jdependency from 2.10 to 2.11 [maven-shade-plugin]

2024-10-13 Thread via GitHub


dependabot[bot] closed pull request #239: Bump org.vafer:jdependency from 2.10 
to 2.11
URL: https://github.com/apache/maven-shade-plugin/pull/239


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.vafer:jdependency from 2.10 to 2.11 [maven-shade-plugin]

2024-10-13 Thread via GitHub


dependabot[bot] commented on PR #239:
URL: 
https://github.com/apache/maven-shade-plugin/pull/239#issuecomment-2409081453

   OK, I won't notify you about org.vafer:jdependency again, unless you re-open 
this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.vafer:jdependency from 2.10 to 2.11 [maven-shade-plugin]

2024-10-13 Thread via GitHub


slachiewicz commented on PR #239:
URL: 
https://github.com/apache/maven-shade-plugin/pull/239#issuecomment-2409081435

   @dependabot ignore this dependency


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.commons:commons-lang3 from 3.15.0 to 3.17.0 [maven-release]

2024-10-13 Thread via GitHub


slachiewicz merged PR #231:
URL: https://github.com/apache/maven-release/pull/231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MARTIFACT-64) add -Ddiagnose and hints for Git commit timestamp support

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889029#comment-17889029
 ] 

ASF GitHub Bot commented on MARTIFACT-64:
-

hboutemy merged PR #59:
URL: https://github.com/apache/maven-artifact-plugin/pull/59




> add -Ddiagnose and hints for Git commit timestamp support
> -
>
> Key: MARTIFACT-64
> URL: https://issues.apache.org/jira/browse/MARTIFACT-64
> Project: Maven Artifact Plugin
>  Issue Type: Improvement
>Affects Versions: 3.5.1
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>
> some issues with Git commit timestamp support has been reported: need to 
> investigate root cause and provide help
> => add {{-Ddiagnose}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MARTIFACT-64] add inheritence diagnostics [maven-artifact-plugin]

2024-10-13 Thread via GitHub


hboutemy merged PR #59:
URL: https://github.com/apache/maven-artifact-plugin/pull/59


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.17.0 [maven-scm-publish-plugin]

2024-10-13 Thread via GitHub


slachiewicz merged PR #43:
URL: https://github.com/apache/maven-scm-publish-plugin/pull/43


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump commons-io:commons-io from 2.16.1 to 2.17.0 [maven-jlink-plugin]

2024-10-13 Thread via GitHub


slachiewicz merged PR #215:
URL: https://github.com/apache/maven-jlink-plugin/pull/215


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump commons-io:commons-io from 2.16.1 to 2.17.0 [maven-artifact-plugin]

2024-10-13 Thread via GitHub


slachiewicz merged PR #55:
URL: https://github.com/apache/maven-artifact-plugin/pull/55


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MARTIFACT-64) add -Ddiagnose and hints for Git commit timestamp support

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889028#comment-17889028
 ] 

ASF GitHub Bot commented on MARTIFACT-64:
-

hboutemy opened a new pull request, #59:
URL: https://github.com/apache/maven-artifact-plugin/pull/59

   (no comment)




> add -Ddiagnose and hints for Git commit timestamp support
> -
>
> Key: MARTIFACT-64
> URL: https://issues.apache.org/jira/browse/MARTIFACT-64
> Project: Maven Artifact Plugin
>  Issue Type: Improvement
>Affects Versions: 3.5.1
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>
> some issues with Git commit timestamp support has been reported: need to 
> investigate root cause and provide help
> => add {{-Ddiagnose}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MARTIFACT-71) don't WARN if timestamp property is inherited but only INFO

2024-10-13 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MARTIFACT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy closed MARTIFACT-71.
--
  Assignee: Herve Boutemy
Resolution: Fixed

> don't WARN if timestamp property is inherited but only INFO
> ---
>
> Key: MARTIFACT-71
> URL: https://issues.apache.org/jira/browse/MARTIFACT-71
> Project: Maven Artifact Plugin
>  Issue Type: Improvement
>  Components: artifact:check-buildplan
>Affects Versions: 3.5.1
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>
> as seen in MNG-8258, WARNING is too aggressive: inheriting is completely 
> valid, just a choice
> it's better to display an INFO in the spirit of "this project inherits 
> timestamp from parent pom yyy, value xxx"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MARTIFACT-71) don't WARN if timestamp property is inherited but only INFO

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889030#comment-17889030
 ] 

ASF GitHub Bot commented on MARTIFACT-71:
-

hboutemy merged PR #58:
URL: https://github.com/apache/maven-artifact-plugin/pull/58




> don't WARN if timestamp property is inherited but only INFO
> ---
>
> Key: MARTIFACT-71
> URL: https://issues.apache.org/jira/browse/MARTIFACT-71
> Project: Maven Artifact Plugin
>  Issue Type: Improvement
>  Components: artifact:check-buildplan
>Affects Versions: 3.5.1
>Reporter: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>
> as seen in MNG-8258, WARNING is too aggressive: inheriting is completely 
> valid, just a choice
> it's better to display an INFO in the spirit of "this project inherits 
> timestamp from parent pom yyy, value xxx"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MARTIFACT-71] warn => info [maven-artifact-plugin]

2024-10-13 Thread via GitHub


hboutemy merged PR #58:
URL: https://github.com/apache/maven-artifact-plugin/pull/58


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.maven.reporting:maven-reporting-api from 4.0.0-M2 to 4.0.0 [maven-dist-tool]

2024-10-13 Thread via GitHub


slachiewicz merged PR #66:
URL: https://github.com/apache/maven-dist-tool/pull/66


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump org.codehaus.groovy:groovy-xml from 2.4.16 to 3.0.22 [maven-archetypes]

2024-10-13 Thread via GitHub


dependabot[bot] opened a new pull request, #35:
URL: https://github.com/apache/maven-archetypes/pull/35

   Bumps [org.codehaus.groovy:groovy-xml](https://github.com/apache/groovy) 
from 2.4.16 to 3.0.22.
   
   Commits
   
   See full diff in https://github.com/apache/groovy/commits";>compare view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.groovy:groovy-xml&package-manager=maven&previous-version=2.4.16&new-version=3.0.22)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump version.maven-archetype-plugin from 3.2.0 to 3.3.0 [maven-archetypes]

2024-10-13 Thread via GitHub


dependabot[bot] opened a new pull request, #34:
URL: https://github.com/apache/maven-archetypes/pull/34

   Bumps `version.maven-archetype-plugin` from 3.2.0 to 3.3.0.
   Updates `org.apache.maven.archetype:archetype-packaging` from 3.2.0 to 3.3.0
   
   Release notes
   Sourced from https://github.com/apache/maven-archetype/releases";>org.apache.maven.archetype:archetype-packaging's
 releases.
   
   3.3.0
   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317122&version=12351178";>Release
 Notes - Maven Archetype - Version 3.3.0
   
   
   
   
   ... (truncated)
   
   
   Commits
   
   https://github.com/apache/maven-archetype/commit/bef57dce0879b13f4daad571092a5e878df4928a";>bef57dc
 [maven-release-plugin] prepare release maven-archetype-3.3.0
   https://github.com/apache/maven-archetype/commit/4f652a79f64d28ce1814370354894b0eb6e9c8d2";>4f652a7
 [ARCHETYPE-678] Code cleanups
   https://github.com/apache/maven-archetype/commit/1e32a017c700044aeb43e8c7eefe9673d0f7aec2";>1e32a01
 [ARCHETYPE-664] Bump commons-io:commons-io from 2.16.1 to 2.17.0 (https://redirect.github.com/apache/maven-archetype/issues/220";>#220)
   https://github.com/apache/maven-archetype/commit/367a9fe79a6698c5a6fc1fbcbfb239819d5ba9c2";>367a9fe
 [ARCHETYPE-655] Get rid of Wagon API to download catalogs
   https://github.com/apache/maven-archetype/commit/054e22db94dbfc9b36cdd49ab63929b764eb745d";>054e22d
 [ARCHETYPE-677] Upgrade versions of archetypes in internal catalog
   https://github.com/apache/maven-archetype/commit/c159afea8b5bc20dd1abf5ab965a5c280071143d";>c159afe
 [ARCHETYPE-661] Refresh download page
   https://github.com/apache/maven-archetype/commit/2e1552b923fe776f3e845ece040c4db92c276d94";>2e1552b
 [ARCHETYPE-632] Add logging conflict line in integration-test (https://redirect.github.com/apache/maven-archetype/issues/114";>#114)
   https://github.com/apache/maven-archetype/commit/835d9273fc6e67ac9387eb56b85e5b2b073e9d97";>835d927
 [ARCHETYPE-658] Bump org.apache.groovy:groovy from 4.0.22 to 4.0.23 (https://redirect.github.com/apache/maven-archetype/issues/214";>#214)
   https://github.com/apache/maven-archetype/commit/1bb59d379fc39ec3eeaf7d871e0132aa6490bb2d";>1bb59d3
 [ARCHETYPE-673] Get rid of maven-artifact-transfer
   https://github.com/apache/maven-archetype/commit/3a0ae15a8556c4ccb1d08806c95287b5ce7d6906";>3a0ae15
 [ARCHETYPE-672] Bump org.codehaus.plexus:plexus-interactivity-api from 1.2 
to...
   Additional commits viewable in https://github.com/apache/maven-archetype/compare/maven-archetype-3.2.0...maven-archetype-3.3.0";>compare
 view
   
   
   
   
   Updates `org.apache.maven.plugins:maven-archetype-plugin` from 3.2.0 to 3.3.0
   
   Release notes
   Sourced from https://github.com/apache/maven-archetype/releases";>org.apache.maven.plugins:maven-archetype-plugin's
 releases.
   
   3.3.0
   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317122&version=12351178";>Release
 Notes - Maven Archetype - Version 3.3.0
   
   
   
   
   ... (truncated)
   
   
   Commits
   
   https://github.com/apache/maven-archetype/commit/bef57dce0879b13f4daad571092a5e878df4928a";>bef57dc
 [maven-release-plugin] prepare release maven-archetype-3.3.0
   https://github.com/apache/maven-archetype/commit/4f652a79f64d28ce1814370354894b0eb6e9c8d2";>4f652a7
 [ARCHETYPE-678] Code cleanups
   https://github.com/apache/maven-archetype/commit/1e32a017c700044aeb43e8c7eefe9673d0f7aec2";>1e32a01
 [ARCHETYPE-664] Bump commons-io:commons-io from 2.16.1 to 2.17.0 (https://redirect.github.com/apache/maven-archetype/issues/220";>#220)
   https://github.com/apache/maven-archetype/commit/367a9fe79a6698c5a6fc1fbcbfb239819d5ba9c2";>367a9fe
 [ARCHETYPE-655] Get rid of Wagon API to download catalogs
   https://github.com/apache/maven-archetype/commit/054e22db94dbfc9b36cdd49ab63929b764eb745d";>054e22d
 [ARCHETYPE-677] Upgrade versions of archetypes in internal catalog
   https://github.com/apache/maven-archetype/commit/c159afea8b5bc20dd1abf5ab965a5c280071143d";>c159afe
 [ARCHETYPE-661] Refresh download page
   https://github.com/apache/maven-archetype/commit/2e1552b923fe776f3e845ece040c4db92c276d94";>2e1552b
 [ARCHETYPE-632] Add logging conflict line in integration-test (https://redirect.github.com/apache/maven-archetype/issues/114";>#114)
   https://github.com/apache/maven-archetype/commit/835d9273fc6e67ac9387eb56b85e5b2b073e9d97";>835d927
 [ARCHETYPE-658] Bump org.apache.groovy:groovy from 4.0.22 to 4.0.23 (https://redirect.github.com/apache/maven-archetype/issues/214";>#214)
   https://github.com/apache/maven-archetype/commit/1bb59d379fc39ec3eeaf7d871e0132aa6490bb2d";>1bb59d3
 [ARCHETYPE-673] Get rid of maven-artifact-transfer
   https://github.com/apache/maven-archetype/commit/3a0ae15a8556c4ccb1d08806c95287b5ce7d6906";>3a0ae15
 [ARCHETYPE-672] Bump org.codehaus.plexus:plexus-interactivity-api from 1.2 
to...
   Additional commits viewable in https://github.com/apache/maven-archetype/compare/maven-archetype-3.2

Re: [PR] [MARTIFACT-69] add takari-lifecycle-plugin [maven-artifact-plugin]

2024-10-13 Thread via GitHub


hboutemy merged PR #60:
URL: https://github.com/apache/maven-artifact-plugin/pull/60


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MARTIFACT-69) add takari-lifecycle-plugin to the list of plugins with issues

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889031#comment-17889031
 ] 

ASF GitHub Bot commented on MARTIFACT-69:
-

hboutemy opened a new pull request, #60:
URL: https://github.com/apache/maven-artifact-plugin/pull/60

   (no comment)




> add takari-lifecycle-plugin to the list of plugins with issues
> --
>
> Key: MARTIFACT-69
> URL: https://issues.apache.org/jira/browse/MARTIFACT-69
> Project: Maven Artifact Plugin
>  Issue Type: Task
>  Components: artifact:check-buildplan
>Affects Versions: 3.5.1
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.5.2
>
>
> https://github.com/takari/takari-lifecycle/issues/171 fixed in 2.1.7



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MARTIFACT-69) add takari-lifecycle-plugin to the list of plugins with issues

2024-10-13 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/MARTIFACT-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated MARTIFACT-69:

Labels: pull-request-available  (was: )

> add takari-lifecycle-plugin to the list of plugins with issues
> --
>
> Key: MARTIFACT-69
> URL: https://issues.apache.org/jira/browse/MARTIFACT-69
> Project: Maven Artifact Plugin
>  Issue Type: Task
>  Components: artifact:check-buildplan
>Affects Versions: 3.5.1
>Reporter: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>
> https://github.com/takari/takari-lifecycle/issues/171 fixed in 2.1.7



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MARTIFACT-69) add takari-lifecycle-plugin to the list of plugins with issues

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889032#comment-17889032
 ] 

ASF GitHub Bot commented on MARTIFACT-69:
-

hboutemy merged PR #60:
URL: https://github.com/apache/maven-artifact-plugin/pull/60




> add takari-lifecycle-plugin to the list of plugins with issues
> --
>
> Key: MARTIFACT-69
> URL: https://issues.apache.org/jira/browse/MARTIFACT-69
> Project: Maven Artifact Plugin
>  Issue Type: Task
>  Components: artifact:check-buildplan
>Affects Versions: 3.5.1
>Reporter: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>
> https://github.com/takari/takari-lifecycle/issues/171 fixed in 2.1.7



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MARTIFACT-69) add takari-lifecycle-plugin to the list of plugins with issues

2024-10-13 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MARTIFACT-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy closed MARTIFACT-69.
--
  Assignee: Herve Boutemy
Resolution: Fixed

> add takari-lifecycle-plugin to the list of plugins with issues
> --
>
> Key: MARTIFACT-69
> URL: https://issues.apache.org/jira/browse/MARTIFACT-69
> Project: Maven Artifact Plugin
>  Issue Type: Task
>  Components: artifact:check-buildplan
>Affects Versions: 3.5.1
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>
> https://github.com/takari/takari-lifecycle/issues/171 fixed in 2.1.7



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MARTIFACT-66) Upgrade maven resolver version 1.9.18 to 1.9.20

2024-10-13 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MARTIFACT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy closed MARTIFACT-66.
--
Fix Version/s: 3.5.2
 Assignee: Herve Boutemy
   Resolution: Fixed

> Upgrade maven resolver version 1.9.18 to 1.9.20
> ---
>
> Key: MARTIFACT-66
> URL: https://issues.apache.org/jira/browse/MARTIFACT-66
> Project: Maven Artifact Plugin
>  Issue Type: Task
>Reporter: Zhongming Hua
>Assignee: Herve Boutemy
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MARTIFACT-66) Upgrade maven resolver version 1.9.18 to 1.9.20

2024-10-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889033#comment-17889033
 ] 

ASF GitHub Bot commented on MARTIFACT-66:
-

hboutemy merged PR #43:
URL: https://github.com/apache/maven-artifact-plugin/pull/43




> Upgrade maven resolver version 1.9.18 to 1.9.20
> ---
>
> Key: MARTIFACT-66
> URL: https://issues.apache.org/jira/browse/MARTIFACT-66
> Project: Maven Artifact Plugin
>  Issue Type: Task
>Reporter: Zhongming Hua
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MARTIFACT-66] Upgrade maven resolver version 1.9.18 to 1.9.20 [maven-artifact-plugin]

2024-10-13 Thread via GitHub


hboutemy merged PR #43:
URL: https://github.com/apache/maven-artifact-plugin/pull/43


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Comment Edited] (MARTIFACT-57) Combining artifact:buildinfo and artifact:compare fails

2024-10-13 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889034#comment-17889034
 ] 

Herve Boutemy edited comment on MARTIFACT-57 at 10/13/24 7:01 PM:
--

guessing environment is not that hard, without requiring buildinfo storage
see 
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/bin/wip.sh 
and 
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/bin/add-new-release.sh

and experience has proven that storing buildinfo to Maven Central cause issues 
when data stored has been generated with an old plugin, and compare is run with 
newer that has changed format

definitively, storing buildinfo in Maven Central has been a bad idea when I 
started, 5 years ago


was (Author: hboutemy):
guessing environment is not that hard, without requiring buildinfo storage
see 
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/bin/wip.sh 
and 
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/bin/add-new-release.sh

> Combining artifact:buildinfo and artifact:compare fails
> ---
>
> Key: MARTIFACT-57
> URL: https://issues.apache.org/jira/browse/MARTIFACT-57
> Project: Maven Artifact Plugin
>  Issue Type: Bug
>  Components: artifact:compare
>Affects Versions: 3.5.0
>Reporter: Marcono1234
>Priority: Major
>
> h2. The issue
> When you combine the goals {{artifact:buildinfo}} and {{artifact:compare}}, 
> then {{compare}} fails, claiming the {{.buildinfo}} file differs.
> For my build the {{artifact:buildinfo}} goal is configured in the {{build}} 
> section of the {{pom.xml}} so that it always creates the {{.buildinfo}} file.
> I haven't investigated this in detail, but to me it seems the underlying 
> issue is this:
> When running {{mvn clean verify artifact:compare}} (as suggested by the 
> [Maven 
> guide|https://maven.apache.org/guides/mini/guide-reproducible-builds.html#how-to-test-my-maven-build-reproducibility]):
> # It implicitly runs the {{artifact:buildinfo}} goal during the {{verify}} 
> phase and attaches the {{.buildinfo}} artifact.
> # {{artifact:compare}} itself seems to also generate a {{.buildinfo}} file 
> which is supposed to include all artifacts, but this (erroneously?) includes 
> the {{.buildinfo}} file from {{artifact:buildinfo}}.
> And also, because it is currently in the process of overwriting that file, it 
> seems to report {{length=0}} (\?).
> h2. Reproduction steps
> # Create a {{pom.xml}} with the following content:
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
>   4.0.0
>   com.mycompany.app
>   my-app
>   1.0-SNAPSHOT
>   
> UTF-8
> 
> 2023-01-01T00:00:00Z
>   
>   
> 
>   
> org.apache.maven.plugins
> maven-artifact-plugin
> 3.5.0
> 
>   
> 
>   buildinfo
> 
>   
> 
>   
> 
>   
> 
> {code}
> # Run
> {code}
> mvn clean install
> {code}
> # Run
> {code}
> mvn clean verify artifact:compare
> {code}
> (x) Bug: It fails, claiming the {{.buildinfo}} files differ
> # Inspect the {{target/my-app-1.0-SNAPSHOT.buildinfo}} file
> (x) Bug: It contains the following bogus entry
> {code}
> outputs.2.groupId=com.mycompany.app
> outputs.2.filename=my-app-1.0-SNAPSHOT.buildinfo
> outputs.2.length=0
> outputs.2.checksums.sha512=cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e
> {code}
> *Important:* Remember to delete the 
> {{/.m2/repository/com/mycompany}} directory from your local Maven 
> repository afterwards.
> h2. Workaround
> Run {{artifact:compare}} in combination with {{-Dbuildinfo.attach=false}}:
> {code}
> mvn clean verify artifact:compare -Dbuildinfo.attach=false
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MARTIFACT-57) Combining artifact:buildinfo and artifact:compare fails

2024-10-13 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/MARTIFACT-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889034#comment-17889034
 ] 

Herve Boutemy commented on MARTIFACT-57:


guessing environment is not that hard, without requiring buildinfo storage
see 
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/bin/wip.sh 
and 
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/bin/add-new-release.sh

> Combining artifact:buildinfo and artifact:compare fails
> ---
>
> Key: MARTIFACT-57
> URL: https://issues.apache.org/jira/browse/MARTIFACT-57
> Project: Maven Artifact Plugin
>  Issue Type: Bug
>  Components: artifact:compare
>Affects Versions: 3.5.0
>Reporter: Marcono1234
>Priority: Major
>
> h2. The issue
> When you combine the goals {{artifact:buildinfo}} and {{artifact:compare}}, 
> then {{compare}} fails, claiming the {{.buildinfo}} file differs.
> For my build the {{artifact:buildinfo}} goal is configured in the {{build}} 
> section of the {{pom.xml}} so that it always creates the {{.buildinfo}} file.
> I haven't investigated this in detail, but to me it seems the underlying 
> issue is this:
> When running {{mvn clean verify artifact:compare}} (as suggested by the 
> [Maven 
> guide|https://maven.apache.org/guides/mini/guide-reproducible-builds.html#how-to-test-my-maven-build-reproducibility]):
> # It implicitly runs the {{artifact:buildinfo}} goal during the {{verify}} 
> phase and attaches the {{.buildinfo}} artifact.
> # {{artifact:compare}} itself seems to also generate a {{.buildinfo}} file 
> which is supposed to include all artifacts, but this (erroneously?) includes 
> the {{.buildinfo}} file from {{artifact:buildinfo}}.
> And also, because it is currently in the process of overwriting that file, it 
> seems to report {{length=0}} (\?).
> h2. Reproduction steps
> # Create a {{pom.xml}} with the following content:
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
>   4.0.0
>   com.mycompany.app
>   my-app
>   1.0-SNAPSHOT
>   
> UTF-8
> 
> 2023-01-01T00:00:00Z
>   
>   
> 
>   
> org.apache.maven.plugins
> maven-artifact-plugin
> 3.5.0
> 
>   
> 
>   buildinfo
> 
>   
> 
>   
> 
>   
> 
> {code}
> # Run
> {code}
> mvn clean install
> {code}
> # Run
> {code}
> mvn clean verify artifact:compare
> {code}
> (x) Bug: It fails, claiming the {{.buildinfo}} files differ
> # Inspect the {{target/my-app-1.0-SNAPSHOT.buildinfo}} file
> (x) Bug: It contains the following bogus entry
> {code}
> outputs.2.groupId=com.mycompany.app
> outputs.2.filename=my-app-1.0-SNAPSHOT.buildinfo
> outputs.2.length=0
> outputs.2.checksums.sha512=cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e
> {code}
> *Important:* Remember to delete the 
> {{/.m2/repository/com/mycompany}} directory from your local Maven 
> repository afterwards.
> h2. Workaround
> Run {{artifact:compare}} in combination with {{-Dbuildinfo.attach=false}}:
> {code}
> mvn clean verify artifact:compare -Dbuildinfo.attach=false
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Bump ch.qos.logback:logback-classic from 1.5.8 to 1.5.10 [maven]

2024-10-13 Thread via GitHub


dependabot[bot] opened a new pull request, #1794:
URL: https://github.com/apache/maven/pull/1794

   Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) 
from 1.5.8 to 1.5.10.
   
   Commits
   
   https://github.com/qos-ch/logback/commit/56ec7b2e0f6047aef077dbefc34a57ed38881a54";>56ec7b2
 prepare release 1.5.10
   https://github.com/qos-ch/logback/commit/a95bbc2b80c6a1da6eecac8bdfd1bf3f24177bf8";>a95bbc2
 minor refactorings to allow ConfigurationModelHandlerFull and 
PropertiesConfi...
   https://github.com/qos-ch/logback/commit/cbbd8206d7c0e21c05c67d16a510384663878981";>cbbd820
 fix issues/866
   https://github.com/qos-ch/logback/commit/77e95e0e8d67c6845c369ab9f7dee4824b9d5ff3";>77e95e0
 start work on 1.5.10-SNAPSHOT
   https://github.com/qos-ch/logback/commit/49663a8898b6efdf061603a9caf35996462b0c4c";>49663a8
 disable flaky test
   https://github.com/qos-ch/logback/commit/275664017e988ca2155728b250c3b3b6c38be7c1";>2756640
 prepare release 1.5.9
   https://github.com/qos-ch/logback/commit/81d8376fdc54fe2cd9ca455243a814bded5e5d11";>81d8376
 test for properties change detection from URL/http
   https://github.com/qos-ch/logback/commit/a496a040fab5dae285bccc87f8431941ed390c5e";>a496a04
 adding http scan capability, had to move tests
   https://github.com/qos-ch/logback/commit/67c24f682198d87a980086adaa74c489d09dd962";>67c24f6
 minor changes in RollingFileAppenderTest
   https://github.com/qos-ch/logback/commit/42caff87ae6eb553dcbf77e25ba87a9d340357ee";>42caff8
 fix writing the header for RollingFileAppender (https://redirect.github.com/qos-ch/logback/issues/862";>#862)
   Additional commits viewable in https://github.com/qos-ch/logback/compare/v_1.5.8...v_1.5.10";>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ch.qos.logback:logback-classic&package-manager=maven&previous-version=1.5.8&new-version=1.5.10)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MNG-8303] Bump ch.qos.logback:logback-classic from 1.5.8 to 1.5.9 [maven]

2024-10-13 Thread via GitHub


dependabot[bot] closed pull request #1789: [MNG-8303] Bump 
ch.qos.logback:logback-classic from 1.5.8 to 1.5.9
URL: https://github.com/apache/maven/pull/1789


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MNG-8303] Bump ch.qos.logback:logback-classic from 1.5.8 to 1.5.9 [maven]

2024-10-13 Thread via GitHub


dependabot[bot] commented on PR #1789:
URL: https://github.com/apache/maven/pull/1789#issuecomment-2409642411

   Superseded by #1794.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [SUREFIRE-2276] - Fix for retries of JUnit TestTemplate tests [maven-surefire]

2024-10-13 Thread via GitHub


fxbonnet commented on code in PR #788:
URL: https://github.com/apache/maven-surefire/pull/788#discussion_r1798774808


##
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java:
##
@@ -317,12 +317,14 @@ private String[] toClassMethodName(TestIdentifier 
testIdentifier) {
 boolean needsSpaceSeparator = isNotBlank(parentDisplay) && 
!display.startsWith("[");
 String methodDisplay = parentDisplay + (needsSpaceSeparator ? " " 
: "") + display;
 
+boolean isParameterized = 
isNotBlank(methodSource.getMethodParameterTypes());
 boolean hasParameterizedParent = 
collectAllTestIdentifiersInHierarchy(testIdentifier)
 .filter(identifier -> !identifier.getSource().isPresent())
 .map(TestIdentifier::getLegacyReportingName)
 .anyMatch(legacyReportingName -> 
legacyReportingName.matches("^\\[.+]$"));
+boolean isTestTemplate = 
testIdentifier.getLegacyReportingName().matches("^.*\\[\\d+]$");

Review Comment:
   Does this work only for numeric parameters?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MWRAPPER-152) only-mvnw is not POSIX compatible

2024-10-13 Thread Ryan Worcester (Jira)


 [ 
https://issues.apache.org/jira/browse/MWRAPPER-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan Worcester updated MWRAPPER-152:

Description: 
The maven wrapper type only-script file mvnw declares a shebang of #!/bin/sh 
which is the default shell. The default shell can be any shell therefore for 
this script to work as expected it needs to only use things common to all 
shells.

v3.3.2 at 
[https://github.com/apache/maven-wrapper/blob/maven-wrapper-3.3.2/maven-wrapper-distribution/src/resources/only-mvnw#L161]
 uses mktemp which is not POSIX compliant. mktemp doesn't exist in ksh (korn 
shell) and doesn't exist in some versions of bash. My app's server has bash 
"GNU bash, version 5.0.0(2){-}release{-}(powerpc-ibm-aix6.1.9.0)" which lacks 
mktemp.

  was:v3.3.2 at 
[https://github.com/apache/maven-wrapper/blob/maven-wrapper-3.3.2/maven-wrapper-distribution/src/resources/only-mvnw#L161]
 uses mktemp which is not POSIX compliant. mktemp doesn't exist in ksh (korn 
shell) and doesn't exist in some versions of bash. My app's server has bash 
"GNU bash, version 5.0.0(2)-release-(powerpc-ibm-aix6.1.9.0)" which lacks 
mktemp.


> only-mvnw is not POSIX compatible
> -
>
> Key: MWRAPPER-152
> URL: https://issues.apache.org/jira/browse/MWRAPPER-152
> Project: Maven Wrapper
>  Issue Type: Bug
>  Components: Maven Wrapper Scripts
>Affects Versions: 3.3.2
>Reporter: Ryan Worcester
>Priority: Major
>  Labels: posix
>
> The maven wrapper type only-script file mvnw declares a shebang of #!/bin/sh 
> which is the default shell. The default shell can be any shell therefore for 
> this script to work as expected it needs to only use things common to all 
> shells.
> v3.3.2 at 
> [https://github.com/apache/maven-wrapper/blob/maven-wrapper-3.3.2/maven-wrapper-distribution/src/resources/only-mvnw#L161]
>  uses mktemp which is not POSIX compliant. mktemp doesn't exist in ksh (korn 
> shell) and doesn't exist in some versions of bash. My app's server has bash 
> "GNU bash, version 5.0.0(2){-}release{-}(powerpc-ibm-aix6.1.9.0)" which lacks 
> mktemp.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [SUREFIRE-2276] - Fix for retries of JUnit TestTemplate tests [maven-surefire]

2024-10-13 Thread via GitHub


hubertgrzeskowiak commented on code in PR #788:
URL: https://github.com/apache/maven-surefire/pull/788#discussion_r1798801882


##
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java:
##
@@ -317,12 +317,14 @@ private String[] toClassMethodName(TestIdentifier 
testIdentifier) {
 boolean needsSpaceSeparator = isNotBlank(parentDisplay) && 
!display.startsWith("[");
 String methodDisplay = parentDisplay + (needsSpaceSeparator ? " " 
: "") + display;
 
+boolean isParameterized = 
isNotBlank(methodSource.getMethodParameterTypes());
 boolean hasParameterizedParent = 
collectAllTestIdentifiersInHierarchy(testIdentifier)
 .filter(identifier -> !identifier.getSource().isPresent())
 .map(TestIdentifier::getLegacyReportingName)
 .anyMatch(legacyReportingName -> 
legacyReportingName.matches("^\\[.+]$"));
+boolean isTestTemplate = 
testIdentifier.getLegacyReportingName().matches("^.*\\[\\d+]$");

Review Comment:
   Thanks for the good question!
   
   A test template function gets invoked within a loop (stream to be precise), 
once for each invocation context. This legacy name contains the index of the 
invocation and is unrelated to any params the method actually receives, and 
even unrelated to the display name we set in the invocation context.
   
   I just also double checked by changing the integers used in the test 
fixtures to strings, and the tests pass just fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump commons-codec:commons-codec from 1.17.0 to 1.17.1 [maven-artifact-plugin]

2024-10-13 Thread via GitHub


slachiewicz commented on PR #51:
URL: 
https://github.com/apache/maven-artifact-plugin/pull/51#issuecomment-2410144775

   @dependabot rebase 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.maven:maven-archiver from 3.6.1 to 3.6.2 [maven-artifact-plugin]

2024-10-13 Thread via GitHub


slachiewicz commented on PR #37:
URL: 
https://github.com/apache/maven-artifact-plugin/pull/37#issuecomment-2410146139

   @dependabot rebase 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.simplify4u.plugins:pgpverify-maven-plugin from 1.17.0 to 1.18.2 [maven-artifact-plugin]

2024-10-13 Thread via GitHub


slachiewicz commented on PR #47:
URL: 
https://github.com/apache/maven-artifact-plugin/pull/47#issuecomment-2410145776

   @dependabot rebase 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 42 to 43 [maven-artifact-plugin]

2024-10-13 Thread via GitHub


slachiewicz commented on PR #50:
URL: 
https://github.com/apache/maven-artifact-plugin/pull/50#issuecomment-2410144954

   @dependabot rebase 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [SUREFIRE-2276] - Fix for retries of JUnit TestTemplate tests [maven-surefire]

2024-10-13 Thread via GitHub


hubertgrzeskowiak commented on PR #788:
URL: https://github.com/apache/maven-surefire/pull/788#issuecomment-2409509572

   This is ready to merge from my side :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MWRAPPER-152) only-mvnw is not POSIX compatible

2024-10-13 Thread Ryan Worcester (Jira)
Ryan Worcester created MWRAPPER-152:
---

 Summary: only-mvnw is not POSIX compatible
 Key: MWRAPPER-152
 URL: https://issues.apache.org/jira/browse/MWRAPPER-152
 Project: Maven Wrapper
  Issue Type: Bug
  Components: Maven Wrapper Scripts
Affects Versions: 3.3.2
Reporter: Ryan Worcester


v3.3.2 at 
[https://github.com/apache/maven-wrapper/blob/maven-wrapper-3.3.2/maven-wrapper-distribution/src/resources/only-mvnw#L161]
 uses mktemp which is not POSIX compliant. mktemp doesn't exist in ksh (korn 
shell) and doesn't exist in some versions of bash. My app's server has bash 
"GNU bash, version 5.0.0(2)-release-(powerpc-ibm-aix6.1.9.0)" which lacks 
mktemp.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Bump asmVersion from 9.7 to 9.7.1 [maven-shade-plugin]

2024-10-13 Thread via GitHub


dependabot[bot] opened a new pull request, #242:
URL: https://github.com/apache/maven-shade-plugin/pull/242

   Bumps `asmVersion` from 9.7 to 9.7.1.
   Updates `org.ow2.asm:asm` from 9.7 to 9.7.1
   
   Updates `org.ow2.asm:asm-commons` from 9.7 to 9.7.1
   
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump org.codehaus.plexus:plexus-xml from 3.0.1 to 4.0.4 [maven-resolver]

2024-10-13 Thread via GitHub


dependabot[bot] opened a new pull request, #582:
URL: https://github.com/apache/maven-resolver/pull/582

   Bumps 
[org.codehaus.plexus:plexus-xml](https://github.com/codehaus-plexus/plexus-xml) 
from 3.0.1 to 4.0.4.
   
   Release notes
   Sourced from https://github.com/codehaus-plexus/plexus-xml/releases";>org.codehaus.plexus:plexus-xml's
 releases.
   
   4.0.4
   
   🐛 Bug Fixes
   
   Allow nulls for write elements in MXSerializer (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/29";>#29) 
https://github.com/garydgregory";>@​garydgregory
   Remove special chars from xml output (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/28";>#28) 
https://github.com/slawekjaranowski";>@​slawekjaranowski
   
   📦 Dependency updates
   
   Bump org.codehaus.plexus:plexus from 17 to 18 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/39";>#39) 
https://github.com/dependabot";>@​dependabot
   Bump org.codehaus.plexus:plexus from 16 to 17 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/35";>#35) 
https://github.com/dependabot";>@​dependabot
   Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/37";>#37) 
https://github.com/dependabot";>@​dependabot
   Bump release-drafter/release-drafter from 5 to 6 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/34";>#34) 
https://github.com/dependabot";>@​dependabot
   
   4.0.3
   What's Changed
   
   explain 3 vs 4 by https://github.com/hboutemy";>@​hboutemy in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/24";>codehaus-plexus/plexus-xml#24
   Update dependencies by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/26";>codehaus-plexus/plexus-xml#26
   Upgrade to Maven 4.0.0-alpha-9 by https://github.com/gnodet";>@​gnodet in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/27";>codehaus-plexus/plexus-xml#27
   
   New Contributors
   
   https://github.com/cstamas";>@​cstamas made 
their first contribution in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/26";>codehaus-plexus/plexus-xml#26
   
   Full Changelog: https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.2...plexus-xml-4.0.3";>https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.2...plexus-xml-4.0.3
   4.0.2
   What's Changed
   
   Cleanup after parent pom upgrade by https://github.com/slachiewicz";>@​slachiewicz in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/22";>codehaus-plexus/plexus-xml#22
   Upgrade to 4.0.0-alpha-7 and exclude dependency to sisu (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/17";>#17)
 by https://github.com/gnodet";>@​gnodet in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/23";>codehaus-plexus/plexus-xml#23
   
   New Contributors
   
   https://github.com/slachiewicz";>@​slachiewicz 
made their first contribution in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/22";>codehaus-plexus/plexus-xml#22
   
   Full Changelog: https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.1...plexus-xml-4.0.2";>https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.1...plexus-xml-4.0.2
   4.0.0
   
   
   Use spotless (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/8";>#8) https://github.com/gnodet";>@​gnodet
   Fix site generation (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/15";>#15) 
https://github.com/gnodet";>@​gnodet
   Switch build ci workflow to master branch (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/14";>#14) 
https://github.com/gnodet";>@​gnodet
   Fix SCM urls (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/13";>#13) 
https://github.com/gnodet";>@​gnodet
   MXParser tokenization fails when PI is before first tag (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/7";>#7) 
(https://redirect.github.com/codehaus-plexus/plexus-xml/pull/12";>#12) 
https://github.com/gnodet";>@​gnodet
   Deprecate Xpp3DomUtils (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/6";>#6) 
(https://redirect.github.com/codehaus-plexus/plexus-xml/pull/9";>#9) https://github.com/gnodet";>@​gnodet
   Use a ArrayDeque (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/5";>#5) https://github.com/gnodet";>@​gnodet
   Upgrade plugins and clean build warnings (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/4";>#4) https://github.com/gnodet";>@​gnodet
   Switch to junit 5 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/2";>#2) https://github.com/gnodet";>@​gnodet
   Fix parsing an UTF-8 file without BOM and ISO-8859-1 encoding (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/1";>#1) https://github.com/gnodet";>@​gnodet
   
   
   
   
   Commits
   
   https://github.com/codehaus-plexus/plexus-xml/commit/f25521bc31d321c2ffb57cf26ae17f745c2c35a6";>f25521b

  1   2   >