hubertgrzeskowiak commented on code in PR #790:
URL: https://github.com/apache/maven-surefire/pull/790#discussion_r1798627583


##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java:
##########
@@ -84,12 +85,14 @@ public static RunResult toRunResult(File 
failsafeSummaryXml) throws Exception {
             String skipped = xpath.evaluate("/failsafe-summary/skipped", root);
             String failureMessage = 
xpath.evaluate("/failsafe-summary/failureMessage", root);
             String timeout = xpath.evaluate("/failsafe-summary/@timeout", 
root);
+            String flakes = xpath.evaluate("/failsafe-summary/flakes", root);

Review Comment:
   nit: would be better to move this two lines up, right under `skipped`. 
`completed`, `errors`, `failures` and `skipped` all belong to the same type of 
field as `flakes`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to