hubertgrzeskowiak commented on code in PR #790:
URL: https://github.com/apache/maven-surefire/pull/790#discussion_r1798627694
##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/util/FailsafeSummaryXmlUtils.java:
##########
@@ -84,12 +85,14 @@ public static RunResult toRunResult(File
failsafeSummaryXml) throws Exception {
String skipped = xpath.evaluate("/failsafe-summary/skipped", root);
String failureMessage =
xpath.evaluate("/failsafe-summary/failureMessage", root);
String timeout = xpath.evaluate("/failsafe-summary/@timeout",
root);
+ String flakes = xpath.evaluate("/failsafe-summary/flakes", root);
return new RunResult(
parseInt(completed),
parseInt(errors),
parseInt(failures),
parseInt(skipped),
+ isBlank(flakes) ? 0 : parseInt(flakes),
Review Comment:
nit: do you reckon it's worth adding a comment why we are treating this
differently, i.e. because of backward compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
