slawekjaranowski commented on code in PR #433:
URL:
https://github.com/apache/maven-dependency-plugin/pull/433#discussion_r1798476056
##########
src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java:
##########
@@ -228,11 +228,15 @@ public abstract class AbstractAnalyzeMojo extends
AbstractMojo {
* For example, <code>org.apache.*</code> will match all artifacts whose
group id starts with
* <code>org.apache.</code>, and <code>:::*-SNAPSHOT</code> will match all
snapshot artifacts.
* </p>
+ * <p>
+ * By default, org.slf4j:slf4j-simple is ignored. Setting this property to
an empty list
+ * will allow it to be detected.
+ * </p>
*
* @since 2.10
*/
@Parameter
- private String[] ignoredUnusedDeclaredDependencies = new String[0];
+ private String[] ignoredUnusedDeclaredDependencies =
{"org.slf4j:slf4j-simple::"};
Review Comment:
1. why not use a `default` option of parameter?
2. when user defined another ignores list it will be overridden ... maybe we
need add it latter to be always ignored ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]