[jira] [Commented] (MDEP-568) dependency:go-offline -DexcludeGroupIds=xxxx still try to resolve artifacts in the excluded group xxxx

[Fabrice Bacchella (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809834#comment-17809834
 ] 

Fabrice Bacchella commented on MDEP-568:


-DexcludeScope and -DexcludeArtifactIds are broken too. And configuring it in 
the pom doesn’t solve it either.

> dependency:go-offline -DexcludeGroupIds= still try to resolve artifacts 
> in the excluded group 
> --
>
> Key: MDEP-568
> URL: https://issues.apache.org/jira/browse/MDEP-568
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: go-offline, resolve
>Affects Versions: 2.3, 3.0.0
> Environment: windows / cygwin xp64 bit / bash / maven 3.0.3
>Reporter: Archimedes Trajano
>Priority: Major
> Attachments: MDEP-568-maven-dependency-plugin.patch, 
> go-offline_copy-dependencies_patch_sample.zip, test.tgz
>
>
> see thread: 
> http://mail-archives.apache.org/mod_mbox/maven-users/201109.mbox/%3c0B02C46601D44673A4A2DF4C4F907E9E@black%3e
> in attached sample pom structure:
> mvn org.apache.maven.plugins:maven-dependency-plugin:2.3:go-offline 
> -DexcludeGroupIds=us.pdinc.foo.maven.test
> fails



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MDEP-904) Drop go-offline goal

[Fabrice Bacchella (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809841#comment-17809841
 ] 

Fabrice Bacchella commented on MDEP-904:


That’s not the same thing.  Using quick build using -Dtest=void will compile. 
That’s not the purpose of go-offine that resolve the dependencies without 
building any thing.

> Drop go-offline goal
> 
>
> Key: MDEP-904
> URL: https://issues.apache.org/jira/browse/MDEP-904
> Project: Maven Dependency Plugin
>  Issue Type: Task
>  Components: go-offline
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0
>
>
> The simplest and trivial way to "go offline" is to quick build (using 
> {{-Dtest=void}} and NOT {{-DskipTests}}!) the project with empty local 
> repository and use that.
> There are two "go offline" mojos out there (ours and an independent one) and 
> both suffer from issues like "annotation processor is not downloaded", etc. 
> This will just become worse. But not only this: by NOT building but by 
> artificially collecting artifacts needed for build and resolving them (not 
> doable correctly, only "almost correctly") messes up the recorded contexts in 
> the reverse dependency tree in local repository as well.
> Remember, Maven2 times are past, Maven3+ local repository is much much more 
> than Maven2 local repository was, just a bunch a files...
> Related issues:
> * https://issues.apache.org/jira/browse/MRESOLVER-262
> * https://issues.apache.org/jira/browse/MNG-7619



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MRESOLVER-467] Pull out shared HTTP stuff [maven-resolver]

[via GitHub]

michael-o commented on code in PR #410:
URL: https://github.com/apache/maven-resolver/pull/410#discussion_r1462965681


##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/transport/http/DefaultChecksumExtractor.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.internal.impl.transport.http;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.util.Map;
+import java.util.function.Function;
+
+import org.eclipse.aether.spi.connector.transport.http.ChecksumExtractor;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Checksum extractor.
+ */
+@Singleton
+@Named
+public final class DefaultChecksumExtractor implements ChecksumExtractor {
+private final Map strategies;

Review Comment:
   Why do you need this empty interface?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MRESOLVER-467) Pull out shared HTTP (Remote Included checksum) code

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809843#comment-17809843
 ] 

ASF GitHub Bot commented on MRESOLVER-467:
--

michael-o commented on code in PR #410:
URL: https://github.com/apache/maven-resolver/pull/410#discussion_r1462965681


##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/transport/http/DefaultChecksumExtractor.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.internal.impl.transport.http;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.util.Map;
+import java.util.function.Function;
+
+import org.eclipse.aether.spi.connector.transport.http.ChecksumExtractor;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Checksum extractor.
+ */
+@Singleton
+@Named
+public final class DefaultChecksumExtractor implements ChecksumExtractor {
+private final Map strategies;

Review Comment:
   Why do you need this empty interface?





> Pull out shared HTTP (Remote Included checksum) code
> 
>
> Key: MRESOLVER-467
> URL: https://issues.apache.org/jira/browse/MRESOLVER-467
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-7
>
>
> The logic for them is basically duplicated (triplicated) in all HTTP 
> transport implementations (apache, jdk, jetty).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MRESOLVER-467] Pull out shared HTTP stuff [maven-resolver]

[via GitHub]

cstamas commented on code in PR #410:
URL: https://github.com/apache/maven-resolver/pull/410#discussion_r1462975817


##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/transport/http/DefaultChecksumExtractor.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.internal.impl.transport.http;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.util.Map;
+import java.util.function.Function;
+
+import org.eclipse.aether.spi.connector.transport.http.ChecksumExtractor;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Checksum extractor.
+ */
+@Singleton
+@Named
+public final class DefaultChecksumExtractor implements ChecksumExtractor {
+private final Map strategies;

Review Comment:
   To distinguish component types, otherwise on inject it would be a loop -> 
failure (entry point would like to inject itself), hence using subtype. Also, 
later on, the Strategy interface MAY become different, while currently it does 
not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MRESOLVER-467) Pull out shared HTTP (Remote Included checksum) code

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809846#comment-17809846
 ] 

ASF GitHub Bot commented on MRESOLVER-467:
--

cstamas commented on code in PR #410:
URL: https://github.com/apache/maven-resolver/pull/410#discussion_r1462975817


##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/transport/http/DefaultChecksumExtractor.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.internal.impl.transport.http;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.util.Map;
+import java.util.function.Function;
+
+import org.eclipse.aether.spi.connector.transport.http.ChecksumExtractor;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Checksum extractor.
+ */
+@Singleton
+@Named
+public final class DefaultChecksumExtractor implements ChecksumExtractor {
+private final Map strategies;

Review Comment:
   To distinguish component types, otherwise on inject it would be a loop -> 
failure (entry point would like to inject itself), hence using subtype. Also, 
later on, the Strategy interface MAY become different, while currently it does 
not.





> Pull out shared HTTP (Remote Included checksum) code
> 
>
> Key: MRESOLVER-467
> URL: https://issues.apache.org/jira/browse/MRESOLVER-467
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-7
>
>
> The logic for them is basically duplicated (triplicated) in all HTTP 
> transport implementations (apache, jdk, jetty).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MNG-8023] New method + javadoc on Project [maven]

[via GitHub]

cstamas commented on PR #1387:
URL: https://github.com/apache/maven/pull/1387#issuecomment-1905649823

   Superseded by https://github.com/apache/maven/pull/1389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-8023) New method for project artifacts

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-8023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809847#comment-17809847
 ] 

ASF GitHub Bot commented on MNG-8023:
-

cstamas commented on PR #1387:
URL: https://github.com/apache/maven/pull/1387#issuecomment-1905649823

   Superseded by https://github.com/apache/maven/pull/1389




> New method for project artifacts
> 
>
> Key: MNG-8023
> URL: https://issues.apache.org/jira/browse/MNG-8023
> Project: Maven
>  Issue Type: Task
>  Components: API
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Introduce a new method on API Project object that exposes "main artifacts" of 
> project. The method can return 1 or 2 artifacts (never less than 1 and never 
> more than 2). These are NOT the attached artifacts! (see ProjectManager for 
> that).
> In short: projects with packaging "pom", "bom" (that produce only one 
> artifact) will on this method return 1 artifact, while projects for example 
> with packaging "jar" will return 2 artifacts (as they produce, install, 
> deploy two artifacts, the POM and the JAR/WAR/etc).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MDEP-904) Drop go-offline goal

[Slawomir Jaranowski (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809856#comment-17809856
 ] 

Slawomir Jaranowski commented on MDEP-904:
--

Mojo should be fixed instead of removing

> Drop go-offline goal
> 
>
> Key: MDEP-904
> URL: https://issues.apache.org/jira/browse/MDEP-904
> Project: Maven Dependency Plugin
>  Issue Type: Task
>  Components: go-offline
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0
>
>
> The simplest and trivial way to "go offline" is to quick build (using 
> {{-Dtest=void}} and NOT {{-DskipTests}}!) the project with empty local 
> repository and use that.
> There are two "go offline" mojos out there (ours and an independent one) and 
> both suffer from issues like "annotation processor is not downloaded", etc. 
> This will just become worse. But not only this: by NOT building but by 
> artificially collecting artifacts needed for build and resolving them (not 
> doable correctly, only "almost correctly") messes up the recorded contexts in 
> the reverse dependency tree in local repository as well.
> Remember, Maven2 times are past, Maven3+ local repository is much much more 
> than Maven2 local repository was, just a bunch a files...
> Related issues:
> * https://issues.apache.org/jira/browse/MRESOLVER-262
> * https://issues.apache.org/jira/browse/MNG-7619



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MDEP-904) Drop go-offline goal

[Tamas Cservenak (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809860#comment-17809860
 ] 

Tamas Cservenak commented on MDEP-904:
--

Mojo cannot be fixed, see related issues.

> Drop go-offline goal
> 
>
> Key: MDEP-904
> URL: https://issues.apache.org/jira/browse/MDEP-904
> Project: Maven Dependency Plugin
>  Issue Type: Task
>  Components: go-offline
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0
>
>
> The simplest and trivial way to "go offline" is to quick build (using 
> {{-Dtest=void}} and NOT {{-DskipTests}}!) the project with empty local 
> repository and use that.
> There are two "go offline" mojos out there (ours and an independent one) and 
> both suffer from issues like "annotation processor is not downloaded", etc. 
> This will just become worse. But not only this: by NOT building but by 
> artificially collecting artifacts needed for build and resolving them (not 
> doable correctly, only "almost correctly") messes up the recorded contexts in 
> the reverse dependency tree in local repository as well.
> Remember, Maven2 times are past, Maven3+ local repository is much much more 
> than Maven2 local repository was, just a bunch a files...
> Related issues:
> * https://issues.apache.org/jira/browse/MRESOLVER-262
> * https://issues.apache.org/jira/browse/MNG-7619



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Comment Edited] (MDEP-904) Drop go-offline goal

[Tamas Cservenak (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809860#comment-17809860
 ] 

Tamas Cservenak edited comment on MDEP-904 at 1/23/24 10:03 AM:


Mojo cannot be fixed, see related issues. This whole concept comes from Maven2.


was (Author: cstamas):
Mojo cannot be fixed, see related issues.

> Drop go-offline goal
> 
>
> Key: MDEP-904
> URL: https://issues.apache.org/jira/browse/MDEP-904
> Project: Maven Dependency Plugin
>  Issue Type: Task
>  Components: go-offline
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0
>
>
> The simplest and trivial way to "go offline" is to quick build (using 
> {{-Dtest=void}} and NOT {{-DskipTests}}!) the project with empty local 
> repository and use that.
> There are two "go offline" mojos out there (ours and an independent one) and 
> both suffer from issues like "annotation processor is not downloaded", etc. 
> This will just become worse. But not only this: by NOT building but by 
> artificially collecting artifacts needed for build and resolving them (not 
> doable correctly, only "almost correctly") messes up the recorded contexts in 
> the reverse dependency tree in local repository as well.
> Remember, Maven2 times are past, Maven3+ local repository is much much more 
> than Maven2 local repository was, just a bunch a files...
> Related issues:
> * https://issues.apache.org/jira/browse/MRESOLVER-262
> * https://issues.apache.org/jira/browse/MNG-7619



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MDEP-904) Drop go-offline goal

[Tamas Cservenak (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809861#comment-17809861
 ] 

Tamas Cservenak commented on MDEP-904:
--

[~fbacchella] Well, "same thing" I assume is "local repository is primed", at 
least that is the intent of this goal, no? Why is it a problem for you? Or 
could you also skip compiler maybe?

> Drop go-offline goal
> 
>
> Key: MDEP-904
> URL: https://issues.apache.org/jira/browse/MDEP-904
> Project: Maven Dependency Plugin
>  Issue Type: Task
>  Components: go-offline
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0
>
>
> The simplest and trivial way to "go offline" is to quick build (using 
> {{-Dtest=void}} and NOT {{-DskipTests}}!) the project with empty local 
> repository and use that.
> There are two "go offline" mojos out there (ours and an independent one) and 
> both suffer from issues like "annotation processor is not downloaded", etc. 
> This will just become worse. But not only this: by NOT building but by 
> artificially collecting artifacts needed for build and resolving them (not 
> doable correctly, only "almost correctly") messes up the recorded contexts in 
> the reverse dependency tree in local repository as well.
> Remember, Maven2 times are past, Maven3+ local repository is much much more 
> than Maven2 local repository was, just a bunch a files...
> Related issues:
> * https://issues.apache.org/jira/browse/MRESOLVER-262
> * https://issues.apache.org/jira/browse/MNG-7619



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MPLUGIN-507) NPE during plugin run in Creadur RAT to generate mojo descriptor / worked in versions before 3.11.0

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MPLUGIN-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809863#comment-17809863
 ] 

Michael Osipov commented on MPLUGIN-507:


Does it work with Maven 3.8.x?

> NPE during plugin run in Creadur RAT to generate mojo descriptor / worked in 
> versions before 3.11.0
> ---
>
> Key: MPLUGIN-507
> URL: https://issues.apache.org/jira/browse/MPLUGIN-507
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-annotations
>Affects Versions: 3.11.0
>Reporter: Philipp Ottlinger
>Priority: Major
>
> While working on broken links via RAT-353 I realized after adding the new 
> maven-plugin-report-plugin a NPE breaks the build and no site-related pages 
> are generated.
> {code:java}
> Exception -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-cli) on 
> project apache-rat-plugin: Error generating 
> maven-plugin-report-plugin:3.11.0:report report
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:336)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:318)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:74)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> at 
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:107)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:60)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:126)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:223)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:148)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:958)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:205)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating 
> maven-plugin-report-plugin:3.11.0:report report
> at 
> org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:153)
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:144)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:330)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:318)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:74)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> at 
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:107)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.

Re: [PR] [MJLINK-75] create reproducible zip archive [maven-jlink-plugin]

[via GitHub]

hboutemy commented on code in PR #190:
URL: 
https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1463034499


##
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##
@@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File 
outputDirectory, File outputDirector
 throws MojoExecutionException {
 zipArchiver.addDirectory(outputDirectoryImage);
 
+// configure for Reproducible Builds based on outputTimestamp value
+Date lastModified = new 
MavenArchiver().parseOutputTimestamp(outputTimestamp);
+if (lastModified != null) {
+zipArchiver.configureReproducible(lastModified);
+}

Review Comment:
   because here it a method for Plexus Archiver, while in maven-rar-plugin it's 
a Maven Archiver (that only works on jars)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MJLINK-75) Reproducibility of ZIP artifacts

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809865#comment-17809865
 ] 

ASF GitHub Bot commented on MJLINK-75:
--

hboutemy commented on code in PR #190:
URL: 
https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1463034499


##
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##
@@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File 
outputDirectory, File outputDirector
 throws MojoExecutionException {
 zipArchiver.addDirectory(outputDirectoryImage);
 
+// configure for Reproducible Builds based on outputTimestamp value
+Date lastModified = new 
MavenArchiver().parseOutputTimestamp(outputTimestamp);
+if (lastModified != null) {
+zipArchiver.configureReproducible(lastModified);
+}

Review Comment:
   because here it a method for Plexus Archiver, while in maven-rar-plugin it's 
a Maven Archiver (that only works on jars)





> Reproducibility of ZIP artifacts
> 
>
> Key: MJLINK-75
> URL: https://issues.apache.org/jira/browse/MJLINK-75
> Project: Maven JLink Plugin
>  Issue Type: New Feature
>Affects Versions: 3.1.0
>Reporter: Piotr Karwasz
>Assignee: Herve Boutemy
>Priority: Minor
> Fix For: 3.2.0
>
>
> The artifacts produced by this plugin do not use the 
> {{'project.build.outputTimestamp'}} property for the ZIP file entries and 
> therefore are not reproducible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MJLINK-75] create reproducible zip archive [maven-jlink-plugin]

[via GitHub]

hboutemy commented on code in PR #190:
URL: 
https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1463035542


##
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##
@@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File 
outputDirectory, File outputDirector
 throws MojoExecutionException {
 zipArchiver.addDirectory(outputDirectoryImage);
 
+// configure for Reproducible Builds based on outputTimestamp value
+Date lastModified = new 
MavenArchiver().parseOutputTimestamp(outputTimestamp);
+if (lastModified != null) {

Review Comment:
   in jlink, it's a zip, not a jar, then there are no MANIFEST.MF metadata



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MJLINK-75) Reproducibility of ZIP artifacts

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809867#comment-17809867
 ] 

ASF GitHub Bot commented on MJLINK-75:
--

hboutemy commented on code in PR #190:
URL: 
https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1463035542


##
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##
@@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File 
outputDirectory, File outputDirector
 throws MojoExecutionException {
 zipArchiver.addDirectory(outputDirectoryImage);
 
+// configure for Reproducible Builds based on outputTimestamp value
+Date lastModified = new 
MavenArchiver().parseOutputTimestamp(outputTimestamp);
+if (lastModified != null) {

Review Comment:
   in jlink, it's a zip, not a jar, then there are no MANIFEST.MF metadata





> Reproducibility of ZIP artifacts
> 
>
> Key: MJLINK-75
> URL: https://issues.apache.org/jira/browse/MJLINK-75
> Project: Maven JLink Plugin
>  Issue Type: New Feature
>Affects Versions: 3.1.0
>Reporter: Piotr Karwasz
>Assignee: Herve Boutemy
>Priority: Minor
> Fix For: 3.2.0
>
>
> The artifacts produced by this plugin do not use the 
> {{'project.build.outputTimestamp'}} property for the ZIP file entries and 
> therefore are not reproducible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MDEP-904) Drop go-offline goal

[Fabrice Bacchella (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809866#comment-17809866
 ] 

Fabrice Bacchella commented on MDEP-904:


When doing build on CI tools, I like to separate steps that resolve 
dependencies from step that builds and step that run tests, it make 
understanding problems easier, as maven resolving dependencies is very verbose. 
To do the same things without go-offline, I will needs something like “mvn test 
-Dmaven.test.skip=true -Dmaven.main.skip=true” but that will not be enough.
So both solutions are broken, which one is the least broken ?

> Drop go-offline goal
> 
>
> Key: MDEP-904
> URL: https://issues.apache.org/jira/browse/MDEP-904
> Project: Maven Dependency Plugin
>  Issue Type: Task
>  Components: go-offline
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0
>
>
> The simplest and trivial way to "go offline" is to quick build (using 
> {{-Dtest=void}} and NOT {{-DskipTests}}!) the project with empty local 
> repository and use that.
> There are two "go offline" mojos out there (ours and an independent one) and 
> both suffer from issues like "annotation processor is not downloaded", etc. 
> This will just become worse. But not only this: by NOT building but by 
> artificially collecting artifacts needed for build and resolving them (not 
> doable correctly, only "almost correctly") messes up the recorded contexts in 
> the reverse dependency tree in local repository as well.
> Remember, Maven2 times are past, Maven3+ local repository is much much more 
> than Maven2 local repository was, just a bunch a files...
> Related issues:
> * https://issues.apache.org/jira/browse/MRESOLVER-262
> * https://issues.apache.org/jira/browse/MNG-7619



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MJLINK-75] create reproducible zip archive [maven-jlink-plugin]

[via GitHub]

hboutemy commented on code in PR #190:
URL: 
https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1463034499


##
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##
@@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File 
outputDirectory, File outputDirector
 throws MojoExecutionException {
 zipArchiver.addDirectory(outputDirectoryImage);
 
+// configure for Reproducible Builds based on outputTimestamp value
+Date lastModified = new 
MavenArchiver().parseOutputTimestamp(outputTimestamp);
+if (lastModified != null) {
+zipArchiver.configureReproducible(lastModified);
+}

Review Comment:
   because here it's a method for Plexus Archiver, while in maven-rar-plugin 
it's Maven Archiver (that only works on jars)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MJLINK-75) Reproducibility of ZIP artifacts

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809868#comment-17809868
 ] 

ASF GitHub Bot commented on MJLINK-75:
--

hboutemy commented on code in PR #190:
URL: 
https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1463034499


##
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##
@@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File 
outputDirectory, File outputDirector
 throws MojoExecutionException {
 zipArchiver.addDirectory(outputDirectoryImage);
 
+// configure for Reproducible Builds based on outputTimestamp value
+Date lastModified = new 
MavenArchiver().parseOutputTimestamp(outputTimestamp);
+if (lastModified != null) {
+zipArchiver.configureReproducible(lastModified);
+}

Review Comment:
   because here it's a method for Plexus Archiver, while in maven-rar-plugin 
it's Maven Archiver (that only works on jars)





> Reproducibility of ZIP artifacts
> 
>
> Key: MJLINK-75
> URL: https://issues.apache.org/jira/browse/MJLINK-75
> Project: Maven JLink Plugin
>  Issue Type: New Feature
>Affects Versions: 3.1.0
>Reporter: Piotr Karwasz
>Assignee: Herve Boutemy
>Priority: Minor
> Fix For: 3.2.0
>
>
> The artifacts produced by this plugin do not use the 
> {{'project.build.outputTimestamp'}} property for the ZIP file entries and 
> therefore are not reproducible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MDEP-904) Drop go-offline goal

[Tamas Cservenak (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809871#comment-17809871
 ] 

Tamas Cservenak commented on MDEP-904:
--

Well, IF the problem is that "maven resolving is too verbose" (if I see 
correctly),  then it may need some totally different solution, like this?

https://github.com/apache/maven/pull/1238

> Drop go-offline goal
> 
>
> Key: MDEP-904
> URL: https://issues.apache.org/jira/browse/MDEP-904
> Project: Maven Dependency Plugin
>  Issue Type: Task
>  Components: go-offline
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0
>
>
> The simplest and trivial way to "go offline" is to quick build (using 
> {{-Dtest=void}} and NOT {{-DskipTests}}!) the project with empty local 
> repository and use that.
> There are two "go offline" mojos out there (ours and an independent one) and 
> both suffer from issues like "annotation processor is not downloaded", etc. 
> This will just become worse. But not only this: by NOT building but by 
> artificially collecting artifacts needed for build and resolving them (not 
> doable correctly, only "almost correctly") messes up the recorded contexts in 
> the reverse dependency tree in local repository as well.
> Remember, Maven2 times are past, Maven3+ local repository is much much more 
> than Maven2 local repository was, just a bunch a files...
> Related issues:
> * https://issues.apache.org/jira/browse/MRESOLVER-262
> * https://issues.apache.org/jira/browse/MNG-7619



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MRESOLVER-467] Pull out shared HTTP stuff [maven-resolver]

[via GitHub]

cstamas commented on code in PR #410:
URL: https://github.com/apache/maven-resolver/pull/410#discussion_r1463053485


##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/transport/http/DefaultChecksumExtractor.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.internal.impl.transport.http;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.util.Map;
+import java.util.function.Function;
+
+import org.eclipse.aether.spi.connector.transport.http.ChecksumExtractor;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Checksum extractor.
+ */
+@Singleton
+@Named
+public final class DefaultChecksumExtractor implements ChecksumExtractor {
+private final Map strategies;

Review Comment:
   You are right, separated them out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MRESOLVER-467) Pull out shared HTTP (Remote Included checksum) code

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809873#comment-17809873
 ] 

ASF GitHub Bot commented on MRESOLVER-467:
--

cstamas commented on code in PR #410:
URL: https://github.com/apache/maven-resolver/pull/410#discussion_r1463053485


##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/transport/http/DefaultChecksumExtractor.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.internal.impl.transport.http;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.util.Map;
+import java.util.function.Function;
+
+import org.eclipse.aether.spi.connector.transport.http.ChecksumExtractor;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Checksum extractor.
+ */
+@Singleton
+@Named
+public final class DefaultChecksumExtractor implements ChecksumExtractor {
+private final Map strategies;

Review Comment:
   You are right, separated them out.





> Pull out shared HTTP (Remote Included checksum) code
> 
>
> Key: MRESOLVER-467
> URL: https://issues.apache.org/jira/browse/MRESOLVER-467
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-7
>
>
> The logic for them is basically duplicated (triplicated) in all HTTP 
> transport implementations (apache, jdk, jetty).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (MRESOLVER-469) Upgrade to Maven 4.0.0-alpha-12

[Tamas Cservenak (Jira)]

Tamas Cservenak created MRESOLVER-469:
-

 Summary: Upgrade to Maven 4.0.0-alpha-12
 Key: MRESOLVER-469
 URL: https://issues.apache.org/jira/browse/MRESOLVER-469
 Project: Maven Resolver
  Issue Type: Dependency upgrade
  Components: Resolver
Reporter: Tamas Cservenak
 Fix For: 2.0.0, 2.0.0-alpha-7


Use latest Maven 4.0.0-alpha-12



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (MNG-8025) API incompatibility with m-remote-resources-p

[Guillaume Nodet (Jira)]

Guillaume Nodet created MNG-8025:


 Summary: API incompatibility with m-remote-resources-p
 Key: MNG-8025
 URL: https://issues.apache.org/jira/browse/MNG-8025
 Project: Maven
  Issue Type: Improvement
Affects Versions: 4.0.0-alpha-12
Reporter: Guillaume Nodet


{code:java}
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process (default) 
on project sshd: Execution default of goal 
org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process failed: An 
API incompatibility was encountered while executing 
org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process: 
java.lang.NoSuchMethodError: 'void 
org.apache.maven.model.Plugin.unsetInheritanceApplied()'
[ERROR] -
[ERROR] realm =    
plugin>org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
 {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MNG-8025) API incompatibility with m-remote-resources-p

[Guillaume Nodet (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-8025:
-
Issue Type: Bug  (was: Improvement)

> API incompatibility with m-remote-resources-p
> -
>
> Key: MNG-8025
> URL: https://issues.apache.org/jira/browse/MNG-8025
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 4.0.0-alpha-12
>Reporter: Guillaume Nodet
>Priority: Major
>
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process 
> (default) on project sshd: Execution default of goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process failed: 
> An API incompatibility was encountered while executing 
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process: 
> java.lang.NoSuchMethodError: 'void 
> org.apache.maven.model.Plugin.unsetInheritanceApplied()'
> [ERROR] -
> [ERROR] realm =    
> plugin>org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MNG-8025) API incompatibility with m-remote-resources-p

[Guillaume Nodet (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-8025:
-
Fix Version/s: 4.0.x-candidate

> API incompatibility with m-remote-resources-p
> -
>
> Key: MNG-8025
> URL: https://issues.apache.org/jira/browse/MNG-8025
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 4.0.0-alpha-12
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process 
> (default) on project sshd: Execution default of goal 
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process failed: 
> An API incompatibility was encountered while executing 
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0:process: 
> java.lang.NoSuchMethodError: 'void 
> org.apache.maven.model.Plugin.unsetInheritanceApplied()'
> [ERROR] -
> [ERROR] realm =    
> plugin>org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MPLUGIN-507) NPE during plugin run in Creadur RAT to generate mojo descriptor / worked in versions before 3.11.0

[Philipp Ottlinger (Jira)]

[ 
https://issues.apache.org/jira/browse/MPLUGIN-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809895#comment-17809895
 ] 

Philipp Ottlinger commented on MPLUGIN-507:
---

[~michael-o] Thanks for pointing me in the right direction - this seems to be a 
Maven 4.x problem. Build runs through with Maven 3.9.6 and the files are 
properly generated. I will change the bug's description accordingly.

> NPE during plugin run in Creadur RAT to generate mojo descriptor / worked in 
> versions before 3.11.0
> ---
>
> Key: MPLUGIN-507
> URL: https://issues.apache.org/jira/browse/MPLUGIN-507
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-annotations
>Affects Versions: 3.11.0
>Reporter: Philipp Ottlinger
>Priority: Major
>
> While working on broken links via RAT-353 I realized after adding the new 
> maven-plugin-report-plugin a NPE breaks the build and no site-related pages 
> are generated.
> {code:java}
> Exception -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-cli) on 
> project apache-rat-plugin: Error generating 
> maven-plugin-report-plugin:3.11.0:report report
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:336)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:318)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:74)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> at 
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:107)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:60)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:126)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:223)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:148)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:958)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:205)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating 
> maven-plugin-report-plugin:3.11.0:report report
> at 
> org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:153)
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:144)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:330)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:318)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:74)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> at 
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilde

[jira] [Updated] (MPLUGIN-507) NPE during plugin run in Creadur RAT to generate mojo descriptor - only Maven 4.x-related

[Philipp Ottlinger (Jira)]

 [ 
https://issues.apache.org/jira/browse/MPLUGIN-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philipp Ottlinger updated MPLUGIN-507:
--
Summary: NPE during plugin run in Creadur RAT to generate mojo descriptor - 
only Maven 4.x-related  (was: NPE during plugin run in Creadur RAT to generate 
mojo descriptor / worked in versions before 3.11.0)

> NPE during plugin run in Creadur RAT to generate mojo descriptor - only Maven 
> 4.x-related
> -
>
> Key: MPLUGIN-507
> URL: https://issues.apache.org/jira/browse/MPLUGIN-507
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-annotations
>Affects Versions: 3.11.0
>Reporter: Philipp Ottlinger
>Priority: Major
>
> While working on broken links via RAT-353 I realized after adding the new 
> maven-plugin-report-plugin a NPE breaks the build and no site-related pages 
> are generated.
> {code:java}
> Exception -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-cli) on 
> project apache-rat-plugin: Error generating 
> maven-plugin-report-plugin:3.11.0:report report
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:336)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:318)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:74)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> at 
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:107)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:60)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:126)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:223)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:148)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:958)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:205)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating 
> maven-plugin-report-plugin:3.11.0:report report
> at 
> org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:153)
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:144)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:330)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:318)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:74)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> at 
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:107)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildP

[jira] [Commented] (MPLUGIN-507) NPE during plugin run in Creadur RAT to generate mojo descriptor - only Maven 4.x-related

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MPLUGIN-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809898#comment-17809898
 ] 

Michael Osipov commented on MPLUGIN-507:


Then, [~gnodet].

> NPE during plugin run in Creadur RAT to generate mojo descriptor - only Maven 
> 4.x-related
> -
>
> Key: MPLUGIN-507
> URL: https://issues.apache.org/jira/browse/MPLUGIN-507
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-annotations
>Affects Versions: 3.11.0
>Reporter: Philipp Ottlinger
>Priority: Major
>
> While working on broken links via RAT-353 I realized after adding the new 
> maven-plugin-report-plugin a NPE breaks the build and no site-related pages 
> are generated.
> {code:java}
> Exception -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-cli) on 
> project apache-rat-plugin: Error generating 
> maven-plugin-report-plugin:3.11.0:report report
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:336)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:318)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:74)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> at 
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:107)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:60)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:126)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:223)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:148)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:958)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:205)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating 
> maven-plugin-report-plugin:3.11.0:report report
> at 
> org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:153)
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:144)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:330)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:318)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:74)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> at 
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:107)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(Single

[jira] [Created] (MRESOLVER-470) Artifact properties should be used in opaque way

[Tamas Cservenak (Jira)]

Tamas Cservenak created MRESOLVER-470:
-

 Summary: Artifact properties should be used in opaque way
 Key: MRESOLVER-470
 URL: https://issues.apache.org/jira/browse/MRESOLVER-470
 Project: Maven Resolver
  Issue Type: Task
Reporter: Tamas Cservenak
 Fix For: 2.0.0, 2.0.0-alpha-7


Maybe just deprecate ctors that over simplify them?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] Fix documented output directory [maven-apache-parent]

[via GitHub]

kwin opened a new pull request, #192:
URL: https://github.com/apache/maven-apache-parent/pull/192

   Improve formatting, minor cleanup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MPLUGIN-507) NPE during plugin run in Creadur RAT to generate mojo descriptor - only Maven 4.x-related

[Tamas Cservenak (Jira)]

[ 
https://issues.apache.org/jira/browse/MPLUGIN-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809910#comment-17809910
 ] 

Tamas Cservenak commented on MPLUGIN-507:
-

Is fixed by https://issues.apache.org/jira/browse/MPLUGIN-508

> NPE during plugin run in Creadur RAT to generate mojo descriptor - only Maven 
> 4.x-related
> -
>
> Key: MPLUGIN-507
> URL: https://issues.apache.org/jira/browse/MPLUGIN-507
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-annotations
>Affects Versions: 3.11.0
>Reporter: Philipp Ottlinger
>Priority: Major
>
> While working on broken links via RAT-353 I realized after adding the new 
> maven-plugin-report-plugin a NPE breaks the build and no site-related pages 
> are generated.
> {code:java}
> Exception -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-cli) on 
> project apache-rat-plugin: Error generating 
> maven-plugin-report-plugin:3.11.0:report report
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:336)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:318)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:74)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> at 
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:107)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:60)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:126)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:223)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:148)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:958)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:205)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
> at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating 
> maven-plugin-report-plugin:3.11.0:report report
> at 
> org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:153)
> at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:144)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:330)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:318)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:74)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> at 
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:107)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.si

[jira] [Commented] (MPLUGIN-507) NPE during plugin run in Creadur RAT to generate mojo descriptor - only Maven 4.x-related

[Tamas Cservenak (Jira)]

[ 
https://issues.apache.org/jira/browse/MPLUGIN-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809912#comment-17809912
 ] 

Tamas Cservenak commented on MPLUGIN-507:
-

Locally confirmed that PR built mpp works:
{noformat}
[INFO] 
--
[INFO] Reactor Summary for Apache Creadur Rat 0.16.1-SNAPSHOT:
[INFO] 
[INFO] Apache Creadur Rat 
...
 SUCCESS [  9.334 s]
[INFO] Apache Creadur Rat::Core 
. 
SUCCESS [  7.413 s]
[INFO] Apache Creadur Rat::Plugin4Maven 
. SUCCESS [ 
 9.531 s]
[INFO] Apache Creadur Rat::Tasks4Ant 
 
SUCCESS [  4.651 s]
[INFO] Apache Creadur Rat::Command Line 
. SUCCESS [ 
 2.955 s]
[INFO] 
--
[INFO] BUILD SUCCESS
[INFO] 
--
[INFO] Total time:  34.076 s
[INFO] Finished at: 2024-01-23T12:52:22+01:00
[INFO] 
--
[cstamas@angeleyes creadur-rat (master *)]$ mvn -v
Apache Maven 4.0.0-alpha-12 (e627879aedd8a0c1859e58a527852ae8de1b4878)
Maven home: /home/cstamas/.sdkman/candidates/maven/4.0.0-alpha-12
Java version: 21.0.1, vendor: Eclipse Adoptium, runtime: 
/home/cstamas/.sdkman/candidates/java/21.0.1-tem
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.6.12-200.fc39.x86_64", arch: "amd64", family: 
"unix"
[cstamas@angeleyes creadur-rat (master *)]$  {noformat}

> NPE during plugin run in Creadur RAT to generate mojo descriptor - only Maven 
> 4.x-related
> -
>
> Key: MPLUGIN-507
> URL: https://issues.apache.org/jira/browse/MPLUGIN-507
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: maven-plugin-annotations
>Affects Versions: 3.11.0
>Reporter: Philipp Ottlinger
>Priority: Major
>
> While working on broken links via RAT-353 I realized after adding the new 
> maven-plugin-report-plugin a NPE breaks the build and no site-related pages 
> are generated.
> {code:java}
> Exception -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-cli) on 
> project apache-rat-plugin: Error generating 
> maven-plugin-report-plugin:3.11.0:report report
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:336)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:318)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:175)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:74)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:163)
> at 
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:160)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:107)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:60)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:126)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:223)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:148)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:958)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:205)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMetho

Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-12 [maven-plugin-tools]

[via GitHub]

slawekjaranowski commented on code in PR #242:
URL: 
https://github.com/apache/maven-plugin-tools/pull/242#discussion_r1463162158


##
maven-plugin-plugin/src/it/beanshell-simple/pom.xml:
##
@@ -53,6 +53,7 @@
 maven-plugin-plugin
 ${pluginPluginVersion}
 
+  3.6.5

Review Comment:
   Maven version 3.6.5 is not exist ... last in 3.6.x is 3.6.3 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MPLUGIN-508) Upgrade to Maven 4.0.0-alpha-12

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MPLUGIN-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809915#comment-17809915
 ] 

ASF GitHub Bot commented on MPLUGIN-508:


slawekjaranowski commented on code in PR #242:
URL: 
https://github.com/apache/maven-plugin-tools/pull/242#discussion_r1463162158


##
maven-plugin-plugin/src/it/beanshell-simple/pom.xml:
##
@@ -53,6 +53,7 @@
 maven-plugin-plugin
 ${pluginPluginVersion}
 
+  3.6.5

Review Comment:
   Maven version 3.6.5 is not exist ... last in 3.6.x is 3.6.3 





> Upgrade to Maven 4.0.0-alpha-12
> ---
>
> Key: MPLUGIN-508
> URL: https://issues.apache.org/jira/browse/MPLUGIN-508
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.12.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MNG-8024] Make WrapperProperties and WrapperList serizalizable. [maven]

[via GitHub]

cstamas commented on PR #1388:
URL: https://github.com/apache/maven/pull/1388#issuecomment-1905890251

   Yes, that is exactly what is happening, the incremental build basically taks 
"bits" of model and would like to serialize those with DataOutputStream...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-8024) Maven4 models are not serializable, despite marked as such

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809917#comment-17809917
 ] 

ASF GitHub Bot commented on MNG-8024:
-

cstamas commented on PR #1388:
URL: https://github.com/apache/maven/pull/1388#issuecomment-1905890251

   Yes, that is exactly what is happening, the incremental build basically taks 
"bits" of model and would like to serialize those with DataOutputStream...




> Maven4 models are not serializable, despite marked as such
> --
>
> Key: MNG-8024
> URL: https://issues.apache.org/jira/browse/MNG-8024
> Project: Maven
>  Issue Type: Bug
>  Components: API
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Maven4 models are marked as {{{}Serializable{}}}, but they are not. Example:
> {noformat}
> Caused by: java.io.NotSerializableException: 
> org.apache.maven.model.ModelBase$$Lambda/0x7fd7ac284278
>     at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1200)
>     at 
> java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1585)
>     at 
> java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1542)
>     at 
> java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1451)
>     at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1194)
>     at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:358)
>     at 
> io.takari.incrementalbuild.spi.DefaultBuildContextState.writeMap(DefaultBuildContextState.java:126)
>     at 
> io.takari.incrementalbuild.spi.DefaultBuildContextState.storeTo(DefaultBuildContextState.java:109)
>     at 
> io.takari.incrementalbuild.spi.AbstractBuildContext.commit(AbstractBuildContext.java:525)
>     at 
> io.takari.incrementalbuild.maven.internal.MavenBuildContextFinalizer.afterMojoExecutionSuccess(MavenBuildContextFinalizer.java:83)
>     at 
> org.apache.maven.execution.scope.internal.MojoExecutionScope.afterMojoExecutionSuccess(MojoExecutionScope.java:129)
>     at 
> org.apache.maven.plugin.CompoundMojoExecutionListener.afterMojoExecutionSuccess(CompoundMojoExecutionListener.java:42)
> {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MNG-8023] New method + javadoc on Project [maven]

[via GitHub]

cstamas merged PR #1387:
URL: https://github.com/apache/maven/pull/1387


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-8023) New method for project artifacts

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-8023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809921#comment-17809921
 ] 

ASF GitHub Bot commented on MNG-8023:
-

cstamas merged PR #1387:
URL: https://github.com/apache/maven/pull/1387




> New method for project artifacts
> 
>
> Key: MNG-8023
> URL: https://issues.apache.org/jira/browse/MNG-8023
> Project: Maven
>  Issue Type: Task
>  Components: API
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Introduce a new method on API Project object that exposes "main artifacts" of 
> project. The method can return 1 or 2 artifacts (never less than 1 and never 
> more than 2). These are NOT the attached artifacts! (see ProjectManager for 
> that).
> In short: projects with packaging "pom", "bom" (that produce only one 
> artifact) will on this method return 1 artifact, while projects for example 
> with packaging "jar" will return 2 artifacts (as they produce, install, 
> deploy two artifacts, the POM and the JAR/WAR/etc).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (MNG-8023) New method for project artifacts

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-8023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MNG-8023.

Resolution: Fixed

> New method for project artifacts
> 
>
> Key: MNG-8023
> URL: https://issues.apache.org/jira/browse/MNG-8023
> Project: Maven
>  Issue Type: Task
>  Components: API
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Introduce a new method on API Project object that exposes "main artifacts" of 
> project. The method can return 1 or 2 artifacts (never less than 1 and never 
> more than 2). These are NOT the attached artifacts! (see ProjectManager for 
> that).
> In short: projects with packaging "pom", "bom" (that produce only one 
> artifact) will on this method return 1 artifact, while projects for example 
> with packaging "jar" will return 2 artifacts (as they produce, install, 
> deploy two artifacts, the POM and the JAR/WAR/etc).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] Fix documented output directory [maven-apache-parent]

[via GitHub]

slawekjaranowski commented on code in PR #192:
URL: 
https://github.com/apache/maven-apache-parent/pull/192#discussion_r1463175494


##
src/site-docs/apt/index.apt.vm:
##
@@ -136,27 +136,27 @@ The <<>> Profile
 If you want to avoid this default assembly execution to provide your own 
mechanism to produce the source release archive,
 you can disable the execution by configuring <<>> parameter 
for this <<>> execution id
 
- * maven-source-plugin: configured to build and attach a source jar.
+ * : configured to build and attach a source jar.
 
- * maven-javadoc-plugin: configured to build and attach a javadoc jar.
+ * : configured to build and attach a javadoc jar.
 
- * maven-gpg-plugin: configured to sign everything. It expects to find
+ * : configured to sign everything. It expects to find
 a passphrase in <<<$\{gpg.passphrase\}>>>, presumably in your 
<<>>.
 
- * checksum-maven-plugin: configured to create a checksum file(s) for source 
release as
+ * : configured to create a checksum file(s) for source 
release as
 required by 
{{{http://www.apache.org/dev/release-distribution#sigs-and-sums}Apache release 
distribution policy}}.
 
  []
 
-  When doing a release with maven-release-plugin, this creates files in 
<<>> ready
+  When doing a release with , this creates files in 
<<>> ready

Review Comment:
   Released files are in `target/checkout/target` in `target` we have current 
project snapshot version.
   So sentence was correct.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix documented output directory [maven-apache-parent]

[via GitHub]

kwin closed pull request #192: Fix documented output directory
URL: https://github.com/apache/maven-apache-parent/pull/192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix documented output directory [maven-apache-parent]

[via GitHub]

kwin commented on code in PR #192:
URL: 
https://github.com/apache/maven-apache-parent/pull/192#discussion_r1463194525


##
src/site-docs/apt/index.apt.vm:
##
@@ -136,27 +136,27 @@ The <<>> Profile
 If you want to avoid this default assembly execution to provide your own 
mechanism to produce the source release archive,
 you can disable the execution by configuring <<>> parameter 
for this <<>> execution id
 
- * maven-source-plugin: configured to build and attach a source jar.
+ * : configured to build and attach a source jar.
 
- * maven-javadoc-plugin: configured to build and attach a javadoc jar.
+ * : configured to build and attach a javadoc jar.
 
- * maven-gpg-plugin: configured to sign everything. It expects to find
+ * : configured to sign everything. It expects to find
 a passphrase in <<<$\{gpg.passphrase\}>>>, presumably in your 
<<>>.
 
- * checksum-maven-plugin: configured to create a checksum file(s) for source 
release as
+ * : configured to create a checksum file(s) for source 
release as
 required by 
{{{http://www.apache.org/dev/release-distribution#sigs-and-sums}Apache release 
distribution policy}}.
 
  []
 
-  When doing a release with maven-release-plugin, this creates files in 
<<>> ready
+  When doing a release with , this creates files in 
<<>> ready

Review Comment:
   You are right, this sentence refers only to releasing with m-r-p but not to 
the profile in general.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MRESOLVER-466] Site documentation updates [maven-resolver]

[via GitHub]

cstamas commented on code in PR #409:
URL: https://github.com/apache/maven-resolver/pull/409#discussion_r1463215080


##
src/site/markdown/common-misconceptions.md:
##
@@ -0,0 +1,204 @@
+# Common Misconceptions
+
+
+Due to smooth transitions from Maven2 into Maven3 (and soon
+Maven4), and the fact that Maven2 plugins kept working with Maven3, maybe
+even without change, there were some misconceptions crept in 
+as well. Despite the marvel of "compatibility", Maven3 resolution
+differs quite much from Maven2, and the sole reason is actual improvement
+in area of resolution, it became much more precise (and, due
+that lost some "bad" habits present in Maven2). Here, we will try to
+enumerate some of the most common misconceptions.
+
+## Misconception No1: How Resolver Works
+
+(Simplified)
+
+The most typical use case for Resolver is to "resolve transitively" 
+dependencies. Resolver, to achieve this, internally (but these are
+exposed via API as distinguished API calls as well) performs 3 steps:
+"collect", "transform" and "resolve".
+
+The "collect" step is first, where it builds the "dirty tree" (dirty graph)
+of artifacts. It is important to remark, that in "collect" step, while 
+the graph is being built, Maven uses only POMs. Hence, if collecting an 
+Artifact that was never downloaded to your local repository, it will 
+download **the POMs only**. Using POMs resolver is able to build current 
+"node" of graph, but also figure outgoing vertices and adjacent nodes of 
+current node and so on. Which dependency is chosen to continue with from
+the current node POM is decided by various criteria (configured).
+
+The "transform" step transforms the "dirty graph": this is where conflict 
resolution
+happens. It is here when resolver applies various rules to resolve conflicting 
+versions, conflicting scopes, and so on. Here, if "verbose tree" is asked for,
+conflict resolution does not remove graph nodes, merely marks the conflicts
+and the conflict "winner". Thus, "verbose tree" cannot be resolved.
+
+Finally, the "resolve" step runs, when the (transformed) graph node artifacts
+are being resolved, basically ensuring (and downloading if needed) their 
+correspondent files (i.e. JAR files) are present in local repository.
+
+It is important to state, that in "collect" step happens the selection of nodes
+by various criteria, among other by the configured scope filters. And here we
+come to the notion of "runtime classpath" vs "test classpath". 
+
+In resolver, maybe un-intuitively, the "scope filter" is usually used (but 
does 
+not have to, this is just how it IS used in Maven Core, probably for historical
+reasons) as "what should be omitted". The default session filter in Maven 
+is set up as this:
+
+```
+  new ScopeDependencySelector("test", "provided")
+```
+
+This means, that "current dependency node" dependencies in "test" and 
"provided" scope
+will be simply omitted from the graph. In other words, this filter builds
+the "downstream runtime classpath" of supplied artifact (i.e. "what is needed 
by the 
+artifact at runtime when I depend on it").
+
+With selector like this:
+
+```
+  new ScopeDependencySelector("provided")
+```
+
+the "downstream dependency test classpath" would be built. Aside of giving 
example,
+this selector is actually never used, as "test classpath" makes sense only in 
the
+scope of "current project", but not for "downstream dependant projects".
+
+Note: these are NOT "Maven related" notions yet, there is nowhere Maven in 
picture here,
+and these are not the classpath used by Compiler or Surefire plugins, merely 
just
+a showcase how Resolver works.
+
+
+## Misconception No2: "Test classpath" Is Superset of "Runtime classpath"

Review Comment:
   ```suggestion
   ## Misconception No2: "Test classpath" Is Superset Of "Runtime classpath"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MRESOLVER-466) Extend site documentation

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809930#comment-17809930
 ] 

ASF GitHub Bot commented on MRESOLVER-466:
--

cstamas commented on code in PR #409:
URL: https://github.com/apache/maven-resolver/pull/409#discussion_r1463215080


##
src/site/markdown/common-misconceptions.md:
##
@@ -0,0 +1,204 @@
+# Common Misconceptions
+
+
+Due to smooth transitions from Maven2 into Maven3 (and soon
+Maven4), and the fact that Maven2 plugins kept working with Maven3, maybe
+even without change, there were some misconceptions crept in 
+as well. Despite the marvel of "compatibility", Maven3 resolution
+differs quite much from Maven2, and the sole reason is actual improvement
+in area of resolution, it became much more precise (and, due
+that lost some "bad" habits present in Maven2). Here, we will try to
+enumerate some of the most common misconceptions.
+
+## Misconception No1: How Resolver Works
+
+(Simplified)
+
+The most typical use case for Resolver is to "resolve transitively" 
+dependencies. Resolver, to achieve this, internally (but these are
+exposed via API as distinguished API calls as well) performs 3 steps:
+"collect", "transform" and "resolve".
+
+The "collect" step is first, where it builds the "dirty tree" (dirty graph)
+of artifacts. It is important to remark, that in "collect" step, while 
+the graph is being built, Maven uses only POMs. Hence, if collecting an 
+Artifact that was never downloaded to your local repository, it will 
+download **the POMs only**. Using POMs resolver is able to build current 
+"node" of graph, but also figure outgoing vertices and adjacent nodes of 
+current node and so on. Which dependency is chosen to continue with from
+the current node POM is decided by various criteria (configured).
+
+The "transform" step transforms the "dirty graph": this is where conflict 
resolution
+happens. It is here when resolver applies various rules to resolve conflicting 
+versions, conflicting scopes, and so on. Here, if "verbose tree" is asked for,
+conflict resolution does not remove graph nodes, merely marks the conflicts
+and the conflict "winner". Thus, "verbose tree" cannot be resolved.
+
+Finally, the "resolve" step runs, when the (transformed) graph node artifacts
+are being resolved, basically ensuring (and downloading if needed) their 
+correspondent files (i.e. JAR files) are present in local repository.
+
+It is important to state, that in "collect" step happens the selection of nodes
+by various criteria, among other by the configured scope filters. And here we
+come to the notion of "runtime classpath" vs "test classpath". 
+
+In resolver, maybe un-intuitively, the "scope filter" is usually used (but 
does 
+not have to, this is just how it IS used in Maven Core, probably for historical
+reasons) as "what should be omitted". The default session filter in Maven 
+is set up as this:
+
+```
+  new ScopeDependencySelector("test", "provided")
+```
+
+This means, that "current dependency node" dependencies in "test" and 
"provided" scope
+will be simply omitted from the graph. In other words, this filter builds
+the "downstream runtime classpath" of supplied artifact (i.e. "what is needed 
by the 
+artifact at runtime when I depend on it").
+
+With selector like this:
+
+```
+  new ScopeDependencySelector("provided")
+```
+
+the "downstream dependency test classpath" would be built. Aside of giving 
example,
+this selector is actually never used, as "test classpath" makes sense only in 
the
+scope of "current project", but not for "downstream dependant projects".
+
+Note: these are NOT "Maven related" notions yet, there is nowhere Maven in 
picture here,
+and these are not the classpath used by Compiler or Surefire plugins, merely 
just
+a showcase how Resolver works.
+
+
+## Misconception No2: "Test classpath" Is Superset of "Runtime classpath"

Review Comment:
   ```suggestion
   ## Misconception No2: "Test classpath" Is Superset Of "Runtime classpath"
   ```





> Extend site documentation
> -
>
> Key: MRESOLVER-466
> URL: https://issues.apache.org/jira/browse/MRESOLVER-466
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-7
>
>
> Add more details to site (RRF, Checksums, etc).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MNG-8024] Make WrapperProperties and WrapperList serizalizable. [maven]

[via GitHub]

gnodet commented on PR #1388:
URL: https://github.com/apache/maven/pull/1388#issuecomment-1906038901

   > Yes, that is exactly what is happening, the incremental build basically 
taks "bits" of model and would like to serialize those with DataOutputStream...
   
   I'm not sure we should support this use case, as I think the whole model 
will be serialised anyway.  The lambdas in the list/properties objects do 
retain a reference to the parent up to the Model.  This is needed in order to 
implement the modification methods while keeping the original reference.
   
   So while this may actually make things work, I'm not completely sure we 
should do it...  It may be easier to simplify check if there's a 
`getDelegate()` method, and if so, serialize that object instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-8024) Maven4 models are not serializable, despite marked as such

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809939#comment-17809939
 ] 

ASF GitHub Bot commented on MNG-8024:
-

gnodet commented on PR #1388:
URL: https://github.com/apache/maven/pull/1388#issuecomment-1906038901

   > Yes, that is exactly what is happening, the incremental build basically 
taks "bits" of model and would like to serialize those with DataOutputStream...
   
   I'm not sure we should support this use case, as I think the whole model 
will be serialised anyway.  The lambdas in the list/properties objects do 
retain a reference to the parent up to the Model.  This is needed in order to 
implement the modification methods while keeping the original reference.
   
   So while this may actually make things work, I'm not completely sure we 
should do it...  It may be easier to simplify check if there's a 
`getDelegate()` method, and if so, serialize that object instead.




> Maven4 models are not serializable, despite marked as such
> --
>
> Key: MNG-8024
> URL: https://issues.apache.org/jira/browse/MNG-8024
> Project: Maven
>  Issue Type: Bug
>  Components: API
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Maven4 models are marked as {{{}Serializable{}}}, but they are not. Example:
> {noformat}
> Caused by: java.io.NotSerializableException: 
> org.apache.maven.model.ModelBase$$Lambda/0x7fd7ac284278
>     at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1200)
>     at 
> java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1585)
>     at 
> java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1542)
>     at 
> java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1451)
>     at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1194)
>     at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:358)
>     at 
> io.takari.incrementalbuild.spi.DefaultBuildContextState.writeMap(DefaultBuildContextState.java:126)
>     at 
> io.takari.incrementalbuild.spi.DefaultBuildContextState.storeTo(DefaultBuildContextState.java:109)
>     at 
> io.takari.incrementalbuild.spi.AbstractBuildContext.commit(AbstractBuildContext.java:525)
>     at 
> io.takari.incrementalbuild.maven.internal.MavenBuildContextFinalizer.afterMojoExecutionSuccess(MavenBuildContextFinalizer.java:83)
>     at 
> org.apache.maven.execution.scope.internal.MojoExecutionScope.afterMojoExecutionSuccess(MojoExecutionScope.java:129)
>     at 
> org.apache.maven.plugin.CompoundMojoExecutionListener.afterMojoExecutionSuccess(CompoundMojoExecutionListener.java:42)
> {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MRESOLVER-470) Artifact properties should be used in opaque way

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-470:
--
Description: Just add them more space, like DefArtifact coord string ctor 
has no type assignment ability. Also, clear up some of the related classes.  
(was: Maybe just deprecate ctors that over simplify them?)

> Artifact properties should be used in opaque way
> 
>
> Key: MRESOLVER-470
> URL: https://issues.apache.org/jira/browse/MRESOLVER-470
> Project: Maven Resolver
>  Issue Type: Task
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-7
>
>
> Just add them more space, like DefArtifact coord string ctor has no type 
> assignment ability. Also, clear up some of the related classes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (MRESOLVER-470) Artifact properties should be used in opaque way

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MRESOLVER-470:
-

Assignee: Tamas Cservenak

> Artifact properties should be used in opaque way
> 
>
> Key: MRESOLVER-470
> URL: https://issues.apache.org/jira/browse/MRESOLVER-470
> Project: Maven Resolver
>  Issue Type: Task
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-7
>
>
> Maybe just deprecate ctors that over simplify them?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-12 [maven-plugin-tools]

[via GitHub]

gnodet commented on code in PR #242:
URL: 
https://github.com/apache/maven-plugin-tools/pull/242#discussion_r1463395796


##
maven-plugin-plugin/src/it/beanshell-simple/pom.xml:
##
@@ -53,6 +53,7 @@
 maven-plugin-plugin
 ${pluginPluginVersion}
 
+  3.6.5

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MPLUGIN-508) Upgrade to Maven 4.0.0-alpha-12

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MPLUGIN-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809976#comment-17809976
 ] 

ASF GitHub Bot commented on MPLUGIN-508:


gnodet commented on code in PR #242:
URL: 
https://github.com/apache/maven-plugin-tools/pull/242#discussion_r1463395796


##
maven-plugin-plugin/src/it/beanshell-simple/pom.xml:
##
@@ -53,6 +53,7 @@
 maven-plugin-plugin
 ${pluginPluginVersion}
 
+  3.6.5

Review Comment:
   Fixed





> Upgrade to Maven 4.0.0-alpha-12
> ---
>
> Key: MPLUGIN-508
> URL: https://issues.apache.org/jira/browse/MPLUGIN-508
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.12.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MNG-8024] Make WrapperProperties and WrapperList serizalizable. [maven]

[via GitHub]

gnodet commented on PR #1388:
URL: https://github.com/apache/maven/pull/1388#issuecomment-1906223854

   > > Yes, that is exactly what is happening, the incremental build basically 
taks "bits" of model and would like to serialize those with DataOutputStream...
   > 
   > I'm not sure we should support this use case, as I think the whole model 
will be serialised anyway. The lambdas in the list/properties objects do retain 
a reference to the parent up to the Model. This is needed in order to implement 
the modification methods while keeping the original reference.
   > 
   > So while this may actually make things work, I'm not completely sure we 
should do it... It may be easier to simplify check if there's a `getDelegate()` 
method, and if so, serialize that object instead.
   
   Another way would be to generate writeObject / readObject methods that will 
actually delegate to... the delegates from the v4 model.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-8024) Maven4 models are not serializable, despite marked as such

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809977#comment-17809977
 ] 

ASF GitHub Bot commented on MNG-8024:
-

gnodet commented on PR #1388:
URL: https://github.com/apache/maven/pull/1388#issuecomment-1906223854

   > > Yes, that is exactly what is happening, the incremental build basically 
taks "bits" of model and would like to serialize those with DataOutputStream...
   > 
   > I'm not sure we should support this use case, as I think the whole model 
will be serialised anyway. The lambdas in the list/properties objects do retain 
a reference to the parent up to the Model. This is needed in order to implement 
the modification methods while keeping the original reference.
   > 
   > So while this may actually make things work, I'm not completely sure we 
should do it... It may be easier to simplify check if there's a `getDelegate()` 
method, and if so, serialize that object instead.
   
   Another way would be to generate writeObject / readObject methods that will 
actually delegate to... the delegates from the v4 model.




> Maven4 models are not serializable, despite marked as such
> --
>
> Key: MNG-8024
> URL: https://issues.apache.org/jira/browse/MNG-8024
> Project: Maven
>  Issue Type: Bug
>  Components: API
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-13
>
>
> Maven4 models are marked as {{{}Serializable{}}}, but they are not. Example:
> {noformat}
> Caused by: java.io.NotSerializableException: 
> org.apache.maven.model.ModelBase$$Lambda/0x7fd7ac284278
>     at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1200)
>     at 
> java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1585)
>     at 
> java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1542)
>     at 
> java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1451)
>     at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1194)
>     at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:358)
>     at 
> io.takari.incrementalbuild.spi.DefaultBuildContextState.writeMap(DefaultBuildContextState.java:126)
>     at 
> io.takari.incrementalbuild.spi.DefaultBuildContextState.storeTo(DefaultBuildContextState.java:109)
>     at 
> io.takari.incrementalbuild.spi.AbstractBuildContext.commit(AbstractBuildContext.java:525)
>     at 
> io.takari.incrementalbuild.maven.internal.MavenBuildContextFinalizer.afterMojoExecutionSuccess(MavenBuildContextFinalizer.java:83)
>     at 
> org.apache.maven.execution.scope.internal.MojoExecutionScope.afterMojoExecutionSuccess(MojoExecutionScope.java:129)
>     at 
> org.apache.maven.plugin.CompoundMojoExecutionListener.afterMojoExecutionSuccess(CompoundMojoExecutionListener.java:42)
> {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (MRELEASE-1138) @{releaseLabel} variable is not resolved in the commit message of the branch goal

[Thomas Mortagne (Jira)]

Thomas Mortagne created MRELEASE-1138:
-

 Summary: @{releaseLabel} variable is not resolved in the commit 
message of the branch goal
 Key: MRELEASE-1138
 URL: https://issues.apache.org/jira/browse/MRELEASE-1138
 Project: Maven Release Plugin
  Issue Type: Bug
  Components: branch
Affects Versions: 3.0.1
Reporter: Thomas Mortagne


We get the following commit message since the upgrade to the release plugin 
3.0.1 (from 2.5.3): "[maven-release-plugin] prepare branch @{releaseLabel}" 
(see 
https://github.com/xwiki/xwiki-commons/commit/4e7eba27102a6c3c4954cf8dd7925232b8858157
 for an example).

We used the following command line in this case:

{code}
mvn release:branch -DbranchName=stable-16.0.x -DautoVersionSubmodules 
-DdevelopmentVersion=16.1.0-SNAPSHOT -DpushChanges=false 
-Pci,integration-tests,office-tests,legacy,standalone,flavor-integration-tests,distribution,docker
{code}

Before the upgrade, we used to get messages like "[maven-release-plugin] 
prepare branch stable-14.6.x" with the same command line (exception for the 
versions related parameters values, of course).

The release prepare goal message which contains the same variable according to 
the documentation does not seem to have the same problem as we get 
"[maven-release-plugin] prepare release xwiki-commons-16.0.0-rc-1" (see 
https://github.com/xwiki/xwiki-commons/commit/716ed16279968ea1a251cfbcb200893f9f43735c
 for example) with command line

{code}
  mvn --batch-mode release:prepare -DpushChanges=false -DlocalCheckout=true 
-DreleaseVersion=16.0.0-rc-1 -DdevelopmentVersion=16.0.0-SNAPSHOT 
-Dtag=xwiki-commons-16.0.0-rc-1 -DautoVersionSubmodules=true 
-Plegacy,integration-tests,office-tests,standalone,flavor-integration-tests,distribution,docker
{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MNG-7955) Plugins should be allowed some control over the imported packages

[Guillaume Nodet (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7955:
-
Description: 
We need some simple configuration to allow plugins to indicate which packages / 
artifacts they need to be provided.  This could solve the problems with 
{{org.slf4j}} package.

I think the defaults could be the following packages:
 * org.apache.maven.api,org.apache.maven.api.*
 * org.slf4j
 * jarkata.inject

 

See 
[https://github.com/apache/maven/pull/1336|https://github.com/apache/maven/pull/1336/files#diff-9600f93ce04acabe017b026dc1ebbb445e8cb363bb2677a764a783ab85cf804aR106-R108]
 which is related.

  was:
We need some simple configuration to allow plugins to indicate which packages / 
artifacts they need to be provided.  This could solve the problems with 
{{org.slf4j}} package.

I think the defaults could be the following packages:
 * org.apache.maven.api,org.apache.maven.api.*
 * org.sl4j
 * jarkata.inject

 

See 
[https://github.com/apache/maven/pull/1336|https://github.com/apache/maven/pull/1336/files#diff-9600f93ce04acabe017b026dc1ebbb445e8cb363bb2677a764a783ab85cf804aR106-R108]
 which is related.


> Plugins should be allowed some control over the imported packages
> -
>
> Key: MNG-7955
> URL: https://issues.apache.org/jira/browse/MNG-7955
> Project: Maven
>  Issue Type: New Feature
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0
>
>
> We need some simple configuration to allow plugins to indicate which packages 
> / artifacts they need to be provided.  This could solve the problems with 
> {{org.slf4j}} package.
> I think the defaults could be the following packages:
>  * org.apache.maven.api,org.apache.maven.api.*
>  * org.slf4j
>  * jarkata.inject
>  
> See 
> [https://github.com/apache/maven/pull/1336|https://github.com/apache/maven/pull/1336/files#diff-9600f93ce04acabe017b026dc1ebbb445e8cb363bb2677a764a783ab85cf804aR106-R108]
>  which is related.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] Bump org.springframework:spring-core from 5.3.31 to 6.0.15 in /indexer-examples/indexer-examples-spring [maven-indexer]

[via GitHub]

dependabot[bot] opened a new pull request, #351:
URL: https://github.com/apache/maven-indexer/pull/351

   Bumps 
[org.springframework:spring-core](https://github.com/spring-projects/spring-framework)
 from 5.3.31 to 6.0.15.
   
   Release notes
   Sourced from https://github.com/spring-projects/spring-framework/releases";>org.springframework:spring-core's
 releases.
   
   v6.0.15
   :star: New Features
   
   Skip buffer allocation in StreamUtils.copy(String) https://redirect.github.com/spring-projects/spring-framework/issues/31631";>#31631
   
   :lady_beetle: Bug Fixes
   
    unnecessarily requires explicit 
arg-type since 6.0 https://redirect.github.com/spring-projects/spring-framework/issues/31828";>#31828
   MergedAnnotations finds duplicate annotations on method in 
multi-level interface hierarchy https://redirect.github.com/spring-projects/spring-framework/issues/31824";>#31824
   Fix condition for "Too many elements" in 
MimeTypeUtils.sortBySpecificity() https://redirect.github.com/spring-projects/spring-framework/issues/31773";>#31773
   Spring unable to decode aggregated JSON content https://redirect.github.com/spring-projects/spring-framework/issues/31772";>#31772
   Multipart messages with empty parts are not correctly parsed in WebFlux 
https://redirect.github.com/spring-projects/spring-framework/issues/31766";>#31766
   PathEditor cannot handle absolute Windows paths with forward slashes https://redirect.github.com/spring-projects/spring-framework/issues/31727";>#31727
   TraceId is missing in WebFlux controller handlers https://redirect.github.com/spring-projects/spring-framework/issues/31716";>#31716
   Wrong observation status tag when a Not Found in a webflux application 
https://redirect.github.com/spring-projects/spring-framework/issues/31715";>#31715
   Fail to register MBean with bean name containing invalid character https://redirect.github.com/spring-projects/spring-framework/issues/31708";>#31708
   Include Hibernate's Query.scroll() in 
SharedEntityManagerCreator's queryTerminatingMethods 
set https://redirect.github.com/spring-projects/spring-framework/issues/31683";>#31683
   TypeDescriptor does not check generics in equals method 
(for ConversionService caching) https://redirect.github.com/spring-projects/spring-framework/issues/31673";>#31673
   SpEL expression on a reloadable type can no longer be resolved https://redirect.github.com/spring-projects/spring-framework/issues/31670";>#31670
   Slow SpEL performance due to method sorting in ReflectiveMethodResolver 
https://redirect.github.com/spring-projects/spring-framework/issues/31664";>#31664
   Jackson encoder releases resources in wrong order https://redirect.github.com/spring-projects/spring-framework/issues/31656";>#31656
   Current Observation.Context missing from WebClient request https://redirect.github.com/spring-projects/spring-framework/issues/31646";>#31646
   WebSocketMessageBrokerStats has null stats for stompSubProtocolHandler 
since 5.3.2 https://redirect.github.com/spring-projects/spring-framework/issues/31641";>#31641
    no longer works with a 
business-interface attribute https://redirect.github.com/spring-projects/spring-framework/issues/31630";>#31630
   GeneratedFiles#addSourceFile should not allow to add a source in the 
default package https://redirect.github.com/spring-projects/spring-framework/issues/31629";>#31629
   PathResourceResolver.getResource() does not log warning if 
Resource#getURL() throws exception https://redirect.github.com/spring-projects/spring-framework/issues/31624";>#31624
   
   :notebook_with_decorative_cover: Documentation
   
   Document explicit @ModelAttribute is required for 
reflection hints inference https://redirect.github.com/spring-projects/spring-framework/issues/31767";>#31767
   Documentation needs to be updated with instructions for STOMP Client https://redirect.github.com/spring-projects/spring-framework/issues/31678";>#31678
   Improve STOMP WebSocket documentation for input message buffer size https://redirect.github.com/spring-projects/spring-framework/issues/31654";>#31654
   
   :hammer: Dependency Upgrades
   
   Upgrade to Reactor 2022.0.14 https://redirect.github.com/spring-projects/spring-framework/issues/31815";>#31815
   
   v6.0.14
   :star: New Features
   
   Provide caching for HandlerMappingIntrospector lookups https://redirect.github.com/spring-projects/spring-framework/issues/31588";>#31588
   Log4jLog needs to re-resolve ExtendedLogger on 
deserialization (for compatibility with Log4J 2.21) https://redirect.github.com/spring-projects/spring-framework/issues/31582";>#31582
   Optimize StandardTypeLocator for hotspot when the same 
classes are resolved https://redirect.github.com/spring-projects/spring-framework/issues/31579";>#31579
   Add duplicate key exception error code for SAP HANA database https://redirect.github.com/spring-projects/spring-framework/pull/31554";>#31554
   Do not delegate TRACE to Htt

[PR] Upgrade JLine to 3.25.1 [maven]

[via GitHub]

gnodet opened a new pull request, #1390:
URL: https://github.com/apache/maven/pull/1390

   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
  where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA 
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] 
SUMMARY`.
  Best practice is to use the JIRA issue title in both the pull request 
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MRELEASE-1138) @{releaseLabel} variable is not resolved in the commit message of the branch goal

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MRELEASE-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810072#comment-17810072
 ] 

Michael Osipov commented on MRELEASE-1138:
--

It did work with 3.0.0?

> @{releaseLabel} variable is not resolved in the commit message of the branch 
> goal
> -
>
> Key: MRELEASE-1138
> URL: https://issues.apache.org/jira/browse/MRELEASE-1138
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: branch
>Affects Versions: 3.0.1
>Reporter: Thomas Mortagne
>Priority: Major
>
> We get the following commit message since the upgrade to the release plugin 
> 3.0.1 (from 2.5.3): "[maven-release-plugin] prepare branch @{releaseLabel}" 
> (see 
> https://github.com/xwiki/xwiki-commons/commit/4e7eba27102a6c3c4954cf8dd7925232b8858157
>  for an example).
> We used the following command line in this case:
> {code}
> mvn release:branch -DbranchName=stable-16.0.x -DautoVersionSubmodules 
> -DdevelopmentVersion=16.1.0-SNAPSHOT -DpushChanges=false 
> -Pci,integration-tests,office-tests,legacy,standalone,flavor-integration-tests,distribution,docker
> {code}
> Before the upgrade, we used to get messages like "[maven-release-plugin] 
> prepare branch stable-14.6.x" with the same command line (exception for the 
> versions related parameters values, of course).
> The release prepare goal message which contains the same variable according 
> to the documentation does not seem to have the same problem as we get 
> "[maven-release-plugin] prepare release xwiki-commons-16.0.0-rc-1" (see 
> https://github.com/xwiki/xwiki-commons/commit/716ed16279968ea1a251cfbcb200893f9f43735c
>  for example) with command line
> {code}
>   mvn --batch-mode release:prepare -DpushChanges=false -DlocalCheckout=true 
> -DreleaseVersion=16.0.0-rc-1 -DdevelopmentVersion=16.0.0-SNAPSHOT 
> -Dtag=xwiki-commons-16.0.0-rc-1 -DautoVersionSubmodules=true 
> -Plegacy,integration-tests,office-tests,standalone,flavor-integration-tests,distribution,docker
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.41.1 to 2.43.0 [maven-parent]

[via GitHub]

dependabot[bot] opened a new pull request, #161:
URL: https://github.com/apache/maven-parent/pull/161

   Bumps 
[com.diffplug.spotless:spotless-maven-plugin](https://github.com/diffplug/spotless)
 from 2.41.1 to 2.43.0.
   
   Changelog
   Sourced from https://github.com/diffplug/spotless/blob/main/CHANGES.md";>com.diffplug.spotless:spotless-maven-plugin's
 changelog.
   
   [2.43.0] - 2023-11-27
   Added
   
   Support custom rule sets for Ktlint. (https://redirect.github.com/diffplug/spotless/pull/1896";>#1896)
   
   Fixed
   
   Fix Eclipse JDT on some settings files. (https://redirect.github.com/diffplug/spotless/pull/1864";>#1864 fixes 
https://redirect.github.com/diffplug/spotless/issues/1638";>#1638)
   
   Changes
   
   Bump default ktlint version to latest 1.0.0 
-> 1.0.1. (https://redirect.github.com/diffplug/spotless/pull/1855";>#1855)
   Add a Step to remove semicolons from Groovy files. (https://redirect.github.com/diffplug/spotless/pull/1881";>#1881)
   
   [2.42.0] - 2023-09-28
   Added
   
   Support for biome. The Rome project https://biomejs.dev/blog/annoucing-biome/";>was renamed to Biome.
   The configuration is still the same, but you should switch to the new 
biome tag / function and adjust
   the version accordingly. (https://redirect.github.com/diffplug/spotless/issues/1804";>#1804).
   Support for google-java-format's 
skip-javadoc-formatting option. (https://redirect.github.com/diffplug/spotless/pull/1793";>#1793)
   Support configuration of mirrors for P2 repositories in Maven DSL (https://redirect.github.com/diffplug/spotless/issues/1697";>#1697).
   New line endings mode GIT_ATTRIBUTES_FAST_ALLSAME. (https://redirect.github.com/diffplug/spotless/pull/1838";>#1838)
   
   Fixed
   
   Fix support for plugins when using Prettier version 3.0.0 
and newer. (https://redirect.github.com/diffplug/spotless/pull/1802";>#1802)
   Fix configuration cache issue around external process started 
'/usr/bin/git --version'. (https://redirect.github.com/diffplug/spotless/issues/1806";>#1806)
   
   Changes
   
   Bump default flexmark version to latest 0.64.0 
-> 0.64.8. (https://redirect.github.com/diffplug/spotless/pull/1801";>#1801)
   Bump default ktlint version to latest 0.50.0 
-> 1.0.0. (https://redirect.github.com/diffplug/spotless/pull/1808";>#1808)
   
   [2.41.0] - 2023-08-29
   Added
   
   Add a jsonPatch step to json formatter 
configurations. This allows patching of JSON documents using https://jsonpatch.com";>JSON Patches. (https://redirect.github.com/diffplug/spotless/pull/1753";>#1753)
   Support GJF own import order. (https://redirect.github.com/diffplug/spotless/pull/1780";>#1780)
   
   Fixed
   
   Use latest versions of popular style guides for eslint 
tests to fix failing useEslintXoStandardRules test. (https://redirect.github.com/diffplug/spotless/pull/1761";>#1761, https://redirect.github.com/diffplug/spotless/issues/1756";>#1756)
   Add support for prettier version 3.0.0 and 
newer. (https://redirect.github.com/diffplug/spotless/pull/1760";>#1760, https://redirect.github.com/diffplug/spotless/issues/1751";>#1751)
   Fix npm install calls when npm cache is not up-to-date. (https://redirect.github.com/diffplug/spotless/pull/1760";>#1760, https://redirect.github.com/diffplug/spotless/issues/1750";>#1750)
   
   Changes
   
   Bump default eslint version to latest 8.31.0 
-> 8.45.0 (https://redirect.github.com/diffplug/spotless/pull/1761";>#1761)
   Bump default prettier version to latest (v2) 
2.8.1 -> 2.8.8. (https://redirect.github.com/diffplug/spotless/pull/1760";>#1760)
   Bump default greclipse version to latest 4.27 
-> 4.28. (https://redirect.github.com/diffplug/spotless/pull/1775";>#1775)
   
   [2.40.0] - 2023-07-17
   Added
   
   Added support for Protobuf formatting based on https://buf.build/";>Buf. (https://redirect.github.com/diffplug/spotless/issues/1208";>#1208)
   enum OnMatch { INCLUDE, EXCLUDE } so that 
FormatterStep.filterByContent can not only include based on the 
pattern but also exclude. (https://redirect.github.com/diffplug/spotless/pull/1749";>#1749)
   
   Fixed
   
   Update documented default semanticSort to 
false. (https://redirect.github.com/diffplug/spotless/pull/1728";>#1728)
   
   Changes
   
   Bump default cleanthat version to latest 2.13 
-> 2.17. (https://redirect.github.com/diffplug/spotless/pull/1734";>#1734)
   Bump default ktlint version to latest 0.49.1 
-> 0.50.0. (https://redirect.github.com/diffplug/spotless/issues/1741";>#1741)
   
   Dropped support for ktlint 0.47.x following our policy of 
supporting two breaking changes at a time.
   Dropped support for deprecated useExperimental parameter in 
favor of the ktlint_experimental property.
   
   
   
   [2.39.0] - 2023-05-24
   
   
   ... (truncated)
   
   
   Commits
   
   https://github.com/diffplug/spotless/commit/23972d3fa9c9950bc34eb653f0e598cc968b2620";>23972d3
 Published lib/2.43.0
   https://github.com/diffplug/spotless/commit/c4511b680a0938a7417c48660ecb

Re: [PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.41.1 to 2.42.0 [maven-parent]

[via GitHub]

dependabot[bot] closed pull request #158: Bump 
com.diffplug.spotless:spotless-maven-plugin from 2.41.1 to 2.42.0
URL: https://github.com/apache/maven-parent/pull/158


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.41.1 to 2.42.0 [maven-parent]

[via GitHub]

dependabot[bot] commented on PR #158:
URL: https://github.com/apache/maven-parent/pull/158#issuecomment-1907347516

   Superseded by #161.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org