[
https://issues.apache.org/jira/browse/MRESOLVER-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809846#comment-17809846
]
ASF GitHub Bot commented on MRESOLVER-467:
------------------------------------------
cstamas commented on code in PR #410:
URL: https://github.com/apache/maven-resolver/pull/410#discussion_r1462975817
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/transport/http/DefaultChecksumExtractor.java:
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.internal.impl.transport.http;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.util.Map;
+import java.util.function.Function;
+
+import org.eclipse.aether.spi.connector.transport.http.ChecksumExtractor;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Checksum extractor.
+ */
+@Singleton
+@Named
+public final class DefaultChecksumExtractor implements ChecksumExtractor {
+ private final Map<String, Strategy> strategies;
Review Comment:
To distinguish component types, otherwise on inject it would be a loop ->
failure (entry point would like to inject itself), hence using subtype. Also,
later on, the Strategy interface MAY become different, while currently it does
not.
> Pull out shared HTTP (Remote Included checksum) code
> ----------------------------------------------------
>
> Key: MRESOLVER-467
> URL: https://issues.apache.org/jira/browse/MRESOLVER-467
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-7
>
>
> The logic for them is basically duplicated (triplicated) in all HTTP
> transport implementations (apache, jdk, jetty).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
