hboutemy commented on code in PR #190:
URL:
https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1463034499
##########
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##########
@@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File
outputDirectory, File outputDirector
throws MojoExecutionException {
zipArchiver.addDirectory(outputDirectoryImage);
+ // configure for Reproducible Builds based on outputTimestamp value
+ Date lastModified = new
MavenArchiver().parseOutputTimestamp(outputTimestamp);
+ if (lastModified != null) {
+ zipArchiver.configureReproducible(lastModified);
+ }
Review Comment:
because here it a method for Plexus Archiver, while in maven-rar-plugin it's
a Maven Archiver (that only works on jars)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
