[
https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809865#comment-17809865
]
ASF GitHub Bot commented on MJLINK-75:
--------------------------------------
hboutemy commented on code in PR #190:
URL:
https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1463034499
##########
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##########
@@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File
outputDirectory, File outputDirector
throws MojoExecutionException {
zipArchiver.addDirectory(outputDirectoryImage);
+ // configure for Reproducible Builds based on outputTimestamp value
+ Date lastModified = new
MavenArchiver().parseOutputTimestamp(outputTimestamp);
+ if (lastModified != null) {
+ zipArchiver.configureReproducible(lastModified);
+ }
Review Comment:
because here it a method for Plexus Archiver, while in maven-rar-plugin it's
a Maven Archiver (that only works on jars)
> Reproducibility of ZIP artifacts
> --------------------------------
>
> Key: MJLINK-75
> URL: https://issues.apache.org/jira/browse/MJLINK-75
> Project: Maven JLink Plugin
> Issue Type: New Feature
> Affects Versions: 3.1.0
> Reporter: Piotr Karwasz
> Assignee: Herve Boutemy
> Priority: Minor
> Fix For: 3.2.0
>
>
> The artifacts produced by this plugin do not use the
> {{'project.build.outputTimestamp'}} property for the ZIP file entries and
> therefore are not reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
