date:20220705

[GitHub] [maven] mthmulders commented on pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-05 Thread GitBox



mthmulders commented on PR #757:
URL: https://github.com/apache/maven/pull/757#issuecomment-1174706250

   > (notice: PR CI build does not seem to detect the associate core ITs 
branch...)
   
   Looking at the [CI job for this 
PR](https://github.com/apache/maven/runs/7169900218?check_suite_focus=true), I 
see it detected the branch in m-i-t correctly and ran the new tests correctly:
   
   
![image](https://user-images.githubusercontent.com/430114/177271786-b419e03d-cd0c-463c-8f5c-4c4b89bb6af3.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562411#comment-17562411
 ] 

ASF GitHub Bot commented on MNG-7353:
-

mthmulders commented on PR #757:
URL: https://github.com/apache/maven/pull/757#issuecomment-1174706250

   > (notice: PR CI build does not seem to detect the associate core ITs 
branch...)
   
   Looking at the [CI job for this 
PR](https://github.com/apache/maven/runs/7169900218?check_suite_focus=true), I 
see it detected the branch in m-i-t correctly and ran the new tests correctly:
   
   
![image](https://user-images.githubusercontent.com/430114/177271786-b419e03d-cd0c-463c-8f5c-4c4b89bb6af3.png)
   




> add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven] michael-o commented on pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-05 Thread GitBox



michael-o commented on PR #757:
URL: https://github.com/apache/maven/pull/757#issuecomment-1174709069

   Will test this week...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562413#comment-17562413
 ] 

ASF GitHub Bot commented on MNG-7353:
-

michael-o commented on PR #757:
URL: https://github.com/apache/maven/pull/757#issuecomment-1174709069

   Will test this week...




> add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven] mthmulders commented on a diff in pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-05 Thread GitBox



mthmulders commented on code in PR #757:
URL: https://github.com/apache/maven/pull/757#discussion_r913478933


##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java:
##
@@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task, 
MavenSession session, Mave
 }
 else if ( numTokens == 3 )
 {
-// We have everything that we need except the version
-//
-// 
org.apache.maven.plugins:maven-remote-resources-plugin:???:process
-//
-// groupId
-// artifactId
-// ???
-// goal
-//
-plugin = new Plugin();
-plugin.setGroupId( tok.nextToken() );
-plugin.setArtifactId( tok.nextToken() );
+// groupId:artifactId:goal or pluginPrefix:version:goal (since 
Maven 3.9)
+
+String firstToken = tok.nextToken();
+// groupId or pluginPrefix? heuristics: groupId contains . but not 
pluginPrefix
+if ( firstToken.contains( "." ) )

Review Comment:
   I gave it some thought, but I can't find a better heuristic either. The only 
thing more or less foolproof would be to look at the first token, assuming it 
is a plugin prefix. If that lookup yields nothing, it would be a groupId.
   
   Even that is not 100% safe, though. Imagine you're not connected to the 
network, so lookup fails, so we decide it's a groupId -- this certainly doesn't 
make sense. But more importantly, it's probably quite costly compared to a 
`String.contains` :-).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562422#comment-17562422
 ] 

ASF GitHub Bot commented on MNG-7353:
-

mthmulders commented on code in PR #757:
URL: https://github.com/apache/maven/pull/757#discussion_r913478933


##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java:
##
@@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task, 
MavenSession session, Mave
 }
 else if ( numTokens == 3 )
 {
-// We have everything that we need except the version
-//
-// 
org.apache.maven.plugins:maven-remote-resources-plugin:???:process
-//
-// groupId
-// artifactId
-// ???
-// goal
-//
-plugin = new Plugin();
-plugin.setGroupId( tok.nextToken() );
-plugin.setArtifactId( tok.nextToken() );
+// groupId:artifactId:goal or pluginPrefix:version:goal (since 
Maven 3.9)
+
+String firstToken = tok.nextToken();
+// groupId or pluginPrefix? heuristics: groupId contains . but not 
pluginPrefix
+if ( firstToken.contains( "." ) )

Review Comment:
   I gave it some thought, but I can't find a better heuristic either. The only 
thing more or less foolproof would be to look at the first token, assuming it 
is a plugin prefix. If that lookup yields nothing, it would be a groupId.
   
   Even that is not 100% safe, though. Imagine you're not connected to the 
network, so lookup fails, so we decide it's a groupId 

> add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven] mthmulders commented on a diff in pull request #701: [MNG-7443] Make logging consistent between optional profiles and projects

2022-07-05 Thread GitBox



mthmulders commented on code in PR #701:
URL: https://github.com/apache/maven/pull/701#discussion_r913499478


##
maven-core/src/main/java/org/apache/maven/graph/ProjectSelector.java:
##
@@ -0,0 +1,144 @@
+package org.apache.maven.graph;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.MavenExecutionException;
+import org.apache.maven.execution.MavenExecutionRequest;
+import org.apache.maven.project.MavenProject;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.util.HashSet;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+
+public final class ProjectSelector

Review Comment:
   Would it be possible to add unit tests for this new class?



##
maven-core/src/main/java/org/apache/maven/DefaultMaven.java:
##
@@ -631,6 +638,21 @@ private void validateRequiredProfiles( MavenSession 
session, ProfileActivation p
 }
 }
 
+/**
+ * Check whether any of the requested optional projects were not activated 
or deactivated.
+ * @param request the {@link MavenExecutionRequest}.
+ * @param session the {@link MavenSession}.
+ */
+private void validateOptionalProjects( MavenExecutionRequest request, 
MavenSession session )
+{
+final ProjectActivation projectActivation = 
request.getProjectActivation();
+final Set allOptionalSelectors = Sets.union( 
projectActivation.getOptionalActiveProjectSelectors(),

Review Comment:
   Do we really need `Sets.union` here? If we want to know the combination of 
optional active project selectors and optional inactive project selectors, 
can't we create a new `Set` and put all items from both backing sets in it? 
   
   Since `Set` does not allow duplicate elements, I guess we would have the 
same result - but without using an external lib for it. It's two lines more 
code this way, but at least we don't increase our dependency on Guava or Google 
Collections or whatnot.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7443) Consistent logging between optional projects and optional profiles

2022-07-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562441#comment-17562441
 ] 

ASF GitHub Bot commented on MNG-7443:
-

mthmulders commented on code in PR #701:
URL: https://github.com/apache/maven/pull/701#discussion_r913499478


##
maven-core/src/main/java/org/apache/maven/graph/ProjectSelector.java:
##
@@ -0,0 +1,144 @@
+package org.apache.maven.graph;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.MavenExecutionException;
+import org.apache.maven.execution.MavenExecutionRequest;
+import org.apache.maven.project.MavenProject;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.util.HashSet;
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+
+public final class ProjectSelector

Review Comment:
   Would it be possible to add unit tests for this new class?



##
maven-core/src/main/java/org/apache/maven/DefaultMaven.java:
##
@@ -631,6 +638,21 @@ private void validateRequiredProfiles( MavenSession 
session, ProfileActivation p
 }
 }
 
+/**
+ * Check whether any of the requested optional projects were not activated 
or deactivated.
+ * @param request the {@link MavenExecutionRequest}.
+ * @param session the {@link MavenSession}.
+ */
+private void validateOptionalProjects( MavenExecutionRequest request, 
MavenSession session )
+{
+final ProjectActivation projectActivation = 
request.getProjectActivation();
+final Set allOptionalSelectors = Sets.union( 
projectActivation.getOptionalActiveProjectSelectors(),

Review Comment:
   Do we really need `Sets.union` here? If we want to know the combination of 
optional active project selectors and optional inactive project selectors, 
can't we create a new `Set` and put all items from both backing sets in it? 
   
   Since `Set` does not allow duplicate elements, I guess we would have the 
same result - but without using an external lib for it. It's two lines more 
code this way, but at least we don't increase our dependency on Guava or Google 
Collections or whatnot.





> Consistent logging between optional projects and optional profiles
> --
>
> Key: MNG-7443
> URL: https://issues.apache.org/jira/browse/MNG-7443
> Project: Maven
>  Issue Type: Improvement
>  Components: Core, Logging
>Affects Versions: 4.0.0-alpha-1
>Reporter: Giovanni van der Schelde
>Priority: Minor
> Attachments: example.png
>
>
> Maven 4 introduces optional profiles and optional projects. However, the 
> feedback provided to the user on whether a project or profile has been 
> skipped is inconsistent between the two (see image attached). 
> For profiles, it will be logged twice: before and after the build.
> For projects, it will be logged once: before the build.
> The idea would be to log the information for skipped optional projects after 
> the build as well.
> !example.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-gh-actions-shared] michael-o commented on a diff in pull request #49: Matrix build with many Maven versions

2022-07-05 Thread GitBox



michael-o commented on code in PR #49:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/49#discussion_r913629014


##
.github/workflows/maven-verify-test.yml:
##
@@ -32,3 +32,4 @@ jobs:
   ff-goal: test
   verify-goal: clean install
   verify-fail-fast: false
+  maven-matrix: '[ "3.2.5", "3.8.6" ]'

Review Comment:
   Is this an interval or simply the lowest and the highest version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] michael-o commented on a diff in pull request #49: Matrix build with many Maven versions

2022-07-05 Thread GitBox



michael-o commented on code in PR #49:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/49#discussion_r913629920


##
.github/workflows/maven-verify-test.yml:
##
@@ -32,3 +32,4 @@ jobs:
   ff-goal: test
   verify-goal: clean install

Review Comment:
   Do we really need install? Isn't verify sufficient and saves time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] olamy commented on a diff in pull request #49: Matrix build with many Maven versions

2022-07-05 Thread GitBox



olamy commented on code in PR #49:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/49#discussion_r913632969


##
.github/workflows/maven-verify-test.yml:
##
@@ -17,7 +17,7 @@
 
 name: Verify - Test
 
-on: push
+on: [ push, pull_request ]

Review Comment:
   is this change related to Matrix build?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] olamy commented on a diff in pull request #49: Matrix build with many Maven versions

2022-07-05 Thread GitBox



olamy commented on code in PR #49:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/49#discussion_r913636164


##
.github/workflows/maven-verify.yml:
##
@@ -20,54 +20,54 @@ name: Verify
 on:
   workflow_call:
 inputs:
-  maven_args:
+  maven-args:
 description: The arguments to pass to all Maven commands when building 
the code
 required: false
 default: '-D"invoker.streamLogsOnFailures"'
 type: string
 
-  maven_version:
-description: The Maven version used for builds
-required: false
-default: '3.8.6'
-type: string
-
   os-matrix:
-description: 'os matrix as json array'
+description: os matrix as json array
 required: false
 default: '[ "ubuntu-latest", "windows-latest", "macOS-latest" ]'
 type: string
 
   jdk-matrix:
-description: 'jdk matrix as json array'
+description: jdk matrix as json array
 required: false
 default: '[ "8", "11", "17" ]'
 type: string
 
+  jdk-distribution-matrix:
+description: jdk distribution matrix
+required: false
+default: '[ "temurin" ]'
+type: string
+
+  maven-matrix:
+description: The Maven version matrix as json array
+required: false
+default: '[ "3.8.6" ]'
+type: string
+
   matrix-exclude:
-description: 'exclude for matrix as json'
+description: exclude for matrix as json
 required: false
 default: '[]'
 type: string
 
   max-parallel:
-description: 'max parallel jobs'
+description: max parallel jobs
 required: false
 default: 100
 type: number
 
   timeout-minutes:
-description: 'timeout-minutes used by the builds (defaults to 360)'
+description: timeout-minutes used by the builds (defaults to 360)
 required: false
 default: 360
 type: number
 
-  jdk-distribution-matrix:

Review Comment:
   is this compatible for builds currently using this argument? (such 
https://github.com/apache/maven-compiler-plugin/blob/master/.github/workflows/maven-verify.yml)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a diff in pull request #50: add a clean to ensure we do not lock files for a windows build

2022-07-05 Thread GitBox



slawekjaranowski commented on code in PR #50:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/50#discussion_r913654884


##
.github/workflows/maven-verify.yml:
##
@@ -272,6 +272,10 @@ jobs:
   - name: Build with Maven
 if: steps.should-run.conclusion == 'success'
 run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven_args 
}} ${{ inputs.verify-goal }}
+
+  - name: Clean Ensuring no file handle remains open on windows
+if: steps.should-run.conclusion == 'success'
+run: ./mvnw clean

Review Comment:
   As I understand each GH job is executed in new VM which is removed after job 
finish, so all used resources should be decommissioned and should not have 
impact to other jobs.
   
   
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#using-a-github-hosted-runner



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] olamy commented on a diff in pull request #50: add a clean to ensure we do not lock files for a windows build

2022-07-05 Thread GitBox



olamy commented on code in PR #50:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/50#discussion_r913662891


##
.github/workflows/maven-verify.yml:
##
@@ -272,6 +272,10 @@ jobs:
   - name: Build with Maven
 if: steps.should-run.conclusion == 'success'
 run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven_args 
}} ${{ inputs.verify-goal }}
+
+  - name: Clean Ensuring no file handle remains open on windows
+if: steps.should-run.conclusion == 'success'
+run: ./mvnw clean

Review Comment:
   yes for sure but this is not the goal of the check.
   The goal is to be sure we do not left file for people who wants to build 
this locally.
   if you cannot run `mvn test` then `mvn clean test` because of file leaking 
in a windows env we should consider this as a bug.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] olamy commented on a diff in pull request #49: Matrix build with many Maven versions

2022-07-05 Thread GitBox



olamy commented on code in PR #49:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/49#discussion_r913636164


##
.github/workflows/maven-verify.yml:
##
@@ -20,54 +20,54 @@ name: Verify
 on:
   workflow_call:
 inputs:
-  maven_args:
+  maven-args:
 description: The arguments to pass to all Maven commands when building 
the code
 required: false
 default: '-D"invoker.streamLogsOnFailures"'
 type: string
 
-  maven_version:
-description: The Maven version used for builds
-required: false
-default: '3.8.6'
-type: string
-
   os-matrix:
-description: 'os matrix as json array'
+description: os matrix as json array
 required: false
 default: '[ "ubuntu-latest", "windows-latest", "macOS-latest" ]'
 type: string
 
   jdk-matrix:
-description: 'jdk matrix as json array'
+description: jdk matrix as json array
 required: false
 default: '[ "8", "11", "17" ]'
 type: string
 
+  jdk-distribution-matrix:
+description: jdk distribution matrix
+required: false
+default: '[ "temurin" ]'
+type: string
+
+  maven-matrix:
+description: The Maven version matrix as json array
+required: false
+default: '[ "3.8.6" ]'
+type: string
+
   matrix-exclude:
-description: 'exclude for matrix as json'
+description: exclude for matrix as json
 required: false
 default: '[]'
 type: string
 
   max-parallel:
-description: 'max parallel jobs'
+description: max parallel jobs
 required: false
 default: 100
 type: number
 
   timeout-minutes:
-description: 'timeout-minutes used by the builds (defaults to 360)'
+description: timeout-minutes used by the builds (defaults to 360)
 required: false
 default: 360
 type: number
 
-  jdk-distribution-matrix:

Review Comment:
   is this compatible for builds currently using this argument? (such 
https://github.com/apache/maven-compiler-plugin/blob/master/.github/workflows/maven-verify.yml)
   or because it;s v3 we don;t care and we will maintaining 2 branches?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] olamy commented on a diff in pull request #49: Matrix build with many Maven versions

2022-07-05 Thread GitBox



olamy commented on code in PR #49:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/49#discussion_r913636164


##
.github/workflows/maven-verify.yml:
##
@@ -20,54 +20,54 @@ name: Verify
 on:
   workflow_call:
 inputs:
-  maven_args:
+  maven-args:
 description: The arguments to pass to all Maven commands when building 
the code
 required: false
 default: '-D"invoker.streamLogsOnFailures"'
 type: string
 
-  maven_version:
-description: The Maven version used for builds
-required: false
-default: '3.8.6'
-type: string
-
   os-matrix:
-description: 'os matrix as json array'
+description: os matrix as json array
 required: false
 default: '[ "ubuntu-latest", "windows-latest", "macOS-latest" ]'
 type: string
 
   jdk-matrix:
-description: 'jdk matrix as json array'
+description: jdk matrix as json array
 required: false
 default: '[ "8", "11", "17" ]'
 type: string
 
+  jdk-distribution-matrix:
+description: jdk distribution matrix
+required: false
+default: '[ "temurin" ]'
+type: string
+
+  maven-matrix:
+description: The Maven version matrix as json array
+required: false
+default: '[ "3.8.6" ]'
+type: string
+
   matrix-exclude:
-description: 'exclude for matrix as json'
+description: exclude for matrix as json
 required: false
 default: '[]'
 type: string
 
   max-parallel:
-description: 'max parallel jobs'
+description: max parallel jobs
 required: false
 default: 100
 type: number
 
   timeout-minutes:
-description: 'timeout-minutes used by the builds (defaults to 360)'
+description: timeout-minutes used by the builds (defaults to 360)
 required: false
 default: 360
 type: number
 
-  jdk-distribution-matrix:

Review Comment:
   is this compatible for builds currently using this argument? (such 
https://github.com/apache/maven-compiler-plugin/blob/master/.github/workflows/maven-verify.yml)
   or because it's v3 we don't care and we will maintain 2 branches?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a diff in pull request #49: Matrix build with many Maven versions

2022-07-05 Thread GitBox



slawekjaranowski commented on code in PR #49:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/49#discussion_r913664764


##
.github/workflows/maven-verify-test.yml:
##
@@ -32,3 +32,4 @@ jobs:
   ff-goal: test
   verify-goal: clean install
   verify-fail-fast: false
+  maven-matrix: '[ "3.2.5", "3.8.6" ]'

Review Comment:
   t is only test workflow executed in this repo



##
.github/workflows/maven-verify-test.yml:
##
@@ -32,3 +32,4 @@ jobs:
   ff-goal: test
   verify-goal: clean install

Review Comment:
   it is only test workflow executed in this repo - show what happens when 
`ff-goal` and `verify-goal` have different commands



##
.github/workflows/maven-verify-test.yml:
##
@@ -17,7 +17,7 @@
 
 name: Verify - Test
 
-on: push
+on: [ push, pull_request ]

Review Comment:
   not 😄 



##
.github/workflows/maven-verify.yml:
##
@@ -20,54 +20,54 @@ name: Verify
 on:
   workflow_call:
 inputs:
-  maven_args:
+  maven-args:
 description: The arguments to pass to all Maven commands when building 
the code
 required: false
 default: '-D"invoker.streamLogsOnFailures"'
 type: string
 
-  maven_version:
-description: The Maven version used for builds
-required: false
-default: '3.8.6'
-type: string
-
   os-matrix:
-description: 'os matrix as json array'
+description: os matrix as json array
 required: false
 default: '[ "ubuntu-latest", "windows-latest", "macOS-latest" ]'
 type: string
 
   jdk-matrix:
-description: 'jdk matrix as json array'
+description: jdk matrix as json array
 required: false
 default: '[ "8", "11", "17" ]'
 type: string
 
+  jdk-distribution-matrix:
+description: jdk distribution matrix
+required: false
+default: '[ "temurin" ]'
+type: string
+
+  maven-matrix:
+description: The Maven version matrix as json array
+required: false
+default: '[ "3.8.6" ]'
+type: string
+
   matrix-exclude:
-description: 'exclude for matrix as json'
+description: exclude for matrix as json
 required: false
 default: '[]'
 type: string
 
   max-parallel:
-description: 'max parallel jobs'
+description: max parallel jobs
 required: false
 default: 100
 type: number
 
   timeout-minutes:
-description: 'timeout-minutes used by the builds (defaults to 360)'
+description: timeout-minutes used by the builds (defaults to 360)
 required: false
 default: 360
 type: number
 
-  jdk-distribution-matrix:

Review Comment:
   I grupped all `*-matrix` options together - it is preserved in line 41



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] olamy commented on a diff in pull request #49: Matrix build with many Maven versions

2022-07-05 Thread GitBox



olamy commented on code in PR #49:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/49#discussion_r913668219


##
.github/workflows/maven-verify.yml:
##
@@ -20,54 +20,54 @@ name: Verify
 on:
   workflow_call:
 inputs:
-  maven_args:
+  maven-args:

Review Comment:
   is this backward compatible?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] olamy commented on a diff in pull request #50: add a clean to ensure we do not lock files for a windows build

2022-07-05 Thread GitBox



olamy commented on code in PR #50:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/50#discussion_r913662891


##
.github/workflows/maven-verify.yml:
##
@@ -272,6 +272,10 @@ jobs:
   - name: Build with Maven
 if: steps.should-run.conclusion == 'success'
 run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven_args 
}} ${{ inputs.verify-goal }}
+
+  - name: Clean Ensuring no file handle remains open on windows
+if: steps.should-run.conclusion == 'success'
+run: ./mvnw clean

Review Comment:
   yes for sure but this is not the goal of the check.
   The goal is to be sure we do not leave files open for people who wants to 
build this locally.
   if you cannot run `mvn test` then `mvn clean test` because of file leaking 
in a windows env we should consider this as a bug.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] olamy commented on a diff in pull request #50: add a clean to ensure we do not lock files for a windows build

2022-07-05 Thread GitBox



olamy commented on code in PR #50:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/50#discussion_r913662891


##
.github/workflows/maven-verify.yml:
##
@@ -272,6 +272,10 @@ jobs:
   - name: Build with Maven
 if: steps.should-run.conclusion == 'success'
 run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven_args 
}} ${{ inputs.verify-goal }}
+
+  - name: Clean Ensuring no file handle remains open on windows
+if: steps.should-run.conclusion == 'success'
+run: ./mvnw clean

Review Comment:
   yes for sure I know that.
   But the goal is to be sure we do not leave files open for people who wants 
to build this locally.
   if you cannot run `mvn test` then `mvn clean test` because of file leaking 
in a windows env we should consider this as a bug.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (MWRAPPER-71) Allow label current as Maven version

2022-07-05 Thread Slawomir Jaranowski (Jira)

Slawomir Jaranowski created MWRAPPER-71:
---

 Summary: Allow label current as Maven version
 Key: MWRAPPER-71
 URL: https://issues.apache.org/jira/browse/MWRAPPER-71
 Project: Maven Wrapper
  Issue Type: New Feature
Reporter: Slawomir Jaranowski


We can provide specific version for Maven, like {{3.2.5}} 

When we don't set option for version wrapper will use current Maven version.

It will be useful to allow specific label like {{current}} with the same 
behavior.

It can be used in CI system when for matrix build we can set list of version, 
like {{3.2.5}}, {{current}}




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven] hboutemy commented on pull request #757: [MNG-7353] support CLI "mvn pluginPrefix:version:goal"

2022-07-05 Thread GitBox



hboutemy commented on PR #757:
URL: https://github.com/apache/maven/pull/757#issuecomment-1174937188

   on Junit 4 vs 5: I'm not a purist, I just copied from others, it's so basic 
:)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7353) add support for "mvn pluginPrefix:version:goal"

2022-07-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562604#comment-17562604
 ] 

ASF GitHub Bot commented on MNG-7353:
-

hboutemy commented on PR #757:
URL: https://github.com/apache/maven/pull/757#issuecomment-1174937188

   on Junit 4 vs 5: I'm not a purist, I just copied from others, it's so basic 
:)




> add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a diff in pull request #49: Matrix build with many Maven versions

2022-07-05 Thread GitBox



slawekjaranowski commented on code in PR #49:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/49#discussion_r913678722


##
.github/workflows/maven-verify.yml:
##
@@ -20,54 +20,54 @@ name: Verify
 on:
   workflow_call:
 inputs:
-  maven_args:
+  maven-args:

Review Comment:
   not - description update
   so I created next branch - version v3
   
   changed to be consequently in options name format



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a diff in pull request #50: add a clean to ensure we do not lock files for a windows build

2022-07-05 Thread GitBox



slawekjaranowski commented on code in PR #50:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/50#discussion_r913686661


##
.github/workflows/maven-verify.yml:
##
@@ -272,6 +272,10 @@ jobs:
   - name: Build with Maven
 if: steps.should-run.conclusion == 'success'
 run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven_args 
}} ${{ inputs.verify-goal }}
+
+  - name: Clean Ensuring no file handle remains open on windows
+if: steps.should-run.conclusion == 'success'
+run: ./mvnw clean

Review Comment:
   I don't think that somebody use GH scripts locally ...
   In GH we take additional a few seconds for build 
   
   if needed pleas also add `--errors --batch-mode --show-version`
   and add the same to `fail-fast-build`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] olamy commented on a diff in pull request #50: add a clean to ensure we do not lock files for a windows build

2022-07-05 Thread GitBox



olamy commented on code in PR #50:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/50#discussion_r913690360


##
.github/workflows/maven-verify.yml:
##
@@ -272,6 +272,10 @@ jobs:
   - name: Build with Maven
 if: steps.should-run.conclusion == 'success'
 run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven_args 
}} ${{ inputs.verify-goal }}
+
+  - name: Clean Ensuring no file handle remains open on windows
+if: steps.should-run.conclusion == 'success'
+run: ./mvnw clean

Review Comment:
   With locally I mean locally on your laptop :)
   This check is here to detect our builds/plugins/etc do not leave files open 
for windows users.
   It would be a problem if anything leave files open for windows users.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a diff in pull request #50: add a clean to ensure we do not lock files for a windows build

2022-07-05 Thread GitBox



slawekjaranowski commented on code in PR #50:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/50#discussion_r913692789


##
.github/workflows/maven-verify.yml:
##
@@ -272,6 +272,10 @@ jobs:
   - name: Build with Maven
 if: steps.should-run.conclusion == 'success'
 run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven_args 
}} ${{ inputs.verify-goal }}
+
+  - name: Clean Ensuring no file handle remains open on windows
+if: steps.should-run.conclusion == 'success'
+run: ./mvnw clean

Review Comment:
   I see, we want to detect in this step if all files are closed - if no - 
build will break



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (MNG-5697) remove LifecycleMapping and ArtifactHandler from maven-core: move to target packaging plugin

2022-07-05 Thread Herve Boutemy (Jira)



 [ 
https://issues.apache.org/jira/browse/MNG-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy updated MNG-5697:
---
Fix Version/s: 4.x / Backlog

> remove LifecycleMapping and ArtifactHandler from maven-core: move to target 
> packaging plugin
> 
>
> Key: MNG-5697
> URL: https://issues.apache.org/jira/browse/MNG-5697
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 4.x / Backlog
>
>
> Maven Core should only be aware of the pom packaging details, the rest of the 
> {{ArtifactHandlers}} and {{LifecycleMappings}} should be moved to their own 
> packaging plugin:
> - jar packaging: maven-jar-plugin
> - ejb and ejb3 packagings: maven-ejb-plugin
> - maven-plugin packaging: maven-plugin-plugin
> - war packaging: maven-war-plugin
> - ear packaging: maven-ear-plugin
> - rar packaging: maven-rar-plugin
> - par packaging: ?
> {{LifecycleMappings}} 
> http://maven.apache.org/ref/3.2.5/maven-core/default-bindings.html
> {{ArtifactHandlers}} 
> http://maven.apache.org/ref/3.2.5/maven-core/artifact-handlers.html
> Maven core should then get the lifecycle mappings and artifact handlers 
> configurations from the plugin at the beginning or the build, before begin 
> able to calculate the build plan



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MNG-5697) remove LifecycleMapping and ArtifactHandler from maven-core: move to target packaging plugin

2022-07-05 Thread Herve Boutemy (Jira)



 [ 
https://issues.apache.org/jira/browse/MNG-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy updated MNG-5697:
---
Description: 
Maven Core should only be aware of the pom packaging details, the rest of the 
{{ArtifactHandlers}} and {{LifecycleMappings}} should be moved to their own 
packaging plugin:
- jar packaging: maven-jar-plugin
- ejb and ejb3 packagings: maven-ejb-plugin
- maven-plugin packaging: maven-plugin-plugin
- war packaging: maven-war-plugin
- ear packaging: maven-ear-plugin
- rar packaging: maven-rar-plugin
- par packaging: ?

{{LifecycleMappings}} 
http://maven.apache.org/ref/3.2.5/maven-core/default-bindings.html
{{ArtifactHandlers}} 
http://maven.apache.org/ref/3.2.5/maven-core/artifact-handlers.html

*Maven core should then get the lifecycle mappings and artifact handlers 
configurations from the plugin at the beginning or the build, before begin able 
to calculate the build plan*


  was:
Maven Core should only be aware of the pom packaging details, the rest of the 
{{ArtifactHandlers}} and {{LifecycleMappings}} should be moved to their own 
packaging plugin:
- jar packaging: maven-jar-plugin
- ejb and ejb3 packagings: maven-ejb-plugin
- maven-plugin packaging: maven-plugin-plugin
- war packaging: maven-war-plugin
- ear packaging: maven-ear-plugin
- rar packaging: maven-rar-plugin
- par packaging: ?

{{LifecycleMappings}} 
http://maven.apache.org/ref/3.2.5/maven-core/default-bindings.html
{{ArtifactHandlers}} 
http://maven.apache.org/ref/3.2.5/maven-core/artifact-handlers.html

Maven core should then get the lifecycle mappings and artifact handlers 
configurations from the plugin at the beginning or the build, before begin able 
to calculate the build plan



> remove LifecycleMapping and ArtifactHandler from maven-core: move to target 
> packaging plugin
> 
>
> Key: MNG-5697
> URL: https://issues.apache.org/jira/browse/MNG-5697
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Reporter: Robert Scholte
>Priority: Major
> Fix For: 4.x / Backlog
>
>
> Maven Core should only be aware of the pom packaging details, the rest of the 
> {{ArtifactHandlers}} and {{LifecycleMappings}} should be moved to their own 
> packaging plugin:
> - jar packaging: maven-jar-plugin
> - ejb and ejb3 packagings: maven-ejb-plugin
> - maven-plugin packaging: maven-plugin-plugin
> - war packaging: maven-war-plugin
> - ear packaging: maven-ear-plugin
> - rar packaging: maven-rar-plugin
> - par packaging: ?
> {{LifecycleMappings}} 
> http://maven.apache.org/ref/3.2.5/maven-core/default-bindings.html
> {{ArtifactHandlers}} 
> http://maven.apache.org/ref/3.2.5/maven-core/artifact-handlers.html
> *Maven core should then get the lifecycle mappings and artifact handlers 
> configurations from the plugin at the beginning or the build, before begin 
> able to calculate the build plan*



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (MNGSITE-486) Broken link to JDK toolchain version range definitions

2022-07-05 Thread Andrey (Jira)

Andrey created MNGSITE-486:
--

 Summary: Broken link to JDK toolchain version range definitions
 Key: MNGSITE-486
 URL: https://issues.apache.org/jira/browse/MNGSITE-486
 Project: Maven Project Web Site
  Issue Type: Bug
Reporter: Andrey
 Attachments: image-2022-07-05-15-46-17-107.png

[https://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/jdk.html]

!image-2022-07-05-15-46-17-107.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-integration-testing] michael-o commented on pull request #176: Move ITs to JDK 8 / JUnit 5

2022-07-05 Thread GitBox



michael-o commented on PR #176:
URL: 
https://github.com/apache/maven-integration-testing/pull/176#issuecomment-1175024899

   @gnodet Does 8b575970d5ace770560d1f6b60fc226fab11e51f find the symptom or 
the cause? Why does not happen at all now, not before?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] gnodet commented on pull request #176: Move ITs to JDK 8 / JUnit 5

2022-07-05 Thread GitBox



gnodet commented on PR #176:
URL: 
https://github.com/apache/maven-integration-testing/pull/176#issuecomment-1175031065

   > @gnodet Does 
[8b57597](https://github.com/apache/maven-integration-testing/commit/8b575970d5ace770560d1f6b60fc226fab11e51f)
 find the symptom or the cause? Why does not happen at all now, not before?
   
   However, I found out that the error `[SUREFIRE] std/in stream corrupted` is 
caused by the input stream being closed and `plexus-interactivity-api` does 
close the input stream, so I'm trying to work around the problem.
   I don't really know why this happen now and not before though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Moved] (MTOOLCHAINS-41) Broken link to JDK toolchain version range definitions

2022-07-05 Thread Michael Osipov (Jira)



 [ 
https://issues.apache.org/jira/browse/MTOOLCHAINS-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov moved MNGSITE-486 to MTOOLCHAINS-41:
---

Key: MTOOLCHAINS-41  (was: MNGSITE-486)
Project: Maven Toolchains Plugin  (was: Maven Project Web Site)

> Broken link to JDK toolchain version range definitions
> --
>
> Key: MTOOLCHAINS-41
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-41
> Project: Maven Toolchains Plugin
>  Issue Type: Bug
>Reporter: Andrey
>Priority: Major
> Attachments: image-2022-07-05-15-46-17-107.png
>
>
> [https://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/jdk.html]
> !image-2022-07-05-15-46-17-107.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-integration-testing] gnodet commented on pull request #176: Move ITs to JDK 8 / JUnit 5

2022-07-05 Thread GitBox



gnodet commented on PR #176:
URL: 
https://github.com/apache/maven-integration-testing/pull/176#issuecomment-1175079712

   It does not seem to be enough. The problem is that I can't really reproduce 
it locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] chalmagr commented on pull request #516: [SUREFIRE-2065] Test Reports Inconsistencies with Parameterized and junit4

2022-07-05 Thread GitBox



chalmagr commented on PR #516:
URL: https://github.com/apache/maven-surefire/pull/516#issuecomment-1175088348

   @Tibor17 are you still available to look into this? should someone else be 
pulled in?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MTOOLCHAINS-41) Broken link to JDK toolchain version range definitions

2022-07-05 Thread Slawomir Jaranowski (Jira)



[ 
https://issues.apache.org/jira/browse/MTOOLCHAINS-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562694#comment-17562694
 ] 

Slawomir Jaranowski commented on MTOOLCHAINS-41:


Should be https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html

> Broken link to JDK toolchain version range definitions
> --
>
> Key: MTOOLCHAINS-41
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-41
> Project: Maven Toolchains Plugin
>  Issue Type: Bug
>Reporter: Andrey
>Priority: Major
> Attachments: image-2022-07-05-15-46-17-107.png
>
>
> [https://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/jdk.html]
> !image-2022-07-05-15-46-17-107.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (MASSEMBLY-965) Symbolic links get copied with absolute path

2022-07-05 Thread Marc Guillemot (Jira)

Marc Guillemot created MASSEMBLY-965:


 Summary: Symbolic links get copied with absolute path
 Key: MASSEMBLY-965
 URL: https://issues.apache.org/jira/browse/MASSEMBLY-965
 Project: Maven Assembly Plugin
  Issue Type: Bug
Affects Versions: 3.4.0
Reporter: Marc Guillemot


Copied symbolic links in a `` have an absolute path as target and not 
the one of the original resource.

Example:

Source: {{foo -> ../my-file1}}

Assembly: {{foo ->/home/marc/projects/demo/src/somestuff/myfile1}}

This is a regression compared to 3.3.0. According to git bisect, the problem 
has been introduced with commit

[https://github.com/apache/maven-assembly-plugin/commit/937750250bfe06333f92351fa1a19a9cd5e59d28]

Pull Request with failing integration test follows.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-assembly-plugin] mguillem opened a new pull request, #82: [MASSEMBLY-965] integration test ensuring correct copy of symbolic link

2022-07-05 Thread GitBox



mguillem opened a new pull request, #82:
URL: https://github.com/apache/maven-assembly-plugin/pull/82

   This is an integration test illustrating the regression. It doesn't fix it.
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] michael-o commented on pull request #176: Move ITs to JDK 8 / JUnit 5

2022-07-05 Thread GitBox



michael-o commented on PR #176:
URL: 
https://github.com/apache/maven-integration-testing/pull/176#issuecomment-1175145751

   > > @gnodet Does 
[8b57597](https://github.com/apache/maven-integration-testing/commit/8b575970d5ace770560d1f6b60fc226fab11e51f)
 find the symptom or the cause? Why does not happen at all now, not before?
   > 
   > I found out that the error `[SUREFIRE] std/in stream corrupted` is caused 
by the input stream being closed and `plexus-interactivity-api` does close the 
input stream, so I'm trying to work around the problem. I don't really know why 
this happen now and not before though.
   
   Interesting, how is this here involved? What if we supply always batch mode?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-integration-testing] gnodet commented on pull request #176: Move ITs to JDK 8 / JUnit 5

2022-07-05 Thread GitBox



gnodet commented on PR #176:
URL: 
https://github.com/apache/maven-integration-testing/pull/176#issuecomment-1175157588

   > > > @gnodet Does 
[8b57597](https://github.com/apache/maven-integration-testing/commit/8b575970d5ace770560d1f6b60fc226fab11e51f)
 find the symptom or the cause? Why does not happen at all now, not before?
   > > 
   > > 
   > > I found out that the error `[SUREFIRE] std/in stream corrupted` is 
caused by the input stream being closed and `plexus-interactivity-api` does 
close the input stream, so I'm trying to work around the problem. I don't 
really know why this happen now and not before though.
   > 
   > Interesting, how is this here involved? What if we supply always batch 
mode?
   
   The `plexus-interactivity-api` is a dependency of several plugins like 
`maven-jar-plugin:2.4`, or `maven-resources-plugin:2.6` and also 
`maven-it-plugin-uses-wagon`.  The `plexus-interactivity-api` defines a 
plexus-component `DefaultInputHandler` which is activated by the plexus 
container started by the `Verifier`. This component creates a console reader on 
top of the `System.in` stream and closes the reader when the component is 
disposed.  This call causes the underlying `System.in` stream to be closed.   
This is problematic when surefire embeds the test (i.e. not forking), because 
surefire does use the standard input stream as a way to communicate with the 
forked JVM.  Hence the error displayed by surefire that the std/in has been 
closed.
   
   In a real scenario, this is usually not a problem.  And also, this has been 
fixed a few months ago by 
https://github.com/codehaus-plexus/plexus-interactivity/commit/58cbbe06afd5ad61b9481180e9228c6e7cea187c,
 so recent plugins won't suffer from this problem.
   
   Anyway, to support tests that do use the old API, we need to wrap the 
`System.in` in a non closeable stream before booting the plexus container.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] Tibor17 commented on pull request #516: [SUREFIRE-2065] Test Reports Inconsistencies with Parameterized and junit4

2022-07-05 Thread GitBox



Tibor17 commented on PR #516:
URL: https://github.com/apache/maven-surefire/pull/516#issuecomment-1175171232

   @chalmagr 
   @br0nstein 
   I have returned back from my trip and I want to continue on my local 
changes, and my local changes are the solution for your problem and we can 
proove my fix with your IT but the change in `RunListenerAdapter` is the last 
change of all changes and the most probable fix would appear in 
`TestSetRunListener` + `StatelessXmlReporter` + M6 release. So I will show you 
my PR, and there you will see why the **stateful** JUnit5 reports were chaotic 
in rerun and parallel exec too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (MWRAPPER-72) Windows mvnw.cmd from root directory of drive fails with java usage display

2022-07-05 Thread Clifford W Johnson (Jira)



 [ 
https://issues.apache.org/jira/browse/MWRAPPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clifford W Johnson updated MWRAPPER-72:
---
Description: 
Attempting to use {{.\mvnw.cmd}} when the project root is at the root of a 
Windows drive (as would happen if {{subst Z: }} is used) results in 
the script displaying the `java` usage information and not performing the 
expected Maven operation. It seems that `java` has an issue in parsing the 
command line argument {{{}"-Dmaven.multiModuleProjectDirectory=Z:\"{}}}.

My local work-around was to append a dot/period ({{{}.{}}}) to the {{EXEC_DIR}} 
if {{EXEC_DIR}} ends with {{{}:{}}}.

  was:
Attempting to use {{.\mvnw.cmd}} when the project root is at the root of a 
Windows drive (as would happen if {{subst Z: }} is used) results in 
the script displaying the `java` usage information and not performing the 
expected Maven operation. It seems that `java` has an issue in parsing the 
command line argument {{{}"-Dmaven.multiModuleProjectDirectory=Z:\"{}}}.

My local work-around was to append a dot/period ({{{}.{}}}) to the {{EXEC_DIR}} 
if \{EXEC_DIR}} ends with {{{}:\{}}}.


> Windows mvnw.cmd from root directory of drive fails with java usage display
> ---
>
> Key: MWRAPPER-72
> URL: https://issues.apache.org/jira/browse/MWRAPPER-72
> Project: Maven Wrapper
>  Issue Type: Bug
>  Components: Maven Wrapper Scripts
>Affects Versions: 0.5.6
> Environment: Windows 10
>Reporter: Clifford W Johnson
>Priority: Normal
> Attachments: mvnw-cmd_failure.txt
>
>
> Attempting to use {{.\mvnw.cmd}} when the project root is at the root of a 
> Windows drive (as would happen if {{subst Z: }} is used) results 
> in the script displaying the `java` usage information and not performing the 
> expected Maven operation. It seems that `java` has an issue in parsing the 
> command line argument {{{}"-Dmaven.multiModuleProjectDirectory=Z:\"{}}}.
> My local work-around was to append a dot/period ({{{}.{}}}) to the 
> {{EXEC_DIR}} if {{EXEC_DIR}} ends with {{{}:{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (MWRAPPER-72) Windows mvnw.cmd from root directory of drive fails with java usage display

2022-07-05 Thread Clifford W Johnson (Jira)

Clifford W Johnson created MWRAPPER-72:
--

 Summary: Windows mvnw.cmd from root directory of drive fails with 
java usage display
 Key: MWRAPPER-72
 URL: https://issues.apache.org/jira/browse/MWRAPPER-72
 Project: Maven Wrapper
  Issue Type: Bug
  Components: Maven Wrapper Scripts
Affects Versions: 0.5.6
 Environment: Windows 10
Reporter: Clifford W Johnson
 Attachments: mvnw-cmd_failure.txt

Attempting to use {{.\mvnw.cmd}} when the project root is at the root of a 
Windows drive (as would happen if {{subst Z: }} is used) results in 
the script displaying the `java` usage information and not performing the 
expected Maven operation. It seems that `java` has an issue in parsing the 
command line argument {{{}"-Dmaven.multiModuleProjectDirectory=Z:\"{}}}.

My local work-around was to append a dot/period ({{{}.{}}}) to the {{EXEC_DIR}} 
if \{EXEC_DIR}} ends with {{{}:\{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MWRAPPER-72) Windows mvnw.cmd from root directory of drive fails with java usage display

2022-07-05 Thread Clifford W Johnson (Jira)



 [ 
https://issues.apache.org/jira/browse/MWRAPPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clifford W Johnson updated MWRAPPER-72:
---
Description: 
Attempting to use {{.\mvnw.cmd}} when the project root is at the root of a 
Windows drive (as would happen if {{subst Z: }} is used) results in 
the script displaying the `java` usage information and not performing the 
expected Maven operation. It seems that `java` has an issue in parsing the 
command line argument {{{}"-Dmaven.multiModuleProjectDirectory=Z:\"{}}}.

My local work-around was to append a dot/period ({{{}.{}}}) to the {{EXEC_DIR}} 
if {{EXEC_DIR}} ends with {{{}:\{}}}.

  was:
Attempting to use {{.\mvnw.cmd}} when the project root is at the root of a 
Windows drive (as would happen if {{subst Z: }} is used) results in 
the script displaying the `java` usage information and not performing the 
expected Maven operation. It seems that `java` has an issue in parsing the 
command line argument {{{}"-Dmaven.multiModuleProjectDirectory=Z:\"{}}}.

My local work-around was to append a dot/period ({{{}.{}}}) to the {{EXEC_DIR}} 
if {{EXEC_DIR}} ends with {{{}:{}}}.


> Windows mvnw.cmd from root directory of drive fails with java usage display
> ---
>
> Key: MWRAPPER-72
> URL: https://issues.apache.org/jira/browse/MWRAPPER-72
> Project: Maven Wrapper
>  Issue Type: Bug
>  Components: Maven Wrapper Scripts
>Affects Versions: 0.5.6
> Environment: Windows 10
>Reporter: Clifford W Johnson
>Priority: Normal
> Attachments: mvnw-cmd_failure.txt
>
>
> Attempting to use {{.\mvnw.cmd}} when the project root is at the root of a 
> Windows drive (as would happen if {{subst Z: }} is used) results 
> in the script displaying the `java` usage information and not performing the 
> expected Maven operation. It seems that `java` has an issue in parsing the 
> command line argument {{{}"-Dmaven.multiModuleProjectDirectory=Z:\"{}}}.
> My local work-around was to append a dot/period ({{{}.{}}}) to the 
> {{EXEC_DIR}} if {{EXEC_DIR}} ends with {{{}:\{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MWRAPPER-72) Windows mvnw.cmd from root directory of drive fails with java usage display

2022-07-05 Thread Clifford W Johnson (Jira)



 [ 
https://issues.apache.org/jira/browse/MWRAPPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clifford W Johnson updated MWRAPPER-72:
---
Description: 
Attempting to use {{.\mvnw.cmd}} when the project root is at the root of a 
Windows drive (as would happen if {{subst Z: }} is used) results in 
the script displaying the `java` usage information and not performing the 
expected Maven operation. It seems that `java` has an issue in parsing the 
command line argument {{{}"-Dmaven.multiModuleProjectDirectory=Z:\"{}}}.

My local work-around was to append a dot/period ({{{}.{}}}) to the {{EXEC_DIR}} 
if {{EXEC_DIR}} ends with {{}} {{":\"{}}}.

  was:
Attempting to use {{.\mvnw.cmd}} when the project root is at the root of a 
Windows drive (as would happen if {{subst Z: }} is used) results in 
the script displaying the `java` usage information and not performing the 
expected Maven operation. It seems that `java` has an issue in parsing the 
command line argument {{{}"-Dmaven.multiModuleProjectDirectory=Z:\"{}}}.

My local work-around was to append a dot/period ({{{}.{}}}) to the {{EXEC_DIR}} 
if {{EXEC_DIR}} ends with {{{}:\{}}}.


> Windows mvnw.cmd from root directory of drive fails with java usage display
> ---
>
> Key: MWRAPPER-72
> URL: https://issues.apache.org/jira/browse/MWRAPPER-72
> Project: Maven Wrapper
>  Issue Type: Bug
>  Components: Maven Wrapper Scripts
>Affects Versions: 0.5.6
> Environment: Windows 10
>Reporter: Clifford W Johnson
>Priority: Normal
> Attachments: mvnw-cmd_failure.txt
>
>
> Attempting to use {{.\mvnw.cmd}} when the project root is at the root of a 
> Windows drive (as would happen if {{subst Z: }} is used) results 
> in the script displaying the `java` usage information and not performing the 
> expected Maven operation. It seems that `java` has an issue in parsing the 
> command line argument {{{}"-Dmaven.multiModuleProjectDirectory=Z:\"{}}}.
> My local work-around was to append a dot/period ({{{}.{}}}) to the 
> {{EXEC_DIR}} if {{EXEC_DIR}} ends with {{}} {{":\"{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (MWRAPPER-73) Empty maven property cause to invalid configuration

2022-07-05 Thread Slawomir Jaranowski (Jira)

Slawomir Jaranowski created MWRAPPER-73:
---

 Summary: Empty maven property cause to invalid configuration
 Key: MWRAPPER-73
 URL: https://issues.apache.org/jira/browse/MWRAPPER-73
 Project: Maven Wrapper
  Issue Type: Bug
Reporter: Slawomir Jaranowski


When {{maven}} property in not set at all, than current system Maven version is 
used in configuration.

When execute with {{-Dmaven}} or {{-Dmaven=}} we will have invalid configuration



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-indexer] StefSC commented on pull request #227: [MINDEXER-155] Add Maven site descriptor for all modules

2022-07-05 Thread GitBox



StefSC commented on PR #227:
URL: https://github.com/apache/maven-indexer/pull/227#issuecomment-1175348184

   @slawekjaranowski - I did it the same as the ones that were already there 
(indexer-cli, etc). 
   Do you want me to modify those files as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wrapper] michael-o commented on a diff in pull request #44: [MWRAPPER-67] Remove invalid line endings from wrapperUrl when used with git bash with mvnw script

2022-07-05 Thread GitBox



michael-o commented on code in PR #44:
URL: https://github.com/apache/maven-wrapper/pull/44#discussion_r914154356


##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -192,7 +192,8 @@ else
   
wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar";
 fi
 while IFS="=" read key value; do
-  case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
+  # Remove invalid line endings from value
+  case "$key" in (wrapperUrl) wrapperUrl="${value%$'\r'}"; break ;;

Review Comment:
   Not this month. I have basically no interest in the wrapper since I consider 
it more or less pointless.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MWRAPPER-67) mvnw script does not download jar if used in git bash in windows

2022-07-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MWRAPPER-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562826#comment-17562826
 ] 

ASF GitHub Bot commented on MWRAPPER-67:


michael-o commented on code in PR #44:
URL: https://github.com/apache/maven-wrapper/pull/44#discussion_r914154356


##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -192,7 +192,8 @@ else
   
wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar";
 fi
 while IFS="=" read key value; do
-  case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
+  # Remove invalid line endings from value
+  case "$key" in (wrapperUrl) wrapperUrl="${value%$'\r'}"; break ;;

Review Comment:
   Not this month. I have basically no interest in the wrapper since I consider 
it more or less pointless.





> mvnw script does not download jar if used in git bash in windows
> 
>
> Key: MWRAPPER-67
> URL: https://issues.apache.org/jira/browse/MWRAPPER-67
> Project: Maven Wrapper
>  Issue Type: Bug
>  Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Jeremy Landis
>Priority: Minor
>
> Usage of git bash will not download the maven wrapper jar along with curl 
> (probably others) due to having windows line endings in the URL (trailing).  
> To ensure that is not the case, make sure to strip invalid line endings out 
> before usage.
> Use case, ./mvnw in powershell will use mvnw.cmd and has no issues 
> downloading.  If user does same in git bash, it will fail with invalid URL 
> error with curl.  Using ./mvnw.cmd there will work but not natural usage.  To 
> ensure this simply just works for full support, trim out invalid line feeds.
> note: This only affected the download.  It worked otherwise.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven] jtnord closed pull request #133: [MNG-5600] Dependency management import should support exclusions.

2022-07-05 Thread GitBox



jtnord closed pull request #133: [MNG-5600] Dependency management import should 
support exclusions.
URL: https://github.com/apache/maven/pull/133


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-5600) Dependency management import should support exclusions.

2022-07-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562829#comment-17562829
 ] 

ASF GitHub Bot commented on MNG-5600:
-

jtnord closed pull request #133: [MNG-5600] Dependency management import should 
support exclusions.
URL: https://github.com/apache/maven/pull/133




> Dependency management import should support exclusions.
> ---
>
> Key: MNG-5600
> URL: https://issues.apache.org/jira/browse/MNG-5600
> Project: Maven
>  Issue Type: Improvement
>  Components: Dependencies
>Reporter: Radai Rosenblatt
>Priority: Major
> Fix For: 4.0.x-candidate
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> suppose i have a multi-module project that uses spring, and so have this in 
> dependency-managements in a parent pom:
> {code:xml}
> 
>   org.springframework
>   spring-framework-bom
>   ${org.springframework.version}
>   pom
>   import   
> 
> {code}
> spring artifacts (or at least a lot of them) have a dependency on 
> commons-logging. right now, if i want to exclude commons-logging i have to 
> add an exclusion to every spring dependency in every module of my project, 
> which is actually more XML overall than giving up on using the bom dependency 
> altogether and listing all spring dependencies with excludes once in the 
> parent dependency management.
> I'd like to be able to do this:
> {code:xml}
> 
>   org.springframework
>   spring-framework-bom
>   ${org.springframework.version}
>   pom
>   import
>   
>   
>   commons-logging
>   commons-logging
>   
>   
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-mvnd] eperret commented on issue #637: Timeout waiting to connect to the Maven daemon

2022-07-05 Thread GitBox



eperret commented on issue #637:
URL: https://github.com/apache/maven-mvnd/issues/637#issuecomment-1175721540

   It failed for me as well.  I'm using JDK 11.0.9.1 on Mac OS 12.4
   ```
   Exception in thread "main" 
org.mvndaemon.mvnd.common.DaemonException$ConnectException: Could not connect 
to the Maven daemon.
   Daemon id: d542b597
 log file: /Users/user_name/.m2/mvnd/registry/0.8.0/daemon-d542b597.log
   - Last  200 lines from daemon log file - 
/Users/user_name/.m2/mvnd/registry/0.8.0/daemon-d542b597.log -
   19:48:52.056 D Initializing daemon with properties:
mvnd.home=/usr/local/Cellar/mvnd/0.8.0/libexec
jdk.java.options=--add-opens java.base/java.io=ALL-UNNAMED --add-opens 
java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED 
--add-opens java.base/sun.net.www.protocol.jar=ALL-UNNAMED --add-opens 
java.base/sun.nio.fs=ALL-UNNAMED
mvnd.noDaemon=false
mvnd.debug=false
mvnd.idleTimeout=3h
mvnd.keepAlive=100ms
mvnd.extClasspath=
mvnd.coreExtensions=
mvnd.enableAssertions=false
mvnd.expirationCheckDelay=10s
mvnd.duplicateDaemonGracePeriod=10s
mvnd.socketFamily=inet
   
   19:48:52.061 I Daemon started
   19:48:52.062 D daemon is running. Sleeping until state changes.
   - End of the daemon log file -
 output: /Users/user_name/.m2/mvnd/registry/0.8.0/daemon-d542b597.out.log
   - Last  200 lines from daemon output - 
/Users/user_name/.m2/mvnd/registry/0.8.0/daemon-d542b597.out.log -
   NOTE: Picked up JDK_JAVA_OPTIONS: --add-opens java.base/java.io=ALL-UNNAMED 
--add-opens java.base/java.lang=ALL-UNNAMED --add-opens 
java.base/java.util=ALL-UNNAMED --add-opens 
java.base/sun.net.www.protocol.jar=ALL-UNNAMED --add-opens 
java.base/sun.nio.fs=ALL-UNNAMED
   - End of the daemon output -
   
at 
org.mvndaemon.mvnd.client.DaemonConnector.connectToDaemonWithId(DaemonConnector.java:435)
at 
org.mvndaemon.mvnd.client.DaemonConnector.startDaemon(DaemonConnector.java:287)
at 
org.mvndaemon.mvnd.client.DaemonConnector.connect(DaemonConnector.java:121)
at 
org.mvndaemon.mvnd.client.DefaultClient.execute(DefaultClient.java:284)
at org.mvndaemon.mvnd.client.DefaultClient.main(DefaultClient.java:129)
   Caused by: org.mvndaemon.mvnd.common.DaemonException$ConnectException: Could 
not connect to server /127.0.0.1:58138.
at 
org.mvndaemon.mvnd.client.DaemonConnector.connect(DaemonConnector.java:517)
at 
org.mvndaemon.mvnd.client.DaemonConnector.connectToDaemon(DaemonConnector.java:446)
at 
org.mvndaemon.mvnd.client.DaemonConnector.connectToDaemonWithId(DaemonConnector.java:432)
... 4 more
   Caused by: java.io.IOException: Timeout
at 
org.mvndaemon.mvnd.client.DaemonConnector.connect(DaemonConnector.java:494)
... 6 more
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #50: add a clean to ensure we do not lock files for a windows build

2022-07-05 Thread GitBox



slawekjaranowski commented on PR #50:
URL: 
https://github.com/apache/maven-gh-actions-shared/pull/50#issuecomment-1175801725

   pleas add `--errors --batch-mode --show-version` to command
   and add the same to `fail-fast-build`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gh-actions-shared] slawekjaranowski merged pull request #49: Matrix build with many Maven versions

2022-07-05 Thread GitBox



slawekjaranowski merged PR #49:
URL: https://github.com/apache/maven-gh-actions-shared/pull/49


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wrapper] slawekjaranowski opened a new pull request, #55: [MWRAPPER-73] Allow empty maven version property

2022-07-05 Thread GitBox



slawekjaranowski opened a new pull request, #55:
URL: https://github.com/apache/maven-wrapper/pull/55

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MWRAPPER) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MWRAPPER-73) Empty maven property cause to invalid configuration

2022-07-05 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MWRAPPER-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562965#comment-17562965
 ] 

ASF GitHub Bot commented on MWRAPPER-73:


slawekjaranowski opened a new pull request, #55:
URL: https://github.com/apache/maven-wrapper/pull/55

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MWRAPPER) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Empty maven property cause to invalid configuration
> ---
>
> Key: MWRAPPER-73
> URL: https://issues.apache.org/jira/browse/MWRAPPER-73
> Project: Maven Wrapper
>  Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> When {{maven}} property in not set at all, than current system Maven version 
> is used in configuration.
> When execute with {{-Dmaven}} or {{-Dmaven=}} we will have invalid 
> configuration



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-site] ravn commented on pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-05 Thread GitBox



ravn commented on PR #308:
URL: https://github.com/apache/maven-site/pull/308#issuecomment-1175829420

   I have removed deprecated bits.  The file shrunk quite a bit 🙂 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

57 matches

Mail list logo