olamy commented on code in PR #49:
URL:
https://github.com/apache/maven-gh-actions-shared/pull/49#discussion_r913636164
##########
.github/workflows/maven-verify.yml:
##########
@@ -20,54 +20,54 @@ name: Verify
on:
workflow_call:
inputs:
- maven_args:
+ maven-args:
description: The arguments to pass to all Maven commands when building
the code
required: false
default: '-D"invoker.streamLogsOnFailures"'
type: string
- maven_version:
- description: The Maven version used for builds
- required: false
- default: '3.8.6'
- type: string
-
os-matrix:
- description: 'os matrix as json array'
+ description: os matrix as json array
required: false
default: '[ "ubuntu-latest", "windows-latest", "macOS-latest" ]'
type: string
jdk-matrix:
- description: 'jdk matrix as json array'
+ description: jdk matrix as json array
required: false
default: '[ "8", "11", "17" ]'
type: string
+ jdk-distribution-matrix:
+ description: jdk distribution matrix
+ required: false
+ default: '[ "temurin" ]'
+ type: string
+
+ maven-matrix:
+ description: The Maven version matrix as json array
+ required: false
+ default: '[ "3.8.6" ]'
+ type: string
+
matrix-exclude:
- description: 'exclude for matrix as json'
+ description: exclude for matrix as json
required: false
default: '[]'
type: string
max-parallel:
- description: 'max parallel jobs'
+ description: max parallel jobs
required: false
default: 100
type: number
timeout-minutes:
- description: 'timeout-minutes used by the builds (defaults to 360)'
+ description: timeout-minutes used by the builds (defaults to 360)
required: false
default: 360
type: number
- jdk-distribution-matrix:
Review Comment:
is this compatible for builds currently using this argument? (such
https://github.com/apache/maven-compiler-plugin/blob/master/.github/workflows/maven-verify.yml)
or because it;s v3 we don;t care and we will maintaining 2 branches?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
