olamy commented on code in PR #50:
URL:
https://github.com/apache/maven-gh-actions-shared/pull/50#discussion_r913662891
##########
.github/workflows/maven-verify.yml:
##########
@@ -272,6 +272,10 @@ jobs:
- name: Build with Maven
if: steps.should-run.conclusion == 'success'
run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven_args
}} ${{ inputs.verify-goal }}
+
+ - name: Clean Ensuring no file handle remains open on windows
+ if: steps.should-run.conclusion == 'success'
+ run: ./mvnw clean
Review Comment:
yes for sure but this is not the goal of the check.
The goal is to be sure we do not left file for people who wants to build
this locally.
if you cannot run `mvn test` then `mvn clean test` because of file leaking
in a windows env we should consider this as a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
