[
https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562422#comment-17562422
]
ASF GitHub Bot commented on MNG-7353:
-------------------------------------
mthmulders commented on code in PR #757:
URL: https://github.com/apache/maven/pull/757#discussion_r913478933
##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java:
##########
@@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task,
MavenSession session, Mave
}
else if ( numTokens == 3 )
{
- // We have everything that we need except the version
- //
- //
org.apache.maven.plugins:maven-remote-resources-plugin:???:process
- //
- // groupId
- // artifactId
- // ???
- // goal
- //
- plugin = new Plugin();
- plugin.setGroupId( tok.nextToken() );
- plugin.setArtifactId( tok.nextToken() );
+ // groupId:artifactId:goal or pluginPrefix:version:goal (since
Maven 3.9)
+
+ String firstToken = tok.nextToken();
+ // groupId or pluginPrefix? heuristics: groupId contains . but not
pluginPrefix
+ if ( firstToken.contains( "." ) )
Review Comment:
I gave it some thought, but I can't find a better heuristic either. The only
thing more or less foolproof would be to look at the first token, assuming it
is a plugin prefix. If that lookup yields nothing, it would be a groupId.
Even that is not 100% safe, though. Imagine you're not connected to the
network, so lookup fails, so we decide it's a groupId
> add support for "mvn pluginPrefix:version:goal"
> -----------------------------------------------
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
> Issue Type: New Feature
> Components: Command Line
> Affects Versions: 3.8.4
> Reporter: Herve Boutemy
> Priority: Major
> Fix For: 4.0.x-candidate
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
