[jira] [Commented] (DOXIA-590) Either provided element class or default class gets ignored
[
https://issues.apache.org/jira/browse/DOXIA-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540552#comment-17540552
]
ASF GitHub Bot commented on DOXIA-590:
--
michael-o commented on code in PR #98:
URL: https://github.com/apache/maven-doxia/pull/98#discussion_r878813984
##
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java:
##
@@ -1567,21 +1567,24 @@ public void tableRow()
@Override
public void tableRow( SinkEventAttributes attributes )
{
-MutableAttributeSet att = new SinkEventAttributeSet();
+MutableAttributeSet atts = SinkUtils.filterAttributes(
+attributes, SinkUtils.SINK_TR_ATTRIBUTES );
-if ( evenTableRow )
+if ( atts == null )
{
-att.addAttribute( Attribute.CLASS, "a" );
+atts = new SinkEventAttributeSet();
}
-else
+
+String rowClass = evenTableRow ? "a" : "b";
+if ( atts.isDefined( Attribute.CLASS.toString() ) )
{
-att.addAttribute( Attribute.CLASS, "b" );
+String givenRowClass = (String) atts.getAttribute(
Attribute.CLASS.toString() );
+rowClass = givenRowClass + " " + rowClass;
Review Comment:
Let me get back to you when I have sorted out issues in Maven SCM.
##
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java:
##
@@ -1567,21 +1567,24 @@ public void tableRow()
@Override
public void tableRow( SinkEventAttributes attributes )
{
-MutableAttributeSet att = new SinkEventAttributeSet();
+MutableAttributeSet atts = SinkUtils.filterAttributes(
+attributes, SinkUtils.SINK_TR_ATTRIBUTES );
-if ( evenTableRow )
+if ( atts == null )
{
-att.addAttribute( Attribute.CLASS, "a" );
+atts = new SinkEventAttributeSet();
}
-else
+
+String rowClass = evenTableRow ? "a" : "b";
+if ( atts.isDefined( Attribute.CLASS.toString() ) )
{
-att.addAttribute( Attribute.CLASS, "b" );
+String givenRowClass = (String) atts.getAttribute(
Attribute.CLASS.toString() );
+rowClass = givenRowClass + " " + rowClass;
Review Comment:
Let me get back to you after I have sorted out issues in Maven SCM.
> Either provided element class or default class gets ignored
> ---
>
> Key: DOXIA-590
> URL: https://issues.apache.org/jira/browse/DOXIA-590
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.8
>Reporter: Fred Eckertson
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M3, 1.11.2
>
> Attachments: image-2022-05-18-21-57-40-619.png
>
>
> The following construct is somewhat common in doxia-core
> att.addAttribute( Attribute.CLASS, "a" );
> The documentation says that basic attributes (including CLASS) are supported.
> However in cases like this either that "a" or the CLASS that was provided in
> the attributes parameter will be ignored. The correct way to do this is to
> append the provided CLASS to "a " if a CLASS attribute was provided.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-doxia] michael-o commented on a diff in pull request #98: [DOXIA-590] Either provided element class or default class gets ignored
michael-o commented on code in PR #98:
URL: https://github.com/apache/maven-doxia/pull/98#discussion_r878813984
##
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java:
##
@@ -1567,21 +1567,24 @@ public void tableRow()
@Override
public void tableRow( SinkEventAttributes attributes )
{
-MutableAttributeSet att = new SinkEventAttributeSet();
+MutableAttributeSet atts = SinkUtils.filterAttributes(
+attributes, SinkUtils.SINK_TR_ATTRIBUTES );
-if ( evenTableRow )
+if ( atts == null )
{
-att.addAttribute( Attribute.CLASS, "a" );
+atts = new SinkEventAttributeSet();
}
-else
+
+String rowClass = evenTableRow ? "a" : "b";
+if ( atts.isDefined( Attribute.CLASS.toString() ) )
{
-att.addAttribute( Attribute.CLASS, "b" );
+String givenRowClass = (String) atts.getAttribute(
Attribute.CLASS.toString() );
+rowClass = givenRowClass + " " + rowClass;
Review Comment:
Let me get back to you when I have sorted out issues in Maven SCM.
##
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java:
##
@@ -1567,21 +1567,24 @@ public void tableRow()
@Override
public void tableRow( SinkEventAttributes attributes )
{
-MutableAttributeSet att = new SinkEventAttributeSet();
+MutableAttributeSet atts = SinkUtils.filterAttributes(
+attributes, SinkUtils.SINK_TR_ATTRIBUTES );
-if ( evenTableRow )
+if ( atts == null )
{
-att.addAttribute( Attribute.CLASS, "a" );
+atts = new SinkEventAttributeSet();
}
-else
+
+String rowClass = evenTableRow ? "a" : "b";
+if ( atts.isDefined( Attribute.CLASS.toString() ) )
{
-att.addAttribute( Attribute.CLASS, "b" );
+String givenRowClass = (String) atts.getAttribute(
Attribute.CLASS.toString() );
+rowClass = givenRowClass + " " + rowClass;
Review Comment:
Let me get back to you after I have sorted out issues in Maven SCM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-scm] asfgit closed pull request #138: [SCM-980] Remove code duplication in ListMojo
asfgit closed pull request #138: [SCM-980] Remove code duplication in ListMojo URL: https://github.com/apache/maven-scm/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] asfgit merged pull request #139: [SCM-943] scm:check-local-modification does not support excludes
asfgit merged PR #139: URL: https://github.com/apache/maven-scm/pull/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-943) scm:check-local-modification does not support excludes
[
https://issues.apache.org/jira/browse/SCM-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540555#comment-17540555
]
ASF GitHub Bot commented on SCM-943:
asfgit merged PR #139:
URL: https://github.com/apache/maven-scm/pull/139
> scm:check-local-modification does not support excludes
> --
>
> Key: SCM-943
> URL: https://issues.apache.org/jira/browse/SCM-943
> Project: Maven SCM
> Issue Type: Improvement
>Reporter: Michiel Kalkman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> It seems like scm:check-local-modification does not support the excludes and
> includes parameters. Which is annoying, because I want to exclude *.iml from
> Intellij from this check.
> Looking (but not yet testing) at CheckLocalModificationsMojo::execute(), it
> does:
> {code:java}
> result = getScmManager().status( repository, new ScmFileSet( baseDirectory )
> );
> {code}
> So it does not address neither includes, nor excludes parameter.
> My first though would be that something like this is the start of fix:
> {code:java}
> result = getScmManager().status( repository, new ScmFileSet(
> getWorkingDirectory(), getIncludes(), getExcludes() ) );
> {code}
> Is this something that has not yet been implemented, or is there a user error
> on my part?
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SCM-980) Remove code duplication in ListMojo
[
https://issues.apache.org/jira/browse/SCM-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540554#comment-17540554
]
ASF GitHub Bot commented on SCM-980:
asfgit closed pull request #138: [SCM-980] Remove code duplication in ListMojo
URL: https://github.com/apache/maven-scm/pull/138
> Remove code duplication in ListMojo
> ---
>
> Key: SCM-980
> URL: https://issues.apache.org/jira/browse/SCM-980
> Project: Maven SCM
> Issue Type: Task
> Components: maven-plugin
>Affects Versions: 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> The {{ListMojo}} has a {{getFileSet()}} method which is exactly the same as
> in {{AbstractScmMojo.getFileSet()}}. This duplication shall be removed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (SCM-943) scm:check-local-modification does not support excludes
[
https://issues.apache.org/jira/browse/SCM-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SCM-943.
--
Resolution: Fixed
Fixed with
[bbd23dcfa9fced2c5a2f91abb47be1c4a660e6ea|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=bbd23dcfa9fced2c5a2f91abb47be1c4a660e6ea]
and with
[d7107dac448fa0117c35726e5ea52260340f3574|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=d7107dac448fa0117c35726e5ea52260340f3574]
for {{maven-scm-1.x}} branch.
> scm:check-local-modification does not support excludes
> --
>
> Key: SCM-943
> URL: https://issues.apache.org/jira/browse/SCM-943
> Project: Maven SCM
> Issue Type: Improvement
>Reporter: Michiel Kalkman
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> It seems like scm:check-local-modification does not support the excludes and
> includes parameters. Which is annoying, because I want to exclude *.iml from
> Intellij from this check.
> Looking (but not yet testing) at CheckLocalModificationsMojo::execute(), it
> does:
> {code:java}
> result = getScmManager().status( repository, new ScmFileSet( baseDirectory )
> );
> {code}
> So it does not address neither includes, nor excludes parameter.
> My first though would be that something like this is the start of fix:
> {code:java}
> result = getScmManager().status( repository, new ScmFileSet(
> getWorkingDirectory(), getIncludes(), getExcludes() ) );
> {code}
> Is this something that has not yet been implemented, or is there a user error
> on my part?
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] asfgit closed pull request #138: [SCM-980] Remove code duplication in ListMojo
asfgit closed pull request #138: [SCM-980] Remove code duplication in ListMojo URL: https://github.com/apache/maven-scm/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-980) Remove code duplication in ListMojo
[
https://issues.apache.org/jira/browse/SCM-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540557#comment-17540557
]
ASF GitHub Bot commented on SCM-980:
asfgit closed pull request #138: [SCM-980] Remove code duplication in ListMojo
URL: https://github.com/apache/maven-scm/pull/138
> Remove code duplication in ListMojo
> ---
>
> Key: SCM-980
> URL: https://issues.apache.org/jira/browse/SCM-980
> Project: Maven SCM
> Issue Type: Task
> Components: maven-plugin
>Affects Versions: 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> The {{ListMojo}} has a {{getFileSet()}} method which is exactly the same as
> in {{AbstractScmMojo.getFileSet()}}. This duplication shall be removed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (SCM-980) Remove code duplication in ListMojo
[
https://issues.apache.org/jira/browse/SCM-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SCM-980.
--
Resolution: Fixed
Fixed with
[828043a46886a2101aba297cee95dd694497cd37|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=828043a46886a2101aba297cee95dd694497cd37]
and with
[52c2cda64d476831513175e06383d4d6b87cd945|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=52c2cda64d476831513175e06383d4d6b87cd945]
for {{maven-scm-1.x}} branch.
> Remove code duplication in ListMojo
> ---
>
> Key: SCM-980
> URL: https://issues.apache.org/jira/browse/SCM-980
> Project: Maven SCM
> Issue Type: Task
> Components: maven-plugin
>Affects Versions: 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> The {{ListMojo}} has a {{getFileSet()}} method which is exactly the same as
> in {{AbstractScmMojo.getFileSet()}}. This duplication shall be removed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on pull request #143: [SCM-979] De-Junit 3
michael-o commented on PR #143: URL: https://github.com/apache/maven-scm/pull/143#issuecomment-1133850001 > steps to reproduce locally site build error: > > ``` > rm -rf ~/.m2/repository-prv/org/apache/maven/scm/ > mvn verify -P run-its > mvn site -P reporting > ``` > > second run - will pass: > > ``` > mvn site -P reporting > ``` This I will check, but focusing on tests for now only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-979) Replace Plexus Container Default with Sisu Plexus Shim
[ https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540561#comment-17540561 ] ASF GitHub Bot commented on SCM-979: michael-o commented on PR #143: URL: https://github.com/apache/maven-scm/pull/143#issuecomment-1133850001 > steps to reproduce locally site build error: > > ``` > rm -rf ~/.m2/repository-prv/org/apache/maven/scm/ > mvn verify -P run-its > mvn site -P reporting > ``` > > second run - will pass: > > ``` > mvn site -P reporting > ``` This I will check, but focusing on tests for now only. > Replace Plexus Container Default with Sisu Plexus Shim > -- > > Key: SCM-979 > URL: https://issues.apache.org/jira/browse/SCM-979 > Project: Maven SCM > Issue Type: Task >Reporter: Michael Osipov >Assignee: Tamás Cservenák >Priority: Major > Fix For: 2.0.0-M2 > > > Changes: > * update dependencies accordingly > * remove any uses of deprecated Plexus APIs > * replace plexus-container-default with plexus-shim -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MRELEASE-1092) Synch with changes plugin
Ernst Reissner created MRELEASE-1092: Summary: Synch with changes plugin Key: MRELEASE-1092 URL: https://issues.apache.org/jira/browse/MRELEASE-1092 Project: Maven Release Plugin Issue Type: New Feature Components: prepare Affects Versions: 3.0.0-M5 Reporter: Ernst Reissner the changes plugin is based on the file changes.xml. It is a sequence of releases each covering the changes made in the current release. The form is ```[xml] ... ``` I suggest, that the release plugin shall check whether - the version is the version to be - the date is the current date - the description is not empty. If all this is true, on can assume that the release element is maintained. One should advise to start with empty version and empty date and empty description. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-scm] olamy commented on a diff in pull request #142: [SCM-979] ScmLogger nonsense dropped
olamy commented on code in PR #142:
URL: https://github.com/apache/maven-scm/pull/142#discussion_r878842822
##
maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/add/HgAddConsumer.java:
##
@@ -54,17 +52,17 @@ public void doConsume( ScmFileStatus status, String
trimmedLine )
File tmpFile = new File( workingDir, trimmedLine );
if ( !tmpFile.exists() )
{
-if ( getLogger().isWarnEnabled() )
+if ( logger.isWarnEnabled() )
{
-getLogger().warn( "Not a file: " + tmpFile + ". Ignored" );
+logger.warn( "Not a file: " + tmpFile + ". Ignored" );
Review Comment:
why not changing/simplify this as well by removing the if and `logger.warn(
"Not a file: {}. Ignored", tmpFile );`
this apply to plenty of lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-979) Replace Plexus Container Default with Sisu Plexus Shim
[
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540572#comment-17540572
]
ASF GitHub Bot commented on SCM-979:
olamy commented on code in PR #142:
URL: https://github.com/apache/maven-scm/pull/142#discussion_r878842822
##
maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/add/HgAddConsumer.java:
##
@@ -54,17 +52,17 @@ public void doConsume( ScmFileStatus status, String
trimmedLine )
File tmpFile = new File( workingDir, trimmedLine );
if ( !tmpFile.exists() )
{
-if ( getLogger().isWarnEnabled() )
+if ( logger.isWarnEnabled() )
{
-getLogger().warn( "Not a file: " + tmpFile + ". Ignored" );
+logger.warn( "Not a file: " + tmpFile + ". Ignored" );
Review Comment:
why not changing/simplify this as well by removing the if and `logger.warn(
"Not a file: {}. Ignored", tmpFile );`
this apply to plenty of lines
> Replace Plexus Container Default with Sisu Plexus Shim
> --
>
> Key: SCM-979
> URL: https://issues.apache.org/jira/browse/SCM-979
> Project: Maven SCM
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Changes:
> * update dependencies accordingly
> * remove any uses of deprecated Plexus APIs
> * replace plexus-container-default with plexus-shim
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] olamy commented on a diff in pull request #142: [SCM-979] ScmLogger nonsense dropped
olamy commented on code in PR #142:
URL: https://github.com/apache/maven-scm/pull/142#discussion_r878842889
##
maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/remove/HgRemoveConsumer.java:
##
@@ -55,17 +53,17 @@ public void doConsume( ScmFileStatus status, String
trimmedLine )
File tmpFile = new File( workingDir, trimmedLine );
if ( !tmpFile.exists() )
{
-if ( getLogger().isWarnEnabled() )
+if ( logger.isWarnEnabled() )
{
-getLogger().warn( "Not a file: " + tmpFile + ". Ignored" );
+logger.warn( "Not a file: " + tmpFile + ". Ignored" );
Review Comment:
could be simplify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-scm] olamy commented on a diff in pull request #142: [SCM-979] ScmLogger nonsense dropped
olamy commented on code in PR #142:
URL: https://github.com/apache/maven-scm/pull/142#discussion_r878842952
##
maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/status/HgStatusConsumer.java:
##
@@ -52,24 +50,24 @@ public void doConsume( ScmFileStatus status, String
trimmedLine )
File tmpFile = new File( workingDir, trimmedLine );
if ( !tmpFile.exists() )
{
-if ( getLogger().isInfoEnabled() )
+if ( logger.isInfoEnabled() )
{
-getLogger().info( "Not a file: " + tmpFile + ". Ignoring" );
+logger.info( "Not a file: " + tmpFile + ". Ignoring" );
Review Comment:
could be simplify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-979) Replace Plexus Container Default with Sisu Plexus Shim
[
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540574#comment-17540574
]
ASF GitHub Bot commented on SCM-979:
olamy commented on code in PR #142:
URL: https://github.com/apache/maven-scm/pull/142#discussion_r878842889
##
maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/remove/HgRemoveConsumer.java:
##
@@ -55,17 +53,17 @@ public void doConsume( ScmFileStatus status, String
trimmedLine )
File tmpFile = new File( workingDir, trimmedLine );
if ( !tmpFile.exists() )
{
-if ( getLogger().isWarnEnabled() )
+if ( logger.isWarnEnabled() )
{
-getLogger().warn( "Not a file: " + tmpFile + ". Ignored" );
+logger.warn( "Not a file: " + tmpFile + ". Ignored" );
Review Comment:
could be simplify
> Replace Plexus Container Default with Sisu Plexus Shim
> --
>
> Key: SCM-979
> URL: https://issues.apache.org/jira/browse/SCM-979
> Project: Maven SCM
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Changes:
> * update dependencies accordingly
> * remove any uses of deprecated Plexus APIs
> * replace plexus-container-default with plexus-shim
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SCM-979) Replace Plexus Container Default with Sisu Plexus Shim
[
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540575#comment-17540575
]
ASF GitHub Bot commented on SCM-979:
olamy commented on code in PR #142:
URL: https://github.com/apache/maven-scm/pull/142#discussion_r878842952
##
maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/status/HgStatusConsumer.java:
##
@@ -52,24 +50,24 @@ public void doConsume( ScmFileStatus status, String
trimmedLine )
File tmpFile = new File( workingDir, trimmedLine );
if ( !tmpFile.exists() )
{
-if ( getLogger().isInfoEnabled() )
+if ( logger.isInfoEnabled() )
{
-getLogger().info( "Not a file: " + tmpFile + ". Ignoring" );
+logger.info( "Not a file: " + tmpFile + ". Ignoring" );
Review Comment:
could be simplify
> Replace Plexus Container Default with Sisu Plexus Shim
> --
>
> Key: SCM-979
> URL: https://issues.apache.org/jira/browse/SCM-979
> Project: Maven SCM
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Changes:
> * update dependencies accordingly
> * remove any uses of deprecated Plexus APIs
> * replace plexus-container-default with plexus-shim
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on a diff in pull request #142: [SCM-979] ScmLogger nonsense dropped
michael-o commented on code in PR #142:
URL: https://github.com/apache/maven-scm/pull/142#discussion_r878844685
##
maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/add/HgAddConsumer.java:
##
@@ -54,17 +52,17 @@ public void doConsume( ScmFileStatus status, String
trimmedLine )
File tmpFile = new File( workingDir, trimmedLine );
if ( !tmpFile.exists() )
{
-if ( getLogger().isWarnEnabled() )
+if ( logger.isWarnEnabled() )
{
-getLogger().warn( "Not a file: " + tmpFile + ". Ignored" );
+logger.warn( "Not a file: " + tmpFile + ". Ignored" );
Review Comment:
This PR is a mechanical replacement. Placeholders are next, but are right of
course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-979) Replace Plexus Container Default with Sisu Plexus Shim
[
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540577#comment-17540577
]
ASF GitHub Bot commented on SCM-979:
michael-o commented on code in PR #142:
URL: https://github.com/apache/maven-scm/pull/142#discussion_r878844685
##
maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/add/HgAddConsumer.java:
##
@@ -54,17 +52,17 @@ public void doConsume( ScmFileStatus status, String
trimmedLine )
File tmpFile = new File( workingDir, trimmedLine );
if ( !tmpFile.exists() )
{
-if ( getLogger().isWarnEnabled() )
+if ( logger.isWarnEnabled() )
{
-getLogger().warn( "Not a file: " + tmpFile + ". Ignored" );
+logger.warn( "Not a file: " + tmpFile + ". Ignored" );
Review Comment:
This PR is a mechanical replacement. Placeholders are next, but are right of
course.
> Replace Plexus Container Default with Sisu Plexus Shim
> --
>
> Key: SCM-979
> URL: https://issues.apache.org/jira/browse/SCM-979
> Project: Maven SCM
> Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Changes:
> * update dependencies accordingly
> * remove any uses of deprecated Plexus APIs
> * replace plexus-container-default with plexus-shim
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-invoker-plugin] cstamas commented on a diff in pull request #124: [MINVOKER-304] Use only common groovy modules - xml, json
cstamas commented on code in PR #124: URL: https://github.com/apache/maven-invoker-plugin/pull/124#discussion_r878855103 ## pom.xml: ## @@ -71,7 +71,7 @@ under the License. bsh 2.0b6 org.codehaus.groovy -groovy-all +groovy Review Comment: why not remove this property, that is used on single place now? (or I may missed other places not changed?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski commented on a diff in pull request #124: [MINVOKER-304] Use only common groovy modules - xml, json
slawekjaranowski commented on code in PR #124: URL: https://github.com/apache/maven-invoker-plugin/pull/124#discussion_r878859390 ## pom.xml: ## @@ -71,7 +71,7 @@ under the License. bsh 2.0b6 org.codehaus.groovy -groovy-all +groovy Review Comment: You right, It can be removed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] G-Ork opened a new pull request, #144: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
G-Ork opened a new pull request, #144: URL: https://github.com/apache/maven-scm/pull/144 Fourth try to fix [SCM-925] - Implement remove command for JGit provider - Write TCK for remove command. - No other upgrades (Java 1.8 or JGit) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-925) RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing
[ https://issues.apache.org/jira/browse/SCM-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540598#comment-17540598 ] ASF GitHub Bot commented on SCM-925: G-Ork opened a new pull request, #144: URL: https://github.com/apache/maven-scm/pull/144 Fourth try to fix [SCM-925] - Implement remove command for JGit provider - Write TCK for remove command. - No other upgrades (Java 1.8 or JGit) > RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing > - > > Key: SCM-925 > URL: https://issues.apache.org/jira/browse/SCM-925 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-jgit >Affects Versions: 1.11.2 >Reporter: Georg Tsakumagos >Priority: Major > Attachments: maven-scm-provider-jgit.log > > Time Spent: 10m > Remaining Estimate: 0h > > The git scm plugins differs in support for the scm command _remove_. This > breaks the goal _prepare-with-pom_ of the _maven-release-plugin_ using the > _maven-scm-provider-jgit_. The method is not fully implemented and throws an > UnsupportedOperationException. > Referring to the ["Maven SCM Providers > Matrix"|https://maven.apache.org/scm/matrix.html] this feature is documented > as supported and should be implemented in the _jgit_ provider like in > maven-scm-provider-gitexe. > > ||Variant||remove supported||Source|| > |maven-scm-provider-gitexe|(/)|[Github - GitExeScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java#L97]| > |maven-scm-provider-jgit|(x)|[Github - JGitScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/JGitScmProvider.java#L113]| > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-scm] G-Ork commented on pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
G-Ork commented on PR #132: URL: https://github.com/apache/maven-scm/pull/132#issuecomment-1133899041 Closed and create a new #144 containing only the bare minimum. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] G-Ork closed pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
G-Ork closed pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit URL: https://github.com/apache/maven-scm/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-925) RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing
[ https://issues.apache.org/jira/browse/SCM-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540599#comment-17540599 ] ASF GitHub Bot commented on SCM-925: G-Ork commented on PR #132: URL: https://github.com/apache/maven-scm/pull/132#issuecomment-1133899041 Closed and create a new #144 containing only the bare minimum. > RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing > - > > Key: SCM-925 > URL: https://issues.apache.org/jira/browse/SCM-925 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-jgit >Affects Versions: 1.11.2 >Reporter: Georg Tsakumagos >Priority: Major > Attachments: maven-scm-provider-jgit.log > > Time Spent: 10m > Remaining Estimate: 0h > > The git scm plugins differs in support for the scm command _remove_. This > breaks the goal _prepare-with-pom_ of the _maven-release-plugin_ using the > _maven-scm-provider-jgit_. The method is not fully implemented and throws an > UnsupportedOperationException. > Referring to the ["Maven SCM Providers > Matrix"|https://maven.apache.org/scm/matrix.html] this feature is documented > as supported and should be implemented in the _jgit_ provider like in > maven-scm-provider-gitexe. > > ||Variant||remove supported||Source|| > |maven-scm-provider-gitexe|(/)|[Github - GitExeScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java#L97]| > |maven-scm-provider-jgit|(x)|[Github - JGitScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/JGitScmProvider.java#L113]| > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SCM-925) RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing
[ https://issues.apache.org/jira/browse/SCM-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540600#comment-17540600 ] ASF GitHub Bot commented on SCM-925: G-Ork closed pull request #132: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit URL: https://github.com/apache/maven-scm/pull/132 > RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing > - > > Key: SCM-925 > URL: https://issues.apache.org/jira/browse/SCM-925 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-jgit >Affects Versions: 1.11.2 >Reporter: Georg Tsakumagos >Priority: Major > Attachments: maven-scm-provider-jgit.log > > Time Spent: 10m > Remaining Estimate: 0h > > The git scm plugins differs in support for the scm command _remove_. This > breaks the goal _prepare-with-pom_ of the _maven-release-plugin_ using the > _maven-scm-provider-jgit_. The method is not fully implemented and throws an > UnsupportedOperationException. > Referring to the ["Maven SCM Providers > Matrix"|https://maven.apache.org/scm/matrix.html] this feature is documented > as supported and should be implemented in the _jgit_ provider like in > maven-scm-provider-gitexe. > > ||Variant||remove supported||Source|| > |maven-scm-provider-gitexe|(/)|[Github - GitExeScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java#L97]| > |maven-scm-provider-jgit|(x)|[Github - JGitScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/JGitScmProvider.java#L113]| > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on pull request #144: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
michael-o commented on PR #144: URL: https://github.com/apache/maven-scm/pull/144#issuecomment-1133911062 Looks much better now, will happily review. Did you try, does this apply cleanly to 1.x? If yes, I'd back port and deliver with upcoming 1.13.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-925) RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing
[ https://issues.apache.org/jira/browse/SCM-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540610#comment-17540610 ] ASF GitHub Bot commented on SCM-925: michael-o commented on PR #144: URL: https://github.com/apache/maven-scm/pull/144#issuecomment-1133911062 Looks much better now, will happily review. Did you try, does this apply cleanly to 1.x? If yes, I'd back port and deliver with upcoming 1.13.0. > RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing > - > > Key: SCM-925 > URL: https://issues.apache.org/jira/browse/SCM-925 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-jgit >Affects Versions: 1.11.2 >Reporter: Georg Tsakumagos >Priority: Major > Attachments: maven-scm-provider-jgit.log > > Time Spent: 10m > Remaining Estimate: 0h > > The git scm plugins differs in support for the scm command _remove_. This > breaks the goal _prepare-with-pom_ of the _maven-release-plugin_ using the > _maven-scm-provider-jgit_. The method is not fully implemented and throws an > UnsupportedOperationException. > Referring to the ["Maven SCM Providers > Matrix"|https://maven.apache.org/scm/matrix.html] this feature is documented > as supported and should be implemented in the _jgit_ provider like in > maven-scm-provider-gitexe. > > ||Variant||remove supported||Source|| > |maven-scm-provider-gitexe|(/)|[Github - GitExeScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java#L97]| > |maven-scm-provider-jgit|(x)|[Github - JGitScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/JGitScmProvider.java#L113]| > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-invoker-plugin] slawekjaranowski commented on pull request #124: [MINVOKER-304] Use only common groovy modules - xml, json
slawekjaranowski commented on PR #124: URL: https://github.com/apache/maven-invoker-plugin/pull/124#issuecomment-1133912142 I added page about groovy versions, pleas look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MPLUGIN-389) Update level to Java 8
[ https://issues.apache.org/jira/browse/MPLUGIN-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MPLUGIN-389: --- Assignee: Slawomir Jaranowski > Update level to Java 8 > -- > > Key: MPLUGIN-389 > URL: https://issues.apache.org/jira/browse/MPLUGIN-389 > Project: Maven Plugin Tools > Issue Type: Task > Components: Plugin Plugin >Reporter: Tamás Cservenák >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Update plugin Java level to Java 8. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-plugin-tools] slawekjaranowski opened a new pull request, #85: [MPLUGIN-389] Update level to Java 8
slawekjaranowski opened a new pull request, #85: URL: https://github.com/apache/maven-plugin-tools/pull/85 step by step 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-389) Update level to Java 8
[ https://issues.apache.org/jira/browse/MPLUGIN-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540616#comment-17540616 ] ASF GitHub Bot commented on MPLUGIN-389: slawekjaranowski opened a new pull request, #85: URL: https://github.com/apache/maven-plugin-tools/pull/85 step by step 😄 > Update level to Java 8 > -- > > Key: MPLUGIN-389 > URL: https://issues.apache.org/jira/browse/MPLUGIN-389 > Project: Maven Plugin Tools > Issue Type: Task > Components: Plugin Plugin >Reporter: Tamás Cservenák >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Update plugin Java level to Java 8. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MPLUGIN-398) Support for java 19 - ASM 9.3
Slawomir Jaranowski created MPLUGIN-398: --- Summary: Support for java 19 - ASM 9.3 Key: MPLUGIN-398 URL: https://issues.apache.org/jira/browse/MPLUGIN-398 Project: Maven Plugin Tools Issue Type: Improvement Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: 3.7.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-plugin-tools] slawekjaranowski merged pull request #83: Bump asmVersion from 9.2 to 9.3
slawekjaranowski merged PR #83: URL: https://github.com/apache/maven-plugin-tools/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-398) Support for java 19 - ASM 9.3
[ https://issues.apache.org/jira/browse/MPLUGIN-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540617#comment-17540617 ] Slawomir Jaranowski commented on MPLUGIN-398: - https://asm.ow2.io/versions.html > Support for java 19 - ASM 9.3 > - > > Key: MPLUGIN-398 > URL: https://issues.apache.org/jira/browse/MPLUGIN-398 > Project: Maven Plugin Tools > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-plugin-tools] dependabot[bot] opened a new pull request, #86: Bump plexus-archiver from 3.6.0 to 4.2.7
dependabot[bot] opened a new pull request, #86: URL: https://github.com/apache/maven-plugin-tools/pull/86 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 3.6.0 to 4.2.7. Release notes Sourced from https://github.com/codehaus-plexus/plexus-archiver/releases";>plexus-archiver's releases. Plexus Archiver 4.2.7 🚀 New features and improvements Respect order of META-INF/ and META-INF/MANIFEST.MF entries in a JAR file (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/189";>#189) https://github.com/michael-o";>@michael-o Plexus Archiver 4.2.6 This release updates commons-compress to 1.21 which contains security fixed for https://github.com/advisories/GHSA-xqfj-vm6h-2x34";>CVE-2021-35517 https://github.com/advisories/GHSA-crv7-7245-f45f";>CVE-2021-35516 https://github.com/advisories/GHSA-7hfm-57qf-j43q";>CVE-2021-35515 https://github.com/advisories/GHSA-mc84-pj99-q6hh";>CVE-2021-36090 This version requires Java 8 as minimum (commons-compress 1.21 requires Java 8). 🚀 New features and improvements FileInputStream, FileOutputStream, FileReader and FileWriter are no longer used (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/183";>#183) https://github.com/jorsol";>@jorsol Code cleanup (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/172";>#172) https://github.com/olamy";>@olamy 📦 Dependency updates Bump plexus from 7 to 8 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/179";>#179) https://github.com/dependabot";>@dependabot Bump plexus-utils from 3.3.0 to 3.4.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/181";>#181) https://github.com/dependabot";>@dependabot Bump commons-compress from 1.20 to 1.21 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/177";>#177) https://github.com/dependabot";>@dependabot Plexus Archiver 4.2.5 🚀 New features and improvements Speed improvements (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/157";>#157) https://github.com/gnodet";>@gnodet 🐛 Bug Fixes Fix use of a mismatching Unicode path extra field in zip unarchiving (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/167";>#167) https://github.com/cwalther";>@cwalther In some cases zip archiver may update the file path but not the Unicode path extra field. This would result in Plexus Archiver extracting the file using wrong (obsolete) path. Now Plexus Archiver follows the specification and in this case will ignore the extra filed and extract the file in the correct location. 📦 Dependency updates Bump plexus from 6.5 to 7 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/158";>#158) https://github.com/dependabot";>@dependabot Bump xz from 1.8 to 1.9 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/165";>#165) https://github.com/dependabot";>@dependabot Plexus Archiver 4.2.4 🐛 Bug Fixes Fix unjustified warning about casing for directory entries (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/155";>#155) https://github.com/mthmulders";>@mthmulders Plexus Archiver 4.2.2 In this version the reproducible build is enabled (thanks to https://github.com/hboutemy";>@hboutemy) so the resulting jar should be reproducible. For more info check the https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74682318";>wiki page. :bug: Bug Fixes DirectoryArchiver fails for symlinks if a parent directory doesn't exist (https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/131";>#131) https://github.com/jameshans";>@jameshans ... (truncated) Changelog Sourced from https://github.com/codehaus-plexus/plexus-archiver/blob/master/ReleaseNotes.md";>plexus-archiver's changelog. Plexus Archiver Release Notes Plexus Archiver 4.2.1 Bugs [Issue https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/126";>#126][issue-126] - Fixed broken javadoc for Archiver#configureReproducible. [Issue https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/127";>#127][issue-127] - Fixed reproducible zip entry time depends on local daylight saving time. Plexus Archiver 4.2.0 Improvements [Pull Request https://github-redirect.dependabot.com/codehaus-plexus/plexus-archiver/issues/121";>#121][pr-121] - Add API to configure reproducible archives - Archiver#configureReproducible. Add option to force the user and group for all archive entries. Add option to force the last modified date for all archive entries. [Issue https://github-redirect.dependabot.com/codeha
[jira] [Closed] (MPLUGIN-398) Support for java 19 - ASM 9.3
[ https://issues.apache.org/jira/browse/MPLUGIN-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPLUGIN-398. --- Resolution: Fixed > Support for java 19 - ASM 9.3 > - > > Key: MPLUGIN-398 > URL: https://issues.apache.org/jira/browse/MPLUGIN-398 > Project: Maven Plugin Tools > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-scm] G-Ork commented on pull request #144: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
G-Ork commented on PR #144: URL: https://github.com/apache/maven-scm/pull/144#issuecomment-1133928593 I did not try any back ports. Where do i find the code base for 1.x? The tag i tried are broken so i lost patience. There could only be two possible problems in back porting: 1. No Java 1.8 (NIO) Support. I used NIO in test because org.codehaus.plexus.util.FileUtils.fileAppend(String, String) was deprecated. Could easyly be changed. 2. JGIT does not support remove in the older verison. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-925) RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing
[ https://issues.apache.org/jira/browse/SCM-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540623#comment-17540623 ] ASF GitHub Bot commented on SCM-925: G-Ork commented on PR #144: URL: https://github.com/apache/maven-scm/pull/144#issuecomment-1133928593 I did not try any back ports. Where do i find the code base for 1.x? The tag i tried are broken so i lost patience. There could only be two possible problems in back porting: 1. No Java 1.8 (NIO) Support. I used NIO in test because org.codehaus.plexus.util.FileUtils.fileAppend(String, String) was deprecated. Could easyly be changed. 2. JGIT does not support remove in the older verison. > RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing > - > > Key: SCM-925 > URL: https://issues.apache.org/jira/browse/SCM-925 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-jgit >Affects Versions: 1.11.2 >Reporter: Georg Tsakumagos >Priority: Major > Attachments: maven-scm-provider-jgit.log > > Time Spent: 10m > Remaining Estimate: 0h > > The git scm plugins differs in support for the scm command _remove_. This > breaks the goal _prepare-with-pom_ of the _maven-release-plugin_ using the > _maven-scm-provider-jgit_. The method is not fully implemented and throws an > UnsupportedOperationException. > Referring to the ["Maven SCM Providers > Matrix"|https://maven.apache.org/scm/matrix.html] this feature is documented > as supported and should be implemented in the _jgit_ provider like in > maven-scm-provider-gitexe. > > ||Variant||remove supported||Source|| > |maven-scm-provider-gitexe|(/)|[Github - GitExeScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java#L97]| > |maven-scm-provider-jgit|(x)|[Github - JGitScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/JGitScmProvider.java#L113]| > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-plugin-tools] michael-o commented on a diff in pull request #85: [MPLUGIN-389] Update level to Java 8
michael-o commented on code in PR #85:
URL: https://github.com/apache/maven-plugin-tools/pull/85#discussion_r878910313
##
maven-plugin-plugin/src/it/ant-reference-parameter/src/main/java/org/apache/maven/plugins/antWithRefs/ArtifactsTask.java:
##
@@ -29,7 +29,7 @@
public void execute()
throws BuildException
{
-log( String.valueOf( getProject().getReference( "artifacts" ) ) );
+log( String.valueOf( ( Object ) getProject().getReference( "artifacts"
) ) );
Review Comment:
The reference is never null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPLUGIN-389) Update level to Java 8
[
https://issues.apache.org/jira/browse/MPLUGIN-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540647#comment-17540647
]
ASF GitHub Bot commented on MPLUGIN-389:
michael-o commented on code in PR #85:
URL: https://github.com/apache/maven-plugin-tools/pull/85#discussion_r878910313
##
maven-plugin-plugin/src/it/ant-reference-parameter/src/main/java/org/apache/maven/plugins/antWithRefs/ArtifactsTask.java:
##
@@ -29,7 +29,7 @@
public void execute()
throws BuildException
{
-log( String.valueOf( getProject().getReference( "artifacts" ) ) );
+log( String.valueOf( ( Object ) getProject().getReference( "artifacts"
) ) );
Review Comment:
The reference is never null?
> Update level to Java 8
> --
>
> Key: MPLUGIN-389
> URL: https://issues.apache.org/jira/browse/MPLUGIN-389
> Project: Maven Plugin Tools
> Issue Type: Task
> Components: Plugin Plugin
>Reporter: Tamás Cservenák
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Update plugin Java level to Java 8.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (SCM-925) RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing
[ https://issues.apache.org/jira/browse/SCM-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned SCM-925: -- Assignee: Michael Osipov > RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing > - > > Key: SCM-925 > URL: https://issues.apache.org/jira/browse/SCM-925 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-jgit >Affects Versions: 1.11.2 >Reporter: Georg Tsakumagos >Assignee: Michael Osipov >Priority: Major > Attachments: maven-scm-provider-jgit.log > > Time Spent: 10m > Remaining Estimate: 0h > > The git scm plugins differs in support for the scm command _remove_. This > breaks the goal _prepare-with-pom_ of the _maven-release-plugin_ using the > _maven-scm-provider-jgit_. The method is not fully implemented and throws an > UnsupportedOperationException. > Referring to the ["Maven SCM Providers > Matrix"|https://maven.apache.org/scm/matrix.html] this feature is documented > as supported and should be implemented in the _jgit_ provider like in > maven-scm-provider-gitexe. > > ||Variant||remove supported||Source|| > |maven-scm-provider-gitexe|(/)|[Github - GitExeScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java#L97]| > |maven-scm-provider-jgit|(x)|[Github - JGitScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/JGitScmProvider.java#L113]| > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on pull request #144: [SCM-925] Implement RemoveCommand in maven-scm-provider-jgit
michael-o commented on PR #144: URL: https://github.com/apache/maven-scm/pull/144#issuecomment-1133952425 > I did not try any back ports. Where do i find the code base for 1.x? The tag i tried are broken so i lost patience. There could only be two possible problems in back porting: > > 1. No Java 1.8 (NIO) Support. I used NIO in test because org.codehaus.plexus.util.FileUtils.fileAppend(String, String) was deprecated. Could easyly be changed. Look into the `maven-scm-1.x` branch. It is still Java 7. If you want your change with Maven SCM 1.13.0 delivered then use Plexus Utils, the deprecation is OK for now. We will likely update all in one go. > 2. JGIT does not support remove in the older verison. The currently used JGit version does not support what you need? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-925) RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing
[ https://issues.apache.org/jira/browse/SCM-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540648#comment-17540648 ] ASF GitHub Bot commented on SCM-925: michael-o commented on PR #144: URL: https://github.com/apache/maven-scm/pull/144#issuecomment-1133952425 > I did not try any back ports. Where do i find the code base for 1.x? The tag i tried are broken so i lost patience. There could only be two possible problems in back porting: > > 1. No Java 1.8 (NIO) Support. I used NIO in test because org.codehaus.plexus.util.FileUtils.fileAppend(String, String) was deprecated. Could easyly be changed. Look into the `maven-scm-1.x` branch. It is still Java 7. If you want your change with Maven SCM 1.13.0 delivered then use Plexus Utils, the deprecation is OK for now. We will likely update all in one go. > 2. JGIT does not support remove in the older verison. The currently used JGit version does not support what you need? > RemoveCommand unsupported - maven-release-plugin:prepare-with-pom failing > - > > Key: SCM-925 > URL: https://issues.apache.org/jira/browse/SCM-925 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-jgit >Affects Versions: 1.11.2 >Reporter: Georg Tsakumagos >Assignee: Michael Osipov >Priority: Major > Attachments: maven-scm-provider-jgit.log > > Time Spent: 10m > Remaining Estimate: 0h > > The git scm plugins differs in support for the scm command _remove_. This > breaks the goal _prepare-with-pom_ of the _maven-release-plugin_ using the > _maven-scm-provider-jgit_. The method is not fully implemented and throws an > UnsupportedOperationException. > Referring to the ["Maven SCM Providers > Matrix"|https://maven.apache.org/scm/matrix.html] this feature is documented > as supported and should be implemented in the _jgit_ provider like in > maven-scm-provider-gitexe. > > ||Variant||remove supported||Source|| > |maven-scm-provider-gitexe|(/)|[Github - GitExeScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/GitExeScmProvider.java#L97]| > |maven-scm-provider-jgit|(x)|[Github - JGitScmProvider.java - > getRemoveCommand()|https://github.com/apache/maven-scm/blob/a1f7e9857076940c878a370ff599b394df768d33/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/JGitScmProvider.java#L113]| > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #85: [MPLUGIN-389] Update level to Java 8
slawekjaranowski commented on code in PR #85:
URL: https://github.com/apache/maven-plugin-tools/pull/85#discussion_r878911287
##
maven-plugin-plugin/src/it/ant-reference-parameter/src/main/java/org/apache/maven/plugins/antWithRefs/ArtifactsTask.java:
##
@@ -29,7 +29,7 @@
public void execute()
throws BuildException
{
-log( String.valueOf( getProject().getReference( "artifacts" ) ) );
+log( String.valueOf( ( Object ) getProject().getReference( "artifacts"
) ) );
Review Comment:
Without such cast we will have exception:
```
Caused by: java.lang.ClassCastException: java.util.LinkedHashSet cannot be
cast to [C
at org.apache.maven.plugins.antWithRefs.ArtifactsTask.execute
(ArtifactsTask.java:32)
at org.apache.tools.ant.UnknownElement.execute (UnknownElement.java:299)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
```
As scripting Mojo are deprecated I didn't investigate it, simply did in such
way to make test pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPLUGIN-389) Update level to Java 8
[
https://issues.apache.org/jira/browse/MPLUGIN-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540650#comment-17540650
]
ASF GitHub Bot commented on MPLUGIN-389:
slawekjaranowski commented on code in PR #85:
URL: https://github.com/apache/maven-plugin-tools/pull/85#discussion_r878911287
##
maven-plugin-plugin/src/it/ant-reference-parameter/src/main/java/org/apache/maven/plugins/antWithRefs/ArtifactsTask.java:
##
@@ -29,7 +29,7 @@
public void execute()
throws BuildException
{
-log( String.valueOf( getProject().getReference( "artifacts" ) ) );
+log( String.valueOf( ( Object ) getProject().getReference( "artifacts"
) ) );
Review Comment:
Without such cast we will have exception:
```
Caused by: java.lang.ClassCastException: java.util.LinkedHashSet cannot be
cast to [C
at org.apache.maven.plugins.antWithRefs.ArtifactsTask.execute
(ArtifactsTask.java:32)
at org.apache.tools.ant.UnknownElement.execute (UnknownElement.java:299)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
```
As scripting Mojo are deprecated I didn't investigate it, simply did in such
way to make test pass.
> Update level to Java 8
> --
>
> Key: MPLUGIN-389
> URL: https://issues.apache.org/jira/browse/MPLUGIN-389
> Project: Maven Plugin Tools
> Issue Type: Task
> Components: Plugin Plugin
>Reporter: Tamás Cservenák
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Update plugin Java level to Java 8.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-plugin-tools] michael-o commented on a diff in pull request #85: [MPLUGIN-389] Update level to Java 8
michael-o commented on code in PR #85:
URL: https://github.com/apache/maven-plugin-tools/pull/85#discussion_r878911823
##
maven-plugin-plugin/src/it/ant-reference-parameter/src/main/java/org/apache/maven/plugins/antWithRefs/ArtifactsTask.java:
##
@@ -29,7 +29,7 @@
public void execute()
throws BuildException
{
-log( String.valueOf( getProject().getReference( "artifacts" ) ) );
+log( String.valueOf( ( Object ) getProject().getReference( "artifacts"
) ) );
Review Comment:
Yes, true. That is fully acceptable!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPLUGIN-389) Update level to Java 8
[
https://issues.apache.org/jira/browse/MPLUGIN-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540651#comment-17540651
]
ASF GitHub Bot commented on MPLUGIN-389:
michael-o commented on code in PR #85:
URL: https://github.com/apache/maven-plugin-tools/pull/85#discussion_r878911823
##
maven-plugin-plugin/src/it/ant-reference-parameter/src/main/java/org/apache/maven/plugins/antWithRefs/ArtifactsTask.java:
##
@@ -29,7 +29,7 @@
public void execute()
throws BuildException
{
-log( String.valueOf( getProject().getReference( "artifacts" ) ) );
+log( String.valueOf( ( Object ) getProject().getReference( "artifacts"
) ) );
Review Comment:
Yes, true. That is fully acceptable!
> Update level to Java 8
> --
>
> Key: MPLUGIN-389
> URL: https://issues.apache.org/jira/browse/MPLUGIN-389
> Project: Maven Plugin Tools
> Issue Type: Task
> Components: Plugin Plugin
>Reporter: Tamás Cservenák
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Update plugin Java level to Java 8.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] asfgit closed pull request #143: [SCM-979] De-Junit 3
asfgit closed pull request #143: [SCM-979] De-Junit 3 URL: https://github.com/apache/maven-scm/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-979) Replace Plexus Container Default with Sisu Plexus Shim
[ https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540654#comment-17540654 ] ASF GitHub Bot commented on SCM-979: asfgit closed pull request #143: [SCM-979] De-Junit 3 URL: https://github.com/apache/maven-scm/pull/143 > Replace Plexus Container Default with Sisu Plexus Shim > -- > > Key: SCM-979 > URL: https://issues.apache.org/jira/browse/SCM-979 > Project: Maven SCM > Issue Type: Task >Reporter: Michael Osipov >Assignee: Tamás Cservenák >Priority: Major > Fix For: 2.0.0-M2 > > > Changes: > * update dependencies accordingly > * remove any uses of deprecated Plexus APIs > * replace plexus-container-default with plexus-shim -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SCM-984) Replace use of JUnit 3 PlexusTestCase with Junit 4
[ https://issues.apache.org/jira/browse/SCM-984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed SCM-984. -- Resolution: Fixed Fixed with [915235eaf14666ff76fe795fb7288b7f427bc90a|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=915235eaf14666ff76fe795fb7288b7f427bc90a]. > Replace use of JUnit 3 PlexusTestCase with Junit 4 > -- > > Key: SCM-984 > URL: https://issues.apache.org/jira/browse/SCM-984 > Project: Maven SCM > Issue Type: Task >Affects Versions: 2.0.0-M1 >Reporter: Michael Osipov >Assignee: Tamás Cservenák >Priority: Major > Fix For: 2.0.0-M2 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SCM-979) Replace Plexus Container Default with Sisu Plexus Shim
[ https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540655#comment-17540655 ] ASF GitHub Bot commented on SCM-979: michael-o commented on PR #143: URL: https://github.com/apache/maven-scm/pull/143#issuecomment-1133955513 > steps to reproduce locally site build error: > > ``` > rm -rf ~/.m2/repository-prv/org/apache/maven/scm/ > mvn verify -P run-its > mvn site -P reporting > ``` > > second run - will pass: > > ``` > mvn site -P reporting > ``` The effect you see is sometimes expected because some reporting plugins require the react with package phase to be run to properly do its work otherwise they will fail. This is such a case: mvn package site -Preporting. Remember that during release an install has already happened. > Replace Plexus Container Default with Sisu Plexus Shim > -- > > Key: SCM-979 > URL: https://issues.apache.org/jira/browse/SCM-979 > Project: Maven SCM > Issue Type: Task >Reporter: Michael Osipov >Assignee: Tamás Cservenák >Priority: Major > Fix For: 2.0.0-M2 > > > Changes: > * update dependencies accordingly > * remove any uses of deprecated Plexus APIs > * replace plexus-container-default with plexus-shim -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on pull request #143: [SCM-979] De-Junit 3
michael-o commented on PR #143: URL: https://github.com/apache/maven-scm/pull/143#issuecomment-1133955513 > steps to reproduce locally site build error: > > ``` > rm -rf ~/.m2/repository-prv/org/apache/maven/scm/ > mvn verify -P run-its > mvn site -P reporting > ``` > > second run - will pass: > > ``` > mvn site -P reporting > ``` The effect you see is sometimes expected because some reporting plugins require the react with package phase to be run to properly do its work otherwise they will fail. This is such a case: mvn package site -Preporting. Remember that during release an install has already happened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] michael-o commented on pull request #140: [SCM-981] Add run-its profile and fix broken tests
michael-o commented on PR #140: URL: https://github.com/apache/maven-scm/pull/140#issuecomment-1133955767 @nielsbasjes Please rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540656#comment-17540656
]
ASF GitHub Bot commented on SCM-981:
michael-o commented on PR #140:
URL: https://github.com/apache/maven-scm/pull/140#issuecomment-1133955767
@nielsbasjes Please rebase
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SCM-942) No run-its profile
[ https://issues.apache.org/jira/browse/SCM-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540659#comment-17540659 ] Michael Osipov commented on SCM-942: [~nielsbasjes], this is related to your work... > No run-its profile > -- > > Key: SCM-942 > URL: https://issues.apache.org/jira/browse/SCM-942 > Project: Maven SCM > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Priority: Minor > > Need to reconfigure Jenkins > [WARNING] The requested profile "run-its" could not be activated because it > does not exist.[INFO] [jenkins-event-spy] Generated > F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_master@tmp\withMaven7ef059b8\maven-spy-20200512-063430-10311619434683088559632.log -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-plugin-tools] slawekjaranowski merged pull request #85: [MPLUGIN-389] Update level to Java 8
slawekjaranowski merged PR #85: URL: https://github.com/apache/maven-plugin-tools/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPLUGIN-389) Update level to Java 8
[ https://issues.apache.org/jira/browse/MPLUGIN-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPLUGIN-389. --- Resolution: Fixed > Update level to Java 8 > -- > > Key: MPLUGIN-389 > URL: https://issues.apache.org/jira/browse/MPLUGIN-389 > Project: Maven Plugin Tools > Issue Type: Task > Components: Plugin Plugin >Reporter: Tamás Cservenák >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Update plugin Java level to Java 8. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MPLUGIN-389) Update level to Java 8
[ https://issues.apache.org/jira/browse/MPLUGIN-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540665#comment-17540665 ] ASF GitHub Bot commented on MPLUGIN-389: slawekjaranowski merged PR #85: URL: https://github.com/apache/maven-plugin-tools/pull/85 > Update level to Java 8 > -- > > Key: MPLUGIN-389 > URL: https://issues.apache.org/jira/browse/MPLUGIN-389 > Project: Maven Plugin Tools > Issue Type: Task > Components: Plugin Plugin >Reporter: Tamás Cservenák >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Update plugin Java level to Java 8. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #82: Bump antVersion from 1.9.16 to 1.10.12
slawekjaranowski commented on PR #82: URL: https://github.com/apache/maven-plugin-tools/pull/82#issuecomment-1133960114 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #84: Bump assertj-core from 2.9.1 to 3.22.0
slawekjaranowski commented on PR #84: URL: https://github.com/apache/maven-plugin-tools/pull/84#issuecomment-1133960286 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-389) Update level to Java 8
[ https://issues.apache.org/jira/browse/MPLUGIN-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540671#comment-17540671 ] Hudson commented on MPLUGIN-389: Build succeeded in Jenkins: Maven » Maven TLP » maven-plugin-tools » master #11 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/11/ > Update level to Java 8 > -- > > Key: MPLUGIN-389 > URL: https://issues.apache.org/jira/browse/MPLUGIN-389 > Project: Maven Plugin Tools > Issue Type: Task > Components: Plugin Plugin >Reporter: Tamás Cservenák >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Update plugin Java level to Java 8. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (SCM-985) Drop/replace usage of Commons Lang 2
Michael Osipov created SCM-985: -- Summary: Drop/replace usage of Commons Lang 2 Key: SCM-985 URL: https://issues.apache.org/jira/browse/SCM-985 Project: Maven SCM Issue Type: Task Affects Versions: 1.12.2 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 1.13.0, 2.0.0-M2 It is used only a few times and can be replaced with Plexus Utils. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
Michael Osipov created SCM-986: -- Summary: SvnExe's SvnRemoteInfoCommand incorrectly implemented Key: SCM-986 URL: https://issues.apache.org/jira/browse/SCM-986 Project: Maven SCM Issue Type: Bug Components: maven-scm-provider-svn Affects Versions: 1.12.2, 2.0.0-M1 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 1.13.0, 2.0.0-M2 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SCM-986:
---
Description:
Several bugs:
1st bug:
This class claims to process the following URLs:
* {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
* {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works, but
the second is processed to {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
2nd bug:
Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags" +
"@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branhes" + "@" );}}
3rd bug:
{{LsConsumer}} receives the new, reduced base URL as constructor arg and
contructs the final tag/branch URLs as:
{{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
{{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}} the path segments
{{tags}} and {{branches}} are never passed.
Branch SCM-986 includes in extended TCK test to verify this faulty behavior.
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branhes" + "@"
> );}}
> 3rd bug:
> {{LsConsumer}} receives the new, reduced base URL as constructor arg and
> contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}} the path segments
> {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes in extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SCM-986:
---
Description:
Several bugs:
1st bug:
This class claims to process the following URLs:
* {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
* {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works, but
the second is processed to {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
2nd bug:
Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags" +
"@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@" );}}
3rd bug:
{{new LsConsumer()}} receives the new, reduced base URL as constructor arg and
contructs the final tag/branch URLs as:
{{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
{{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path segments
{{tags}} and {{branches}} are never passed.
Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
was:
Several bugs:
1st bug:
This class claims to process the following URLs:
* {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
* {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works, but
the second is processed to {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
2nd bug:
Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags" +
"@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branhes" + "@" );}}
3rd bug:
{{LsConsumer}} receives the new, reduced base URL as constructor arg and
contructs the final tag/branch URLs as:
{{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
{{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}} the path segments
{{tags}} and {{branches}} are never passed.
Branch SCM-986 includes in extended TCK test to verify this faulty behavior.
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o opened a new pull request, #145: [SCM-986] SvnExe's SvnRemoteInfoCommand incorrectly implemented
michael-o opened a new pull request, #145: URL: https://github.com/apache/maven-scm/pull/145 Extend TCK test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540679#comment-17540679
]
ASF GitHub Bot commented on SCM-986:
michael-o opened a new pull request, #145:
URL: https://github.com/apache/maven-scm/pull/145
Extend TCK test
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] nielsbasjes commented on pull request #140: [SCM-981] Add run-its profile and fix broken tests
nielsbasjes commented on PR #140: URL: https://github.com/apache/maven-scm/pull/140#issuecomment-1133973802 I have - Fixed a few broken tests. - Added a tck-hg and tck-local for consistency - Added a run-its profile that runs all. - Added the method ScmTckTestCase::getScmProviderCommand which either returns null (i.e. no command needs to exist) or the name of the command that must exist. This has been overridden in all `Hg...TckTest` , `SvnExe...TckTest` and `GitExe...TckTest` classes (except the two specials mentioned above). This method is checked before each test and ignores tests for which the required command is missing. Classes with things I consider "unexpected" and have not changed: - GitListCommandTckTest is abstract and not actually implemented anywhere. - GitInfoCommandTckTest extends ScmTestCase instead of ScmTckTestCase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540681#comment-17540681
]
ASF GitHub Bot commented on SCM-981:
nielsbasjes commented on PR #140:
URL: https://github.com/apache/maven-scm/pull/140#issuecomment-1133973802
I have
- Fixed a few broken tests.
- Added a tck-hg and tck-local for consistency
- Added a run-its profile that runs all.
- Added the method ScmTckTestCase::getScmProviderCommand which either
returns null (i.e. no command needs to exist) or the name of the command that
must exist.
This has been overridden in all `Hg...TckTest` , `SvnExe...TckTest` and
`GitExe...TckTest` classes (except the two specials mentioned above). This
method is checked before each test and ignores tests for which the required
command is missing.
Classes with things I consider "unexpected" and have not changed:
- GitListCommandTckTest is abstract and not actually implemented anywhere.
- GitInfoCommandTckTest extends ScmTestCase instead of ScmTckTestCase
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on pull request #140: [SCM-981] Add run-its profile and fix broken tests
michael-o commented on PR #140: URL: https://github.com/apache/maven-scm/pull/140#issuecomment-1133977138 * `GitListCommandTckTest` hasn't obviously not being implemented... * Looking at `GitInfoCommandTckTest` it does not seem seem to be a TCK test, but merely a unit test. It does not have the same structure as TCK tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540682#comment-17540682
]
ASF GitHub Bot commented on SCM-981:
michael-o commented on PR #140:
URL: https://github.com/apache/maven-scm/pull/140#issuecomment-1133977138
* `GitListCommandTckTest` hasn't obviously not being implemented...
* Looking at `GitInfoCommandTckTest` it does not seem seem to be a TCK test,
but merely a unit test. It does not have the same structure as TCK tests.
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MNG-7481) [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> [Help 1]
[
https://issues.apache.org/jira/browse/MNG-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540683#comment-17540683
]
Karl Heinz Marbaise commented on MNG-7481:
--
Yes please upgrade to most recent versions because 3.0.5 is of 2013-02-23
so roughly 10 years old... also I've checked the referenced project which uses
a version like {{${revision}} which will not work in Maven 3.0.5... also the
project contains a [maven-enforcer-rule which says to use at least Maven
3.5.0...|https://github.com/jenkinsci/analysis-model/blob/master/pom.xml#L495]
> [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 ->
> [Help 1]
> ---
>
> Key: MNG-7481
> URL: https://issues.apache.org/jira/browse/MNG-7481
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.0.5
> Environment: CentOS 7
> $ mvn --version
> Apache Maven 3.0.5 (Red Hat 3.0.5-17)
> Maven home: /usr/share/maven
> Java version: 1.8.0_332, vendor: Red Hat, Inc.
> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.332.b09-1.el7_9.x86_64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.10.0-1160.15.2.el7.x86_64", arch: "amd64",
> family: "unix"
>Reporter: Simon Matthews
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> I get this message when I run "mvn install" on the unaltered source for the
> Jenkins plugin "analysis model":
> [https://github.com/jenkinsci/analysis-model]
>
> $ mvn install
> [INFO] Scanning for projects...
> [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 ->
> [Help 1]
> org.apache.maven.InternalErrorException: Internal error:
> java.lang.ArrayIndexOutOfBoundsException: 20081
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:414)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:357)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 20081
> at org.codehaus.plexus.util.xml.pull.MXParser.parsePI(MXParser.java:2470)
> at org.codehaus.plexus.util.xml.pull.MXParser.nextImpl(MXParser.java:1257)
> at org.codehaus.plexus.util.xml.pull.MXParser.next(MXParser.java:1105)
> at org.codehaus.plexus.util.xml.pull.MXParser.nextTag(MXParser.java:1090)
> at
> org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePluginExecution(MavenXpp3ReaderEx.java:3541)
> at
> org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePlugin(MavenXpp3ReaderEx.java:3336)
> at
> org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseBuildBase(MavenXpp3ReaderEx.java:1398)
> at
> org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseProfile(MavenXpp3ReaderEx.java:3751)
> at
> org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseModel(MavenXpp3ReaderEx.java:2809)
> at
> org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:4627)
> at
> org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:837)
> at
> org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:118)
> at
> org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:91)
> at
> org.apache.maven.model.building.DefaultModelProcessor.read(DefaultModelProcessor.java:77)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readModel(DefaultModelBuilder.java:456)
> at
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:261)
> at
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:232)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:410)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:379)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:343)
> at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:636)
> at
> org.apache.maven.DefaultMaven.getPr
[jira] [Commented] (MNG-7481) [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> [Help 1]
[ https://issues.apache.org/jira/browse/MNG-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540684#comment-17540684 ] Michael Osipov commented on MNG-7481: - His entire OS is 10 years old, so he's consistently stuck in 2012/2013. > [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> > [Help 1] > --- > > Key: MNG-7481 > URL: https://issues.apache.org/jira/browse/MNG-7481 > Project: Maven > Issue Type: Bug >Affects Versions: 3.0.5 > Environment: CentOS 7 > $ mvn --version > Apache Maven 3.0.5 (Red Hat 3.0.5-17) > Maven home: /usr/share/maven > Java version: 1.8.0_332, vendor: Red Hat, Inc. > Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.332.b09-1.el7_9.x86_64/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "3.10.0-1160.15.2.el7.x86_64", arch: "amd64", > family: "unix" >Reporter: Simon Matthews >Priority: Major > Fix For: waiting-for-feedback, wontfix-candidate > > > I get this message when I run "mvn install" on the unaltered source for the > Jenkins plugin "analysis model": > [https://github.com/jenkinsci/analysis-model] > > $ mvn install > [INFO] Scanning for projects... > [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> > [Help 1] > org.apache.maven.InternalErrorException: Internal error: > java.lang.ArrayIndexOutOfBoundsException: 20081 > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:414) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:357) > Caused by: java.lang.ArrayIndexOutOfBoundsException: 20081 > at org.codehaus.plexus.util.xml.pull.MXParser.parsePI(MXParser.java:2470) > at org.codehaus.plexus.util.xml.pull.MXParser.nextImpl(MXParser.java:1257) > at org.codehaus.plexus.util.xml.pull.MXParser.next(MXParser.java:1105) > at org.codehaus.plexus.util.xml.pull.MXParser.nextTag(MXParser.java:1090) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePluginExecution(MavenXpp3ReaderEx.java:3541) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePlugin(MavenXpp3ReaderEx.java:3336) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseBuildBase(MavenXpp3ReaderEx.java:1398) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseProfile(MavenXpp3ReaderEx.java:3751) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseModel(MavenXpp3ReaderEx.java:2809) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:4627) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:837) > at > org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:118) > at > org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:91) > at > org.apache.maven.model.building.DefaultModelProcessor.read(DefaultModelProcessor.java:77) > at > org.apache.maven.model.building.DefaultModelBuilder.readModel(DefaultModelBuilder.java:456) > at > org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:261) > at > org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:232) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:410) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:379) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:343) > at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:636) > at > org.apache.maven.DefaultMaven.getProjectsForMavenReactor(DefaultMaven.java:585) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:234) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > ... 11 more > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven us
[GitHub] [maven-scm] michael-o commented on a diff in pull request #140: [SCM-981] Add run-its profile and fix broken tests
michael-o commented on code in PR #140: URL: https://github.com/apache/maven-scm/pull/140#discussion_r878925192 ## maven-scm-providers/maven-scm-provider-local/src/main/java/org/apache/maven/scm/provider/local/command/update/LocalUpdateCommand.java: ## @@ -190,7 +190,7 @@ private List update( File source, File baseDestination, List file int chop = baseDestination.getAbsolutePath().length(); -String fileName = "/" + destinationFile.getAbsolutePath().substring( chop + 1 ); +String fileName = destinationFile.getAbsolutePath().substring( chop + 1 ); Review Comment: Interesting that blindly a slash was prepended. That was doomed to fail on Windows, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540685#comment-17540685
]
ASF GitHub Bot commented on SCM-981:
michael-o commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r878925192
##
maven-scm-providers/maven-scm-provider-local/src/main/java/org/apache/maven/scm/provider/local/command/update/LocalUpdateCommand.java:
##
@@ -190,7 +190,7 @@ private List update( File source, File
baseDestination, List file
int chop = baseDestination.getAbsolutePath().length();
-String fileName = "/" +
destinationFile.getAbsolutePath().substring( chop + 1 );
+String fileName = destinationFile.getAbsolutePath().substring(
chop + 1 );
Review Comment:
Interesting that blindly a slash was prepended. That was doomed to fail on
Windows, no?
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on a diff in pull request #140: [SCM-981] Add run-its profile and fix broken tests
michael-o commented on code in PR #140: URL: https://github.com/apache/maven-scm/pull/140#discussion_r878925439 ## maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/changelog/ChangeLogCommandTckTest.java: ## @@ -94,7 +94,6 @@ public void testChangeLogCommand() ChangeSet changeset = thirdResult.getChangeLog().getChangeSets().get( 0 ); assertTrue( changeset.getDate().after( timeBeforeSecond ) ); - -assertEquals( COMMIT_MSG, changeset.getComment() ); +assertTrue( changeset.getComment().startsWith( COMMIT_MSG ) ); // Sometimes there is a newline appended Review Comment: Under which circumstances did this occur to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540687#comment-17540687
]
ASF GitHub Bot commented on SCM-981:
michael-o commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r878925439
##
maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/changelog/ChangeLogCommandTckTest.java:
##
@@ -94,7 +94,6 @@ public void testChangeLogCommand()
ChangeSet changeset = thirdResult.getChangeLog().getChangeSets().get(
0 );
assertTrue( changeset.getDate().after( timeBeforeSecond ) );
-
-assertEquals( COMMIT_MSG, changeset.getComment() );
+assertTrue( changeset.getComment().startsWith( COMMIT_MSG ) ); //
Sometimes there is a newline appended
Review Comment:
Under which circumstances did this occur to you?
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on a diff in pull request #140: [SCM-981] Add run-its profile and fix broken tests
michael-o commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r878925721
##
maven-scm-test/src/main/java/org/apache/maven/scm/ScmTckTestCase.java:
##
@@ -112,14 +114,19 @@ protected List getScmFileNames()
public abstract void initRepo()
throws Exception;
+private static final Logger LOG = LoggerFactory.getLogger(
ScmTckTestCase.class );
+
@Before
public void checkScmPresence()
{
String scmProviderCommand = getScmProviderCommand();
if ( scmProviderCommand != null )
{
+LOG.warn( "Checking for required SCM command \"{}\" --> {}",
+scmProviderCommand, ScmTestCase.isSystemCmd(
scmProviderCommand ) );
assumeTrue( "Skipping tests because the required command " +
scmProviderCommand + " is not available.",
ScmTestCase.isSystemCmd( scmProviderCommand ) );
+LOG.warn( "Required SCM command \"{}\" exists.",
scmProviderCommand );
Review Comment:
Why warn? Is this intermediate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540688#comment-17540688
]
ASF GitHub Bot commented on SCM-981:
michael-o commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r878925721
##
maven-scm-test/src/main/java/org/apache/maven/scm/ScmTckTestCase.java:
##
@@ -112,14 +114,19 @@ protected List getScmFileNames()
public abstract void initRepo()
throws Exception;
+private static final Logger LOG = LoggerFactory.getLogger(
ScmTckTestCase.class );
+
@Before
public void checkScmPresence()
{
String scmProviderCommand = getScmProviderCommand();
if ( scmProviderCommand != null )
{
+LOG.warn( "Checking for required SCM command \"{}\" --> {}",
+scmProviderCommand, ScmTestCase.isSystemCmd(
scmProviderCommand ) );
assumeTrue( "Skipping tests because the required command " +
scmProviderCommand + " is not available.",
ScmTestCase.isSystemCmd( scmProviderCommand ) );
+LOG.warn( "Required SCM command \"{}\" exists.",
scmProviderCommand );
Review Comment:
Why warn? Is this intermediate?
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] nielsbasjes commented on a diff in pull request #140: [SCM-981] Add run-its profile and fix broken tests
nielsbasjes commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r878925946
##
maven-scm-test/src/main/java/org/apache/maven/scm/ScmTckTestCase.java:
##
@@ -112,14 +114,19 @@ protected List getScmFileNames()
public abstract void initRepo()
throws Exception;
+private static final Logger LOG = LoggerFactory.getLogger(
ScmTckTestCase.class );
+
@Before
public void checkScmPresence()
{
String scmProviderCommand = getScmProviderCommand();
if ( scmProviderCommand != null )
{
+LOG.warn( "Checking for required SCM command \"{}\" --> {}",
+scmProviderCommand, ScmTestCase.isSystemCmd(
scmProviderCommand ) );
assumeTrue( "Skipping tests because the required command " +
scmProviderCommand + " is not available.",
ScmTestCase.isSystemCmd( scmProviderCommand ) );
+LOG.warn( "Required SCM command \"{}\" exists.",
scmProviderCommand );
Review Comment:
I added this just now to figure out why it still fails on macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540689#comment-17540689
]
ASF GitHub Bot commented on SCM-981:
nielsbasjes commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r878925946
##
maven-scm-test/src/main/java/org/apache/maven/scm/ScmTckTestCase.java:
##
@@ -112,14 +114,19 @@ protected List getScmFileNames()
public abstract void initRepo()
throws Exception;
+private static final Logger LOG = LoggerFactory.getLogger(
ScmTckTestCase.class );
+
@Before
public void checkScmPresence()
{
String scmProviderCommand = getScmProviderCommand();
if ( scmProviderCommand != null )
{
+LOG.warn( "Checking for required SCM command \"{}\" --> {}",
+scmProviderCommand, ScmTestCase.isSystemCmd(
scmProviderCommand ) );
assumeTrue( "Skipping tests because the required command " +
scmProviderCommand + " is not available.",
ScmTestCase.isSystemCmd( scmProviderCommand ) );
+LOG.warn( "Required SCM command \"{}\" exists.",
scmProviderCommand );
Review Comment:
I added this just now to figure out why it still fails on macOS.
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] nielsbasjes commented on a diff in pull request #140: [SCM-981] Add run-its profile and fix broken tests
nielsbasjes commented on code in PR #140: URL: https://github.com/apache/maven-scm/pull/140#discussion_r878926063 ## maven-scm-providers/maven-scm-provider-local/src/main/java/org/apache/maven/scm/provider/local/command/update/LocalUpdateCommand.java: ## @@ -190,7 +190,7 @@ private List update( File source, File baseDestination, List file int chop = baseDestination.getAbsolutePath().length(); -String fileName = "/" + destinationFile.getAbsolutePath().substring( chop + 1 ); +String fileName = destinationFile.getAbsolutePath().substring( chop + 1 ); Review Comment: I have Ubuntu and it fails because the assertion expects it without a slash. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540690#comment-17540690
]
ASF GitHub Bot commented on SCM-981:
nielsbasjes commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r878926063
##
maven-scm-providers/maven-scm-provider-local/src/main/java/org/apache/maven/scm/provider/local/command/update/LocalUpdateCommand.java:
##
@@ -190,7 +190,7 @@ private List update( File source, File
baseDestination, List file
int chop = baseDestination.getAbsolutePath().length();
-String fileName = "/" +
destinationFile.getAbsolutePath().substring( chop + 1 );
+String fileName = destinationFile.getAbsolutePath().substring(
chop + 1 );
Review Comment:
I have Ubuntu and it fails because the assertion expects it without a slash.
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] nielsbasjes commented on a diff in pull request #140: [SCM-981] Add run-its profile and fix broken tests
nielsbasjes commented on code in PR #140: URL: https://github.com/apache/maven-scm/pull/140#discussion_r878926224 ## maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/changelog/ChangeLogCommandTckTest.java: ## @@ -94,7 +94,6 @@ public void testChangeLogCommand() ChangeSet changeset = thirdResult.getChangeLog().getChangeSets().get( 0 ); assertTrue( changeset.getDate().after( timeBeforeSecond ) ); - -assertEquals( COMMIT_MSG, changeset.getComment() ); +assertTrue( changeset.getComment().startsWith( COMMIT_MSG ) ); // Sometimes there is a newline appended Review Comment: One of the SCMs returned it with a newline. Perhaps this should be fixed differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] michael-o commented on a diff in pull request #140: [SCM-981] Add run-its profile and fix broken tests
michael-o commented on code in PR #140: URL: https://github.com/apache/maven-scm/pull/140#discussion_r878926275 ## maven-scm-providers/maven-scm-provider-hg/src/test/java/org/apache/maven/scm/provider/hg/HgRepoUtils.java: ## @@ -35,9 +35,11 @@ * * @author mailto:thurner.rup...@ymono.net";>thurner rupert */ -public class HgRepoUtils +public abstract class HgRepoUtils Review Comment: Why? This class even extends `ScmTestCase` for whatsoever reason and has no descendants. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540692#comment-17540692
]
ASF GitHub Bot commented on SCM-981:
michael-o commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r878926275
##
maven-scm-providers/maven-scm-provider-hg/src/test/java/org/apache/maven/scm/provider/hg/HgRepoUtils.java:
##
@@ -35,9 +35,11 @@
*
* @author mailto:thurner.rup...@ymono.net";>thurner rupert
*/
-public class HgRepoUtils
+public abstract class HgRepoUtils
Review Comment:
Why? This class even extends `ScmTestCase` for whatsoever reason and has no
descendants.
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540691#comment-17540691
]
ASF GitHub Bot commented on SCM-981:
nielsbasjes commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r878926224
##
maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/changelog/ChangeLogCommandTckTest.java:
##
@@ -94,7 +94,6 @@ public void testChangeLogCommand()
ChangeSet changeset = thirdResult.getChangeLog().getChangeSets().get(
0 );
assertTrue( changeset.getDate().after( timeBeforeSecond ) );
-
-assertEquals( COMMIT_MSG, changeset.getComment() );
+assertTrue( changeset.getComment().startsWith( COMMIT_MSG ) ); //
Sometimes there is a newline appended
Review Comment:
One of the SCMs returned it with a newline. Perhaps this should be fixed
differently.
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on pull request #140: [SCM-981] Add run-its profile and fix broken tests
michael-o commented on PR #140: URL: https://github.com/apache/maven-scm/pull/140#issuecomment-1133981667 You can rename: GitInfoCommandTckTest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540693#comment-17540693
]
ASF GitHub Bot commented on SCM-981:
michael-o commented on PR #140:
URL: https://github.com/apache/maven-scm/pull/140#issuecomment-1133981667
You can rename: GitInfoCommandTckTest
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on a diff in pull request #140: [SCM-981] Add run-its profile and fix broken tests
michael-o commented on code in PR #140: URL: https://github.com/apache/maven-scm/pull/140#discussion_r878926485 ## maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/changelog/ChangeLogCommandTckTest.java: ## @@ -94,7 +94,6 @@ public void testChangeLogCommand() ChangeSet changeset = thirdResult.getChangeLog().getChangeSets().get( 0 ); assertTrue( changeset.getDate().after( timeBeforeSecond ) ); - -assertEquals( COMMIT_MSG, changeset.getComment() ); +assertTrue( changeset.getComment().startsWith( COMMIT_MSG ) ); // Sometimes there is a newline appended Review Comment: Which? I would rather strip trailing LS and then go through `assertEquals()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540694#comment-17540694
]
ASF GitHub Bot commented on SCM-981:
michael-o commented on code in PR #140:
URL: https://github.com/apache/maven-scm/pull/140#discussion_r878926485
##
maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/changelog/ChangeLogCommandTckTest.java:
##
@@ -94,7 +94,6 @@ public void testChangeLogCommand()
ChangeSet changeset = thirdResult.getChangeLog().getChangeSets().get(
0 );
assertTrue( changeset.getDate().after( timeBeforeSecond ) );
-
-assertEquals( COMMIT_MSG, changeset.getComment() );
+assertTrue( changeset.getComment().startsWith( COMMIT_MSG ) ); //
Sometimes there is a newline appended
Review Comment:
Which? I would rather strip trailing LS and then go through `assertEquals()`
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-pmd-plugin] michael-o commented on pull request #17: MPMD-299 Add IT to reproduce corrupted site:jar
michael-o commented on PR #17: URL: https://github.com/apache/maven-pmd-plugin/pull/17#issuecomment-1133983425 Closing since issue is in MSITE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pmd-plugin] michael-o closed pull request #17: MPMD-299 Add IT to reproduce corrupted site:jar
michael-o closed pull request #17: MPMD-299 Add IT to reproduce corrupted site:jar URL: https://github.com/apache/maven-pmd-plugin/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pmd-plugin] michael-o merged pull request #69: [MPMD-342] No debug log message issued when empty report shall be ski…
michael-o merged PR #69: URL: https://github.com/apache/maven-pmd-plugin/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPMD-342) No debug log message issued when empty report shall be skipped and no issues have been found
[ https://issues.apache.org/jira/browse/MPMD-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPMD-342. --- Resolution: Fixed Fixed with [e82e92b3815fccf44ecd864c95518b5760b7436b|https://gitbox.apache.org/repos/asf?p=maven-pmd-plugin.git;a=commit;h=e82e92b3815fccf44ecd864c95518b5760b7436b]. > No debug log message issued when empty report shall be skipped and no issues > have been found > > > Key: MPMD-342 > URL: https://issues.apache.org/jira/browse/MPMD-342 > Project: Maven PMD Plugin > Issue Type: Bug > Components: CPD, PMD >Affects Versions: 3.16.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.17.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (SCM-981) Several integration tests are never run and fail if you do.
[
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SCM-981:
---
Fix Version/s: 1.13.0
2.0.0-M2
> Several integration tests are never run and fail if you do.
> ---
>
> Key: SCM-981
> URL: https://issues.apache.org/jira/browse/SCM-981
> Project: Maven SCM
> Issue Type: Bug
>Reporter: Niels Basjes
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures"
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are
> apparently never run by anyone.
>
> Proposal:
> * Create a profile run-its that simply activates the appropriate tck
> profiles.
> * Fix the failing tests.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
