[
https://issues.apache.org/jira/browse/SCM-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540572#comment-17540572
]
ASF GitHub Bot commented on SCM-979:
------------------------------------
olamy commented on code in PR #142:
URL: https://github.com/apache/maven-scm/pull/142#discussion_r878842822
##########
maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/add/HgAddConsumer.java:
##########
@@ -54,17 +52,17 @@ public void doConsume( ScmFileStatus status, String
trimmedLine )
File tmpFile = new File( workingDir, trimmedLine );
if ( !tmpFile.exists() )
{
- if ( getLogger().isWarnEnabled() )
+ if ( logger.isWarnEnabled() )
{
- getLogger().warn( "Not a file: " + tmpFile + ". Ignored" );
+ logger.warn( "Not a file: " + tmpFile + ". Ignored" );
Review Comment:
why not changing/simplify this as well by removing the if and `logger.warn(
"Not a file: {}. Ignored", tmpFile );`
this apply to plenty of lines
> Replace Plexus Container Default with Sisu Plexus Shim
> ------------------------------------------------------
>
> Key: SCM-979
> URL: https://issues.apache.org/jira/browse/SCM-979
> Project: Maven SCM
> Issue Type: Task
> Reporter: Michael Osipov
> Assignee: Tamás Cservenák
> Priority: Major
> Fix For: 2.0.0-M2
>
>
> Changes:
> * update dependencies accordingly
> * remove any uses of deprecated Plexus APIs
> * replace plexus-container-default with plexus-shim
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
