olamy commented on code in PR #142:
URL: https://github.com/apache/maven-scm/pull/142#discussion_r878842822
##########
maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/command/add/HgAddConsumer.java:
##########
@@ -54,17 +52,17 @@ public void doConsume( ScmFileStatus status, String
trimmedLine )
File tmpFile = new File( workingDir, trimmedLine );
if ( !tmpFile.exists() )
{
- if ( getLogger().isWarnEnabled() )
+ if ( logger.isWarnEnabled() )
{
- getLogger().warn( "Not a file: " + tmpFile + ". Ignored" );
+ logger.warn( "Not a file: " + tmpFile + ". Ignored" );
Review Comment:
why not changing/simplify this as well by removing the if and `logger.warn(
"Not a file: {}. Ignored", tmpFile );`
this apply to plenty of lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
